aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2017-09-20Merge "Fix for Sonar major issues"Jorge Hernandez1-1/+2
2017-09-20Merge "Fixing VFC simulator for junit tests"Pamela Dragosh3-6/+17
2017-09-20Merge "Fix Major sonar issues"Pamela Dragosh1-6/+7
2017-09-20Fix for Sonar major issuesSwapnilPathak1-1/+2
Add override annotation above the method signature. Issue-ID: POLICY-248 Change-Id: I8086a6fc1dc24719c3ffd3785a12c086ab453ae9 Signed-off-by: SwapnilPathak <SP00494485@techmahindra.com>
2017-09-20Fix Major sonar issuesshashikanth1-6/+7
Fix Major sonar issues in policy/drools-applications module https://sonar.onap.org/component_issues?id=org.onap.policy.drools-applications%3Adrools-pdp-apps#resolved=false|severities=MAJOR Add the "@Override" annotation above this method signature "value" is already a string, there's no need to call "toString()" on it Issue-Id:POLICY-239 Change-Id: Ia64ac87c13d88c5d961b943e0b2286b273bd4831 Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
2017-09-19test tooling to generate vcpe use case in labJorge Hernandez3-1/+280
run successully vcpe case in lab in 2 steps: 1. docker-install load 2. run create-cl-amsterdam (with defaults) 3. injecting dcae.onset and appc.success packaged with archetypes Change-Id: Idb20c0078228da962510dbf36dae96aceb43546c Issue-ID: POLICY-162 Signed-off-by: Jorge Hernandez <jh1730@att.com>
2017-09-19Merge "Adding reading service-id from AA&I"Jorge Hernandez2-14/+61
2017-09-19enhancements to archetype and apps packagingJorge Hernandez7-22/+131
Change-Id: I3e659d35d3cb397c011657f39ef12b10b0564fc9 Issue-ID: POLICY-162 Signed-off-by: Jorge Hernandez <jh1730@att.com>
2017-09-19Remove sonar blocker and unused importPamela Dragosh2-8/+6
Remove the 3 sonar blockers and unused import in AAI code. Issue-ID: POLICY-111 Change-Id: I73001a06810ecff3f22da627583a0238c4a09967 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2017-09-18Inherit guard install env properties for cl.Jorge Hernandez6-12/+13
Clean up a few "mso" references. Disable 1.0.0 template build for now (note that some references are still pointing to old mso). Ie., see https://git.onap.org/policy/drools-applications/tree/controlloop /templates/template.demo.v1.0.0/template.demo /src/test/java/org/onap/policy/template/demo/TestSO.java Since this is going away, rather than maintaining it, and changing this code, disabling it for the build. It will be deleted within the next few days. Issue-ID: POLICY-162 Change-Id: Ibb819a318fbbb2b7f3aa14cdf76155bdec321024 Signed-off-by: Jorge Hernandez <jh1730@att.com>
2017-09-18Merge "Fix sonar critical"Jorge Hernandez5-9/+28
2017-09-18Fixing VFC simulator for junit testsRitu Sood3-6/+17
Added response type to post and removed response id as it is unused. Breaking up from the junit patch for ease of review. Issue-id: POLICY-212 Change-Id: I0c6b0c02b240cfe81246587184fe6a589dcc2367 Signed-off-by: Ritu Sood <ritu.sood@intel.com>
2017-09-17Adding reading service-id from AA&IRitu Sood2-14/+61
For VFC adding getting service-id from AA&I. Issue-Id: POLICY-57 Change-Id: I740c7749bfb2d395851cbd5eb3e486bf4eb9b560 Signed-off-by: Ritu Sood <ritu.sood@intel.com>
2017-09-15Fix sonar criticalPamela Dragosh5-9/+28
Last transient/serializable issues. Throw a dedicated exception for DateUtil class Unused imports Make the enclosing method "static" or remove this set. Issue-ID: POLICY-115 Change-Id: I366f85922c4d4d290b320e0b88678c805de59872 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2017-09-15Merge "ONAP AAI GET Query code"Jorge Hernandez3-2/+150
2017-09-15Merge "Fix sonar criticals"Jorge Hernandez20-41/+43
2017-09-15ONAP AAI GET Query codeJoseph Chou3-2/+150
Update ControlLoopEventManager to raise exception on null AAI response Issue-ID: POLICY-103 Change-Id: Iebe8b03269a1801c4293600920aa267490cea1af Signed-off-by: Joseph Chou <jc2555@att.com>
2017-09-15Fix sonar criticalsPamela Dragosh20-41/+43
Either re-interrupt this method or rethrow Exception Transient/Serializable issues Unused imports logging exceptions Issue-ID: POLICY-115 Change-Id: I4c8a0c780e2f6c6e8218c1457f18470f7d95919c Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2017-09-15Master lab template changes for MSO rename to SOHockla, Ali (ah999m)4-21/+21
Issue-ID: POLICY-162 Change-Id: Ieb0952379cd854e0ed8e4a3b068b7e29f3b93770 Signed-off-by: Hockla, Ali (ah999m) <ah999m@att.com>
2017-09-15Merge "Modify AAI simulator to support new requests"Pamela Dragosh16-56/+155
2017-09-15Modify AAI simulator to support new requestsCharles Cole16-56/+155
Updated the AAI simulator to support new AAI queries. Also, modified the post response to allow multiple responses. Added code to ensure the simulators were able to sucessfully start up. Change-Id: I3e855b5e54c073f55fbaadc0064c140695fc1a58 Issue-ID: POLICY-200 Signed-off-by: Charles Cole <cc847m@att.com>
2017-09-14Clear eclipse warnings and sonarPamela Dragosh9-82/+35
Removing warnings introduced with A&AI code. This should also address sonar criticals and majors. Issue-ID: POLICY-140 Change-Id: I3f8186dd9c5aa52bfbb061bf95d67b5614b3fb2e Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2017-09-14Merge "Move credential information out of persistence.xml"Jorge Hernandez5-13/+69
2017-09-14Merge "master lab template maintained under archetype"Jorge Hernandez17-90/+1721
2017-09-14master lab template maintained under archetypeJorge Hernandez17-90/+1721
This is work in progress, the official pom.xml with dependencies, drl template, and support files for controller deployment are maintained here. In the near future the junit template should be consolidated with this one. Added controlloop.properties.environment, this environment file will be populated at installation time with the lab's aai url, etc .. and will be accessible by any drools application such as control loops through the PolicyEngine interface. Note that PDP-D server already supports these environment files, so it is just natural. Therefore, this is the default mechanism to provide to applications, the url, username, and passwords to use at runtime by the control loops for the time being. In the future MSB could set them globally here through existing APIs, or it can be queried by any drools application using MSB library, doesn't matter. There's been some trouble playing nicely with the dependencies used by a control loop application classsloader, and the pdp-d middleware one, causing issues between dependencies version of libraries. Specifically, the snakeyaml library does not play well across classloader when using constructor functionality, note that the snakeyaml libraries are pulled also from jackson parsers used in the pdp-d. I made a change in ControlLoopProcessor to specifically tell the "Yaml" object which classloader to use in order to find the class with the constructor that is intended to be built, otherwise, yaml libraries use a different classloader that does not have visibility into the ControlLoopPolicy that is trying to construct, and fails. This also should respect junits that use the same classloader I pressume and does not give issues. Change-Id: I36271d29cdbf8ff861f9c03ff91cf7116927906a Issue-ID: POLICY-162 Signed-off-by: Jorge Hernandez <jh1730@att.com>
2017-09-14Move credential information out of persistence.xmlTemoc Rodriguez5-13/+69
Move credential information out of persistence.xml. Define properties file which will contain the credentials instead. Access db using new properties file. Issue-ID: POLICY-55 Change-Id: I01ad0611c053ad4285de2a225fca7920a3b1bc8f Signed-off-by: Temoc Rodriguez <cr056n@att.com>
2017-09-14Merge "Added changes for vDNS Use Case"Jorge Hernandez40-235/+620
2017-09-14Added changes for vDNS Use CaseHockla, Ali (ah999m)40-235/+620
-Renamed remaining MSO classes and packages to SO and modified drl accordingly -Connected SO Interface to SO Simulator -Added vDNS Control Loop junit -Modified SOActorServiceProvider to reflect AAI class changes (POLICY-103) Issue-ID: POLICY-102 Change-Id: Iea5d3f096c4ccfedde68e79d7593d66331127aaf Signed-off-by: Hockla, Ali (ah999m) <ah999m@att.com>
2017-09-13Fix AAINQF199 object references to AAINQ objectsdaniel1-14/+14
This is a small change to now reference the new AAI model instead of using the older AAINQF199 model. Issue-ID: POLICY-104 Change-Id: I2a1d2830fbd3bd7d62a9e27067a8c32a1c1ab4b1 Signed-off-by: daniel <dc443y@att.com>
2017-09-13Merge "Fix A&AI Named Query for vFW"Jorge Hernandez6-19/+106
2017-09-13Merge "ONAP code for AAI, consolidate name and get query"Jorge Hernandez32-23/+1918
2017-09-12Fix A&AI Named Query for vFWdaniel6-19/+106
The vFW named query has now been verified with the A&AI simulator. Null checks were added to make the namedQuery method work properly. In addition, a recursive A&AI response parser was added to traverse the response to find the correct generic-vnf object with the target vnf-id. For now the simulator URL is hard coded and the UUID of the named query is hard coded. These should be configurable in future releases. Issue-ID: POLICY-104 Change-Id: I05a1a992ff68ca2c17fb6a578983e6b21626bf44 Signed-off-by: Daniel Cruz <dc443y@att.com>
2017-09-12ONAP code for AAI, consolidate name and get queryJoseph Chou32-23/+1918
Adding AAI GET query feature to support ONAP project (1 commit) Issue-ID: POLICY-103 Change-Id: I0a55f41c3edd7a0bc0562ae4e12a19f262a50d74 Signed-off-by: Joseph Chou <jc2555@att.com>
2017-09-12Merge "Fix nullPointerException"Jorge Hernandez1-2/+3
2017-09-12Merge "Fixing VFC Model response class"Pamela Dragosh4-43/+10
2017-09-12Fix nullPointerExceptionTemoc Rodriguez1-2/+3
Fix nullPointerException by changing return values of attributesProvided and attributesRequired from null to empty Set. Issue-ID: POLICY-55 Change-Id: I9516a9bcad591cc582834cb49fa54e58a1f45a47 Signed-off-by: Temoc Rodriguez <cr056n@att.com>
2017-09-12Fixing VFC Model response classRitu Sood4-43/+10
Fixed the response class for VFC response and also removed the Ignore test case. Change-Id: I4373e86399089b7a3d743be4d19f76cc37d1ceea Issue-id: POLICY-57 Signed-off-by: Ritu Sood <ritu.sood@intel.com>
2017-09-11Add Support for Locking VNF Target Typesdaniel4-11/+18
Fixed the target lock to support vnf target_types. Generic-vnf.vnf-id and generic-vnf.vnf-name are also supported when retrieving the target instance from the onset. These changes are relfected in the vFW and vCPE junits as they now work with VNF target types. Issue-ID: POLICY-222 Change-Id: I92abeb02c769d35f3a9912cce6eaaec4c9cc8efb Signed-off-by: Daniel Cruz <dc443y@att.com>
2017-09-11Move the simulators to a new packageCharles Cole12-49/+159
Moved the simulators to the simulators project in controlloop/common. They can now be accessed with the Util class in the simulators project or the Util class in template.demo, for backwards compatability. Also renamed AaiSimulator to AaiSimulatorJaxRs Issue-IS: POLICY-200 Change-Id: Id131af0243777db31a8f22e110d8a708dc033dcf Signed-off-by: Charles Cole <cc847m@att.com>
2017-09-11Fix Eclipse warnings for raw type parameterizationPamela Dragosh1-4/+4
Eclipse generates warnings for raw types and 2 fields are not accessed statically. Issue-ID: POLICY-102 Change-Id: Ibeb2a76d527949cfd7283ab1a78d97e582725337 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2017-09-11Merge "Cleanup project's name in Sonar"Pamela Dragosh1-1/+1
2017-09-08Set this class as serializablePamela Dragosh4-29/+32
Fixing sonar critical to make this simple class serializable. Issue-ID: POLICY-115 Change-Id: I6a3cf8b1c8c27f434e26d9f2909b2ef38c72825b Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2017-09-08Cleanup project's name in SonarJessica Wagantall1-1/+1
The name parameter in the root pom.xml should match the project name in gerrit to reflect consistency in Sonar. Change-Id: If7e35a530da07411dc0b534da7f185bdb43368dd Issue-id: CIMAN-65 Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
2017-09-08Merge "Clearing sonar critical for missing serialization"Pamela Dragosh3-6/+15
2017-09-08Clearing sonar critical for missing serializationPamela Dragosh3-6/+15
These classes should be serializable in order to remove the sonar critical. Also clearing unused import/code messages. Issue-ID: POLICY-115 Change-Id: I25e504f6edae9fb38080e7d4d33b2b3e4cde4637 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2017-09-08Added changes for vDNS Use Case - MSO InterfaceHockla, Ali (ah999m)40-918/+2424
Rebased and fixed merge conflicts Issue-ID: POLICY-102 Change-Id: Icc36a2cf6391aa9137593bc04f0d4543798b7ccd Signed-off-by: Ali Hockla <ah999m@att.com> Signed-off-by: Hockla, Ali (ah999m) <ah999m@att.com> Signed-off-by: HOCKLA <ah999m@att.com> Signed-off-by: Hockla, Ali (ah999m) <ah999m@att.com>
2017-09-07Merge "Support drl compilation at design/development time"Jorge Hernandez3-1/+20
2017-09-07Add in-mem db to ControlLoopXacmlGuardTestTemoc Rodriguez8-238/+348
Add in-mem specification in test/resources/META-INF/persistence.xml for junit. Use system properties to choose which db to use. Removed named parameters in PIPEngineHistory.java. Change 6.3.0 versions of drools-core to 6.5.0 in pom. Make PIPEngineGetHistory query more general. Increased sleep times in junit. Issue-ID: POLICY-55 Change-Id: I6bc65fd88c43c4e7143f27a7e6d8666c2c4df060 Signed-off-by: Temoc Rodriguez <cr056n@att.com>
2017-09-07Support drl compilation at design/development timeJorge Hernandez3-1/+20
Change-Id: I0fe6277f92c0db7f596ff73d81987e2e78b5793e Issue-ID: POLICY-162 Signed-off-by: Jorge Hernandez <jh1730@att.com>
2017-09-07Merge "Add APPC LCM Interface"Pamela Dragosh40-101/+3683