aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2019-02-18Removed null custom codersJim Hahn10-41/+8
Some code still referenced the customJacksonCoder() method, which has been removed from drools-pdp. However, all the code did was set the jackson & gson coders to null, which is unnecessary, as that is the default value for both. Thus the code was removed altogether so-as not to cause issues in the future. Updated license dates. Change-Id: Ie6f6bc8360890485ca50a751477650af7387b397 Issue-ID: POLICY-1429 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-02-11Merge "Consolidate xacml dependencies"Pamela Dragosh8-140/+38
2019-02-11Merge "basic image with CL app preloaded"Pamela Dragosh7-3/+378
2019-02-08basic image with CL app preloadedJorge Hernandez7-3/+378
The image can replace the drools-pdp and only overrides what is necessary to make sure the CL application is in the image. There should be no functional difference. Tooling to operate with docker images is provided as well, for example: controlloop/tools/docker-cl --help BUILD INFO: image: policy-pdpd-cl image-path: controlloop/packages/docker-controlloop/target/policy-pdpd-cl image: policy-pdpd-cl registry: nexus3.onap.org:10003 patch: 1.4.0-SNAPSHOT version: 1.4-SNAPSHOT timestamp: 20190207T220835 TAGS: BUILD: verify: onap/policy-pdpd-cl:latest nexus3.onap.org:10003/onap/policy-pdpd-cl:1.4-SNAPSHOT-latest nexus3.onap.org:10003/onap/policy-pdpd-cl:1.4.0-SNAPSHOT-20190207T220835Z merge: onap/policy-pdpd-cl:latest nexus3.onap.org:10003/onap/policy-pdpd-cl:1.4-SNAPSHOT-latest nexus3.onap.org:10003/onap/policy-pdpd-cl:1.4.0-SNAPSHOT-20190207T220835Z release: onap/policy-pdpd-cl:latest nexus3.onap.org:10003/onap/policy-pdpd-cl:latest nexus3.onap.org:10003/onap/policy-pdpd-cl:1.4-SNAPSHOT-latest nexus3.onap.org:10003/onap/policy-pdpd-cl:1.4.0-SNAPSHOT-STAGING-20190207T220835Z PUSH: verify: merge: nexus3.onap.org:10003/onap/policy-pdpd-cl:1.4-SNAPSHOT-latest nexus3.onap.org:10003/onap/policy-pdpd-cl:1.4.0-SNAPSHOT-20190207T220835Z release: nexus3.onap.org:10003/onap/policy-pdpd-cl:1.4-SNAPSHOT-latest nexus3.onap.org:10003/onap/policy-pdpd-cl:1.4.0-SNAPSHOT-STAGING-20190207T220835Z SYNTAX: docker-cl [--help|-h] [--build|-b <repo:tag>] [--push|-p <repo:tag>] [--verify|-v] [--merge|-m] [--release|-r] [--run <volume-full-path>] [--cmd <volume-full-path> <cmd>] Change-Id: I0917c0bca212fc0b543e52ae1615c513d43f7d93 Issue-ID: POLICY-1505 Signed-off-by: Jorge Hernandez <jorge.hernandez-herrero@att.com>
2019-02-08Consolidate xacml dependenciesJim Hahn8-140/+38
The xacml dependency appeared in multiple drools-applications pom files, with different exclusion lists. The dependencies have been consolidated into a single pom, with a combined exclusion list. Added comment to the exclusion list. Change-Id: I2a5a66619b376879b44c5e0ce064d7e52c4482bf Issue-ID: POLICY-1429 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-02-08Remove msb project from drools-applicationsJim Hahn11-669/+0
The msb project is no longer needed, so it has been removed. Change-Id: I54b9e2210f11a3c95479fbb83e0564afdfbc5728 Issue-ID: POLICY-1429 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-02-04Assign control loop domain to rules artifactJorge Hernandez1-1/+1
Change-Id: Ia14fe420c54d0535c5f73f572e6ddc9d5797dd67 Issue-ID: POLICY-1500 Signed-off-by: Jorge Hernandez <jorge.hernandez-herrero@att.com>
2019-02-02Use helper class to retrieve network loggerKrzysztof Opasiak6-43/+50
Instead of abusing constant from Topic interface use new dedicated helper class to retrive network logger. Issue-ID: POLICY-1486 Depends-On: Ic1f07466e1ab6abcc00098e617f0e82da19e852d Change-Id: I453a14c3dda337f2a4d08914ead32b37adc17353 Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
2019-01-16Remove jackson from policy/drools-applicationsJim Hahn3-2/+14
Excluded jackson-databind from xacml.jar dependencies. Change-Id: Ia3eb25a33013a04e697e98dcfe6064295bfae138 Issue-ID: POLICY-1429 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-01-14Remove guard checkstyle suppressionsJim Hahn28-276/+249
Renamed a number of fields and methods, in the Guard classes, to conform to camel-case format. Also updated some toString() methods to return "xxxId=" instead of "xxxID=", if the corresponding field names were also xxxId. Updated license data in one changed file. Change-Id: Idac58f8744b5523d6daed7f369026495dd357bf8 Issue-ID: POLICY-1140 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-01-14Remove eventmanager checkstyle suppressionsJim Hahn8-150/+118
Renamed enum class name and various method names in ControlLoopEventManager. Change-Id: I18b4a7d30a24dfcf3b155fd662433590b9d4c769 Issue-ID: POLICY-1138 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-01-14Remove model-imp/rest checkstyle suppressionsJim Hahn20-117/+90
Renamed "RESTManager" class to "RestManager". This did not require any changes to rules. Updated license data in pom. Change-Id: Ide59b99b8c5d939804b7540c71a686404195173c Issue-ID: POLICY-1141 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-01-11Remove model-impl/so checkstyle suppressionsJim Hahn52-504/+461
Renamed classes from "SOxxx" to "SoXxx". Also renamed a few method names to make them camelcase, too. Updated drl files with above changes. Change-Id: I06aa303a20911733f870947c55e01f3a2dc66fa3 Issue-ID: POLICY-1143 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-01-11Merge "Remove trafficgenerator checkstyle suppressions"Jorge Hernandez7-59/+28
2019-01-11Merge "Remove model-impl/vfc checkstyle suppressions"Liam Fallon26-194/+163
2019-01-10Remove trafficgenerator checkstyle suppressionsJim Hahn7-59/+28
Changed class names from "PGxxx" to "PgXxx". Change-Id: I1ea41e94c00ef98d68a6f6617a0173522c91f326 Issue-ID: POLICY-1144 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-01-10Remove feature-cl-trans checkstyle suppressionsJim Hahn4-368/+362
Extracted CacheBasedControlLoopMetricsManager into its own class file. Change-Id: I075d423192eb7a8d44cad7ccae8db8fcfe2715f7 Issue-ID: POLICY-1139 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-01-10Remove model-impl/vfc checkstyle suppressionsJim Hahn26-194/+163
Entails renaming VFCxxx classes and updated drl files, as well. Change-Id: Ib31c61a35536df22772de6090761b22beb1b561b Issue-ID: POLICY-1145 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-01-08Restructuring packaged features installationJorge Hernandez15-481/+192
Some cleaning on the installation. feature-controlloop-management will be installed by default and will contain new capabilities plus common functionality from amsterdam and casablanca. Change-Id: Ic751d3002b5b05342138c77f61209b6c32010ce9 Issue-ID: POLICY-1367 Signed-off-by: Jorge Hernandez <jorge.hernandez-herrero@att.com>
2018-12-19Merge "Add sdnc simulator in controlloop-utils"Jorge Hernandez4-2/+14
2018-12-18Add sdnc simulator in controlloop-utilsVidyashree Rama4-2/+14
Add sdnc simulator in controlloop-utils Issue-ID: POLICY-1356 Change-Id: I999a402370c2ebeeff75d647bd1d72c42dd598f7 Signed-off-by: Vidyashree Rama <vidyashree.rama@huawei.com>
2018-12-17Telemetry extension to manage Operational PoliciesJorge Hernandez15-0/+1155
This is work in progress to directly work with Operational Policies with the casablanca controller for now. It is part of prototyping efforts to enhance the management of control loops, but the functionality can be used in production environments. Change-Id: I4fcb748e162ed38ad4cc4ca22cc4e278fd4c4096 Issue-ID: POLICY-1383 Signed-off-by: Jorge Hernandez <jorge.hernandez-herrero@att.com>
2018-12-01Merge "Update eclipselink version in drools-apps"Liam Fallon4-8/+4
2018-11-30Update eclipselink version in drools-appsJim Hahn4-8/+4
Use eclipselink from policy parent. Change-Id: I468688a79f2f6eb0ca0fd42dc194abc4fb5654f0 Issue-ID: POLICY-1362 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-11-30Merge "Reduce resp values meth complexity"Jorge Hernandez5-49/+208
2018-11-30Reduce resp values meth complexityKrishnakumar Jinka5-49/+208
The response values determining method has more complexity reduce it using enums. Fix build fail due to incorrect response value. Modify LCM response code to enum. Fix enum package. Modify status code enum. Add modification copyright notice. Fix review comments. Add serialization key Issue-ID: POLICY-1251 Change-Id: I49909b6dd2810dd864784afab0a328b855131501 Signed-off-by: kris.jinka <kris.jinka@samsung.com> Signed-off-by: krisjinka <kris.jinka@samsung.com>
2018-11-26Rename test classes in drools-applicationsParshad Patel23-157/+157
Make test classes name consitence by adding 'Support' or 'Dummy' at start of util or dummy type of test classes Issue-ID: POLICY-1258 Change-Id: Idea946375ee46f14512d4c4bc29e65adaa4d2b37 Signed-off-by: Parshad Patel <pars.patel@samsung.com>
2018-11-16Remove unused imports in controlpolicykris.jinka12-57/+172
Remove unused imports that got introduced in recent commits Fix issue with compile failure of test class due to dependency in drools-pdp Datamodel classes. Fix test failures due to compile issues Issue-ID: POLICY-1251 Change-Id: Ib8e496ab96aaa5de67e4f84fa8de515b3dc22ea5 Signed-off-by: kris.jinka <kris.jinka@samsung.com>
2018-11-15Merge "Rename test classes in drools-applications"Jorge Hernandez70-73/+73
2018-11-15Rename test classes in drools-applicationsParshad Patel70-73/+73
Make test classes name consistence by putting 'Test' at end as per google java style guide Issue-ID: POLICY-1258 Change-Id: Id79e5d3fe3688f7f2569b7996613595cc6b746e7 Signed-off-by: Parshad Patel <pars.patel@samsung.com>
2018-11-14Merge "Use parameter obj for policy results"3.0.0-ONAP1.3.4Pamela Dragosh3-42/+96
2018-11-13Fix guard history database configurationJorge Hernandez1-4/+4
Change-Id: I70742b9be80a0b0f77730e2453f96f1d3e7826dd Issue-ID: POLICY-1257 Signed-off-by: Jorge Hernandez <jorge.hernandez-herrero@att.com>
2018-11-13Use parameter obj for policy resultskris.jinka3-42/+96
Policy result method uses more params than allowed Use parameter object for setting params instead Issue-ID: POLICY-1251 Change-Id: I6bf1f20896dc5176811bc363a390c682faa06ca4 Signed-off-by: kris.jinka <kris.jinka@samsung.com>
2018-11-12Merge "Close timing loop-hole when YAML updated"Pamela Dragosh11-70/+1122
2018-11-12Use builder for trigger policykrishnajinka3-52/+140
Fix an issue reported by sonar for using more than 7 parameters in the method. Issue-ID: POLICY-1251 Change-Id: I07d668b706a27dcc03e862d08262f2c0269ad4b7 Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-11-09Close timing loop-hole when YAML updatedJim Hahn11-70/+1122
Noticed when YAML updates are pushed close together that some Params objects are deleted that should not be. Fixed that by eliminating the "active" list concept and only deleting a Params object that has an associated cleaner. If it has no cleaner, then it can't be deleted, regardless of timing with rule updates. Added more tests for rule updates, including cases to check for event objects being retracted, as well as Params objects being retracted when rules are deleted. Change-Id: I6b744b29fca228022f43e9322ea149b16d097675 Issue-ID: POLICY-1248 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-11-08Merge "Apply builder pattern for policy"Jorge Hernandez4-28/+180
2018-11-07Apply builder pattern for policyKrishnajinka4-28/+180
Fix an issue reported by sonar for using more than 7 parameters in the method. Fix imports order in files. Fix line lengths to less than 120 chars Issue-ID: POLICY-1251 Change-Id: I42defc9d6acf970bb555c4a6c5d172241231e483 Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-11-06Merge "Cleanup all Param objects when any rules change"Pamela Dragosh20-278/+1139
2018-11-05Cleanup all Param objects when any rules changeJim Hahn20-278/+1139
Fix license date for new junit test. Updated some comments. Ensured different control loop names in different rule sets of new junit test. Used different mechanism for examining facts in new junit test. Fixed typo in comment. Changed the way new junit checks for existence of facts. Fixed another typo in comment. Updated clean-up rules in CLC template and added junit test to verify that Params are cleaned up appropriately. Removed code that retracts $manager objects so that the manager clean-up rule will be used, instead, thus ensuring that all associated objects are deleted when the manager is deleted. This was done for amsterdam, CLC, and casablanca templates. Added an extra fireAllRules() after calls to fireUntilHalt() to enable clean-up rules to fire in junit tests. Address Josh's review comments. Enhance junit test to compare actual object references to ensure that Param objects are as expected. Change-Id: If1fefd3f57e417180c62a3849defbaa6ae83afc1 Issue-ID: POLICY-1248 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-11-02Exclude commons-collectionsPamela Dragosh1-0/+9
This should have been carried over from template.demo. Issue-ID: POLICY-1228 Change-Id: I8148ae98c9a30d4342482bbba688d6d2e8088892 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-11-02Merge "Re-added requestParams to vDNS policy"Pamela Dragosh6-8/+10
2018-11-02Re-added requestParams to vDNS policyJim Hahn6-8/+10
Undo inadvertent change to compiler test. Change-Id: I1973612f4783936271c3fd74fb978a4f263a14a9 Issue-ID: POLICY-1240 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-11-02Merge "Upgrade xacml 1.0.2"Liam Fallon8-10/+10
2018-11-02Upgrade xacml 1.0.2Pamela Dragosh8-10/+10
This version of xacml only has license changes to the java source files. This will clear ONAP license issues. Issue-ID: POLICY-1228 Change-Id: Ieaff4d52c8046fee8357f7ebc907f2643d77322c Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-11-01Changed actor from "MSO" to "SO"Jim Hahn1-13/+5
Also added "VF Module Delete" to the list of recipes for "SO" accepted by the compiler. Removed "AOTS" and "SDNO" from the list of accepted actors, as code does not exist for those actors. Update remaining actors and recipes. Left "AAI" in the list for now, though it has no recipes listed (and no actor.aai code). Also removed "AAI" from the list of accepted actors. Change-Id: I9db56715d8bea3cf86d2112df1e0086777863192 Issue-ID: POLICY-1239 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-10-31Remove single quotes from casablanca templateJim Hahn2-2/+2
The shell scripts used to populate the operational policies for the casablanca template do not work if the yaml includes single quotes. Replaced the single quotes with %27 instead. Change-Id: I31b20708b69153ecb67b7ac8136f464dbf2ce0c6 Issue-ID: POLICY-1240 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-11-01Merge "Added config params to scale-out policy"Pamela Dragosh5-8/+9
2018-11-01Merge "Add /serviceInstances/ to SO URL for scale-out"Pamela Dragosh4-5/+6
2018-10-31Added config params to scale-out policyJim Hahn5-8/+9
Removed requestParameters and reverted name. Change-Id: Ia3470a751b22375206c571204eff8985e630e05f Issue-ID: POLICY-1240 Signed-off-by: Jim Hahn <jrh3@att.com>