summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2020-03-13Fix sonar issues in drools-applicationsJim Hahn14-451/+42
Fixed various sonar issues, including moving some code to policy-common. Fixed some eclipse warnings, including deprecated junit APIs. Issue-ID: POLICY-2426 Signed-off-by: Jim Hahn <jrh3@att.com> Change-Id: I10b40c1e5af62308f2e4c315e4d399aafff2998f
2020-03-12Retool rules testsJim Hahn76-2508/+4103
Extracted common code from various XxxBaseTest classes into: - Topics class to manage messages for test topics - HttpClients class to manage HttpClient objects for tests - Simulators class to manage simulators for tests - Rules class to manage start up and shutdown of rules Merged remaining code from XxxBaseTest classes into a single class. Modified the Frankfurt and Usescases tests to subclass from this new class and specify just the relevant tests to be executed. Issue-ID: POLICY-2385 Signed-off-by: Jim Hahn <jrh3@att.com> Change-Id: Iaf83c9d2b205a4c343e0dde23ec86508f5773693
2020-03-10Use predefined domain policies from drools corejhh15-1095/+15
Issue-ID: POLICY-2388 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I5948ed5152297e4addbab444ed65dcd3b8002492
2020-03-09Bug fixes to new rulesJim Hahn12-18/+686
Also added VdnsTest, VfwTest, and VcpeTest. Fixed a number of issues with notifications: - event data (e.g., AAI) was missing - notification was missing for the start of an operation - "message" and "history" fields should contain Target object, target entity - "message" field was missing various details (e.g., start time) Still missing subRequestId - that will require enhancements to the actors. Issue-ID: POLICY-2385 Signed-off-by: Jim Hahn <jrh3@att.com> Change-Id: I7fc33ebcd5939d2f33a9d209ac6119e390e0836d
2020-03-09Merge "ONAP m2 base junit coverage"Pamela Dragosh6-167/+390
2020-03-06Add frankfurt rules for Actor redesignJim Hahn66-13/+7857
Note: VcpeTest and VfwTest are not included, as they depend on updates to the APPC and APPC-LCM Actors. Added feature-controlloop-frankfurt. Added HTTP client property files to feature-controlloop-management. Updates per review comments: - pom changes - simplify FrankfurtBase - rename event-svc-http.properties - change "usescases" to "frankfurt" - use blanks for CDS property defaults - trailing spaces in http-client files - add https property to http-client files Added newlines to config files that appear to be missing them (based on feedback from gerrit). Issue-ID: POLICY-2385 Signed-off-by: Jim Hahn <jrh3@att.com> Change-Id: Ib4a4d75461c734ae47309e41dc9d099e8815d55d
2020-03-06ONAP m2 base junit coverageChou, Joseph (jc2555)6-167/+390
Added testcases to improve code coverage Issue-ID: POLICY-2289 Change-Id: Ib573ae668b5bca008c4600df99e7f1cf4053d1a1 Signed-off-by: Joseph Chou <jc2555@att.com>
2020-03-04Merge "decouple topics from controllers"Jorge Hernandez9-27/+188
2020-03-03decouple topics from controllersjhh9-27/+188
native policies will require topics configured at installation (there's no policy to add them). This configuration style also cleans the installation tidier (topics can be overriden or new ones added when being placed in the mounted config directory). Issue-ID: POLICY-2181 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I87fd6889c651147e9229b3487db8c95b34516dfd
2020-03-03use policy/parent awaitilityPamela Dragosh20-205/+30
Also cleaned up a bunch of these pom's, they do not all need to declare JUnit, assertjr, mockito testing classes. Can use more cleanup in some other common dependencies, but we'll defer. Issue-ID: POLICY-2381 Change-Id: Ib1149a0cd0215d1a38d5b625634440413cf79089 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-03-01Use apache Pair not Sdnr custom PairPamela Dragosh1-7/+7
Companion review to https://gerrit.onap.org/r/c/policy/models/+/102162 in which use of Pair from apache vs creating our own. Removed an unused import. Issue-ID: POLICY-2382 Change-Id: Id3cf9a170480c7a621dddf93540d61f993f3553a Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-02-29Tosca policies missing "final_xxx" fieldsJim Hahn1-12/+27
The code that makes Tosca policies backward compatible was not copying the final_xxx fields (e.g., final_failure_retries). Added code to copy the fields. Issue-ID: POLICY-2376 Signed-off-by: Jim Hahn <jrh3@att.com> Change-Id: I05d746ee9c8ace263c7b33a245221c5eb71b612c
2020-02-24vDNS tosca compliant policies supportjhh10-128/+197
Issue-ID: POLICY-2383 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I5d5d864b2853f6e7e0c7e1096cb17746500f2495 Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
2020-02-21Tosca compliant vFirewalljhh11-47/+173
Issue-ID: POLICY-2376 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I362ebbd941c400a6ffc3e952e66ca2d624afbfdd Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
2020-02-18Merge "tosca compliant op policy support + vcpe test"Liam Fallon34-510/+1658
2020-02-18Merge "Inherit from PDP-D (native policies) base image"Jorge Hernandez5-323/+81
2020-02-17tosca compliant op policy support + vcpe testjhh34-510/+1658
Tosca Compliant and Toscal Legacy Operational policies are both supported for backwards compatibility. vCPE usecase junits to support 2 equivalent policies, one tosca compliant and the other one legacy. Issue-ID: POLICY-2360 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: Iafbfc92bbec42e6a3fe4ceb4a9a17c85e636ea14 Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
2020-02-17Inherit from PDP-D (native policies) base imagejhh5-323/+81
Depends on https://gerrit.onap.org/r/#/c/policy/docker/+/101758/ for package cleanup and the native Dockerfile refactoring from https://gerrit.onap.org/r/#/c/policy/drools-pdp/+/101802/. Issue-ID: POLICY-2181 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I6cf2b945157a91abd9985bcff1e70ae6a30ae15d Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
2020-02-14Change ip adresses used for m2 testsBruno Sakoto3-10/+32
By default Mac OS is not able to use loopback addresses other than 127.0.0.1. Issue-ID: POLICY-2368 Signed-off-by: Bruno Sakoto <bruno.sakoto@bell.ca> Change-Id: Ibf4a884d2669a5f4969960963638aa213eebf172
2020-02-13Add tests to AppcLcm to increase coveragedg57623-7/+202
Add additional test cases to AppcLcm to increase jUnit test coverage this includs adding the file AppcLcmActorTest.java. Minimum test converage for the java files is over 80%. Issue-ID: POLICY-2291 Signed-off-by: dg5762 <dg5762@att.com> Change-Id: I26ed2b90f12f51568ceed843b65d2f119155391f
2020-02-09Merge "Updating module names to resolve conflicts"Jim Hahn20-26/+41
2020-02-07activate refactoring in ControlLoopEventManagerjhh1-62/+69
This is to support backwards compatible implementation of Tosca Compliant Operational Policies. Issue-ID: POLICY-2360 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I0e8b96b19375c58e4b62e0dcd1da5c508091ea2f Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
2020-02-07Updating module names to resolve conflictsRam Krishna Verma20-26/+41
Issue-ID: POLICY-2355 Change-Id: If13badaf332f5e4341e23b9dcf22e177e9b67ff2 Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2020-02-06Use CanonicalOnset in usecases.drljhh2-23/+16
Issue-ID: POLICY-2323 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: Ic1258e17c08eacbf8d3a57a6562ba470420e615f
2020-01-17DCAE Onset flood preventionjhh6-9/+64
Issue-ID: POLICY-2323 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I08cd55b442ccce3e0eaaa63c1ebd4422c1e0a0d5 Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
2020-01-17Add jUnit Test Coverage M2 GuardPeyton Puckett2-1/+67
Issue-ID: POLICY-2290 Change-Id: I05a737333141576512841d6872ecdb0a089a0a90 Signed-off-by: Peyton Puckett <peyton.puckett@att.com>
2020-01-17Update m2 test to mockito2 for JDK 11Pamela Dragosh2-2/+2
Peyton's review was pulled in before Ali's JDK 11 fix. So unfortunately this update did not get done. Issue-ID: POLICY-1587 Change-Id: I9666b6e2f2327183e15bfe19d34515d0426c8ff0 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-01-16Merge "Update sonar config"Jorge Hernandez3-78/+16
2020-01-16Update sonar configPamela Dragosh3-78/+16
Get rid of deprecated sonar settings, exclude sub-module that doesn't have code, and ensure there is a single jacoco-ut.exec file created. Issue-ID: POLICY-2321 Change-Id: I05d1c0e4d599aff7c6ad0fec39ff1220cdb9a72d Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-01-16Merge "policy/drools-apps jdk11 upgrades"Pamela Dragosh40-150/+174
2020-01-16policy/drools-apps jdk11 upgradesHockla, Ali (ah999m)40-150/+174
Issue-ID: POLICY-1587 Change-Id: I02bef6c829f2f24954ae73fb0c540ab7198775ce Signed-off-by: Hockla, Ali (ah999m) <ah999m@att.com>
2020-01-14Add jUnit Test Coverage M2 UtilPeyton Puckett2-2/+70
Issue-ID: POLICY-2293 Change-Id: Ia189239911053bd8937c0791aafcc55207c11dcf Signed-off-by: Peyton Puckett <peyton.puckett@att.com>
2020-01-13Merge "Add m2 model, including the LCM application"Pamela Dragosh46-0/+7718
2020-01-13Merge "Parameterize base-image version for drools-apps"Pamela Dragosh2-2/+29
2020-01-13Merge "Support override of xml config files"Ram Krishna Verma1-9/+13
2020-01-10Point to policy/models release versionHockla, Ali (ah999m)1-2/+2
Issue-ID: POLICY-1592 Change-Id: I34ea6afc94d36802a695c7b15b61fcaa0112c427 Signed-off-by: Hockla, Ali (ah999m) <ah999m@att.com>
2020-01-10Support override of xml config filesjhh1-9/+13
This included logback*.xml (including controller ones). Issue-ID: POLICY-2308 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I69471fc0ce5b6ea143560f78019a55daedfd465b
2020-01-10Add m2 model, including the LCM applicationStraubs, Ralph (rs8887)46-0/+7718
Issue-ID: POLICY-1948 Change-Id: I18a5231d3102073c928a591c9e91b241b7093680 Signed-off-by: Straubs, Ralph (rs8887) <rs8887@att.com>
2020-01-09Add ControlLoopParams from models repo.jhh10-16/+171
This class is only useful under drools applications and eventually will be deprecated to accommodate the new Operational Policy Types. Issue-ID: POLICY-2146 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I68927cb144a33fac6fe330be15fe60aee32b15a1
2020-01-09Parameterize base-image version for drools-appsBruno Sakoto2-2/+29
Issue-ID: POLICY-2318 Signed-off-by: Bruno Sakoto <bruno.sakoto@bell.ca> Change-Id: I5cc2761adb2621bca094fb035e626dd40baa08e1
2020-01-03Revert "Parameterize base-image version for drools-apps"Pamela Dragosh2-40/+1
This reverts commit a894ffb5f580dec7ab4e8ea367107fcee09fca1b. Reason for revert: Merge failure Issue-ID: POLICY-2318 Change-Id: I6ea6681677e0ee18f5bce0217f9216e590a53b77 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-12-23Parameterize base-image version for drools-appsRashmi Pujar2-1/+40
Issue-ID: POLICY-2318 Signed-off-by: Rashmi Pujar <rashmi.pujar@bell.ca> Change-Id: Ida14508366f20ca05648f941a9b326899672b274
2019-12-10changes to support offline pdpd control loopsjhh1-4/+6
Issue-ID: POLICY-2191 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: Ieb390de2f3324de2de8e6e54cdc10fbf5ede4070
2019-12-09moved proto-definition dependencyjhh2-6/+4
It shows in the /tmp/policy-install directory in the docker image. It does not need to be applied to all the drools-applications subprojects. Issue-ID: POLICY-2191 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: Ia2048b6e21068a7cd5e36439af368cf024975f01
2019-12-06Point to release versions of policy/parent and policy/commonHockla, Ali (ah999m)1-2/+2
Issue-ID: POLICY-1583 Change-Id: Iaff52d57d08689dedf2759afbd3b68cff4a9d22d Signed-off-by: Hockla, Ali (ah999m) <ah999m@att.com>
2019-11-22Merge "Use dependency management for cds proto-definition artifact"Jim Hahn4-30/+7
2019-11-21Use dependency management for cds proto-definition artifactRashmi Pujar4-30/+7
Refer to: https://gerrit.onap.org/r/#/c/policy/parent/+/98733/ Issue-ID: POLICY-2254 Signed-off-by: Rashmi Pujar <rashmi.pujar@bell.ca> Change-Id: Ia7fe2f294187f5c108781c8798890045445ab825
2019-11-21Merge "use case junit tests"Jorge Hernandez17-0/+1275
2019-11-20use case junit testsjhh17-0/+1275
added vcpe support added scale out support addressed some review comments added vfw support Issue-ID: POLICY-2249 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I245f8fc8d520cd2511080c9aee61bf7a0c0a1499 Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
2019-11-19Build tar.gz without requiring docker image buildjhh1-0/+5
This allows the tar.gz to be released by LF jobs. Issue-ID: POLICY-2250 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I0e12b05c051e12728b9b646838ce0b54579f8009