summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2019-11-11Merge "Do not hardcode io.fabric8 plugin"Pamela Dragosh1-1/+0
2019-11-08Do not hardcode io.fabric8 pluginPamela Dragosh1-1/+0
policy/parent now has this plugin defined Issue-ID: POLICY-2222 Change-Id: I9b212969a34b58206fcd88e154b72902451f6868 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-11-08Fix more sonar issues in drools-applicationsJim Hahn13-349/+99
Addressed the following sonar issues: - unused imports - unused method parameters - superfluous "throws" declaration - fields within a serializable class must also be serializable; this was/will be fixed with a change to AaiCqResponse in policy-models - use logger instead of System.out; turns out that the code that used System.out is no longer needed. In fact, deleted several classes that are no longer needed: ControlLoopLogger and ControlLoopPublisher - cyclomatic complexity and switch/case statements too big; used eclipse to extract chunks of code into separate methods - duplicate code Note: extracted common code and used lambdas to eliminate duplicate code in PolicyGuardYamlToXacml. However, a better approach would be to use object-oriented programming, using mini/nested objects to do the generation. The lambdas would then become abstract methods. Nevertheless, that would entail significantly more re-write of this class than desired at this time Issue-ID: POLICY-2225 Change-Id: Ie503ffd7accbad3e410af602d32b29c0095c3a33 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-11-06Update drools-application due to ↵Rashmi Pujar2-7/+7
https://gerrit.onap.org/r/#/c/policy/models/+/97989/ Issue-ID: POLICY-1896 Signed-off-by: Rashmi Pujar <rashmi.pujar@bell.ca> Change-Id: I6125a1c83f58411f08bb143ff21ccd66d4db4977
2019-11-05Merge "PNF support changes for drools-application"Liam Fallon9-24/+146
2019-11-04Inherit from snapshot drools docker imagejhh1-1/+1
Issue-ID: POLICY-2113 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I806d7bb2e766e3f0eccd5c1457c8d2683204abfb
2019-11-04PNF support changes for drools-applicationRashmi Pujar9-24/+146
Conditional checks for enrichment and validation by target-types PNF specific AAI enrichment Fixed Unit Tests Issue-ID: POLICY-1187 Signed-off-by: Rashmi Pujar <rashmi.pujar@bell.ca> Change-Id: I78bf73e454828253ca69695f9196047449b4d9d6
2019-11-01upgrade to 7.28.0.Final drools librariesjhh10-26/+7
Issue-ID: POLICY-1407 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: Ia3cd03719b52e2d4e1fad3662090b7c35e2acf1f
2019-10-29Update APPC LCM Model referencesDaniel Cruz13-113/+120
Updates to all references of APPC LCM model code based on changes in policy models for APPC LCM. Issue-ID: POLICY-2043 Change-Id: I0102eb27f449578636cfc0bf22124fa863f05724 Signed-off-by: Daniel Cruz <dc443y@att.com>
2019-10-25Reset the custom query flagJim Hahn3-9/+5
Some junits fail, depending on the order. Traced down to VfwControlLoopCdsTest, which sets the custom query flag, but does not reset it when the test is complete. Modified the test superclass to reset it at the start and end of each test class. Issue-ID: POLICY-2088 Signed-off-by: Jim Hahn <jrh3@att.com> Change-Id: I6c9ba7e37074945141ea64dfd130dc99f376a825
2019-10-22Modify drools-applications to use new Lock APIJim Hahn16-1449/+893
Modified code to use new Lock API. Also deleted TargetLock and PolicyGuard, as they are no longer needed. Issue-ID: POLICY-2113 Signed-off-by: Jim Hahn <jrh3@att.com> Change-Id: I5bc9b7732f9cfc6056789b2902d9f6f838b560be
2019-10-16Integrate cds actor service providerBruno Sakoto19-13/+890
* Add request enrichment with aai service instance id and vnf id * Implement cds grpc request * Implement VfwControlLoopCdsTest Issue-ID: POLICY-2088 Signed-off-by: Bruno Sakoto <bruno.sakoto@bell.ca> Change-Id: Ib44d447d6a3a70ff800a5760032b676fdfa32d9c
2019-10-08Fix syntax error when starting policyBruno Sakoto1-2/+2
Fix following syntax error in policy entry point: /opt/app/policy/bin/docker-entrypoint.sh: line 30: syntax error near unexpected token `fi' Issue-ID: POLICY-2088 Signed-off-by: Bruno Sakoto <bruno.sakoto@bell.ca> Change-Id: I517937f5ece8454d83f6c3cad1f96fba52b62317
2019-10-07Allow override of maven settings at instantiationjhh1-0/+22
Issue-ID: POLICY-2111 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: Ib7ec8beab2947fc9fbf55734d0412f444a963fe8 Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
2019-09-19Use snapshot version of models in drools-applicationsJim Hahn1-3/+3
Change-Id: Ifade840231beb3cb548d6dbb7ca69182dcce751a Issue-ID: POLICY-2065 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-09-11remove docker-cl scriptjhh1-273/+0
Issue-ID: POLICY-2077 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I4d085f33889cc6b6d3c2b9dbf093429adea2f10f
2019-09-10Bump versions for drools-apps masterJim Hahn27-27/+28
Change-Id: Ia94e1ba31d0e8b6a980d891df9b26fb6977acc95 Issue-ID: POLICY-2045 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-09-10Release drools-apps 1.5.2Pamela Dragosh1-0/+4
Releasing 1.5.2 of drools-applications Issue-ID: POLICY-2045 Change-Id: Ie3f7588a83158bdd49cfd43e7b8fe76907d16e8d Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-09-10Upgrade drools-apps - JUnit op.pomPamela Dragosh1-1/+1
This should have been updated to released version of drools-pdp. Issue-ID: POLICY-2045 Change-Id: I81032a8da5ff83b43e84671ba7766edb16914e79 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-09-09Upgrade to drools 1.5.2 released artifactsjhh2-5/+5
Issue-ID: POLICY-2045 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: Ie77acc2f85b841004882dc4da021a055eb4fcb9c
2019-09-05Merge "Changes drl files"Pamela Dragosh6-440/+4011
2019-09-04Changes drl filespramod.jamkhedkar6-440/+4011
Changes to the DRL file to change the rules to support custom query. Added new VdnsControlLoop test for custom query, and supporting yaml request Issue-ID: POLICY-1858 Change-Id: Ic1b9e771bd36fe0642e9a3439189076a4906a4b8 Signed-off-by: pramod.jamkhedkar <pramod@research.att.com>
2019-09-04correction when overriding with external truststorejhh2-5/+2
Issue-ID: POLICY-1371 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: Ief22f9d99acbd9c3d7335e59045d45c64296f783
2019-08-29entrypoint: redirect std[out|err] to dev/nulljhh1-4/+4
Issue-ID: POLICY-1371 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I8b4da1523925bbbbbed398365971c9efb7f6f1aa Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
2019-08-27Support arbitrary container init scriptsjhh1-3/+8
Issue-ID: POLICY-1371 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: Ic1c15e6f36fe3eead937d4595b994747e830eb7a
2019-08-27Get latest changes from drools-pdp basejhh1-1/+1
Issue-ID: POLICY-2017 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I370b73c9cba1451e3a678d77c1e86c249663dcdc Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
2019-08-23remove usecases archetypejhh37-1618/+0
Issue-ID: POLICY-1957 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I90436e2d633bf0e9f6153dd40e164214f309b8dc
2019-08-15Modify to work with new drools-pdpJim Hahn28-1603/+543
Due to sonar fixes, drools-pdp changed in a way that requires changes to drools-applications. In the case of template.demo, lots of test cases had to be modified, so they were refactored to extract common setup and tear down code. Fixed checkstyle issues. Fixed license date. Change-Id: Ie9e0239b95916ae7ef8c1b669987f7bb07d841b9 Issue-ID: POLICY-1968 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-08-13Fix sonar issues in drools-applicationsJim Hahn8-180/+194
Addressed sonar issue, "Move constants to a class or enum.", by moving the "manager" object from the ControlLoopMetrics interface into a utility class, ControlLoopMetricsManager. Addressed sonar issue, "duplicated blocks of code must be removed.", by refactoring PolicyGuardYamlToXacml, extracing common functions. Addressed sonar issue, "Remove this unused import", in RestControlLoopManager. Addressed sonar issue, "Refactor this method to throw at most one checked exception", in event manager. Fixed likely new sonar issue with assigning to a parameter. Moved logging line to more appropriate place. Addressed reviewer comment: Use "replace" instead of "replaceAll", thus avoiding escaping Change-Id: I47db957c83c1b3e2bd2330474e261987c6f0aac6 Issue-ID: POLICY-1967 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-08-08Upgrade to snapshot integration parent artifactBruno Sakoto1-1/+1
Issue-ID: POLICY-1603 Signed-off-by: Bruno Sakoto <bruno.sakoto@bell.ca> Change-Id: Iddfdf287bc0781dae1272b1c9336571e1715d087
2019-08-07Bump version of drools-applicationsJim Hahn27-32/+32
Change-Id: I79d59efc93e33f7f234092b34cab0ae935d5ab7b Issue-ID: POLICY-1965 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-08-07Merge "Add release file 1.5.1"Jim Hahn1-0/+4
2019-08-07Add release file 1.5.1jhh1-0/+4
Issue-ID: POLICY-1953 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I7c54ccd8a3c6357596a172038baf0663edf204ca
2019-08-05Update to latest common/models/drools-pdp released versionsjhh2-4/+4
Issue-ID: POLICY-1953 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I1bfe5da619a00b12ab7df0d96879f1531a0e68a9
2019-08-01Add AAI test tooling to telemetry.jhh4-24/+142
Issue-ID: POLICY-1956 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: Icceab57db9c19364afbedbf63ecc8e52c1572cba Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
2019-07-26Add lombok.config to drools-applicationsJim Hahn1-0/+2
This prevents sonar from checking lombok annotations for code coverage. Change-Id: I5aaddfb483069f8a3aff12531a1576fc26ced869 Issue-ID: POLICY-1938 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-07-23Pick up latest changes from drools imagejhh1-1/+1
service API mismatches cause notclassfound errors. Issue-ID: POLICY-1940 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I55d0467d3c1f496c4cb0e13c7c96b85e03459660
2019-07-18change json path to delete regex matchingjhh4-9/+9
This is necessary as the explicit "match-all" regular expressions causes events to be accepted in error, even when the json field is not present in the document. Change-Id: Idf4b408850514f49ebe8375d2870e116e793a935 Issue-ID: POLICY-1830 Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
2019-07-18Rename XxxAPI to XxxApi in drools-applicationsJim Hahn11-25/+24
Now that feature APIs have been renamed to XxxApi in drools-pdp, the same must be done with the META-INF files in drools-applications. Also updated references to XxxApi class names within java code. Change-Id: I7ccc09c36f9b903327b5e92189d0bf2956da6cea Issue-ID: POLICY-1074 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-07-09Fix drools-applications due to sonar changes in commonJim Hahn18-162/+149
Fixed breakages due to changes made in policy/common to satisfy sonar. Repointed op.pom to correct parent, which allowed the other version to be dropped and properties used in the rest of the pom. Change-Id: Ib19c228c38b7f27fb9e9f508e5cf2566a8939cdd Issue-ID: POLICY-1791 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-07-02Upgrade to commons/models/drools-pdp snapshotsPamela Dragosh1-3/+3
Use the latest snapshots to keep in step with those artifacts. Issue-ID: POLICY-1737 Change-Id: I7927fa7a093176f9da81cbaefc9dbf9f406d9cc1 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-07-01Bump drools-apps to 1.5.1-SNAPSHOTPamela Dragosh26-26/+26
Released 1.5.0 Issue-ID: POLICY-1737 Change-Id: I41b9af7672985a681bf4e6ce4ceddc8798caf281 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-07-01Merge "Remove sleep() from junit tests"1.5.0Jim Hahn3-12/+21
2019-06-28Merge "Upgrade to released deps"Jim Hahn2-4/+4
2019-06-28Upgrade to released depsPamela Dragosh2-4/+4
Drools-pdp 1.5.0, common 1.5.0 and models 2.1.0 Issue-ID: POLICY-1737 Change-Id: I19caa0c5a48ff81c60f1974b09fe386c519b1341 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-06-28Remove sleep() from junit testsJim Hahn3-12/+21
Replaced sleep() calls with awaitability.await(). Also shortened the timeout, for the test, from 10s to 2s. Change-Id: I5d9cb84b405782f174b6230294e5d6a47938c4b8 Issue-ID: POLICY-1791 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-06-27Fix some sonar issues in drools-applicationsJim Hahn30-1349/+1232
Added coverage to: - feature-controlloop-management Fixed sonar issues, but didn't add coverage to: - feature-controlloop-trans - eventmanager - guard Change-Id: I12f09c4a533e838c6fb9762ba56194e51ce864eb Issue-ID: POLICY-1791 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-06-26Fix sonar issues in drools-applications databaseJim Hahn10-194/+782
Refactored to eliminate duplicate code blocks. Added coverage tests. Change-Id: I99d2b6f68fee38a1dbbf038ad29d1dfe87fb4ae7 Issue-ID: POLICY-1791 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-06-20Merge "Upgrade to release 3.0.0 parent"Jim Hahn1-1/+1
2019-06-20Upgrade to release 3.0.0 parentPamela Dragosh1-1/+1
Policy/parent released Issue-ID: POLICY-1737 Change-Id: I017bce815fbaa275d0323a29cf92bf7c4fd42f0a Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>