summaryrefslogtreecommitdiffstats
path: root/controlloop/common/actors/actor.so/src
diff options
context:
space:
mode:
Diffstat (limited to 'controlloop/common/actors/actor.so/src')
-rw-r--r--controlloop/common/actors/actor.so/src/main/java/org/onap/policy/controlloop/actor/so/SoActorServiceProvider.java (renamed from controlloop/common/actors/actor.so/src/main/java/org/onap/policy/controlloop/actor/so/SOActorServiceProvider.java)14
-rw-r--r--controlloop/common/actors/actor.so/src/main/resources/META-INF/services/org.onap.policy.controlloop.actorServiceProvider.spi.Actor2
-rw-r--r--controlloop/common/actors/actor.so/src/test/java/org/onap/policy/controlloop/actor/so/SoActorServiceProviderTest.java38
3 files changed, 27 insertions, 27 deletions
diff --git a/controlloop/common/actors/actor.so/src/main/java/org/onap/policy/controlloop/actor/so/SOActorServiceProvider.java b/controlloop/common/actors/actor.so/src/main/java/org/onap/policy/controlloop/actor/so/SoActorServiceProvider.java
index 7c0214bfb..8edddbb40 100644
--- a/controlloop/common/actors/actor.so/src/main/java/org/onap/policy/controlloop/actor/so/SOActorServiceProvider.java
+++ b/controlloop/common/actors/actor.so/src/main/java/org/onap/policy/controlloop/actor/so/SoActorServiceProvider.java
@@ -49,8 +49,8 @@ import org.onap.policy.so.util.Serialization;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-public class SOActorServiceProvider implements Actor {
- private static final Logger logger = LoggerFactory.getLogger(SOActorServiceProvider.class);
+public class SoActorServiceProvider implements Actor {
+ private static final Logger logger = LoggerFactory.getLogger(SoActorServiceProvider.class);
// Strings for SO Actor
private static final String SO_ACTOR = "SO";
@@ -184,7 +184,7 @@ public class SOActorServiceProvider implements Actor {
}
/**
- * Construct SO request to create vf-module
+ * Construct SO request to create vf-module.
*
* @param aaiResponseWrapper the AAI response containing the VF modules
* @param policy the policy
@@ -287,7 +287,7 @@ public class SOActorServiceProvider implements Actor {
}
/**
- * Construct SO request to delete vf-module
+ * Construct SO request to delete vf-module.
*
* @param tenantItem tenant item from A&AI named-query response
* @param vnfItem vnf item from A&AI named-query response
@@ -320,7 +320,7 @@ public class SOActorServiceProvider implements Actor {
}
/**
- * construct requestInfo for the SO requestDetails
+ * Construct requestInfo for the SO requestDetails.
*
* @return SO request information
*/
@@ -333,7 +333,7 @@ public class SOActorServiceProvider implements Actor {
}
/**
- * construct modelInfo of the vfModule for the SO requestDetails
+ * Construct modelInfo of the vfModule for the SO requestDetails.
*
* @param vfModuleItem vf module item from A&AI named-query response
* @return SO Model info for the vfModule
@@ -355,7 +355,7 @@ public class SOActorServiceProvider implements Actor {
}
/**
- * construct cloudConfiguration for the SO requestDetails
+ * Construct cloudConfiguration for the SO requestDetails.
*
* @param tenantItem tenant item from A&AI named-query response
* @return SO cloud configuration
diff --git a/controlloop/common/actors/actor.so/src/main/resources/META-INF/services/org.onap.policy.controlloop.actorServiceProvider.spi.Actor b/controlloop/common/actors/actor.so/src/main/resources/META-INF/services/org.onap.policy.controlloop.actorServiceProvider.spi.Actor
index ad136e98f..a955eb71c 100644
--- a/controlloop/common/actors/actor.so/src/main/resources/META-INF/services/org.onap.policy.controlloop.actorServiceProvider.spi.Actor
+++ b/controlloop/common/actors/actor.so/src/main/resources/META-INF/services/org.onap.policy.controlloop.actorServiceProvider.spi.Actor
@@ -1 +1 @@
-org.onap.policy.controlloop.actor.so.SOActorServiceProvider \ No newline at end of file
+org.onap.policy.controlloop.actor.so.SoActorServiceProvider \ No newline at end of file
diff --git a/controlloop/common/actors/actor.so/src/test/java/org/onap/policy/controlloop/actor/so/SoActorServiceProviderTest.java b/controlloop/common/actors/actor.so/src/test/java/org/onap/policy/controlloop/actor/so/SoActorServiceProviderTest.java
index 9c1d87888..90a4c2868 100644
--- a/controlloop/common/actors/actor.so/src/test/java/org/onap/policy/controlloop/actor/so/SoActorServiceProviderTest.java
+++ b/controlloop/common/actors/actor.so/src/test/java/org/onap/policy/controlloop/actor/so/SoActorServiceProviderTest.java
@@ -63,15 +63,15 @@ public class SoActorServiceProviderTest {
policy.setActor("Dorothy");
policy.setRecipe("GoToOz");
- assertNull(new SOActorServiceProvider().constructRequest(onset, operation, policy, aaiNqResp));
+ assertNull(new SoActorServiceProvider().constructRequest(onset, operation, policy, aaiNqResp));
policy.setActor("SO");
- assertNull(new SOActorServiceProvider().constructRequest(onset, operation, policy, aaiNqResp));
+ assertNull(new SoActorServiceProvider().constructRequest(onset, operation, policy, aaiNqResp));
policy.setRecipe(VF_MODULE_CREATE);
// empty policy payload
- SORequest request = new SOActorServiceProvider().constructRequest(onset, operation, policy, aaiNqResp);
+ SORequest request = new SoActorServiceProvider().constructRequest(onset, operation, policy, aaiNqResp);
assertNotNull(request);
assertEquals("my_module_3", request.getRequestDetails().getRequestInfo().getInstanceName());
@@ -80,7 +80,7 @@ public class SoActorServiceProviderTest {
// non-empty policy payload
policy.setPayload(makePayload());
- request = new SOActorServiceProvider().constructRequest(onset, operation, policy, aaiNqResp);
+ request = new SoActorServiceProvider().constructRequest(onset, operation, policy, aaiNqResp);
assertNotNull(request);
assertEquals(true, request.getRequestDetails().getRequestParameters().isUsePreload());
assertEquals("avalue", request.getRequestDetails().getRequestParameters().getUserParams().get(0).get("akey"));
@@ -89,33 +89,33 @@ public class SoActorServiceProviderTest {
// payload with config, but no request params
policy.setPayload(makePayload());
- policy.getPayload().remove(SOActorServiceProvider.REQ_PARAM_NM);
- request = new SOActorServiceProvider().constructRequest(onset, operation, policy, aaiNqResp);
+ policy.getPayload().remove(SoActorServiceProvider.REQ_PARAM_NM);
+ request = new SoActorServiceProvider().constructRequest(onset, operation, policy, aaiNqResp);
assertNotNull(request);
assertNull(request.getRequestDetails().getRequestParameters());
assertNotNull(request.getRequestDetails().getConfigurationParameters());
// payload with request, but no config params
policy.setPayload(makePayload());
- policy.getPayload().remove(SOActorServiceProvider.CONFIG_PARAM_NM);
- request = new SOActorServiceProvider().constructRequest(onset, operation, policy, aaiNqResp);
+ policy.getPayload().remove(SoActorServiceProvider.CONFIG_PARAM_NM);
+ request = new SoActorServiceProvider().constructRequest(onset, operation, policy, aaiNqResp);
assertNotNull(request);
assertNotNull(request.getRequestDetails().getRequestParameters());
assertNull(request.getRequestDetails().getConfigurationParameters());
// null response
- assertNull(new SOActorServiceProvider().constructRequest(onset, operation, policy, null));
+ assertNull(new SoActorServiceProvider().constructRequest(onset, operation, policy, null));
// response has no base VF module
- assertNull(new SOActorServiceProvider().constructRequest(onset, operation, policy,
+ assertNull(new SoActorServiceProvider().constructRequest(onset, operation, policy,
loadAaiResponse(onset, "aai/AaiNqResponse-NoBase.json")));
// response has no non-base VF modules (other than the "dummy")
- assertNull(new SOActorServiceProvider().constructRequest(onset, operation, policy,
+ assertNull(new SoActorServiceProvider().constructRequest(onset, operation, policy,
loadAaiResponse(onset, "aai/AaiNqResponse-NoNonBase.json")));
policy.setRecipe(VF_MODULE_DELETE);
- SORequest deleteRequest = new SOActorServiceProvider().constructRequest(onset, operation, policy, aaiNqResp);
+ SORequest deleteRequest = new SoActorServiceProvider().constructRequest(onset, operation, policy, aaiNqResp);
assertNotNull(deleteRequest);
assertEquals(SoOperationType.DELETE_VF_MODULE, deleteRequest.getOperationType());
@@ -128,22 +128,22 @@ public class SoActorServiceProviderTest {
// null tenant
aaiNqResp.getAaiNqResponse().getInventoryResponseItems().get(0).getItems().getInventoryResponseItems()
.remove(1);
- assertNull(new SOActorServiceProvider().constructRequest(onset, operation, policy, aaiNqResp));
+ assertNull(new SoActorServiceProvider().constructRequest(onset, operation, policy, aaiNqResp));
// null service item
aaiNqResp.getAaiNqResponse().getInventoryResponseItems().get(0).getItems().getInventoryResponseItems().get(0)
.setItems(null);
- assertNull(new SOActorServiceProvider().constructRequest(onset, operation, policy, aaiNqResp));
+ assertNull(new SoActorServiceProvider().constructRequest(onset, operation, policy, aaiNqResp));
// null response
aaiNqResp.setAaiNqResponse(null);
- assertNull(new SOActorServiceProvider().constructRequest(onset, operation, policy, aaiNqResp));
+ assertNull(new SoActorServiceProvider().constructRequest(onset, operation, policy, aaiNqResp));
}
@Test
public void testSendRequest() {
try {
- SOActorServiceProvider.sendRequest(UUID.randomUUID().toString(), null, null);
+ SoActorServiceProvider.sendRequest(UUID.randomUUID().toString(), null, null);
} catch (Exception e) {
fail("Test should not throw an exception");
}
@@ -151,7 +151,7 @@ public class SoActorServiceProviderTest {
@Test
public void testMethods() {
- SOActorServiceProvider sp = new SOActorServiceProvider();
+ SoActorServiceProvider sp = new SoActorServiceProvider();
assertEquals("SO", sp.actor());
assertEquals(2, sp.recipes().size());
@@ -170,8 +170,8 @@ public class SoActorServiceProviderTest {
private Map<String, String> makePayload() {
Map<String, String> payload = new TreeMap<>();
- payload.put(SOActorServiceProvider.REQ_PARAM_NM, makeReqParams());
- payload.put(SOActorServiceProvider.CONFIG_PARAM_NM, makeConfigParams());
+ payload.put(SoActorServiceProvider.REQ_PARAM_NM, makeReqParams());
+ payload.put(SoActorServiceProvider.CONFIG_PARAM_NM, makeConfigParams());
return payload;
}