Implement JUnit tests for actor.vfc

JUnit tests for the VFC actor implemented.

Change-Id: Ifcd433a4ce6f46cad46d50f4ce4c7c03e2abec67
Issue-ID: POLICY-455
Signed-off-by: liamfallon <liam.fallon@ericsson.com>

2 files changed, 108 insertions, 6 deletions

diff --git a/controlloop/common/actors/actor.vfc/src/test/java/org/onap/policy/controlloop/actor/vfc/TestVFCActorServiceProvider.java b/controlloop/common/actors/actor.vfc/src/test/java/org/onap/policy/controlloop/actor/vfc/TestVFCActorServiceProvider.java
new file mode 100644
index 000000000..7919af446
--- /dev/null
+++ b/controlloop/common/actors/actor.vfc/src/test/java/org/onap/policy/controlloop/actor/vfc/TestVFCActorServiceProvider.java
@@ -0,0 +1,108 @@
+/*-
+ * ============LICENSE_START=======================================================
+ * TestVFCActorServiceProvider
+ * ================================================================================
+ * Copyright (C) 2018 Ericsson. All rights reserved.
+ * ================================================================================
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ * 
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * ============LICENSE_END=========================================================
+ */
+
+package org.onap.policy.controlloop.actor.vfc;
+
+import static org.junit.Assert.*;
+
+import java.util.UUID;
+
+import org.junit.AfterClass;
+import org.junit.BeforeClass;
+import org.junit.Test;
+import org.onap.policy.aai.AAIGETVnfResponse;
+import org.onap.policy.controlloop.ControlLoopOperation;
+import org.onap.policy.controlloop.VirtualControlLoopEvent;
+import org.onap.policy.controlloop.policy.Policy;
+import org.onap.policy.drools.http.server.HttpServletServer;
+import org.onap.policy.drools.system.PolicyEngine;
+import org.onap.policy.simulators.Util;
+import org.onap.policy.vfc.VFCRequest;
+
+public class TestVFCActorServiceProvider {
+	@BeforeClass
+	public static void setUpSimulator() {
+		try {
+			Util.buildAaiSim();
+		} catch (Exception e) {
+			fail(e.getMessage());
+		}
+	}
+
+	@AfterClass
+	public static void tearDownSimulator() {
+		HttpServletServer.factory.destroy();
+	}
+
+	@Test
+	public void testConstructRequest() {
+		VirtualControlLoopEvent onset = new VirtualControlLoopEvent();
+		ControlLoopOperation operation = new ControlLoopOperation();
+
+		Policy policy = new Policy();
+		policy.setRecipe("GoToOz");
+		
+		assertNull(VFCActorServiceProvider.constructRequest(onset, operation, policy, null));
+		
+		onset.getAAI().put("generic-vnf.vnf-id", "dorothy.gale.1939");
+		assertNull(VFCActorServiceProvider.constructRequest(onset, operation, policy, null));
+		
+		PolicyEngine.manager.setEnvironmentProperty("aai.url", "http://localhost:6666");
+        PolicyEngine.manager.setEnvironmentProperty("aai.username", "AAI");
+        PolicyEngine.manager.setEnvironmentProperty("aai.password", "AAI");
+		assertNull(VFCActorServiceProvider.constructRequest(onset, operation, policy, null));
+		
+		UUID requestID = UUID.randomUUID();
+		onset.setRequestID(requestID);
+		assertNull(VFCActorServiceProvider.constructRequest(onset, operation, policy, null));
+		
+		onset.getAAI().put("generic-vnf.vnf-name", "Dorothy");
+        PolicyEngine.manager.getEnvironment().remove("aai.password");
+		assertNull(VFCActorServiceProvider.constructRequest(onset, operation, policy, null));
+		
+        PolicyEngine.manager.setEnvironmentProperty("aai.password", "AAI");
+		assertNull(VFCActorServiceProvider.constructRequest(onset, operation, policy, null));
+		
+		onset.getAAI().put("service-instance.service-instance-id", "");
+		assertNull(VFCActorServiceProvider.constructRequest(onset, operation, policy, null));
+
+		assertNull(VFCActorServiceProvider.constructRequest(onset, operation, policy, new AAIGETVnfResponse()));
+		
+		policy.setRecipe("Restart");
+		assertNotNull(VFCActorServiceProvider.constructRequest(onset, operation, policy, new AAIGETVnfResponse()));
+
+		VFCRequest request = VFCActorServiceProvider.constructRequest(onset, operation, policy, new AAIGETVnfResponse());
+		
+		assertEquals(requestID, request.getRequestId());
+		assertEquals("dorothy.gale.1939", request.getHealRequest().getVnfInstanceId());
+		assertEquals("restartvm", request.getHealRequest().getAdditionalParams().getAction());
+    }
+
+	@Test
+	public void testMethods() {
+		VFCActorServiceProvider sp = new VFCActorServiceProvider();
+
+		assertEquals("VFC", sp.actor());
+		assertEquals(1, sp.recipes().size());
+		assertEquals("Restart", sp.recipes().get(0));
+		assertEquals("VM", sp.recipeTargets("Restart").get(0));
+		assertEquals(0, sp.recipePayloads("Restart").size());
+	}
+}
diff --git a/controlloop/common/model-impl/vfc/pom.xml b/controlloop/common/model-impl/vfc/pom.xml
index abccdd8ff..ecbda4de2 100644
--- a/controlloop/common/model-impl/vfc/pom.xml
+++ b/controlloop/common/model-impl/vfc/pom.xml
@@ -41,12 +41,6 @@
 			<scope>test</scope>
 		</dependency>
 		<dependency>
-			<groupId>org.awaitility</groupId>
-			<artifactId>awaitility</artifactId>
-			<version>3.0.0</version>
-			<scope>test</scope>
-		</dependency>
-		<dependency>
 			<groupId>com.google.code.gson</groupId>
 			<artifactId>gson</artifactId>
 			<version>2.5</version>