diff options
author | Jim Hahn <jrh3@att.com> | 2020-09-30 12:52:25 -0400 |
---|---|---|
committer | Jim Hahn <jrh3@att.com> | 2020-09-30 14:59:39 -0400 |
commit | fb9bd637567096f6174bbc2e52a5e149a4eed882 (patch) | |
tree | 7b0d2df1aefbb3635788af501be1157fbe05d798 /controlloop/common/rules-test/src/test/java | |
parent | e8e477ab80c6762fb05aebfe9becc630d2d51e39 (diff) |
Fix new sonars in drools-apps
Addressed the following sonars:
- too many assertions in test method
- rename test class
- use static method to modify static field
- use already defined constant
- code always returns the same value
- use assertNotSame
- use appropriate class name to access static method
- define a constant
- extract nested try block
- don't always return the same value
- use remove() instead of set(null) for thread-local-storage
- add @Override
Issue-ID: POLICY-2852
Change-Id: Icc62acd4ad57afa2d44ed4cdca504a3ac0810228
Signed-off-by: Jim Hahn <jrh3@att.com>
Diffstat (limited to 'controlloop/common/rules-test/src/test/java')
-rw-r--r-- | controlloop/common/rules-test/src/test/java/org/onap/policy/controlloop/common/rules/test/NamedRunner2Test.java (renamed from controlloop/common/rules-test/src/test/java/org/onap/policy/controlloop/common/rules/test/NamedRunnerTest2.java) | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/controlloop/common/rules-test/src/test/java/org/onap/policy/controlloop/common/rules/test/NamedRunnerTest2.java b/controlloop/common/rules-test/src/test/java/org/onap/policy/controlloop/common/rules/test/NamedRunner2Test.java index 1ed5b20bc..91e19ce79 100644 --- a/controlloop/common/rules-test/src/test/java/org/onap/policy/controlloop/common/rules/test/NamedRunnerTest2.java +++ b/controlloop/common/rules-test/src/test/java/org/onap/policy/controlloop/common/rules/test/NamedRunner2Test.java @@ -32,7 +32,7 @@ import org.junit.runner.RunWith; * executed. */ @RunWith(NamedRunner.class) -public class NamedRunnerTest2 { +public class NamedRunner2Test { private static int testCount = 0; |