Reduce Technical Debt on drools-applications

This commit mops up the technical debt issues in
drools-applications that are reaistic to fix witout
major surgery on the code.

note: warnings on non compliant Java class names that are used in
yaml serializaiton and deserailization are ignored.

note: warnings on complexity figures for equals() methods are ignored.

Issue-ID: POLICY-455
Change-Id: I99ccda4bd9932ceb5ccbcfd2778730234b55d7a5
Signed-off-by: liamfallon <liam.fallon@ericsson.com>

2 files changed, 3 insertions, 3 deletions

diff --git a/controlloop/common/model-impl/vfc/src/main/java/org/onap/policy/vfc/VFCResponseDescriptor.java b/controlloop/common/model-impl/vfc/src/main/java/org/onap/policy/vfc/VFCResponseDescriptor.java
index 81eb3bc4d..f237554fd 100644
--- a/controlloop/common/model-impl/vfc/src/main/java/org/onap/policy/vfc/VFCResponseDescriptor.java
+++ b/controlloop/common/model-impl/vfc/src/main/java/org/onap/policy/vfc/VFCResponseDescriptor.java
@@ -42,7 +42,7 @@ public class VFCResponseDescriptor implements Serializable {
     private String responseId;
 
     @SerializedName("responseHistoryList")
-    public List<VFCResponseDescriptor> responseHistoryList;
+    private List<VFCResponseDescriptor> responseHistoryList;
 
     public VFCResponseDescriptor() {
 		// Default constructor for VFCResponseDescriptor
diff --git a/controlloop/common/model-impl/vfc/src/test/java/org/onap/policy/vfc/TestDemo.java b/controlloop/common/model-impl/vfc/src/test/java/org/onap/policy/vfc/TestDemo.java
index 96a62bf9f..69d3d5838 100644
--- a/controlloop/common/model-impl/vfc/src/test/java/org/onap/policy/vfc/TestDemo.java
+++ b/controlloop/common/model-impl/vfc/src/test/java/org/onap/policy/vfc/TestDemo.java
@@ -66,8 +66,8 @@ public class TestDemo {
         responseDescriptor.setErrorCode(null);
         responseDescriptor.setResponseId("11");
 
-	    response.getResponseDescriptor().responseHistoryList = new LinkedList<>();
-        response.getResponseDescriptor().responseHistoryList.add(responseDescriptor);
+	    response.getResponseDescriptor().setResponseHistoryList(new LinkedList<>());
+        response.getResponseDescriptor().getResponseHistoryList().add(responseDescriptor);
 
         body = Serialization.gsonPretty.toJson(response);
         System.out.println(body);