Fix Tech Debt/JUnit on VFC POJOs

Making fields private, fixing field and methods to follow Java guidelines, and adding getter and setter methods.
Unit test added for all classes in org.onap.policy.vfc

Issue-ID: POLICY-455
Change-Id: I262337a816706cd5243849cd51e57689275545bf
Signed-off-by: liamfallon <liam.fallon@ericsson.com>

9 files changed, 641 insertions, 24 deletions

diff --git a/controlloop/common/model-impl/vfc/src/test/java/org/onap/policy/vfc/TestDemo.java b/controlloop/common/model-impl/vfc/src/test/java/org/onap/policy/vfc/TestDemo.java
index fd59325d0..96a62bf9f 100644
--- a/controlloop/common/model-impl/vfc/src/test/java/org/onap/policy/vfc/TestDemo.java
+++ b/controlloop/common/model-impl/vfc/src/test/java/org/onap/policy/vfc/TestDemo.java
@@ -29,45 +29,45 @@ public class TestDemo {
     public void test() {
         VFCRequest request = new VFCRequest();
 
-        request.nsInstanceId = "100";
-        request.healRequest = new VFCHealRequest();
-        request.healRequest.vnfInstanceId = "1";
-        request.healRequest.cause = "vm is down";
+        request.setNSInstanceId("100");
+        request.setHealRequest(new VFCHealRequest());
+        request.getHealRequest().setVnfInstanceId("1");
+        request.getHealRequest().setCause("vm is down");
 
-        request.healRequest.additionalParams = new VFCHealAdditionalParams();
-        request.healRequest.additionalParams.action = "restartvm";
+        request.getHealRequest().setAdditionalParams(new VFCHealAdditionalParams());
+        request.getHealRequest().getAdditionalParams().setAction("restartvm");
 
-        request.healRequest.additionalParams.actionInfo = new VFCHealActionVmInfo();
-        request.healRequest.additionalParams.actionInfo.vmid = "33";
-        request.healRequest.additionalParams.actionInfo.vmname = "xgw-smp11";
+        request.getHealRequest().getAdditionalParams().setActionInfo(new VFCHealActionVmInfo());
+        request.getHealRequest().getAdditionalParams().getActionInfo().setVmid("33");
+        request.getHealRequest().getAdditionalParams().getActionInfo().setVmname("xgw-smp11");
 
         String body = Serialization.gsonPretty.toJson(request);
         System.out.println(body);
 
         VFCResponse response = new VFCResponse();
-        response.jobId = "1";
+        response.setJobId("1");
 
         body = Serialization.gsonPretty.toJson(response);
         System.out.println(body);
 
-        response.responseDescriptor = new VFCResponseDescriptor();
-        response.responseDescriptor.progress = "40";
-        response.responseDescriptor.status = "processing";
-        response.responseDescriptor.statusDescription = "OMC VMs are decommissioned in VIM";
-        response.responseDescriptor.errorCode = null;
-        response.responseDescriptor.responseId = "42";
+        response.setResponseDescriptor(new VFCResponseDescriptor());
+        response.getResponseDescriptor().setProgress("40");
+        response.getResponseDescriptor().setStatus("processing");
+        response.getResponseDescriptor().setStatusDescription("OMC VMs are decommissioned in VIM");
+        response.getResponseDescriptor().setErrorCode(null);
+        response.getResponseDescriptor().setResponseId("42");
         body = Serialization.gsonPretty.toJson(response);
         System.out.println(body);
 
         VFCResponseDescriptor responseDescriptor = new VFCResponseDescriptor();
-        responseDescriptor.progress = "20";
-        responseDescriptor.status = "processing";
-        responseDescriptor.statusDescription = "OMC VMs are decommissioned in VIM";
-        responseDescriptor.errorCode = null;
-        responseDescriptor.responseId = "11";
-
-	    response.responseDescriptor.responseHistoryList = new LinkedList<>();
-        response.responseDescriptor.responseHistoryList.add(responseDescriptor);
+        responseDescriptor.setProgress("20");
+        responseDescriptor.setStatus("processing");
+        responseDescriptor.setStatusDescription("OMC VMs are decommissioned in VIM");
+        responseDescriptor.setErrorCode(null);
+        responseDescriptor.setResponseId("11");
+
+	    response.getResponseDescriptor().responseHistoryList = new LinkedList<>();
+        response.getResponseDescriptor().responseHistoryList.add(responseDescriptor);
 
         body = Serialization.gsonPretty.toJson(response);
         System.out.println(body);
diff --git a/controlloop/common/model-impl/vfc/src/test/java/org/onap/policy/vfc/TestVFCHealActionVmInfo.java b/controlloop/common/model-impl/vfc/src/test/java/org/onap/policy/vfc/TestVFCHealActionVmInfo.java
new file mode 100644
index 000000000..ab57f6415
--- /dev/null
+++ b/controlloop/common/model-impl/vfc/src/test/java/org/onap/policy/vfc/TestVFCHealActionVmInfo.java
@@ -0,0 +1,45 @@
+/*-
+ * ============LICENSE_START=======================================================
+ * vfc
+ * ================================================================================
+ * Copyright (C) 2018 Ericsson. All rights reserved.
+ * ================================================================================
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ * 
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * ============LICENSE_END=========================================================
+ */
+
+package org.onap.policy.vfc;
+
+import static org.junit.Assert.*;
+
+import org.junit.Test;
+
+public class TestVFCHealActionVmInfo {
+
+	@Test
+	public void testVFCHealActionVmInfo() {
+		VFCHealActionVmInfo actionInfo = new VFCHealActionVmInfo();
+		assertNotNull(actionInfo);
+		assertNotEquals(0, actionInfo.hashCode());
+		
+		String vmid = "ECity";
+		actionInfo.setVmid(vmid);
+		assertEquals(vmid, actionInfo.getVmid());
+		
+		String vmName = "Emerald City";
+		actionInfo.setVmname(vmName);
+		assertEquals(vmName, actionInfo.getVmname());
+		
+		assertNotEquals(0, actionInfo.hashCode());
+	}
+}
diff --git a/controlloop/common/model-impl/vfc/src/test/java/org/onap/policy/vfc/TestVFCHealAdditionalParams.java b/controlloop/common/model-impl/vfc/src/test/java/org/onap/policy/vfc/TestVFCHealAdditionalParams.java
new file mode 100644
index 000000000..7fa8fd741
--- /dev/null
+++ b/controlloop/common/model-impl/vfc/src/test/java/org/onap/policy/vfc/TestVFCHealAdditionalParams.java
@@ -0,0 +1,45 @@
+/*-
+ * ============LICENSE_START=======================================================
+ * vfc
+ * ================================================================================
+ * Copyright (C) 2018 Ericsson. All rights reserved.
+ * ================================================================================
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ * 
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * ============LICENSE_END=========================================================
+ */
+
+package org.onap.policy.vfc;
+
+import static org.junit.Assert.*;
+
+import org.junit.Test;
+
+public class TestVFCHealAdditionalParams {
+
+	@Test
+	public void testVFCHealAdditionalParameters() {
+		VFCHealAdditionalParams additionalParams = new VFCHealAdditionalParams();
+		assertNotNull(additionalParams);
+		assertNotEquals(0, additionalParams.hashCode());
+		
+		String action = "Go Home";
+		additionalParams.setAction(action);
+		assertEquals(action, additionalParams.getAction());
+		
+		VFCHealActionVmInfo actionInfo = new VFCHealActionVmInfo();
+		additionalParams.setActionInfo(actionInfo );
+		assertEquals(actionInfo, additionalParams.getActionInfo());
+		
+		assertNotEquals(0, additionalParams.hashCode());
+	}
+}
diff --git a/controlloop/common/model-impl/vfc/src/test/java/org/onap/policy/vfc/TestVFCHealRequest.java b/controlloop/common/model-impl/vfc/src/test/java/org/onap/policy/vfc/TestVFCHealRequest.java
new file mode 100644
index 000000000..5a78bfb0c
--- /dev/null
+++ b/controlloop/common/model-impl/vfc/src/test/java/org/onap/policy/vfc/TestVFCHealRequest.java
@@ -0,0 +1,49 @@
+/*-
+ * ============LICENSE_START=======================================================
+ * vfc
+ * ================================================================================
+ * Copyright (C) 2018 Ericsson. All rights reserved.
+ * ================================================================================
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ * 
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * ============LICENSE_END=========================================================
+ */
+
+package org.onap.policy.vfc;
+
+import static org.junit.Assert.*;
+
+import org.junit.Test;
+
+public class TestVFCHealRequest {
+
+	@Test
+	public void testVFCHealRequest() {
+		VFCHealRequest request = new VFCHealRequest();
+		assertNotNull(request);
+		assertNotEquals(0, request.hashCode());
+		
+		String vnfInstanceId = "Go To Oz";
+		request.setVnfInstanceId(vnfInstanceId);
+		assertEquals(vnfInstanceId, request.getVnfInstanceId());
+		
+		String cause = "West Witch";
+		request.setCause(cause);
+		assertEquals(cause, request.getCause());
+		
+		VFCHealAdditionalParams additionalParams= new VFCHealAdditionalParams();
+		request.setAdditionalParams(additionalParams);
+		assertEquals(additionalParams, request.getAdditionalParams());
+		
+		assertNotEquals(0, request.hashCode());
+	}
+}
diff --git a/controlloop/common/model-impl/vfc/src/test/java/org/onap/policy/vfc/TestVFCManager.java b/controlloop/common/model-impl/vfc/src/test/java/org/onap/policy/vfc/TestVFCManager.java
new file mode 100644
index 000000000..9260430d4
--- /dev/null
+++ b/controlloop/common/model-impl/vfc/src/test/java/org/onap/policy/vfc/TestVFCManager.java
@@ -0,0 +1,281 @@
+/*-
+ * ============LICENSE_START=======================================================
+ * vfc
+ * ================================================================================
+ * Copyright (C) 2018 Ericsson. All rights reserved.
+ * ================================================================================
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ * 
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * ============LICENSE_END=========================================================
+ */
+package org.onap.policy.vfc;
+
+import static org.junit.Assert.*;
+import static org.mockito.ArgumentMatchers.anyMap;
+import static org.mockito.ArgumentMatchers.anyString;
+import static org.mockito.ArgumentMatchers.eq;
+import static org.mockito.ArgumentMatchers.startsWith;
+import static org.mockito.Mockito.*;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.UUID;
+
+import org.drools.core.WorkingMemory;
+import org.junit.Before;
+import org.junit.BeforeClass;
+import org.junit.Test;
+import org.onap.policy.drools.system.PolicyEngine;
+import org.onap.policy.rest.RESTManager;
+import org.onap.policy.rest.RESTManager.Pair;
+import org.onap.policy.vfc.util.Serialization;
+
+public class TestVFCManager {
+	private static WorkingMemory mockedWorkingMemory;
+
+	private RESTManager   mockedRESTManager;
+
+	private Pair<Integer, String> httpResponsePutOK;
+	private Pair<Integer, String> httpResponseGetOK;
+	private Pair<Integer, String> httpResponseBadResponse;
+	private Pair<Integer, String> httpResponseErr;
+
+	private VFCRequest  request;
+	private VFCResponse response;
+
+	@BeforeClass
+	public static void beforeTestVFCManager() {
+		mockedWorkingMemory = mock(WorkingMemory.class);
+	}
+
+	@Before
+	public void setupMockedRest() {
+		mockedRESTManager   = mock(RESTManager.class);
+
+		httpResponsePutOK       = mockedRESTManager.new Pair<>(202, Serialization.gsonPretty.toJson(response));
+		httpResponseGetOK       = mockedRESTManager.new Pair<>(200, Serialization.gsonPretty.toJson(response));
+		httpResponseBadResponse = mockedRESTManager.new Pair<>(202, Serialization.gsonPretty.toJson(null));
+		httpResponseErr         = mockedRESTManager.new Pair<>(200, null);
+	}
+
+	@Before
+	public void createRequestAndResponse() {
+		VFCHealActionVmInfo actionInfo = new VFCHealActionVmInfo();
+		actionInfo.setVmid("TheWizard");
+		actionInfo.setVmname("The Wizard of Oz");
+
+		VFCHealAdditionalParams additionalParams = new VFCHealAdditionalParams();
+		additionalParams.setAction("Go Home");
+		additionalParams.setActionInfo(actionInfo);
+
+		VFCHealRequest healRequest = new VFCHealRequest();
+		healRequest.setAdditionalParams(additionalParams);
+		healRequest.setCause("WestWitch");
+		healRequest.setVnfInstanceId("EmeraldCity");
+
+		UUID requestId = UUID.randomUUID();
+		request = new VFCRequest();
+		request.setHealRequest(healRequest);
+		request.setNSInstanceId("Dorothy");
+		request.setRequestId(requestId);
+
+		List<VFCResponseDescriptor> responseHistoryList = new ArrayList<>();;
+
+		VFCResponseDescriptor responseDescriptor = new VFCResponseDescriptor();
+		responseDescriptor.setErrorCode("1234");
+		responseDescriptor.setProgress("Follow The Yellow Brick Road");
+		responseDescriptor.setResponseHistoryList(responseHistoryList);
+		responseDescriptor.setResponseId(UUID.randomUUID().toString());
+		responseDescriptor.setStatus("finished");
+		responseDescriptor.setStatusDescription("There's no place like home");
+
+		response = new VFCResponse();
+		response.setJobId("1234");
+		response.setRequestId(request.getRequestId().toString());
+		response.setResponseDescriptor(responseDescriptor);
+	}
+
+	@Test
+	public void testVFCInitiation() {
+		try {
+			new VFCManager(null, null);
+			fail("test should throw an exception here");
+		}
+		catch (IllegalArgumentException e) {
+			assertEquals("the parameters \"wm\" and \"request\" on the VFCManager constructor may not be null", e.getMessage());
+		}
+
+		try {
+			new VFCManager(mockedWorkingMemory, null);
+			fail("test should throw an exception here");
+		}
+		catch (IllegalArgumentException e) {
+			assertEquals("the parameters \"wm\" and \"request\" on the VFCManager constructor may not be null", e.getMessage());
+		}
+
+		try {
+			new VFCManager(mockedWorkingMemory, request);
+			fail("test should throw an exception here");
+		}
+		catch (IllegalArgumentException e) {
+			assertEquals("The value of policy engine manager environment property \"vfc.url\" may not be null", e.getMessage());
+		}
+
+		PolicyEngine.manager.getEnvironment().put("vfc.url", "http://somewhere.over.the.rainbow");
+		try {
+			new VFCManager(mockedWorkingMemory, request);
+			fail("test should throw an exception here");
+		}
+		catch (IllegalArgumentException e) {
+			assertEquals("The value of policy engine manager environment property \"vfc.username\" may not be null", e.getMessage());
+		}
+
+		PolicyEngine.manager.getEnvironment().put("vfc.username", "Dorothy");
+		try {
+			new VFCManager(mockedWorkingMemory, request);
+			fail("test should throw an exception here");
+		}
+		catch (IllegalArgumentException e) {
+			assertEquals("The value of policy engine manager environment property \"vfc.password\" may not be null", e.getMessage());
+		}
+
+		PolicyEngine.manager.getEnvironment().put("vfc.password", "Toto");
+		assertNotNull(new VFCManager(mockedWorkingMemory, request));
+
+		PolicyEngine.manager.getEnvironment().remove("vfc.password");
+		PolicyEngine.manager.getEnvironment().remove("vfc.username");
+		PolicyEngine.manager.getEnvironment().remove("vfc.url");
+	}
+
+	@Test
+	public void testVFCExecutionException() throws InterruptedException {
+		PolicyEngine.manager.getEnvironment().put("vfc.url", "http://somewhere.over.the.rainbow");
+		PolicyEngine.manager.getEnvironment().put("vfc.username", "Dorothy");
+		PolicyEngine.manager.getEnvironment().put("vfc.password", "Exception");
+
+		VFCManager manager = new VFCManager(mockedWorkingMemory, request);
+		manager.setRestManager(mockedRESTManager);
+
+		Thread managerThread = new Thread(manager);
+		managerThread.start();
+
+		when(mockedRESTManager.post(startsWith("http://somewhere.over.the.rainbow"), eq("Dorothy"), eq("Exception"), anyMap(), anyString(), anyString()))
+		.thenThrow(new RuntimeException("OzException"));
+
+		while (managerThread.isAlive()) {
+			Thread.sleep(100);
+		}
+
+		PolicyEngine.manager.getEnvironment().remove("vfc.password");
+		PolicyEngine.manager.getEnvironment().remove("vfc.username");
+		PolicyEngine.manager.getEnvironment().remove("vfc.url");
+	}
+
+	@Test
+	public void testVFCExecutionNull() throws InterruptedException {
+		PolicyEngine.manager.getEnvironment().put("vfc.url", "http://somewhere.over.the.rainbow");
+		PolicyEngine.manager.getEnvironment().put("vfc.username", "Dorothy");
+		PolicyEngine.manager.getEnvironment().put("vfc.password", "Null");
+
+		VFCManager manager = new VFCManager(mockedWorkingMemory, request);
+		manager.setRestManager(mockedRESTManager);
+
+		Thread managerThread = new Thread(manager);
+		managerThread.start();
+
+		when(mockedRESTManager.post(startsWith("http://somewhere.over.the.rainbow"), eq("Dorothy"), eq("Null"), anyMap(), anyString(), anyString()))
+		.thenReturn(null);
+
+		while (managerThread.isAlive()) {
+			Thread.sleep(100);
+		}
+
+		PolicyEngine.manager.getEnvironment().remove("vfc.password");
+		PolicyEngine.manager.getEnvironment().remove("vfc.username");
+		PolicyEngine.manager.getEnvironment().remove("vfc.url");
+	}
+
+	@Test
+	public void testVFCExecutionError0() throws InterruptedException {
+		PolicyEngine.manager.getEnvironment().put("vfc.url", "http://somewhere.over.the.rainbow");
+		PolicyEngine.manager.getEnvironment().put("vfc.username", "Dorothy");
+		PolicyEngine.manager.getEnvironment().put("vfc.password", "Error0");
+
+		VFCManager manager = new VFCManager(mockedWorkingMemory, request);
+		manager.setRestManager(mockedRESTManager);
+
+		Thread managerThread = new Thread(manager);
+		managerThread.start();
+
+		when(mockedRESTManager.post(startsWith("http://somewhere.over.the.rainbow"), eq("Dorothy"), eq("Error0"), anyMap(), anyString(), anyString()))
+		.thenReturn(httpResponseErr);
+
+		while (managerThread.isAlive()) {
+			Thread.sleep(100);
+		}
+
+		PolicyEngine.manager.getEnvironment().remove("vfc.password");
+		PolicyEngine.manager.getEnvironment().remove("vfc.username");
+		PolicyEngine.manager.getEnvironment().remove("vfc.url");
+	}
+
+	@Test
+	public void testVFCExecutionBadResponse() throws InterruptedException {
+		PolicyEngine.manager.getEnvironment().put("vfc.url", "http://somewhere.over.the.rainbow");
+		PolicyEngine.manager.getEnvironment().put("vfc.username", "Dorothy");
+		PolicyEngine.manager.getEnvironment().put("vfc.password", "BadResponse");
+
+		VFCManager manager = new VFCManager(mockedWorkingMemory, request);
+		manager.setRestManager(mockedRESTManager);
+
+		Thread managerThread = new Thread(manager);
+		managerThread.start();
+
+		when(mockedRESTManager.post(startsWith("http://somewhere.over.the.rainbow"), eq("Dorothy"), eq("OK"), anyMap(), anyString(), anyString()))
+		.thenReturn(httpResponseBadResponse);
+
+		while (managerThread.isAlive()) {
+			Thread.sleep(100);
+		}
+
+		PolicyEngine.manager.getEnvironment().remove("vfc.password");
+		PolicyEngine.manager.getEnvironment().remove("vfc.username");
+		PolicyEngine.manager.getEnvironment().remove("vfc.url");
+	}
+
+	@Test
+	public void testVFCExecutionOK() throws InterruptedException {
+		PolicyEngine.manager.getEnvironment().put("vfc.url", "http://somewhere.over.the.rainbow");
+		PolicyEngine.manager.getEnvironment().put("vfc.username", "Dorothy");
+		PolicyEngine.manager.getEnvironment().put("vfc.password", "OK");
+
+		VFCManager manager = new VFCManager(mockedWorkingMemory, request);
+		manager.setRestManager(mockedRESTManager);
+
+		Thread managerThread = new Thread(manager);
+		managerThread.start();
+
+		when(mockedRESTManager.post(startsWith("http://somewhere.over.the.rainbow"), eq("Dorothy"), eq("OK"), anyMap(), anyString(), anyString()))
+		.thenReturn(httpResponsePutOK);
+
+		when(mockedRESTManager.get(endsWith("1234"), eq("Dorothy"), eq("OK"), anyMap()))
+		.thenReturn(httpResponseGetOK);
+
+		while (managerThread.isAlive()) {
+			Thread.sleep(100);
+		}
+
+		PolicyEngine.manager.getEnvironment().remove("vfc.password");
+		PolicyEngine.manager.getEnvironment().remove("vfc.username");
+		PolicyEngine.manager.getEnvironment().remove("vfc.url");
+	}
+}
diff --git a/controlloop/common/model-impl/vfc/src/test/java/org/onap/policy/vfc/TestVFCRequest.java b/controlloop/common/model-impl/vfc/src/test/java/org/onap/policy/vfc/TestVFCRequest.java
new file mode 100644
index 000000000..64307fec8
--- /dev/null
+++ b/controlloop/common/model-impl/vfc/src/test/java/org/onap/policy/vfc/TestVFCRequest.java
@@ -0,0 +1,51 @@
+/*-
+ * ============LICENSE_START=======================================================
+ * vfc
+ * ================================================================================
+ * Copyright (C) 2018 Ericsson. All rights reserved.
+ * ================================================================================
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ * 
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * ============LICENSE_END=========================================================
+ */
+
+package org.onap.policy.vfc;
+
+import static org.junit.Assert.*;
+
+import java.util.UUID;
+
+import org.junit.Test;
+
+public class TestVFCRequest {
+
+	@Test
+	public void testVFCRequest() {
+		VFCRequest request = new VFCRequest();
+		assertNotNull(request);
+		assertNotEquals(0, request.hashCode());
+		
+		String nsInstanceId = "Dorothy";
+		request.setNSInstanceId(nsInstanceId);
+		assertEquals(nsInstanceId, request.getNSInstanceId());
+		
+		UUID requestId = UUID.randomUUID();
+		request.setRequestId(requestId);
+		assertEquals(requestId, request.getRequestId());
+		
+		VFCHealRequest healRequest = new VFCHealRequest();
+		request.setHealRequest(healRequest);
+		assertEquals(healRequest, request.getHealRequest());
+		
+		assertNotEquals(0, request.hashCode());
+	}
+}
diff --git a/controlloop/common/model-impl/vfc/src/test/java/org/onap/policy/vfc/TestVFCResponse.java b/controlloop/common/model-impl/vfc/src/test/java/org/onap/policy/vfc/TestVFCResponse.java
new file mode 100644
index 000000000..36591a910
--- /dev/null
+++ b/controlloop/common/model-impl/vfc/src/test/java/org/onap/policy/vfc/TestVFCResponse.java
@@ -0,0 +1,49 @@
+/*-
+ * ============LICENSE_START=======================================================
+ * vfc
+ * ================================================================================
+ * Copyright (C) 2018 Ericsson. All rights reserved.
+ * ================================================================================
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ * 
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * ============LICENSE_END=========================================================
+ */
+
+package org.onap.policy.vfc;
+
+import static org.junit.Assert.*;
+
+import org.junit.Test;
+
+public class TestVFCResponse {
+
+	@Test
+	public void testVFCResponse() {
+		VFCResponse response = new VFCResponse();
+		assertNotNull(response);
+		assertNotEquals(0, response.hashCode());
+
+		String jobId = "GetToOz";
+		response.setJobId(jobId);
+		assertEquals(jobId, response.getJobId());
+		
+		String requestId = "Get Home";
+		response.setRequestId(requestId);
+		assertEquals(requestId, response.getRequestId());
+		
+		VFCResponseDescriptor responseDescriptor = new VFCResponseDescriptor();
+		response.setResponseDescriptor(responseDescriptor);
+		assertEquals(responseDescriptor, response.getResponseDescriptor());
+		
+		assertNotEquals(0, response.hashCode());
+	}
+}
diff --git a/controlloop/common/model-impl/vfc/src/test/java/org/onap/policy/vfc/TestVFCResponseDescriptor.java b/controlloop/common/model-impl/vfc/src/test/java/org/onap/policy/vfc/TestVFCResponseDescriptor.java
new file mode 100644
index 000000000..a2b59dd20
--- /dev/null
+++ b/controlloop/common/model-impl/vfc/src/test/java/org/onap/policy/vfc/TestVFCResponseDescriptor.java
@@ -0,0 +1,64 @@
+/*-
+ * ============LICENSE_START=======================================================
+ * vfc
+ * ================================================================================
+ * Copyright (C) 2018 Ericsson. All rights reserved.
+ * ================================================================================
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ * 
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * ============LICENSE_END=========================================================
+ */
+
+package org.onap.policy.vfc;
+
+import static org.junit.Assert.*;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import org.junit.Test;
+
+public class TestVFCResponseDescriptor {
+
+	@Test
+	public void testVFCResponseDescriptor() {
+		VFCResponseDescriptor descriptor = new VFCResponseDescriptor();
+		assertNotNull(descriptor);
+		assertNotEquals(0, descriptor.hashCode());
+
+		String errorCode = "WitchIsDead";
+		descriptor.setErrorCode(errorCode);
+		assertEquals(errorCode, descriptor.getErrorCode());
+		
+		String progress = "Visited Wizard";
+		descriptor.setProgress(progress);
+		assertEquals(progress, descriptor.getProgress());
+		
+		List<VFCResponseDescriptor> responseHistoryList = new ArrayList<>();
+		descriptor.setResponseHistoryList(responseHistoryList);
+		assertEquals(responseHistoryList, descriptor.getResponseHistoryList());
+		
+		String responseId = "WishHard";
+		descriptor.setResponseId(responseId);
+		assertEquals(responseId, descriptor.getResponseId());
+		
+		String status = "Back in Kansas";
+		descriptor.setStatus(status);
+		assertEquals(status, descriptor.getStatus());
+		
+		String statusDescription = "Back on the prairie";
+		descriptor.setStatusDescription(statusDescription);
+		assertEquals(statusDescription, descriptor.getStatusDescription());
+		
+		assertNotEquals(0, descriptor.hashCode());
+	}
+}
diff --git a/controlloop/common/model-impl/vfc/src/test/java/org/onap/policy/vfc/util/TestSerialization.java b/controlloop/common/model-impl/vfc/src/test/java/org/onap/policy/vfc/util/TestSerialization.java
new file mode 100644
index 000000000..3c4f6154e
--- /dev/null
+++ b/controlloop/common/model-impl/vfc/src/test/java/org/onap/policy/vfc/util/TestSerialization.java
@@ -0,0 +1,33 @@
+/*-
+ * ============LICENSE_START=======================================================
+ * vfc
+ * ================================================================================
+ * Copyright (C) 2018 Ericsson. All rights reserved.
+ * ================================================================================
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ * 
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * ============LICENSE_END=========================================================
+ */
+
+package org.onap.policy.vfc.util;
+
+import static org.junit.Assert.*;
+
+import org.junit.Test;
+
+public class TestSerialization {
+
+	@Test
+	public void test() {
+		assertNotNull(Serialization.gsonPretty);
+	}
+}