Merge "Add simple JUnit test for LCMResponse"

2 files changed, 110 insertions, 2 deletions

diff --git a/controlloop/common/model-impl/appclcm/src/main/java/org/onap/policy/appclcm/LCMResponse.java b/controlloop/common/model-impl/appclcm/src/main/java/org/onap/policy/appclcm/LCMResponse.java
index 003dc573b..82f374868 100644
--- a/controlloop/common/model-impl/appclcm/src/main/java/org/onap/policy/appclcm/LCMResponse.java
+++ b/controlloop/common/model-impl/appclcm/src/main/java/org/onap/policy/appclcm/LCMResponse.java
@@ -37,7 +37,7 @@ public class LCMResponse implements Serializable {
     private String payload;
 
     public LCMResponse() {
-
+    	// EMPTY
     }
 
     /**
@@ -51,7 +51,6 @@ public class LCMResponse implements Serializable {
         this.commonHeader = new LCMCommonHeader(request.getCommonHeader());
         String requestPayload = request.getPayload();
         if (requestPayload != null) {
-            // this.payload.putAll(request.payload);
             this.payload = requestPayload;
         }
     }
diff --git a/controlloop/common/model-impl/appclcm/src/test/java/org/onap/policy/appclcm/LCMResponseTest.java b/controlloop/common/model-impl/appclcm/src/test/java/org/onap/policy/appclcm/LCMResponseTest.java
new file mode 100644
index 000000000..14dee480b
--- /dev/null
+++ b/controlloop/common/model-impl/appclcm/src/test/java/org/onap/policy/appclcm/LCMResponseTest.java
@@ -0,0 +1,109 @@
+/*-
+ * ============LICENSE_START=======================================================
+ * appclcm
+ * ================================================================================
+ * Copyright (C) 2017 AT&T Intellectual Property. All rights reserved.
+ * ================================================================================
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ * 
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * ============LICENSE_END=========================================================
+ */
+package org.onap.policy.appclcm;
+
+import static org.junit.Assert.*;
+
+import org.junit.Test;
+
+public class LCMResponseTest {
+	
+	private static final String PAYLOAD = "payload";
+
+	@Test
+	public void testHashCode() {
+		LCMResponse response = new LCMResponse();
+		assertTrue(response.hashCode() != 0);
+		response.setCommonHeader(new LCMCommonHeader());
+		assertTrue(response.hashCode() != 0);
+		response.setPayload(PAYLOAD);
+		assertTrue(response.hashCode() != 0);
+		response.setStatus(null);
+		assertTrue(response.hashCode() != 0);
+	}
+
+	@Test
+	public void testLCMResponse() {
+		LCMResponse response = new LCMResponse();
+		assertNull(response.getCommonHeader());
+		assertNull(response.getPayload());
+		assertNotNull(response.getStatus());
+	}
+
+	@Test
+	public void testToString() {
+		LCMResponse response = new LCMResponse();
+		assertFalse(response.toString().isEmpty());
+	}
+
+	@Test
+	public void testEqualsObject() {
+		LCMResponse response = new LCMResponse();
+		assertTrue(response.equals(response));
+		assertFalse(response.equals(null));
+		assertFalse(response.equals(new Object()));
+		
+		LCMResponse response2 = new LCMResponse();
+		assertTrue(response.equals(response2));
+		
+		response.setCommonHeader(new LCMCommonHeader());
+		assertFalse(response.equals(response2));
+		response2.setCommonHeader(response.getCommonHeader());
+		assertTrue(response.equals(response2));
+		
+		response.setPayload(PAYLOAD);
+		assertFalse(response.equals(response2));
+		response2.setPayload(response.getPayload());
+		assertTrue(response.equals(response2));
+		
+		response.setCommonHeader(null);
+		assertFalse(response.equals(response2));
+		response2.setCommonHeader(null);
+		assertTrue(response.equals(response2));
+
+		response.setPayload(null);
+		assertFalse(response.equals(response2));
+		response2.setPayload(response.getPayload());
+		assertTrue(response.equals(response2));
+		
+		response.setStatus(null);
+		assertFalse(response.equals(response2));
+		response2.setStatus(response.getStatus());
+		assertTrue(response.equals(response2));
+		
+		LCMResponseStatus status = new LCMResponseStatus();
+		status.setCode(5);
+		response.setStatus(status);
+		response2.setStatus(new LCMResponseStatus());
+		assertFalse(response.equals(response2));
+	}
+	
+	@Test
+	public void testResponseRequest() {
+		LCMRequest request = new LCMRequest();
+		request.setCommonHeader(new LCMCommonHeader());
+		request.setPayload(PAYLOAD);
+		
+		LCMResponse response = new LCMResponse(request);
+		
+		assertTrue(response.getPayload().equals(PAYLOAD));
+	}
+
+}