Cleanup PIP/Database-related code.

Ensure database schema/naming consistent across repos.
Ensure PIP implementation consistent across repos.
Cleanup unused imports and made sure licenses are ok.

Issue-ID: POLICY-1471
Change-Id: I20a325fe3e66e6ae400e603ec366315aea716993
Signed-off-by: Joshua Reich <jreich@research.att.com>
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

3 files changed, 53 insertions, 57 deletions

diff --git a/controlloop/common/guard/src/test/resources/META-INF/persistence.xml b/controlloop/common/guard/src/test/resources/META-INF/persistence.xml
index 73b9e1809..b6d80e099 100644
--- a/controlloop/common/guard/src/test/resources/META-INF/persistence.xml
+++ b/controlloop/common/guard/src/test/resources/META-INF/persistence.xml
@@ -1,47 +1,43 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<!--
-  ============LICENSE_START=======================================================
-  drools-applications
-  ================================================================================
-  Copyright (C) 2018 AT&T Intellectual Property. All rights reserved.
-  ================================================================================
-  Licensed under the Apache License, Version 2.0 (the "License");
-  you may not use this file except in compliance with the License.
-  You may obtain a copy of the License at
-  
-       http://www.apache.org/licenses/LICENSE-2.0
-  
-  Unless required by applicable law or agreed to in writing, software
-  distributed under the License is distributed on an "AS IS" BASIS,
-  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-  See the License for the specific language governing permissions and
-  limitations under the License.
-  ============LICENSE_END=========================================================
-  -->
-<persistence version="2.1"
-    xmlns="http://xmlns.jcp.org/xml/ns/persistence"
-    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-    xsi:schemaLocation="http://xmlns.jcp.org/xml/ns/persistence http://xmlns.jcp.org/xml/ns/persistence/persistence_2_1.xsd">
-
-    <!-- In-mem DB for junit -->
-    <persistence-unit name="TestOperationsHistoryPU"
-        transaction-type="RESOURCE_LOCAL">
-        <provider>org.eclipse.persistence.jpa.PersistenceProvider</provider>
-        <properties>
-            <property name="eclipselink.ddl-generation"
-                value="create-or-extend-tables" />
-            <property name="javax.persistence.jdbc.driver"
-                value="org.h2.Driver" />
-            <property name="javax.persistence.jdbc.url"
-                value="jdbc:h2:mem:test" />
-            <property name="javax.persistence.jdbc.user"
-                value="sa" />
-            <property name="javax.persistence.jdbc.password"
-                value="" />
-            <property name="eclipselink.logging.level"
-                value="CONFIG" />
-        </properties>
-    </persistence-unit>
-
-
-</persistence>
+<?xml version="1.0" encoding="UTF-8"?>

+<!--

+  ============LICENSE_START=======================================================

+  drools-applications

+  ================================================================================

+  Copyright (C) 2018-2019 AT&T Intellectual Property. All rights reserved.

+  ================================================================================

+  Licensed under the Apache License, Version 2.0 (the "License");

+  you may not use this file except in compliance with the License.

+  You may obtain a copy of the License at

+

+       http://www.apache.org/licenses/LICENSE-2.0

+

+  Unless required by applicable law or agreed to in writing, software

+  distributed under the License is distributed on an "AS IS" BASIS,

+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.

+  See the License for the specific language governing permissions and

+  limitations under the License.

+  ============LICENSE_END=========================================================

+  -->

+<persistence xmlns="http://java.sun.com/xml/ns/persistence" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://java.sun.com/xml/ns/persistence persistence_1_0.xsd" version="1.0">

+

+    <!-- In-mem DB for junit -->

+    <persistence-unit name="OperationsHistoryPUTest"

+        transaction-type="RESOURCE_LOCAL">

+        <provider>org.eclipse.persistence.jpa.PersistenceProvider</provider>

+

+        <class>org.onap.policy.database.operationshistory.Dbao</class>

+

+        <properties>

+            <property name="eclipselink.ddl-generation" value="create-tables" />

+            <property name="eclipselink.logging.level" value="FINE" />

+            <property name="hibernate.dialect" value="org.hibernate.dialect.H2Dialect"/>

+            <property name="javax.persistence.jdbc.driver" value="org.h2.Driver" />

+            <property name="javax.persistence.jdbc.url" value="jdbc:h2:mem:testdb;DATABASE_TO_UPPER=FALSE" />

+            <property name="javax.persistence.jdbc.user" value="policy" />

+            <property name="javax.persistence.jdbc.password" value="P01icY" />

+            <property name="javax.persistence.schema-generation.database.action" value="drop-and-create"/>

+            <property name="javax.persistence.schema-generation.create-source" value="metadata"/>

+        </properties>

+    </persistence-unit>

+

+</persistence>

diff --git a/controlloop/common/guard/src/test/resources/blacklist_template.xml b/controlloop/common/guard/src/test/resources/blacklist_template.xml
index 590b19d25..1563e4a7d 100644
--- a/controlloop/common/guard/src/test/resources/blacklist_template.xml
+++ b/controlloop/common/guard/src/test/resources/blacklist_template.xml
@@ -3,7 +3,7 @@
   ============LICENSE_START=======================================================
   drools-applications
   ================================================================================
-  Copyright (C) 2018 AT&T Intellectual Property. All rights reserved.
+  Copyright (C) 2018-2019 AT&T Intellectual Property. All rights reserved.
   ================================================================================
   Licensed under the Apache License, Version 2.0 (the "License");
   you may not use this file except in compliance with the License.
@@ -33,7 +33,7 @@
                         DataType="http://www.w3.org/2001/XMLSchema#string">${clname}</AttributeValue>
                     <AttributeDesignator
                         Category="urn:oasis:names:tc:xacml:1.0:subject-category:access-subject"
-                        AttributeId="urn:oasis:names:tc:xacml:1.0:clname:clname-id"
+                        AttributeId="urn:org:onap:guard:clname:clname-id"
                         DataType="http://www.w3.org/2001/XMLSchema#string"
                         MustBePresent="false" />
                 </Match>
@@ -45,7 +45,7 @@
                         DataType="http://www.w3.org/2001/XMLSchema#string">${actor}</AttributeValue>
                     <AttributeDesignator
                         Category="urn:oasis:names:tc:xacml:1.0:subject-category:access-subject"
-                        AttributeId="urn:oasis:names:tc:xacml:1.0:actor:actor-id"
+                        AttributeId="urn:org:onap:guard:actor:actor-id"
                         DataType="http://www.w3.org/2001/XMLSchema#string"
                         MustBePresent="false" />
                 </Match>
@@ -55,7 +55,7 @@
                         DataType="http://www.w3.org/2001/XMLSchema#string">${recipe}</AttributeValue>
                     <AttributeDesignator
                         Category="urn:oasis:names:tc:xacml:3.0:attribute-category:action"
-                        AttributeId="urn:oasis:names:tc:xacml:1.0:operation:operation-id"
+                        AttributeId="urn:org:onap:guard:operation:operation-id"
                         DataType="http://www.w3.org/2001/XMLSchema#string"
                         MustBePresent="false" />
                 </Match>
@@ -86,7 +86,7 @@
                 FunctionId="urn:oasis:names:tc:xacml:1.0:function:string-one-and-only">
                 <AttributeDesignator
                     Category="urn:oasis:names:tc:xacml:3.0:attribute-category:resource"
-                    AttributeId="urn:oasis:names:tc:xacml:1.0:target:target-id"
+                    AttributeId="urn:org:onap:guard:target:target-id"
                     DataType="http://www.w3.org/2001/XMLSchema#string"
                     MustBePresent="false" />
             </Apply>
diff --git a/controlloop/common/guard/src/test/resources/frequency_limiter_template.xml b/controlloop/common/guard/src/test/resources/frequency_limiter_template.xml
index 34aa1af69..d26432f86 100644
--- a/controlloop/common/guard/src/test/resources/frequency_limiter_template.xml
+++ b/controlloop/common/guard/src/test/resources/frequency_limiter_template.xml
@@ -3,7 +3,7 @@
   ============LICENSE_START=======================================================
   drools-applications
   ================================================================================
-  Copyright (C) 2018 AT&T Intellectual Property. All rights reserved.
+  Copyright (C) 2018-2019 AT&T Intellectual Property. All rights reserved.
   ================================================================================
   Licensed under the Apache License, Version 2.0 (the "License");
   you may not use this file except in compliance with the License.
@@ -34,7 +34,7 @@
                         DataType="http://www.w3.org/2001/XMLSchema#string">${clname}</AttributeValue>
                     <AttributeDesignator
                         Category="urn:oasis:names:tc:xacml:1.0:subject-category:access-subject"
-                        AttributeId="urn:oasis:names:tc:xacml:1.0:clname:clname-id"
+                        AttributeId="urn:org:onap:guard:clname:clname-id"
                         DataType="http://www.w3.org/2001/XMLSchema#string"
                         MustBePresent="false" />
                 </Match>
@@ -46,7 +46,7 @@
                         DataType="http://www.w3.org/2001/XMLSchema#string">${actor}</AttributeValue>
                     <AttributeDesignator
                         Category="urn:oasis:names:tc:xacml:1.0:subject-category:access-subject"
-                        AttributeId="urn:oasis:names:tc:xacml:1.0:actor:actor-id"
+                        AttributeId="urn:org:onap:guard:actor:actor-id"
                         DataType="http://www.w3.org/2001/XMLSchema#string"
                         MustBePresent="false" />
                 </Match>
@@ -56,7 +56,7 @@
                         DataType="http://www.w3.org/2001/XMLSchema#string">${recipe}</AttributeValue>
                     <AttributeDesignator
                         Category="urn:oasis:names:tc:xacml:3.0:attribute-category:action"
-                        AttributeId="urn:oasis:names:tc:xacml:1.0:operation:operation-id"
+                        AttributeId="urn:org:onap:guard:operation:operation-id"
                         DataType="http://www.w3.org/2001/XMLSchema#string"
                         MustBePresent="false" />
                 </Match>
@@ -67,7 +67,7 @@
                         DataType="http://www.w3.org/2001/XMLSchema#string">${targets}</AttributeValue>
                     <AttributeDesignator
                         Category="urn:oasis:names:tc:xacml:3.0:attribute-category:resource"
-                        AttributeId="urn:oasis:names:tc:xacml:1.0:target:target-id"
+                        AttributeId="urn:org:onap:guard:target:target-id"
                         DataType="http://www.w3.org/2001/XMLSchema#string"
                         MustBePresent="false" />
                 </Match>