diff options
author | vdmeer <sven.van.der.meer@ericsson.com> | 2018-01-18 12:50:32 +0000 |
---|---|---|
committer | vdmeer <sven.van.der.meer@ericsson.com> | 2018-01-18 13:44:16 +0000 |
commit | cef733a2902a600c1b4a95ef11b2f4ffc0fcbf99 (patch) | |
tree | 5eaaa6e26b3649d74fb8966cd303b8e8d9898271 /controlloop/common/eventmanager/src | |
parent | bdf5640a2c68a0899363503dafa0f7cb1557e4a6 (diff) |
Fix Technical Debt, add Unit tests for SO
Converted to POJOs, fixed sona lint errors, added JUnit tests
POJOs now have only private members and getters/setters
This implicated actors, simulators, and existing tests
Issue-ID: POLICY-455
Change-Id: I4b80f729565e8675822a890892b15676908f73b4
Signed-off-by: vdmeer.sven <sven.van.der.meer@ericsson.com>
Diffstat (limited to 'controlloop/common/eventmanager/src')
-rw-r--r-- | controlloop/common/eventmanager/src/main/java/org/onap/policy/controlloop/eventmanager/ControlLoopOperationManager.java | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/controlloop/common/eventmanager/src/main/java/org/onap/policy/controlloop/eventmanager/ControlLoopOperationManager.java b/controlloop/common/eventmanager/src/main/java/org/onap/policy/controlloop/eventmanager/ControlLoopOperationManager.java index 0ce3bc5c3..8edb7ef14 100644 --- a/controlloop/common/eventmanager/src/main/java/org/onap/policy/controlloop/eventmanager/ControlLoopOperationManager.java +++ b/controlloop/common/eventmanager/src/main/java/org/onap/policy/controlloop/eventmanager/ControlLoopOperationManager.java @@ -423,13 +423,13 @@ public class ControlLoopOperationManager implements Serializable { } else if (response instanceof SOResponseWrapper) { SOResponseWrapper msoResponse = (SOResponseWrapper) response; - switch (msoResponse.SOResponse.httpResponseCode) { + switch (msoResponse.getSoResponse().getHttpResponseCode()) { case 200: case 202: // // Consider it as success // - this.completeOperation(this.attempts, msoResponse.SOResponse.httpResponseCode + " Success", PolicyResult.SUCCESS); + this.completeOperation(this.attempts, msoResponse.getSoResponse().getHttpResponseCode() + " Success", PolicyResult.SUCCESS); if (this.policyResult != null && this.policyResult.equals(PolicyResult.FAILURE_TIMEOUT)) { return null; } @@ -438,7 +438,7 @@ public class ControlLoopOperationManager implements Serializable { // // Consider it as failure // - this.completeOperation(this.attempts, msoResponse.SOResponse.httpResponseCode + " Failed", PolicyResult.FAILURE); + this.completeOperation(this.attempts, msoResponse.getSoResponse().getHttpResponseCode() + " Failed", PolicyResult.FAILURE); if (this.policyResult != null && this.policyResult.equals(PolicyResult.FAILURE_TIMEOUT)) { return null; } |