diff options
| author |   Jim Hahn <jrh3@att.com> | 2018-09-21 09:31:25 -0400 |
|---|---|---|
| committer | Jim Hahn <jrh3@att.com> | 2018-09-21 10:12:52 -0400 |
| commit | d85e766c5538de762820132ac723d928f5a9bf89 (patch) | |
| tree | 738c4de12a3a261035bbb25199558a490d550d3e /controlloop/common/actors/actor.so | |
| parent | faf283066f186838665ed5c38c1ba8319041bc1c (diff) | |
new sonar issues in drools-applications
Don't return null lists from AAI.
Transient TargetLock.
Extract aai.url, et. al., constants.
Don't allocate extra unneeded variable.
Re-order fields in xacml attributes.
Extract "vserver" constant from simulator.
Replace thread sleep with join.
Change-Id: Iee1bd182862632af1f131cca5db5b526f5865b9f
Issue-ID: POLICY-1129
Signed-off-by: Jim Hahn <jrh3@att.com>
Diffstat (limited to 'controlloop/common/actors/actor.so')
| -rw-r--r-- | controlloop/common/actors/actor.so/src/main/java/org/onap/policy/controlloop/actor/so/SOActorServiceProvider.java | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/controlloop/common/actors/actor.so/src/main/java/org/onap/policy/controlloop/actor/so/SOActorServiceProvider.java b/controlloop/common/actors/actor.so/src/main/java/org/onap/policy/controlloop/actor/so/SOActorServiceProvider.java index 9904bac37..8775e68a6 100644 --- a/controlloop/common/actors/actor.so/src/main/java/org/onap/policy/controlloop/actor/so/SOActorServiceProvider.java +++ b/controlloop/common/actors/actor.so/src/main/java/org/onap/policy/controlloop/actor/so/SOActorServiceProvider.java @@ -393,7 +393,7 @@ public class SOActorServiceProvider implements Actor { */ private AaiNqInventoryResponseItem findVfModule(AaiNqResponseWrapper aaiResponseWrapper, boolean baseFlag) { List<AaiNqInventoryResponseItem> lst = aaiResponseWrapper.getVfModuleItems(baseFlag); - return (lst == null || lst.isEmpty() ? null : lst.get(lst.size() - 1)); + return (lst.isEmpty() ? null : lst.get(lst.size() - 1)); } /** |