diff options
author | 2018-08-06 14:18:00 +0900 | |
---|---|---|
committer | 2018-08-06 22:30:03 +0000 | |
commit | 4ab3c22a653129e347c712cc29118f94b238d87b (patch) | |
tree | e7866a94b8b0f25a810406a06ce6c98c1e2bf7e4 /controlloop/common/actors/actor.so/src | |
parent | 6a9ba373f3eb85e160dc30a54c4d82cff8542a36 (diff) |
Fix basic code issues in controlloop
Found few issues while going through the code. Fixing
these issues in the controlloop package classes
Issue-ID: POLICY-1017
Change-Id: I24d0ce1257ad689c3e9d9b7a3bea07eeb65383f1
Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
Diffstat (limited to 'controlloop/common/actors/actor.so/src')
-rw-r--r-- | controlloop/common/actors/actor.so/src/main/java/org/onap/policy/controlloop/actor/so/SOActorServiceProvider.java | 22 |
1 files changed, 11 insertions, 11 deletions
diff --git a/controlloop/common/actors/actor.so/src/main/java/org/onap/policy/controlloop/actor/so/SOActorServiceProvider.java b/controlloop/common/actors/actor.so/src/main/java/org/onap/policy/controlloop/actor/so/SOActorServiceProvider.java index 49b4e9885..de4e43949 100644 --- a/controlloop/common/actors/actor.so/src/main/java/org/onap/policy/controlloop/actor/so/SOActorServiceProvider.java +++ b/controlloop/common/actors/actor.so/src/main/java/org/onap/policy/controlloop/actor/so/SOActorServiceProvider.java @@ -121,7 +121,7 @@ public class SOActorServiceProvider implements Actor { // Perform named query request and handle response AaiNqResponseWrapper aaiResponseWrapper = performAaiNamedQueryRequest(onset); if (aaiResponseWrapper == null) { - // Tracing and error handling handied in the "performAaiNamedQueryRequest()" method + // Tracing and error handling handled in the "performAaiNamedQueryRequest()" method return null; } @@ -292,8 +292,8 @@ public class SOActorServiceProvider implements Actor { /** * Constructs and sends an AAI vserver Named Query. * - * @param onset the virtial control loop event - * @returns the response to the AAI Named Query + * @param onset the virtual control loop event + * @return the response to the AAI Named Query */ private AaiNqResponseWrapper performAaiNamedQueryRequest(VirtualControlLoopEvent onset) { @@ -353,10 +353,10 @@ public class SOActorServiceProvider implements Actor { * @return the base or non base index or -1 if the index was not found */ private int findIndex(List<AaiNqInventoryResponseItem> inventoryResponseItems, boolean baseIndexFlag) { - for (AaiNqInventoryResponseItem invenoryResponseItem : inventoryResponseItems) { - if (invenoryResponseItem.getVfModule() != null - && baseIndexFlag == invenoryResponseItem.getVfModule().getIsBaseVfModule()) { - return inventoryResponseItems.indexOf(invenoryResponseItem); + for (AaiNqInventoryResponseItem inventoryResponseItem : inventoryResponseItems) { + if (inventoryResponseItem.getVfModule() != null + && baseIndexFlag == inventoryResponseItem.getVfModule().getIsBaseVfModule()) { + return inventoryResponseItems.indexOf(inventoryResponseItem); } } @@ -373,9 +373,9 @@ public class SOActorServiceProvider implements Actor { @SuppressWarnings("unused") private int findNonBaseModules(List<AaiNqInventoryResponseItem> inventoryResponseItems) { int nonBaseModuleCount = 0; - for (AaiNqInventoryResponseItem invenoryResponseItem : inventoryResponseItems) { - if (invenoryResponseItem.getVfModule() != null - && (!invenoryResponseItem.getVfModule().getIsBaseVfModule())) { + for (AaiNqInventoryResponseItem inventoryResponseItem : inventoryResponseItems) { + if (inventoryResponseItem.getVfModule() != null + && (!inventoryResponseItem.getVfModule().getIsBaseVfModule())) { nonBaseModuleCount++; } } @@ -398,7 +398,7 @@ public class SOActorServiceProvider implements Actor { * This method reads and validates environmental properties coming from the policy engine. Null * properties cause an {@link IllegalArgumentException} runtime exception to be thrown * - * @param string the name of the parameter to retrieve + * @param enginePropertyName the name of the parameter to retrieve * @return the property value */ private static String getPeManagerEnvProperty(String enginePropertyName) { |