aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLiam Fallon <liam.fallon@ericsson.com>2018-09-17 13:16:20 +0000
committerGerrit Code Review <gerrit@onap.org>2018-09-17 13:16:20 +0000
commitd76dd05fbb53b382da2e5acf5e4fce748a233af2 (patch)
tree2af80913775bd743e49cd761435037e09e30d9a3
parent0bd7ab17674ca4eee396dfe8df3a769632a6e733 (diff)
parentbe6ee845ae7e6a8a2c2e67fed03f38c8c6ec292e (diff)
Merge "Fixed sonar code smell"
-rw-r--r--controlloop/common/actors/actor.so/src/main/java/org/onap/policy/controlloop/actor/so/SOActorServiceProvider.java8
1 files changed, 3 insertions, 5 deletions
diff --git a/controlloop/common/actors/actor.so/src/main/java/org/onap/policy/controlloop/actor/so/SOActorServiceProvider.java b/controlloop/common/actors/actor.so/src/main/java/org/onap/policy/controlloop/actor/so/SOActorServiceProvider.java
index 5285d54bd..f7df1826c 100644
--- a/controlloop/common/actors/actor.so/src/main/java/org/onap/policy/controlloop/actor/so/SOActorServiceProvider.java
+++ b/controlloop/common/actors/actor.so/src/main/java/org/onap/policy/controlloop/actor/so/SOActorServiceProvider.java
@@ -169,7 +169,7 @@ public class SOActorServiceProvider implements Actor {
return constructCreateRequest(aaiResponseWrapper, policy, tenantItem, vnfItem, vnfServiceItem,
vfModuleItem);
} else if (RECIPE_VF_MODULE_DELETE.equals(policy.getRecipe())) {
- return constructDeleteRequest(aaiResponseWrapper, tenantItem, vnfItem, vnfServiceItem, vfModuleItem);
+ return constructDeleteRequest(tenantItem, vnfItem, vnfServiceItem, vfModuleItem);
} else {
return null;
}
@@ -290,16 +290,14 @@ public class SOActorServiceProvider implements Actor {
/**
* Construct SO request to delete vf-module
*
- * @param aaiResponseWrapper the AAI response containing the VF modules
* @param tenantItem tenant item from A&AI named-query response
* @param vnfItem vnf item from A&AI named-query response
* @param vnfServiceItem vnf service item from A&AI named-query response
* @param vfModuleItem vf module item from A&AI named-query response
* @return SO delete vf-module request
*/
- private SORequest constructDeleteRequest(AaiNqResponseWrapper aaiResponseWrapper, AaiNqInventoryResponseItem
- tenantItem, AaiNqInventoryResponseItem vnfItem, AaiNqInventoryResponseItem vnfServiceItem,
- AaiNqInventoryResponseItem vfModuleItem) {
+ private SORequest constructDeleteRequest(AaiNqInventoryResponseItem tenantItem, AaiNqInventoryResponseItem
+ vnfItem, AaiNqInventoryResponseItem vnfServiceItem, AaiNqInventoryResponseItem vfModuleItem) {
SORequest request = new SORequest();
request.setOperationType(SoOperationType.DELETE_VF_MODULE);
request.setRequestDetails(new SORequestDetails());