summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRashmi Pujar <rashmi.pujar@bell.ca>2019-12-17 15:43:51 -0500
committerRashmi Pujar <rashmi.pujar@bell.ca>2019-12-23 13:22:12 -0500
commita894ffb5f580dec7ab4e8ea367107fcee09fca1b (patch)
treea2af2652ffa30d12b9a35043fded2cccb379caf0
parent927c7c177670a812a4a4139281ef84e85b520645 (diff)
Parameterize base-image version for drools-apps
Issue-ID: POLICY-2318 Signed-off-by: Rashmi Pujar <rashmi.pujar@bell.ca> Change-Id: Ida14508366f20ca05648f941a9b326899672b274
-rw-r--r--controlloop/packages/docker-controlloop/pom.xml39
-rw-r--r--controlloop/packages/docker-controlloop/src/main/docker/Dockerfile2
2 files changed, 40 insertions, 1 deletions
diff --git a/controlloop/packages/docker-controlloop/pom.xml b/controlloop/packages/docker-controlloop/pom.xml
index f709585ee..653fe251e 100644
--- a/controlloop/packages/docker-controlloop/pom.xml
+++ b/controlloop/packages/docker-controlloop/pom.xml
@@ -80,6 +80,44 @@
</execution>
</executions>
</plugin>
+ <!--fabric8.io docker-maven-plugin does not support ARG usage in the FROM statement of Dockerfile
+ even though docker supports it: https://github.com/fabric8io/docker-maven-plugin/issues/859.
+ As a workaround we shall use maven-antrun-plugin to copy the Dockerfile and apply filters to
+ replace the parameterized base-image version. The fabric8.io docker-maven-plugin shall use this filtered file
+ to build the image. After the image is built we perform a cleanup to remove the filtered file.-->
+ <plugin>
+ <artifactId>maven-antrun-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>update-parameterized-dockerfile</id>
+ <phase>initialize</phase>
+ <goals>
+ <goal>run</goal>
+ </goals>
+ <configuration>
+ <tasks>
+ <copy file="src/main/docker/Dockerfile" toFile="src/main/docker/antrun/Dockerfile">
+ <filterset>
+ <filter token="version.policy.drools-pdp" value="${version.policy.drools-pdp}"/>
+ </filterset>
+ </copy>
+ </tasks>
+ </configuration>
+ </execution>
+ <execution>
+ <id>cleanup-filtered-dockerfile</id>
+ <phase>process-sources</phase>
+ <goals>
+ <goal>run</goal>
+ </goals>
+ <configuration>
+ <tasks>
+ <delete dir="src/main/docker/antrun"/>
+ </tasks>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
<plugin>
<groupId>io.fabric8</groupId>
<artifactId>docker-maven-plugin</artifactId>
@@ -93,6 +131,7 @@
<name>onap/policy-pdpd-cl</name>
<build>
<cleanup>try</cleanup>
+ <contextDir>antrun</contextDir>
<dockerFile>Dockerfile</dockerFile>
<tags>
<tag>${project.version}</tag>
diff --git a/controlloop/packages/docker-controlloop/src/main/docker/Dockerfile b/controlloop/packages/docker-controlloop/src/main/docker/Dockerfile
index 14e8c7400..98bf35a8e 100644
--- a/controlloop/packages/docker-controlloop/src/main/docker/Dockerfile
+++ b/controlloop/packages/docker-controlloop/src/main/docker/Dockerfile
@@ -1,4 +1,4 @@
-FROM onap/policy-drools:1.6-SNAPSHOT-latest
+FROM onap/policy-drools:@version.policy.drools-pdp@
ARG BUILD_VERSION_APP_CL=${BUILD_VERSION_APP_CL}
ENV BUILD_VERSION_APP_CL=${BUILD_VERSION_APP_CL}