aboutsummaryrefslogtreecommitdiffstats
path: root/reception/src/main
AgeCommit message (Collapse)AuthorFilesLines
2022-05-12Security issues from sonar cloud fixesadheli.tavares1-5/+5
Issue-ID: POLICY-4168 Change-Id: Iedac6c95be452be81e8c73055193b4707735ef56 Signed-off-by: adheli.tavares <adheli.tavares@est.tech>
2022-04-06Error handling when a decoder fails to parse policyadheli.tavares1-4/+15
- catch exception only if it was a parse error (still raises exception when no decoder found) - reducing of complexity on acm decoding for sonar - added some debug logging and exception messages for better tracking of issues Issue-ID: POLICY-4006 Change-Id: Ie09aaf541fc06244b84477ecbfe70fc837438a86 Signed-off-by: adheli.tavares <adheli.tavares@est.tech>
2022-01-12Add distribution app metrics to prometheusRam Krishna Verma1-36/+49
Adding the distribution application level metrics to prometheus. Adapted the changes so that existing test cases for DistributionStatisticsManager are not affected and still provides the full coverage. Issue-ID: POLICY-3759 Change-Id: I972f107e4ac46c2769dfaeb9bcefa0731bb879ca Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2021-07-30Use new RestClientParameters class in distributionJim Hahn1-1/+2
This is a re-do of a previously reverted review. It's mostly the same as before, but there are some minor differences. Replaced LifecycleApiForwarderParameters with RestClientParameters. Also modified the code to get the HttpClient objects once. Also removed some unused json test files. This requires changes to property files in CSITs and OOM: - add "clientName" to the api & pap structures - rename "hostName" to "hostname" - rename "isHttps" to "useHttps" and move it inside the api & pap structures Issue-ID: POLICY-3456 Change-Id: I32b04bc3b6880ec7798814dad268143bc3b06faf Signed-off-by: Jim Hahn <jrh3@att.com>
2021-07-07Use lombok in policy/distributionRam Krishna Verma1-14/+3
Use lombok for getter, setter, constructor & builder functions. Remove unused classes. Remove duplicate classes for testing exceptions. Issue-ID: POLICY-3393 Change-Id: I8a565bc6a5699b8716982f84e03b6a11d08ce65b Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2021-05-06Fix sonars in policy-distributionJim Hahn4-10/+10
Fixed: - use "var" instead of actual type Issue-ID: POLICY-3285 Change-Id: I0dba2f96870722b4071ac0085287bc91a27dde88 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-04-29Remove GroupValidationResultJim Hahn3-178/+47
Removed GroupValidationResult, replacing it with BeanValidationResult. Modified the ParameterGroup subclasses to use BeanValidator, adding annotations where needed to trigger the validations that had been automatically performed by GroupValidationResult. Issue-ID: POLICY-2059 Change-Id: Ib5c0dc0ac3762e68307e63f5ce29efb49208e55d Signed-off-by: Jim Hahn <jrh3@att.com>
2020-12-04Sonar issues with visibilityPamela Dragosh2-2/+4
S5993 Change the visibility of this constructor to "protected". Issue-ID: POLICY-2908 Change-Id: Id7b7d908eb687345f4d91b05869b3925c8694b05 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-06-19Changes for Checkstyle 8.32 in policy-distributiona.sreekumar6-8/+1
Change-Id: I8f9324279f24cc3b9d26f265c3dacd5b61ce856b Issue-ID: POLICY-2188 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2020-03-27Use AtomicInteger and other sonarPamela Dragosh1-4/+0
Removed unused logger. Added NOSONAR to main to remove security risk, as we do validate arguments. Used AtomicInteger. Issue-ID: POLICY-2305 Change-Id: I18e91836e914b7fd6e3cd9a950dca58fcd8be5b5 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-03-26Remove unused imports and clean logsPamela Dragosh4-9/+15
Unused imports and marked an unused variable. Added m2e eclipse settings (other repos have this). Added some test logback.xml to clear out jetty debug messages. Replaced deprecated newInstance with getDeclaredConstructor. newInstance Either log or throw Exception - chose throw Added some assertions to JUnit test. Issue-ID: POLICY-2305 Change-Id: Ia4e9ce62dc7fb45aea247d470ca7245e694fc26e Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-08-06Changing parameters to use ParameterGroupImplramverma2-26/+11
1. Changing all the decoders & handlers parameters to use ParameterGroupImpl. 2. Fixed all the test cases. Issue-ID: POLICY-1890 Change-Id: I4a124c0acc650020977ac8e2cee143c72003973a Signed-off-by: ramverma <ram.krishna.verma@est.tech>
2019-07-17Changing policy/distribution to use policy/modelsramverma3-14/+14
1) Changed policy distribution framework to use entities from policy/models 2) Changed all the test cases. 3) Commented few test cases which will be fixed along with code fixes. 4) Will be removing the old policy entities once all the pieces are ready. Change-Id: I1fd7b975b2e072c0b24e429903c9ca4796173929 Issue-ID: POLICY-1888 Signed-off-by: ramverma <ram.krishna.verma@est.tech>
2019-02-05Change policy/distribution logging to slf4jramverma6-29/+34
1) Changed logging from FlexLogger to SLF4J with logback 2) Fixed test cases of distribution REST endpoints having infinite while loop Change-Id: I1551873b3d348f9a7d2b4f8dfc3ae5dd6462bdb8 Issue-ID: POLICY-1346 Signed-off-by: ramverma <ram.krishna.verma@est.tech>
2018-11-09Fix sonar/checkstyle issuesPamela Dragosh3-5/+5
The main pom.xml was incorrect, so these issues have creeped into the source code. Issue-ID: POLICY-1256 Change-Id: Ic0b52f3a28f869252120991b0c1946ef8402bcc5 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-09-14Fix sonar bugs in distributionramverma1-0/+4
Change-Id: I20c1246efc3ce0ad6d874e6a0b5c8230c96b9425 Issue-ID: POLICY-1035 Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
2018-09-14Merge "Adding statistics endpoint to distribution"Liam Fallon1-0/+156
2018-09-13Adding statistics endpoint to distributionramverma1-0/+156
* Adding statistics endpoint in DistributionRestController * Adding DistributionStatisticsManager to hold all stats. * Adding StatisticsReport class to represent distribution stats report. * Updating stats at each step in SdcReceptionHandler. * Adding test cases for all code changes. Change-Id: I0b0f97aecc64b18314367fdff6d3ca7bee06efc7 Issue-ID: POLICY-1035 Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
2018-09-13Adding policy decoder to extract file from csarramverma5-1/+152
* Adding decoder configuration parameters infrastructure to support plugin based architecture. Adding a new policy decoder after this will be just creating a new decoder class and its corresponding parameter class. * Adding a new decoder which extracts policy file from given csar. It is written in a generic way to extract file for any pdp like apex, drools. * Adding configuration parameters for the new decoder. The policy file name and policy type is passed as parameter to the decoder. * Fixing few broken package declaration in pdpx decoder tests. * Adding test cases for all code changes. Change-Id: I95e68cebce0f9747ca63b090f9b9116ce8836939 Issue-ID: POLICY-1101 Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
2018-09-09Fixing sonar bugs in distributionramverma2-15/+14
Change-Id: I3ec5c73c54145b1ba9f637eaa95c843e25f46a10 Issue-ID: POLICY-1035 Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
2018-09-05Refactored reception handler parameter handlingmmis5-362/+147
Refactored parameter handling for configuration of reception handlers as the previous implementation does not align with the plugin architecture (.e. plugin specific parameters being handled in core code) Issue-ID: POLICY-1094 Change-Id: I31a9fc7f712ca43f0f69c42a6d99fa481b02cd4b Signed-off-by: mmis <michael.morris@ericsson.com>
2018-09-04Merge "Adding code for managing life cycle of SDC Client"Pamela Dragosh3-3/+58
2018-09-04Adding code for managing life cycle of SDC Clientramverma3-3/+58
* Adding init/start/stop methods in SDCReceptionHandler for managing lifecycle of SDC Client. * Adding a handler status enum to hold all the possible status values. * Adding test cases to cover code changes fully. Change-Id: Ib6f370485ff330538bfada6030c592629ed3fd1c Issue-ID: POLICY-956 Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
2018-08-30Create code infrastructure for policy forwardingmmis1-2/+3
Added sending of polices from the policy forwarder to the xacml PDP and added handling of parameters for configuring the policy forwarders Issue-ID: POLICY-926 Change-Id: I26effe70769f7edc765470a1a9ad40ed9faad82d Signed-off-by: mmis <michael.morris@ericsson.com>
2018-08-29Parameter Service Interface Changesliamfallon1-1/+9
Changes to distribution due to changes to parameter services, mainly addition of setName() to parameter service interface and correct handling of empty parameters Change-Id: I9523da6461874241d220f0feac61419ef6ebbb9d Issue-ID: POLICY-1035 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-08-24Fix sonar and checkstyle issues in distributionramverma9-394/+429
* Fixing all check style issues. * Fixing all sonar issues. * Adding maven check style plugin to fail at warning level. Change-Id: I791b8feef39a3a0c3e1e250efea7b6e78208bf07 Issue-ID: POLICY-1035 Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
2018-08-23Fix sonar code coverage issueliboNet1-69/+138
* Remove unused import * Fix more than 1 statements on one line * Divide validate into three parts to Fix >10 cyclomatic Complexity Change-Id: I9c89c4854de31fa02a9052055662f4b74d12fe10 Issue-ID: POLICY-956 Signed-off-by: liboNet <libo.zhu@intel.com>
2018-08-22integrate PSSDConfiguration to distributionliboNet2-2/+307
* Integrate the PSSDConfiguration to distribution config parameter. * Moved related PSSDConfigurationParameterGroup classes from "handling" to "parameters" to avoid specified sdc dependency. * Modify all the test case since the distribution config parameter has been changed, update CommonTestData to wrap it. * Add neccessnary SDC handling exceptions which to be used for SDC handler integration. * update the PSSDCOnfiguraitonParameterGroup to add UUID to the setName function to generate unique name for each instance. * use builder to create PSSDConfigurationParametersGroup instead of using many parameters Change-Id: I3c78bc2a51ebc84761bc9458096d6ffa18070b47 Issue-ID: POLICY-956 Signed-off-by: liboNet <libo.zhu@intel.com>
2018-08-16Adding termination code changes for distributionramverma6-24/+47
* Code changes for terminating the handlers started by distribution activator. * More test cases to increase coverage. * Fixes for checkstyle issues. * Fixes for sonar issues. Change-Id: I3299317c83fa643ac1d0ba1105ac1a932c0a83f6 Issue-ID: POLICY-1035 Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
2018-08-15Adding code for bootstrapping policy distributionramverma6-44/+439
* Code changes for initializing handlers & related plugins from configuration parameter JSON file. * Using common parameter service for refering parameters at multiple places. * Moved related parameters classes from "main" to "reception" to avoid maven cyclic dependency errors. * Added test cases for new code chnages. The test coverage is around 95%. * Changed logging from slf4j to common-logging. Change-Id: Ifb77cfaa6e6472d43295a7c41a49ddd657c0e2c2 Issue-ID: POLICY-1035 Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
2018-08-02Create interfaces for Policy Distributionmmis5-0/+307
Created interfaces and some skeletal implementations. Implememtations to be further developed in subsequent stories Change-Id: If55be78e34c8783451cb9aa755a563bc0850e569 Issue-ID: POLICY-1029 Signed-off-by: mmis <michael.morris@ericsson.com>