Age | Commit message (Collapse) | Author | Files | Lines |
|
This is a re-do of a previously reverted review. It's mostly the same
as before, but there are some minor differences.
Replaced LifecycleApiForwarderParameters with RestClientParameters.
Also modified the code to get the HttpClient objects once.
Also removed some unused json test files.
This requires changes to property files in CSITs and OOM:
- add "clientName" to the api & pap structures
- rename "hostName" to "hostname"
- rename "isHttps" to "useHttps" and move it inside the api & pap
structures
Issue-ID: POLICY-3456
Change-Id: I32b04bc3b6880ec7798814dad268143bc3b06faf
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Use lombok for getter, setter, constructor & builder functions.
Remove unused classes.
Remove duplicate classes for testing exceptions.
Issue-ID: POLICY-3393
Change-Id: I8a565bc6a5699b8716982f84e03b6a11d08ce65b
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
|
|
The new version of checkstyle identified new issues. Fixed those.
Issue-ID: POLICY-3286
Change-Id: I15adece9fa2e136108febc0d74af6c0d55f975c5
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Fixed:
- more cases of "var"
Issue-ID: POLICY-3285
Change-Id: I41345dfde611497e848b1d207b34eeda1c2c3feb
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Fixed:
- use "var" instead of actual type
Issue-ID: POLICY-3285
Change-Id: I0dba2f96870722b4071ac0085287bc91a27dde88
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Removed GroupValidationResult, replacing it with BeanValidationResult.
Modified the ParameterGroup subclasses to use BeanValidator, adding
annotations where needed to trigger the validations that had been
automatically performed by GroupValidationResult.
Issue-ID: POLICY-2059
Change-Id: Ib5c0dc0ac3762e68307e63f5ce29efb49208e55d
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Also modified the code to work with any HTTP response code in the range
200-299.
Issue-ID: POLICY-3143
Change-Id: Id7bcb0c98714c6d98ad7f5d7ceb3b033906aeab1
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Issue-ID: POLICY-3105
Change-Id: I37f09fb3edb9329fa8a0138b81dbc5fafc5864fa
Signed-off-by: pd1248 <pdragosh@research.att.com>
|
|
Change-Id: Ibb79e61fc7d3923f123539873a5a08e599c175ab
Issue-ID: POLICY-3127
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
|
|
Issue-ID: POLICY-3088
Change-Id: Iefa88438d23defeb73875ec4de9be29541b24b89
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
|
|
Sonar wants to promote one value to a long, to avoid risk of overflow before assignment.
Issue-ID: POLICY-2908
Change-Id: I2a92cfd8e437dac3f77ee0366993ae28b2c4c05e
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Removes unused import and also adds a check for file size.
Since these entries are opened in memory, use NOSONAR to clear
sonar security hotspot.
Issue-ID: POLICY-2908
Change-Id: Ic3511a3f59cd2d78301316df209de5da1e25acdb
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Adding a check to ensure that a zip file cannot be corrupted
with a path injection to open a stream somewhere else in the
file system.
Issue-ID: POLICY-2908
Change-Id: Iaa75fc8c14831ad73fa7ab59c618909ff5af454c
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
The class ToscaPolicyIdentifierOptVersion is replaced by ToscaConceptIdentifierOptVersion in policy/models. Made the corresponding changes in policy/distribution.
Issue-ID: POLICY-2900
Change-Id: I10fb99ecd4f52a811cde49fbc9e35ae2eb28596a
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
|
|
Issue-ID: POLICY-2875
Change-Id: I5d447736a0d74bdce6f6907808d9a7c35a4bf8e0
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
|
|
Issue-ID: POLICY-2869
Change-Id: Iccbc23191763dcb9a2781973e29a85e0e34386cf
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Issue-ID: POLICY-2839
Change-Id: I0de77e37818fb5da771003fbaefc74e97d0ef404
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
|
|
Issue-ID: POLICY-2789
Change-Id: Ic7783fec3955474266fe0e5c4e178b1db21661d8
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
|
|
Junit tests were failing randomly on the build server, perhaps due to
the fact that multiple tests attempt to bind to the server port, 6969.
Modified most of the tests to allocate their own server port.
Issue-ID: POLICY-2713
Change-Id: If40eef7989c9a46e2d458d915ed5bd0281ff0b0d
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Issue-ID: POLICY-2477
Change-Id: Iff4158e2322724265007d5a90459c3ebf62d3fc2
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
|
|
Issue-ID: POLICY-2695
Change-Id: I1ceafeaa50e8563605e5cbaa50e4b7b7769492f9
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Replaced try/catch blocks in policy/distribution test cases with assertj assertions
Issue-ID: POLICY-2451
Change-Id: Ib7ecd13e39abd471bf1424d8a3db22c72ad1e3b8
Signed-off-by: waynedunican <wayne.dunican@est.tech>
|
|
Change-Id: I8f9324279f24cc3b9d26f265c3dacd5b61ce856b
Issue-ID: POLICY-2188
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
|
|
Issue-ID: POLICY-2365
Change-Id: I4f894f73b5f6296d823de3feff342c9ac1824e3e
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
|
|
Issue-ID: POLICY-2116
Change-Id: Ieaa6956ec2b0c3cb81463b359abf70f36708561d
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
|
|
The default provider has been changed to gson, so the provider property
no longer has to be set.
Issue-ID: POLICY-1527
Change-Id: If37d8789a439be216bebab81317df5763c432190
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Issue-ID: POLICY-2514
Change-Id: I22bdaad652917f0d1a30c297fdfd48b7cabd76dd
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Issue-ID: POLICY-2514
Change-Id: I6093e20eb2918a5a5ebf070b5a96c58380d8b30e
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Issue-ID: POLICY-2378
Change-Id: I09f030b2256d0cefe69d88cdedd3f5dc05472296
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
|
|
Per Jim's last comments.
Issue-ID: POLICY-2305
Change-Id: I1bc73dcd264e9a122f6ec0eece08202cbcb3a8e9
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Removed unused logger.
Added NOSONAR to main to remove security risk, as we do
validate arguments.
Used AtomicInteger.
Issue-ID: POLICY-2305
Change-Id: I18e91836e914b7fd6e3cd9a950dca58fcd8be5b5
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Issue-ID: POLICY-2305
Change-Id: If0778cb7bdade11575cab12c4742274939cd22c7
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Unused imports and marked an unused variable.
Added m2e eclipse settings (other repos have this).
Added some test logback.xml to clear out jetty debug
messages.
Replaced deprecated newInstance with getDeclaredConstructor.
newInstance
Either log or throw Exception - chose throw
Added some assertions to JUnit test.
Issue-ID: POLICY-2305
Change-Id: Ia4e9ce62dc7fb45aea247d470ca7245e694fc26e
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Issue-ID: POLICY-2378
Change-Id: Ib343ff092b761c6642d9d0dcd4538ffd41423602
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
|
|
Issue-ID: POLICY-2404
Change-Id: Ia3084c55ea65a3119354079d9afd3ee35689b7d4
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
|
|
Issue-ID: POLICY-2355
Change-Id: I84fe65adb91284f1537ed0422aced705e765b05c
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
|
|
Now that JDK11 upgrade done, policy/parent has the right
parameters defined. Cleaned up and made sure only one
.exec file being generated.
Issue-ID: POLICY-2321
Change-Id: I058119982e56bc5c111ba3f2fe44079be97fd889
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Issue-ID: POLICY-1585
Change-Id: I4aa879656c039d9de9c288f0309105c21f4bf285
Signed-off-by: HOCKLA <ah999m@att.com>
|
|
Change-Id: Ie2ebfa16bc6b08dc54d60ef276f52e9ea2c91b1f
Issue-ID: POLICY-1869
Signed-off-by: Liang Ding <liang.ding@intel.com>
|
|
Change-Id: I25f956c863f93c998c681535f5ef7ec43ca88cde
Issue-ID: POLICY-2029
Signed-off-by: Liang Ding <liang.ding@intel.com>
|
|
These are the lines removed:
+ Proprietary information (Restricted)
+ For use only by authorized individuals and not for general distribution.
Change-Id: I5a51d6f6bb40e464f9f9952cb139b668a4530298
Issue-ID: POLICY-2107
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
|
|
Creating a new policy decoder & its related parameter classes for
decoding the HPA policy as ToscaServiceTemplate which is accepted
by the new Lifecycle API of Policy Framework.
Added couple of changes per review comments.
Issue-ID: POLICY-2122
Change-Id: I2d19b04cd24dd9c5b9fbf959757272077e6413d4
Signed-off-by: ramverma <ram.krishna.verma@est.tech>
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Issue-ID: POLICY-2107
Change-Id: Ib237140f44460cecf7b379c77c7edbd7387638a0
Signed-off-by: ramverma <ram.krishna.verma@est.tech>
|
|
Also added default branch to .gitreview to facilitate branching
in the future.
Change-Id: I37d40b122924c35ddfc2e18aed3b126f0dab819c
Issue-ID: POLICY-2045
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Fixing few unit tests broken due to side effects of change in policy/models.
Issue-ID: POLICY-1871
Change-Id: Ia702e54e21ddbdde114570078ad6fcf85765a660
Signed-off-by: ramverma <ram.krishna.verma@est.tech>
|
|
Bringing back the old HPA policy decoder and its related classes and
tests. The distribution framework will support both the new PAP/API and
the old policy engine in El Alto release.
Issue-ID: POLICY-1871
Change-Id: Iab911b793207a09b02e906ed6913c54bc252f64c
Signed-off-by: ramverma <ram.krishna.verma@est.tech>
|
|
Issue-ID: POLICY-1881
Change-Id: Ib8638bd3f5b8a5527cafa817cde2605b9545aebd
Signed-off-by: ramverma <ram.krishna.verma@est.tech>
|
|
* Adding implementation of LifecycleApiForwarder in policy/distribution
for forwarding policy to new components (PAP & API).
* Adding related test cases and json files for testing.
* Created a rest simulator to use for testing the API calls.
* Fixed review comments
Issue-ID: POLICY-1890
Change-Id: I6682e0366206d3f4ac77f60b676f40a0fd1aad02
Signed-off-by: ramverma <ram.krishna.verma@est.tech>
|
|
1. Changing all the decoders & handlers parameters to use
ParameterGroupImpl.
2. Fixed all the test cases.
Issue-ID: POLICY-1890
Change-Id: I4a124c0acc650020977ac8e2cee143c72003973a
Signed-off-by: ramverma <ram.krishna.verma@est.tech>
|
|
1. Changing all the forwarder parameter groups to extend the
ParameterGroupImpl instead of implementing the ParameterGroup interface.
2. Introducing lombok in distribution.
3. Fixing all the affected test cases.
4. Creating parameter group to hold parameters needed for forwarding
policies to the new lifecycle API's.
Issue-ID: POLICY-1890
Change-Id: I0c8b72f355a610fa5d46daaacc9ef7f06b7cec09
Signed-off-by: ramverma <ram.krishna.verma@est.tech>
|