Age | Commit message (Collapse) | Author | Files | Lines |
|
This commit unpacks the csar received either from SDC or for local
verification from file-system, prepares the toscaservicetemplate with
needed node-types and data-types, forwards the template to controlloop
runtime components for commisioning of controlloop.
Issue-ID: POLICY-3808
Signed-off-by: Sirisha_Manchikanti <sirisha.manchikanti@est.tech>
Change-Id: Ib3600542aca7b32ae19242c2f924bdaf2ab870a8
|
|
KeyStorePassword and KeyStorePath values
can be expressed as simply null instead of "null"
Issue-ID: POLICY-3604
Change-Id: I839bce33df4829fcc8d604f8ed1e52e6f50ef988
Signed-off-by: lapentafd <francesco.lapenta@est.tech>
|
|
Adding support for yaml format of policy & policy types in distribution.
So that users can either define them in json or yaml format.
And then distribute to policy framework.
Issue-ID: POLICY-3509
Change-Id: Ifba7486bbc1e6876f0e3e39b0ae5ebe043567029
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
|
|
Use lombok for getter, setter, constructor & builder functions.
Remove unused classes.
Remove duplicate classes for testing exceptions.
Issue-ID: POLICY-3393
Change-Id: I8a565bc6a5699b8716982f84e03b6a11d08ce65b
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
|
|
The new version of checkstyle identified new issues. Fixed those.
Issue-ID: POLICY-3286
Change-Id: I15adece9fa2e136108febc0d74af6c0d55f975c5
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Fixed:
- more cases of "var"
Issue-ID: POLICY-3285
Change-Id: I41345dfde611497e848b1d207b34eeda1c2c3feb
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Fixed:
- use "var" instead of actual type
Issue-ID: POLICY-3285
Change-Id: I0dba2f96870722b4071ac0085287bc91a27dde88
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Removed GroupValidationResult, replacing it with BeanValidationResult.
Modified the ParameterGroup subclasses to use BeanValidator, adding
annotations where needed to trigger the validations that had been
automatically performed by GroupValidationResult.
Issue-ID: POLICY-2059
Change-Id: Ib5c0dc0ac3762e68307e63f5ce29efb49208e55d
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Sonar wants to promote one value to a long, to avoid risk of overflow before assignment.
Issue-ID: POLICY-2908
Change-Id: I2a92cfd8e437dac3f77ee0366993ae28b2c4c05e
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Removes unused import and also adds a check for file size.
Since these entries are opened in memory, use NOSONAR to clear
sonar security hotspot.
Issue-ID: POLICY-2908
Change-Id: Ic3511a3f59cd2d78301316df209de5da1e25acdb
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Adding a check to ensure that a zip file cannot be corrupted
with a path injection to open a stream somewhere else in the
file system.
Issue-ID: POLICY-2908
Change-Id: Iaa75fc8c14831ad73fa7ab59c618909ff5af454c
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Issue-ID: POLICY-2477
Change-Id: Iff4158e2322724265007d5a90459c3ebf62d3fc2
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
|
|
Change-Id: I8f9324279f24cc3b9d26f265c3dacd5b61ce856b
Issue-ID: POLICY-2188
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
|
|
Per Jim's last comments.
Issue-ID: POLICY-2305
Change-Id: I1bc73dcd264e9a122f6ec0eece08202cbcb3a8e9
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Removed unused logger.
Added NOSONAR to main to remove security risk, as we do
validate arguments.
Used AtomicInteger.
Issue-ID: POLICY-2305
Change-Id: I18e91836e914b7fd6e3cd9a950dca58fcd8be5b5
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Unused imports and marked an unused variable.
Added m2e eclipse settings (other repos have this).
Added some test logback.xml to clear out jetty debug
messages.
Replaced deprecated newInstance with getDeclaredConstructor.
newInstance
Either log or throw Exception - chose throw
Added some assertions to JUnit test.
Issue-ID: POLICY-2305
Change-Id: Ia4e9ce62dc7fb45aea247d470ca7245e694fc26e
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Issue-ID: POLICY-2404
Change-Id: Ia3084c55ea65a3119354079d9afd3ee35689b7d4
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
|
|
Change-Id: Ie2ebfa16bc6b08dc54d60ef276f52e9ea2c91b1f
Issue-ID: POLICY-1869
Signed-off-by: Liang Ding <liang.ding@intel.com>
|
|
Change-Id: I25f956c863f93c998c681535f5ef7ec43ca88cde
Issue-ID: POLICY-2029
Signed-off-by: Liang Ding <liang.ding@intel.com>
|
|
Creating a new policy decoder & its related parameter classes for
decoding the HPA policy as ToscaServiceTemplate which is accepted
by the new Lifecycle API of Policy Framework.
Added couple of changes per review comments.
Issue-ID: POLICY-2122
Change-Id: I2d19b04cd24dd9c5b9fbf959757272077e6413d4
Signed-off-by: ramverma <ram.krishna.verma@est.tech>
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Bringing back the old HPA policy decoder and its related classes and
tests. The distribution framework will support both the new PAP/API and
the old policy engine in El Alto release.
Issue-ID: POLICY-1871
Change-Id: Iab911b793207a09b02e906ed6913c54bc252f64c
Signed-off-by: ramverma <ram.krishna.verma@est.tech>
|
|
1. Changing all the decoders & handlers parameters to use
ParameterGroupImpl.
2. Fixed all the test cases.
Issue-ID: POLICY-1890
Change-Id: I4a124c0acc650020977ac8e2cee143c72003973a
Signed-off-by: ramverma <ram.krishna.verma@est.tech>
|
|
Lifecycle API's for creating policies & policy types in policy/api
expects ToscaServiceTemplate as input instead of ToscaPolicy or
ToscaPolicyType. Hence, changing the return type of decoder to generate
& return ToscaServiceTemplate instead of ToscaPolicy.
Change-Id: I4fb92738e15ee7e2868741f7ca50cf09429d8cde
Issue-ID: POLICY-1888
Signed-off-by: ramverma <ram.krishna.verma@est.tech>
|
|
1) Updated PolicyDecoderFileInCsarToPolicy to parse ToscaPolicy &
TocsaPolicyType from the given csar.
2) Change the parameters
3) Tests cases updated/added.
Change-Id: Ic8d652ae8043d5d332f663a6862eb08e282591cf
Issue-ID: POLICY-1889
Signed-off-by: ramverma <ram.krishna.verma@est.tech>
|
|
1) Changed policy distribution framework to use entities from
policy/models
2) Changed all the test cases.
3) Commented few test cases which will be fixed along with code fixes.
4) Will be removing the old policy entities once all the pieces are
ready.
Change-Id: I1fd7b975b2e072c0b24e429903c9ca4796173929
Issue-ID: POLICY-1888
Signed-off-by: ramverma <ram.krishna.verma@est.tech>
|
|
Sonar fix broke some of the junit tests for parameters; fixed
those.
Also fixed some checkstyle errors (e.g., unused imports).
Change-Id: I76c57792b82b9c2ddd27bdbc35910e9b11d86ea5
Issue-ID: POLICY-1791
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
update pom.xml to use v1.5.1 for sdc-tosca parse
update Extract file since the DM's change
update the csar file based on new DM
update Test file to reflect the new CSAR file
Change-Id: I90da979ff1cedbdedadacc46386aa5ea0e7b6711
Issue-ID: POLICY-1720
Signed-off-by: liboNet <libo.zhu@intel.com>
|
|
Fixed the sonar issues: S134, S3725, S2129.
Issue-ID: POLICY-1638
Change-Id: I1a91b8e5e071a770faf8182e8ac1ada04b63599e
Signed-off-by: Lianhao Lu <lianhao.lu@intel.com>
|
|
Change-Id: Ic9ad2d733ace26fdd085a03af901783192d72a79
Issue-ID: POLICY-1638
Signed-off-by: Lianhao Lu <lianhao.lu@intel.com>
|
|
In the FileSystemReception plugin, we need to shutdown the thread pool
to release the resources gracefully.
Change-Id: I800e4070d7bf8c052d964139117a68dc48c50f76
Issue-ID: POLICY-1631
Signed-off-by: Lianhao Lu <lianhao.lu@intel.com>
|
|
By adding multi-thread support in FileSystemReceptionHander, we can have
a more thorough s3p test to test performance & stablity in multithread
situations.
Change-Id: Id263435531e26dcbadfbda6f82b26ac54a72ba1a
Issue-ID: POLICY-1274
Signed-off-by: Lianhao Lu <lianhao.lu@intel.com>
|
|
1) Changed logging from FlexLogger to SLF4J with logback
2) Fixed test cases of distribution REST endpoints having
infinite while loop
Change-Id: I1551873b3d348f9a7d2b4f8dfc3ae5dd6462bdb8
Issue-ID: POLICY-1346
Signed-off-by: ramverma <ram.krishna.verma@est.tech>
|
|
1) Creating a new thread for watching directory path for new file.
2) Updating distribution statistics from FileSystemReceptionHandler.
Change-Id: Ic539f2cad015f0756407fe910f309a2ea661a764
Issue-ID: POLICY-1437
Signed-off-by: ramverma <ram.krishna.verma@est.tech>
|
|
Some fixes for minor checkstyle issues.
Issue-ID: POLICY-1221
Change-Id: I86577f47283a6fa97be25d7550ed9c2d7ec026a9
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
. change the capital and lower-case letter
. add missing fields in ConfigBody policyName and templateVersion
that are requried by OOF
. add '=' into default operator once no such info in the input CSAR
. based on the vCPE service, which includes several CPs, some may do
NOT connect any VDU. so need deal with such case.
. add new test case to cover complicated service includes 5 policies
. change the resource's type from String to List as requried by OOF
which needs such format to deal with all kind of policies beides hpa
. improve the code style
Change-Id: Id39b1a0511c362c5ae9dce409af18b032832de80
Issue-ID: POLICY-1282
Signed-off-by: liboNet <libo.zhu@intel.com>
|
|
Removed the unused variable. We are reasonably
sure that the cast is ok.
Fixed the JUnit tests, removed useless imports,
unused variables and raw types.
Issue-ID: POLICY-1256
Change-Id: Iad7dbbf02a4dd48648fc9d5c20595c9f0f8d7acb
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Fixed 6 code smell issues reported by sonar.
Change-Id: I537df24f0f0624470efd8675f01ecd433aed1cb0
Issue-ID: POLICY-1256
Signed-off-by: Lianhao Lu <lianhao.lu@intel.com>
|
|
|
|
virtual_binding will bind CP to a VDU but virtual_link
use the node name instead of the name of node's propertiy
add new test case to cover s3p
the picvendorId's path has been changed based on demo repo
Change-Id: I0ca400eab4d16284f14cb568fe3da5b409dd9222
Issue-ID: POLICY-1254
Signed-off-by: liboNet <libo.zhu@intel.com>
|
|
Make FileSystemReceptionHandler tolerant of exceptions thrown when
parsing tosca template and be able to handle new incoming csar.
Also added the unit test for FileSystemReceptionHandler.
Change-Id: I0f1647f6f952576a8e61adca4d027990706d1411
Issue-ID: POLICY-837
Signed-off-by: Lianhao Lu <lianhao.lu@intel.com>
|
|
The main pom.xml was incorrect, so these issues have
creeped into the source code.
Issue-ID: POLICY-1256
Change-Id: Ic0b52f3a28f869252120991b0c1946ef8402bcc5
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
For S3P test, we need to add a new FileSystemRecpetionHandler plugin
which monitors a local directory for newly come csar files.
This patch added the plugin code as well as the configuration file for
s3p to use.
Change-Id: I8f1e65489abde15ae32c54d819bbc6e7cbdf36d0
Issue-ID: POLICY-837
Signed-off-by: Lianhao Lu <lianhao.lu@intel.com>
|
|
To align with OOF/Policy/SO, need add below:
. resource should be set as name field of SDC resource.
. identity should be set as a concatenation of PolicyType + "_" + Resource
. value of flavorDirective's type, expected from OOF, is "flavor_directives"
. policyScope should add the name of service from SDC to align with that from SO.
. Update the Testcase
Change-Id: I57f461ef51e0f50e6096c9c9ba84c5832cb13656
Issue-ID: POLICY-1227
Signed-off-by: liboNet <libo.zhu@intel.com>
|
|
add HPA into PolicyScope to fix the NullPointerException
Change-Id: I160e630d982257c57e1f950906c231c895872c71
Issue-ID: POLICY-1200
Signed-off-by: liboNet <libo.zhu@intel.com>
|
|
the schema format of HPA requirement has been modified
so that the parse needs update too based on the wiki:
https://wiki.onap.org/display/DW/Specifying+HPA+
Capability+Requirements+using+TOSCA-based+VNF+Descriptors
Change-Id: I48b39797e70d686ed0b9b2e7001b9a00068e76fd
Issue-ID: POLICY-1160
Signed-off-by: liboNet <libo.zhu@intel.com>
|
|
SdcToscaParserFactory is looking file file type of .yaml .yml .zip or .csar
As no suffix was provided, .tmp was being appended, hence the process was
failing to parse the csar file.
Change-Id: Ia87bb1e2402f94e44f6cbf3e28beb2adea52db4d
Issue-ID: POLICY-1146
Signed-off-by: Alexis de Talhouët <adetalhouet89@gmail.com>
|
|
* SdcReceptionHandler in distribution tries to initialize & start the
SDC Client when distribution framework comes up. If by any chance the
SDC service is not up then currently the SdcReceptionHandler throws an
exception to the distribution activator and the distribution framework
goes down. And the health check fails.
* This review fixes it by adding a retry mechanism in
SdcReceptionHandler for all lifecycle methods of SdcClient (init, start,
stop). After failure the same operation is retried again with some
delay. The delay is passed as parameter from configuration json file.
The minimum default value for the delay is kept as 30 seconds.
* Adding SdcClientHandler timer task for performing the retries
asynchronously.
Change-Id: Ibb6d936fcf4872c82f87e2cd04a00583b81c92ff
Issue-ID: POLICY-1035
Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
|
|
* As per jacoco, the try-with-resources coverage issue is fixed in 0.8.0
release - https://www.jacoco.org/jacoco/trunk/doc/changes.html
* Adding openpojo test for all the models in distribution-model
* Removed jacoco version from distribution pom as oparent 1.2.1 already
comes with jacoco 0.8.2
Change-Id: I55e2891a0dad1f10113730b46f10d760a883bea6
Issue-ID: POLICY-922
Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
|
|
Change-Id: I6bcb6f6af1020ceb22dd92d6633717d2a183d5b8
Issue-ID: POLICY-1035
Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
|
|
Change-Id: I42e568cab649da74e2a179fe487c32feec9c88fa
Issue-ID: POLICY-1035
Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
|