aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2018-09-24AIOOBE when ApexPdpPolicyForwarder#forwardAlexis de Talhouët1-2/+5
Change-Id: Iebc19d2e734ead405ac398a1011dcd42990b20b8 Issue-ID: POLICY-1147 Signed-off-by: Alexis de Talhouët <adetalhouet89@gmail.com>
2018-09-21Adding retry logic for SDC Client in Distributionramverma7-80/+187
* SdcReceptionHandler in distribution tries to initialize & start the SDC Client when distribution framework comes up. If by any chance the SDC service is not up then currently the SdcReceptionHandler throws an exception to the distribution activator and the distribution framework goes down. And the health check fails. * This review fixes it by adding a retry mechanism in SdcReceptionHandler for all lifecycle methods of SdcClient (init, start, stop). After failure the same operation is retried again with some delay. The delay is passed as parameter from configuration json file. The minimum default value for the delay is kept as 30 seconds. * Adding SdcClientHandler timer task for performing the retries asynchronously. Change-Id: Ibb6d936fcf4872c82f87e2cd04a00583b81c92ff Issue-ID: POLICY-1035 Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
2018-09-19Merge "Fix sonar & add test cases for models"Liam Fallon4-2/+50
2018-09-19Fix sonar & add test cases for modelsramverma4-2/+50
* As per jacoco, the try-with-resources coverage issue is fixed in 0.8.0 release - https://www.jacoco.org/jacoco/trunk/doc/changes.html * Adding openpojo test for all the models in distribution-model * Removed jacoco version from distribution pom as oparent 1.2.1 already comes with jacoco 0.8.2 Change-Id: I55e2891a0dad1f10113730b46f10d760a883bea6 Issue-ID: POLICY-922 Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
2018-09-18Enable passing config file to start scriptmmis1-1/+7
Issue-ID: POLICY-923 Change-Id: I8803b5a94e33d0175a84665dd3b253c7220451ea Signed-off-by: mmis <michael.morris@ericsson.com>
2018-09-17Fix sonar bug in distributionramverma1-30/+9
Change-Id: I6bcb6f6af1020ceb22dd92d6633717d2a183d5b8 Issue-ID: POLICY-1035 Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
2018-09-15Fix sonar bugs in distributionramverma5-146/+240
Change-Id: I42e568cab649da74e2a179fe487c32feec9c88fa Issue-ID: POLICY-1035 Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
2018-09-14Merge "Enabling docker image push"Liam Fallon1-1/+1
2018-09-14Aligned decoder with forwarder for opt. policiesmmis16-254/+559
Changed decoder for optimization policies to generate instance of OptimizationPolicy (instead of PdpxPolicy) as expected by the forwarder. Without this change there is a mismatch between the decoder and the forwarder. Added parameters for configuring the static elements of the optimization policies and setting of these elements. Issue-ID: POLICY-927 Change-Id: Ib91a905dc89eed13622fb88e4dd19b3cb9f62c75 Signed-off-by: mmis <michael.morris@ericsson.com>
2018-09-14Merge "Adding more hpa feature support for Polices"Pamela Dragosh6-32/+282
2018-09-15Adding more hpa feature support for PolicesliboNet6-32/+282
* Add hugePage feature parse * Add SRIOV feature parse * Add pciePassthrough feature parse * Add more test cases and resources Change-Id: Ib45515a26e3fdac742a631b3a13d739fd1784d2f Issue-ID: POLICY-927 Signed-off-by: liboNet <libo.zhu@intel.com>
2018-09-14Enabling docker image pushmmis1-1/+1
Change-Id: I619b0f6e0ff9a31cfeafbd9c23dc93739e065d0c Issue-ID: POLICY-923 Signed-off-by: mmis <michael.morris@ericsson.com>
2018-09-14Fix sonar bugs in distributionramverma3-2/+10
Change-Id: I20c1246efc3ce0ad6d874e6a0b5c8230c96b9425 Issue-ID: POLICY-1035 Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
2018-09-14Merge "Adding statistics endpoint to distribution"Liam Fallon8-1/+600
2018-09-13Fix all sonar issues in distributionramverma10-250/+194
Change-Id: I93c77f929217c185c422fc8f16e9ac2fefe0fd42 Issue-ID: POLICY-1035 Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
2018-09-13Adding statistics endpoint to distributionramverma8-1/+600
* Adding statistics endpoint in DistributionRestController * Adding DistributionStatisticsManager to hold all stats. * Adding StatisticsReport class to represent distribution stats report. * Updating stats at each step in SdcReceptionHandler. * Adding test cases for all code changes. Change-Id: I0b0f97aecc64b18314367fdff6d3ca7bee06efc7 Issue-ID: POLICY-1035 Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
2018-09-13Adding policy decoder to extract file from csarramverma54-185/+1163
* Adding decoder configuration parameters infrastructure to support plugin based architecture. Adding a new policy decoder after this will be just creating a new decoder class and its corresponding parameter class. * Adding a new decoder which extracts policy file from given csar. It is written in a generic way to extract file for any pdp like apex, drools. * Adding configuration parameters for the new decoder. The policy file name and policy type is passed as parameter to the decoder. * Fixing few broken package declaration in pdpx decoder tests. * Adding test cases for all code changes. Change-Id: I95e68cebce0f9747ca63b090f9b9116ce8836939 Issue-ID: POLICY-1101 Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
2018-09-12Merge "Adding code for dynamically generate Polices"Liam Fallon19-3/+1282
2018-09-13Adding code for dynamically generate PolicesliboNet19-3/+1282
* Update sdc tosca version to 1.4.1 * Define the objects to represents the policy used by OOF/Mutlicloud/AAI etc * Integration into the distribution framework to update PdpxPolicy and add new File PolicyDecoderCsarPdpx to do decoder from CSAR * Add two Test case including 2 VNFs, each VNF maps to 1 policy, so to generate 2 polices * use @SerializedName make the variable name different with that in the out json field Change-Id: Icc7175082063db8a245bbe576085cdf5a4b51adc Issue-ID: POLICY-927 Signed-off-by: liboNet <libo.zhu@intel.com>
2018-09-12Adding policy forwarder for apex-pdpramverma7-0/+640
* Adding policy forwarder for apex-pdp * Adding ApexPdpPolicy to hold policies related to apex-pdp * Adding forwarder parameter for configuring apex-pdp forwarder * Adding test cases for all code changes. Change-Id: Ic1cb9bfc11b2b95321ea2d81882c588b025d33fb Issue-ID: POLICY-1101 Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
2018-09-12Removed thoughtworks web-stub dependencymmis1-5/+0
Dependency is unused and so can be removed Change-Id: Ib9036e90b1851210f39b627c20fb90c5c88e7e1a Issue-ID: POLICY-926 Signed-off-by: mmis <michael.morris@ericsson.com>
2018-09-11Fix all sonar issues in distributionramverma9-274/+719
* Fixing all sonar issues in distribution * Adding more test cases to improve code coverage Change-Id: I296f96b66046e25c3c462632091f40565ff75478 Issue-ID: POLICY-1035 Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
2018-09-10Merge "Adding code for sending distribution status to sdc"Pamela Dragosh8-20/+671
2018-09-09Fixing sonar bugs in distributionramverma4-135/+133
Change-Id: I3ec5c73c54145b1ba9f637eaa95c843e25f46a10 Issue-ID: POLICY-1035 Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
2018-09-09Adding code for sending distribution status to sdcramverma8-20/+671
* Adding implementation of IDistributionStatusMessage & IComponentDoneStatusMessage interfaces of SDC. * Adding builder for distribution status classes. * Adding code changes in SdcReceptionHandler to send download/deployment/component status to SDC at various stages of handling notification. * Adding test cases for all new code. Change-Id: I27c9ed373015d728f1ed02528e2ba2a638952bdf Issue-ID: POLICY-956 Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
2018-09-08Merge "Parameter Group fields must have getters"Pamela Dragosh8-90/+49
2018-09-07Parameter Group fields must have gettersliamfallon8-90/+49
Parameter handling is changed so that all fields must have a getter following normal naming conventions. This change brings that in. Issue-ID: POLICY-1095 Change-Id: Idc61960347a67c50f33fc272dcd00ceca7553d95 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-09-06Adding code for handling notifications from SDCramverma8-29/+426
Change-Id: I45f28cbce8defead5e1f43ed81fa5ea6a2b2208b Issue-ID: POLICY-974 Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
2018-09-06Fix oparent version referencePamela Dragosh1-1/+1
Ensuring we are always using the same oparent version that is declared in policy/parent. As part of the work we are doing for security and critical issues. Change-Id: Idc6fdd0f613f1fb2ae4bb3c758847884fa4758f6 Issue-ID: POLICY-1059 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-09-05Refactored reception handler parameter handlingmmis31-453/+619
Refactored parameter handling for configuration of reception handlers as the previous implementation does not align with the plugin architecture (.e. plugin specific parameters being handled in core code) Issue-ID: POLICY-1094 Change-Id: I31a9fc7f712ca43f0f69c42a6d99fa481b02cd4b Signed-off-by: mmis <michael.morris@ericsson.com>
2018-09-05Generate docker image for policy distributionmmis10-0/+847
Added generation of tarball of policy distribution jars and generation of docker image using the tarball Issue-ID: POLICY-923 Change-Id: I9e38143fee864b765fbfd567c7e52bc7b0be2c9a Signed-off-by: mmis <michael.morris@ericsson.com>
2018-09-04Merge "Adding code for managing life cycle of SDC Client"Pamela Dragosh12-43/+538
2018-09-04Merge "Set Activator alive to false in terminate"Pamela Dragosh2-1/+4
2018-09-04Adding code for managing life cycle of SDC Clientramverma12-43/+538
* Adding init/start/stop methods in SDCReceptionHandler for managing lifecycle of SDC Client. * Adding a handler status enum to hold all the possible status values. * Adding test cases to cover code changes fully. Change-Id: Ib6f370485ff330538bfada6030c592629ed3fd1c Issue-ID: POLICY-956 Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
2018-09-03Set Activator alive to false in terminatekrishnajinka2-1/+4
During terminate the alive status should be set to false instead of true Adding test case to cover the scenario Issue-ID: POLICY-1017 Change-Id: I5c1d13172902cc75da8d0819e6e107b4e8d1b246 Signed-off-by: krisjinka <kris.jinka@samsung.com> Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
2018-08-30Create code infrastructure for policy forwardingmmis43-98/+1939
Added sending of polices from the policy forwarder to the xacml PDP and added handling of parameters for configuring the policy forwarders Issue-ID: POLICY-926 Change-Id: I26effe70769f7edc765470a1a9ad40ed9faad82d Signed-off-by: mmis <michael.morris@ericsson.com>
2018-08-29Parameter Service Interface Changesliamfallon8-145/+163
Changes to distribution due to changes to parameter services, mainly addition of setName() to parameter service interface and correct handling of empty parameters Change-Id: I9523da6461874241d220f0feac61419ef6ebbb9d Issue-ID: POLICY-1035 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-08-28Removing plugin dependency from distribution mainramverma29-623/+363
* Removing plugin dependency from main. Ideally main should not be dependent on plugins. * Creating dummy handler, decoder, forwarder classes for test cases in main. * Combined few json test files. * Added more test cases. Change-Id: Id75e21d5d403febd9ac2b059661e17663d638dc2 Issue-ID: POLICY-1035 Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
2018-08-24Fix sonar and checkstyle issues in distributionramverma37-608/+733
* Fixing all check style issues. * Fixing all sonar issues. * Adding maven check style plugin to fail at warning level. Change-Id: I791b8feef39a3a0c3e1e250efea7b6e78208bf07 Issue-ID: POLICY-1035 Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
2018-08-22Merge "Adding health check endpoint to distribution"Pamela Dragosh33-56/+1016
2018-08-23Fix sonar code coverage issueliboNet1-69/+138
* Remove unused import * Fix more than 1 statements on one line * Divide validate into three parts to Fix >10 cyclomatic Complexity Change-Id: I9c89c4854de31fa02a9052055662f4b74d12fe10 Issue-ID: POLICY-956 Signed-off-by: liboNet <libo.zhu@intel.com>
2018-08-22Adding health check endpoint to distributionramverma33-56/+1016
* Adding health check REST endpoint to distribution service. * Adding isAlive field to DistributionActivator to fetch the health status. * Adding parameter group for rest server parameters. * Adding DistributionRestController for hosting all the rest endpoints in distribution service. * Adding DistributionRestServer to manage lifecycle of distribution rest server. * Adding ParameterValidationUtils utility class for common validations. Plan is to move this class to policy-common for wider use later. * Adding test cases for all new code added. * Refering common classes from policy/common Change-Id: I246d57133ed1f0c3548bcdee173d7b64fb368abc Issue-ID: POLICY-1035 Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
2018-08-22integrate PSSDConfiguration to distributionliboNet29-38/+875
* Integrate the PSSDConfiguration to distribution config parameter. * Moved related PSSDConfigurationParameterGroup classes from "handling" to "parameters" to avoid specified sdc dependency. * Modify all the test case since the distribution config parameter has been changed, update CommonTestData to wrap it. * Add neccessnary SDC handling exceptions which to be used for SDC handler integration. * update the PSSDCOnfiguraitonParameterGroup to add UUID to the setName function to generate unique name for each instance. * use builder to create PSSDConfigurationParametersGroup instead of using many parameters Change-Id: I3c78bc2a51ebc84761bc9458096d6ffa18070b47 Issue-ID: POLICY-956 Signed-off-by: liboNet <libo.zhu@intel.com>
2018-08-16Adding termination code changes for distributionramverma18-153/+345
* Code changes for terminating the handlers started by distribution activator. * More test cases to increase coverage. * Fixes for checkstyle issues. * Fixes for sonar issues. Change-Id: I3299317c83fa643ac1d0ba1105ac1a932c0a83f6 Issue-ID: POLICY-1035 Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
2018-08-15Fix sonar code coverage issue in distributionramverma1-5/+88
The jacoco plugin settings in oparent is for creating coverage report for each sub-module sepeartely. That leads to coverage missing in the report if the test cases & actual classes are in different sub-module. Overiding the setting in distribution to create a consolidated report of all sub-modules in one report. Change-Id: Idf4acd07dbb3694d7bff3c1d94a31a322d7027c5 Issue-ID: POLICY-1035 Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
2018-08-15Adding code for bootstrapping policy distributionramverma24-226/+511
* Code changes for initializing handlers & related plugins from configuration parameter JSON file. * Using common parameter service for refering parameters at multiple places. * Moved related parameters classes from "main" to "reception" to avoid maven cyclic dependency errors. * Added test cases for new code chnages. The test coverage is around 95%. * Changed logging from slf4j to common-logging. Change-Id: Ifb77cfaa6e6472d43295a7c41a49ddd657c0e2c2 Issue-ID: POLICY-1035 Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
2018-08-13Merge "Initial moduel structure for SDC handling"Pamela Dragosh6-0/+478
2018-08-14Initial moduel structure for SDC handlingliboNet6-0/+478
This submission defines the initial module structure for this handling and add the IConfiguration implementation and test code, use the json format as the configuration. rename the class name to sensible one with PSSD prefix. remove static variable to make it possible for more than one subscription to SDC. improve the validate func to validate each mandatory parameters and check the int parameter's value Change-Id: I3106ad9d4535b1251eae064e803805b92378f6f1 Issue-ID: POLICY-956 Signed-off-by: liboNet <libo.zhu@intel.com>
2018-08-09Adding configuration parameters for distributionramverma30-188/+1854
* Adding main configuration parameters to distribution component. The intention is to define a top level parameter group that should be capable of handling all the parameters needed for the framework. * Added validation to check the actuall class by loading it from classpath. * Added Test Cases for configuration parameter. The coverage of the package is 95.3 %. Change-Id: I87c4c34d9df2c9b5a0ab75bef2bbe0d25e38747b Issue-ID: POLICY-1035 Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
2018-08-02Create interfaces for Policy Distributionmmis25-0/+1096
Created interfaces and some skeletal implementations. Implememtations to be further developed in subsequent stories Change-Id: If55be78e34c8783451cb9aa755a563bc0850e569 Issue-ID: POLICY-1029 Signed-off-by: mmis <michael.morris@ericsson.com>