Remove unused imports and clean logs

Unused imports and marked an unused variable.
Added m2e eclipse settings (other repos have this).
Added some test logback.xml to clear out jetty debug
messages.
Replaced deprecated newInstance with getDeclaredConstructor.
newInstance
Either log or throw Exception - chose throw
Added some assertions to JUnit test.

Issue-ID: POLICY-2305
Change-Id: Ia4e9ce62dc7fb45aea247d470ca7245e694fc26e
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

1 files changed, 14 insertions, 10 deletions

diff --git a/plugins/forwarding-plugins/src/test/java/org/onap/policy/distribution/forwarding/lifecycle/api/LifecycleApiPolicyForwarderTest.java b/plugins/forwarding-plugins/src/test/java/org/onap/policy/distribution/forwarding/lifecycle/api/LifecycleApiPolicyForwarderTest.java
index 7d84657a..5fce708e 100644
--- a/plugins/forwarding-plugins/src/test/java/org/onap/policy/distribution/forwarding/lifecycle/api/LifecycleApiPolicyForwarderTest.java
+++ b/plugins/forwarding-plugins/src/test/java/org/onap/policy/distribution/forwarding/lifecycle/api/LifecycleApiPolicyForwarderTest.java
@@ -1,6 +1,7 @@
 /*-
  * ============LICENSE_START=======================================================
  *  Copyright (C) 2019 Nordix Foundation.
+ *  Modifications Copyright (C) 2020 AT&T Inc.
  * ================================================================================
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -20,6 +21,7 @@
 
 package org.onap.policy.distribution.forwarding.lifecycle.api;
 
+import static org.assertj.core.api.Assertions.assertThatCode;
 import static org.assertj.core.api.Assertions.assertThatThrownBy;
 
 import java.util.ArrayList;
@@ -83,20 +85,22 @@ public class LifecycleApiPolicyForwarderTest {
 
     @Test
     public void testForwardPolicyUsingSimulator() throws Exception {
+        assertThatCode(() -> {
+            final ToscaServiceTemplate toscaServiceTemplate1 =
+                    standardCoder.decode(ResourceUtils.getResourceAsString(POLICY_TYPE), ToscaServiceTemplate.class);
+            final ToscaServiceTemplate toscaServiceTemplate2 =
+                    standardCoder.decode(ResourceUtils.getResourceAsString(POLICY), ToscaServiceTemplate.class);
 
-        final ToscaServiceTemplate toscaServiceTemplate1 =
-                standardCoder.decode(ResourceUtils.getResourceAsString(POLICY_TYPE), ToscaServiceTemplate.class);
-        final ToscaServiceTemplate toscaServiceTemplate2 =
-                standardCoder.decode(ResourceUtils.getResourceAsString(POLICY), ToscaServiceTemplate.class);
+            final LifecycleApiPolicyForwarder forwarder = new LifecycleApiPolicyForwarder();
+            forwarder.configure(LifecycleApiForwarderParameters.class.getSimpleName());
 
-        final LifecycleApiPolicyForwarder forwarder = new LifecycleApiPolicyForwarder();
-        forwarder.configure(LifecycleApiForwarderParameters.class.getSimpleName());
+            final Collection<ToscaEntity> policies = new ArrayList<>();
+            policies.add(toscaServiceTemplate1);
+            policies.add(toscaServiceTemplate2);
 
-        final Collection<ToscaEntity> policies = new ArrayList<>();
-        policies.add(toscaServiceTemplate1);
-        policies.add(toscaServiceTemplate2);
+            forwarder.forward(policies);
 
-        forwarder.forward(policies);
+        }).doesNotThrowAnyException();
     }
 
     @Test