aboutsummaryrefslogtreecommitdiffstats
path: root/main
diff options
context:
space:
mode:
authoradheli.tavares <adheli.tavares@est.tech>2021-03-03 15:27:56 +0000
committeradheli.tavares <adheli.tavares@est.tech>2021-03-04 12:57:15 +0000
commita2740a32f308b7385a44161ec40e25d72e4ef5e0 (patch)
tree1ef6f292fde0d1b589c3f567a4b3af67e9179be2 /main
parentaa756878665d4e4530babd191c44b1f6cd76b2ad (diff)
Code coverage for Policy distribution
Added code coverage for some missing instructions on main package Issue-ID: POLICY-3090 Change-Id: I1ba870a4b3c7f63f6c00dfc3f4b908eee7ca701b Signed-off-by: adheli.tavares <adheli.tavares@est.tech>
Diffstat (limited to 'main')
-rw-r--r--main/src/test/java/org/onap/policy/distribution/main/parameters/TestDistributionParameterGroup.java25
-rw-r--r--main/src/test/java/org/onap/policy/distribution/main/startstop/TestDistributionCommandLineArguments.java71
2 files changed, 95 insertions, 1 deletions
diff --git a/main/src/test/java/org/onap/policy/distribution/main/parameters/TestDistributionParameterGroup.java b/main/src/test/java/org/onap/policy/distribution/main/parameters/TestDistributionParameterGroup.java
index 6e2f5377..fb5dfbd4 100644
--- a/main/src/test/java/org/onap/policy/distribution/main/parameters/TestDistributionParameterGroup.java
+++ b/main/src/test/java/org/onap/policy/distribution/main/parameters/TestDistributionParameterGroup.java
@@ -2,7 +2,7 @@
* ============LICENSE_START=======================================================
* Copyright (C) 2018 Ericsson. All rights reserved.
* Modifications Copyright (C) 2019-2020 AT&T Intellectual Property. All rights reserved.
- * Modifications Copyright (C) 2020 Nordix Foundation
+ * Modifications Copyright (C) 2020-2021 Nordix Foundation.
* ================================================================================
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -22,6 +22,7 @@
package org.onap.policy.distribution.main.parameters;
+import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.assertThatThrownBy;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFalse;
@@ -227,4 +228,26 @@ public class TestDistributionParameterGroup {
.contains("\"org.onap.policy.common.endpoints.parameters.RestServerParameters\" INVALID, "
+ "parameter group has status INVALID"));
}
+
+ @Test
+ public void testDistributionParameterGroup_NullRestServerParameters() {
+ final RestServerParameters restServerParameters = null;
+ final Map<String, ReceptionHandlerParameters> receptionHandlerParameters =
+ commonTestData.getReceptionHandlerParameters(false);
+ final Map<String, ReceptionHandlerConfigurationParameterGroup> receptionHandlerConfigurations =
+ commonTestData.getReceptionHandlerConfigurationParameters(false);
+ final Map<String, PolicyForwarderConfigurationParameterGroup> forwarderConfigurations =
+ commonTestData.getPolicyForwarderConfigurationParameters(false);
+ final Map<String, PolicyDecoderConfigurationParameterGroup> decoderConfigurations =
+ commonTestData.getPolicyDecoderConfigurationParameters(false);
+
+ final DistributionParameterGroup distributionParameters = new DistributionParameterGroup(
+ CommonTestData.DISTRIBUTION_GROUP_NAME, restServerParameters, receptionHandlerParameters,
+ receptionHandlerConfigurations, forwarderConfigurations, decoderConfigurations);
+ final GroupValidationResult validationResult = distributionParameters.validate();
+ assertFalse(validationResult.isValid());
+ assertThat(validationResult.getResult())
+ .contains("parameter group \"UNDEFINED\" INVALID, "
+ + "must have restServerParameters to configure distribution rest server");
+ }
}
diff --git a/main/src/test/java/org/onap/policy/distribution/main/startstop/TestDistributionCommandLineArguments.java b/main/src/test/java/org/onap/policy/distribution/main/startstop/TestDistributionCommandLineArguments.java
new file mode 100644
index 00000000..7e72b852
--- /dev/null
+++ b/main/src/test/java/org/onap/policy/distribution/main/startstop/TestDistributionCommandLineArguments.java
@@ -0,0 +1,71 @@
+/*-
+ * ============LICENSE_START=======================================================
+ * Copyright (C) 2021 Nordix Foundation.
+ * ================================================================================
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ * SPDX-License-Identifier: Apache-2.0
+ * ============LICENSE_END=========================================================
+ */
+
+package org.onap.policy.distribution.main.startstop;
+
+import static org.assertj.core.api.Assertions.assertThatThrownBy;
+import static org.junit.Assert.assertThrows;
+
+import org.junit.Test;
+import org.onap.policy.distribution.main.PolicyDistributionException;
+import org.onap.policy.distribution.main.PolicyDistributionRuntimeException;
+
+/**
+ * Class to perform unit test of DistributionCommandLineArguments.
+ *
+ * @author Adheli Tavares (adheli.tavares@est.tech)
+ *
+ */
+public class TestDistributionCommandLineArguments {
+
+ @Test
+ public void testDistributionCommandLineArgumentsException() {
+ String[] wrongParams = {"arg1", "nothing", "{\"someJson\":1}"};
+ assertThrows(PolicyDistributionRuntimeException.class, () -> new DistributionCommandLineArguments(wrongParams));
+ }
+
+ @Test
+ public void testValidateFileNameEmpty() {
+ String[] argsOnlyKeyNoValue = {"-c", ""};
+ assertValidate(argsOnlyKeyNoValue, "policy distribution configuration file was not specified as an argument");
+ }
+
+ @Test
+ public void testValidateFileNameDoesNotExist() {
+ String[] fileNameNotExistentArgs = {"-c", "someFileName.json"};
+ assertValidate(fileNameNotExistentArgs,
+ "policy distribution configuration file \"someFileName.json\" does not exist");
+ }
+
+ @Test
+ public void testValidateFileNameIsNotFile() {
+ String[] folderAsFileNameArgs = {"-c", "src/test/resources/parameters"};
+ assertValidate(folderAsFileNameArgs,
+ "policy distribution configuration file \"src/test/resources/parameters\" is not a normal file");
+ }
+
+ protected void assertValidate(String[] testArgs, String expectedErrorMsg) {
+ DistributionCommandLineArguments sutArgs = new DistributionCommandLineArguments(testArgs);
+
+ assertThatThrownBy(() -> sutArgs.validate())
+ .isInstanceOf(PolicyDistributionException.class)
+ .hasMessage(expectedErrorMsg);
+ }
+}