aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
Diffstat
-rw-r--r--src/main/java/org/onap/clamp/loop/CsarInstaller.java7
-rw-r--r--src/main/java/org/onap/clamp/loop/LoopService.java6
-rw-r--r--src/main/java/org/onap/clamp/loop/deploy/DcaeDeployParameters.java (renamed from src/main/java/org/onap/clamp/loop/deploy/DeployParameters.java)59
-rw-r--r--src/main/java/org/onap/clamp/policy/operational/OperationalPolicy.java8
-rw-r--r--src/test/java/org/onap/clamp/clds/model/dcae/DcaeInventoryResponseCacheTest.java3
-rw-r--r--src/test/java/org/onap/clamp/loop/deploy/BlueprintInputParametersTest.java (renamed from src/test/java/org/onap/clamp/loop/deploy/DeployParametersTest.java)5
6 files changed, 48 insertions, 40 deletions
diff --git a/src/main/java/org/onap/clamp/loop/CsarInstaller.java b/src/main/java/org/onap/clamp/loop/CsarInstaller.java
index 371f88e8b..16351b820 100644
--- a/src/main/java/org/onap/clamp/loop/CsarInstaller.java
+++ b/src/main/java/org/onap/clamp/loop/CsarInstaller.java
@@ -31,7 +31,6 @@ import java.io.IOException;
import java.util.Arrays;
import java.util.HashSet;
import java.util.List;
-import java.util.Map;
import java.util.Map.Entry;
import org.json.simple.parser.ParseException;
@@ -45,7 +44,7 @@ import org.onap.clamp.clds.sdc.controller.installer.CsarHandler;
import org.onap.clamp.clds.sdc.controller.installer.MicroService;
import org.onap.clamp.clds.util.JsonUtils;
import org.onap.clamp.clds.util.drawing.SvgFacade;
-import org.onap.clamp.loop.deploy.DeployParameters;
+import org.onap.clamp.loop.deploy.DcaeDeployParameters;
import org.onap.clamp.loop.service.Service;
import org.onap.clamp.loop.service.ServiceRepository;
import org.onap.clamp.policy.Policy;
@@ -98,7 +97,7 @@ public class CsarInstaller {
@Autowired
private SvgFacade svgFacade;
- /**
+ /**
* Verify whether Csar is deployed.
*
* @param csar The Csar Handler
@@ -241,7 +240,7 @@ public class CsarInstaller {
}
private JsonObject createGlobalPropertiesJson(BlueprintArtifact blueprintArtifact, Loop newLoop) {
- return new DeployParameters(blueprintArtifact, newLoop).getDeploymentParametersinJson();
+ return DcaeDeployParameters.getDcaeDeploymentParametersInJson(blueprintArtifact, newLoop);
}
private static JsonObject createVfModuleProperties(CsarHandler csar) {
diff --git a/src/main/java/org/onap/clamp/loop/LoopService.java b/src/main/java/org/onap/clamp/loop/LoopService.java
index 303ae683a..b18c38490 100644
--- a/src/main/java/org/onap/clamp/loop/LoopService.java
+++ b/src/main/java/org/onap/clamp/loop/LoopService.java
@@ -112,6 +112,12 @@ public class LoopService {
.orElseThrow(() -> new EntityNotFoundException("Couldn't find closed loop named: " + loopName));
}
+ /**
+ * Api to refresh the Operational Policy UI window.
+ *
+ * @param loopName The loop Name
+ * @return The refreshed loop object
+ */
public Loop refreshOpPolicyJsonRepresentation(String loopName) {
Loop loop = findClosedLoopByName(loopName);
Set<OperationalPolicy> policyList = loop.getOperationalPolicies();
diff --git a/src/main/java/org/onap/clamp/loop/deploy/DeployParameters.java b/src/main/java/org/onap/clamp/loop/deploy/DcaeDeployParameters.java
index c994af7c0..1a75f71e6 100644
--- a/src/main/java/org/onap/clamp/loop/deploy/DeployParameters.java
+++ b/src/main/java/org/onap/clamp/loop/deploy/DcaeDeployParameters.java
@@ -35,33 +35,14 @@ import org.onap.clamp.loop.Loop;
import org.onap.clamp.policy.microservice.MicroServicePolicy;
import org.yaml.snakeyaml.Yaml;
-public class DeployParameters {
-
- private LinkedHashMap<String, JsonObject> deploymentParamMap = new LinkedHashMap<String, JsonObject>();
-
- /**
- * Constructor.
- *
- * @param blueprintArtifactList A list of blueprint artifacts
- * @param loop The loop object
- */
- public DeployParameters(LinkedHashSet<BlueprintArtifact> blueprintArtifactList, Loop loop) {
- this.init(blueprintArtifactList, loop);
- }
-
- /**
- * Constructor.
- *
- * @param blueprintArtifact One blueprint artifact
- * @param loop The loop object
- */
- public DeployParameters(BlueprintArtifact blueprintArtifact, Loop loop) {
- LinkedHashSet<BlueprintArtifact> blueprintArtifactList = new LinkedHashSet<BlueprintArtifact>();
- blueprintArtifactList.add(blueprintArtifact);
- this.init(blueprintArtifactList, loop);
- }
+/**
+ * To decode the bluprint input parameters.
+ */
+public class DcaeDeployParameters {
- private void init(LinkedHashSet<BlueprintArtifact> blueprintArtifactList, Loop loop) {
+ private static LinkedHashMap<String, JsonObject> init(LinkedHashSet<BlueprintArtifact> blueprintArtifactList,
+ Loop loop) {
+ LinkedHashMap<String, JsonObject> deploymentParamMap = new LinkedHashMap<String, JsonObject>();
String microServiceName = ((MicroServicePolicy) loop.getMicroServicePolicies().toArray()[0]).getName();
// Add index to the microservice name from the 2nd blueprint artifact for now.
// Update the microservice names, when able to link the microserivce <-> blueprint in the future
@@ -69,15 +50,18 @@ public class DeployParameters {
for (BlueprintArtifact blueprintArtifact: blueprintArtifactList) {
if (index > 0) {
deploymentParamMap.put(microServiceName + index,
- generateDeployParameter(blueprintArtifact, microServiceName));
+ generateDcaeDeployParameter(blueprintArtifact, microServiceName));
} else {
- deploymentParamMap.put(microServiceName, generateDeployParameter(blueprintArtifact, microServiceName));
+ deploymentParamMap.put(microServiceName,
+ generateDcaeDeployParameter(blueprintArtifact, microServiceName));
}
index++;
}
+ return deploymentParamMap;
}
- private JsonObject generateDeployParameter(BlueprintArtifact blueprintArtifact, String microServiceName) {
+ private static JsonObject generateDcaeDeployParameter(BlueprintArtifact blueprintArtifact,
+ String microServiceName) {
JsonObject deployJsonBody = new JsonObject();
Yaml yaml = new Yaml();
Map<String, Object> inputsNodes = ((Map<String, Object>) ((Map<String, Object>) yaml
@@ -95,7 +79,7 @@ public class DeployParameters {
return deployJsonBody;
}
- private void addPropertyToNode(JsonObject node, String key, Object value) {
+ private static void addPropertyToNode(JsonObject node, String key, Object value) {
if (value instanceof String) {
node.addProperty(key, (String) value);
} else if (value instanceof Number) {
@@ -114,7 +98,10 @@ public class DeployParameters {
*
* @return The deploymentParameters in Json
*/
- public JsonObject getDeploymentParametersinJson() {
+ public static JsonObject getDcaeDeploymentParametersInJson(LinkedHashSet<BlueprintArtifact> blueprintArtifactList,
+ Loop loop) {
+ LinkedHashMap<String, JsonObject> deploymentParamMap = init(blueprintArtifactList, loop);
+
JsonObject globalProperties = new JsonObject();
JsonObject deployParamJson = new JsonObject();
for (Map.Entry<String, JsonObject> mapElement: deploymentParamMap.entrySet()) {
@@ -124,4 +111,14 @@ public class DeployParameters {
return globalProperties;
}
+ /**
+ * Convert the object in Json.
+ *
+ * @return The deploymentParameters in Json
+ */
+ public static JsonObject getDcaeDeploymentParametersInJson(BlueprintArtifact blueprintArtifact, Loop loop) {
+ LinkedHashSet<BlueprintArtifact> blueprintArtifactList = new LinkedHashSet<BlueprintArtifact>();
+ blueprintArtifactList.add(blueprintArtifact);
+ return getDcaeDeploymentParametersInJson(blueprintArtifactList, loop);
+ }
}
diff --git a/src/main/java/org/onap/clamp/policy/operational/OperationalPolicy.java b/src/main/java/org/onap/clamp/policy/operational/OperationalPolicy.java
index 486210ea9..df7e27bf3 100644
--- a/src/main/java/org/onap/clamp/policy/operational/OperationalPolicy.java
+++ b/src/main/java/org/onap/clamp/policy/operational/OperationalPolicy.java
@@ -139,7 +139,7 @@ public class OperationalPolicy implements Serializable, Policy {
@Override
public JsonObject getJsonRepresentation() {
- return jsonRepresentation;
+ return jsonRepresentation;
}
void setJsonRepresentation(JsonObject jsonRepresentation) {
@@ -247,7 +247,11 @@ public class OperationalPolicy implements Serializable, Policy {
return result;
}
- public void updateJsonRepresentation () {
+ /**
+ * Regenerate the Operational Policy Json Representation.
+ *
+ */
+ public void updateJsonRepresentation() {
try {
this.jsonRepresentation = OperationalPolicyRepresentationBuilder
.generateOperationalPolicySchema(loop.getModelService());
diff --git a/src/test/java/org/onap/clamp/clds/model/dcae/DcaeInventoryResponseCacheTest.java b/src/test/java/org/onap/clamp/clds/model/dcae/DcaeInventoryResponseCacheTest.java
index 70d1b4ac2..26cc831ec 100644
--- a/src/test/java/org/onap/clamp/clds/model/dcae/DcaeInventoryResponseCacheTest.java
+++ b/src/test/java/org/onap/clamp/clds/model/dcae/DcaeInventoryResponseCacheTest.java
@@ -32,6 +32,9 @@ public class DcaeInventoryResponseCacheTest {
public static DcaeInventoryCache inventoryCache = new DcaeInventoryCache();
+ /**
+ * Initialize the responses.
+ */
@BeforeClass
public static void createExample() {
DcaeInventoryResponse response1 = new DcaeInventoryResponse();
diff --git a/src/test/java/org/onap/clamp/loop/deploy/DeployParametersTest.java b/src/test/java/org/onap/clamp/loop/deploy/BlueprintInputParametersTest.java
index 8834ef667..75ca25cff 100644
--- a/src/test/java/org/onap/clamp/loop/deploy/DeployParametersTest.java
+++ b/src/test/java/org/onap/clamp/loop/deploy/BlueprintInputParametersTest.java
@@ -41,7 +41,7 @@ import org.onap.clamp.loop.Loop;
import org.onap.clamp.policy.microservice.MicroServicePolicy;
import org.onap.sdc.tosca.parser.exceptions.SdcToscaParserException;
-public class DeployParametersTest {
+public class BlueprintInputParametersTest {
private BlueprintArtifact buildFakeBuildprintArtifact(String blueprintFilePath) throws IOException {
BlueprintArtifact blueprintArtifact = Mockito.mock(BlueprintArtifact.class);
@@ -77,8 +77,7 @@ public class DeployParametersTest {
umServiceSet.add(umService);
Mockito.when(loop.getMicroServicePolicies()).thenReturn(umServiceSet);
- DeployParameters deployParams = new DeployParameters(buildFakeCsarHandler(), loop);
- JsonObject paramJson = deployParams.getDeploymentParametersinJson();
+ JsonObject paramJson = DcaeDeployParameters.getDcaeDeploymentParametersInJson(buildFakeCsarHandler(), loop);
Assert.assertEquals(JsonUtils.GSON_JPA_MODEL.toJson(paramJson),
ResourceFileUtil.getResourceAsString("example/sdc/expected-result/deployment-parameters.json"));