diff options
author | 2021-04-28 11:12:45 +0200 | |
---|---|---|
committer | 2021-05-05 13:05:48 +0000 | |
commit | 44fac5a66971a6013c429537ab2b509d1a1a8a91 (patch) | |
tree | f1e24b9eeb191ad5c4e5bdcc03f46b89b85eafd5 /ui-react/src/components/loop_viewer/svg | |
parent | 4423d367c47d818493fbad627a43ba68f87d15f2 (diff) |
Add Tests on UI
Add some test to UI and fix errors reported by JEST during Ui tests
Issue-ID: POLICY-3200
Signed-off-by: sebdet <sebastien.determe@intl.att.com>
Change-Id: I69e93ad1f1714fa60a0c7ea9b1f3fb691f089f8a
Signed-off-by: sebdet <sebastien.determe@intl.att.com>
Diffstat (limited to 'ui-react/src/components/loop_viewer/svg')
-rw-r--r-- | ui-react/src/components/loop_viewer/svg/SvgGenerator.js | 24 |
1 files changed, 12 insertions, 12 deletions
diff --git a/ui-react/src/components/loop_viewer/svg/SvgGenerator.js b/ui-react/src/components/loop_viewer/svg/SvgGenerator.js index f5f5047ba..6d3cd7a21 100644 --- a/ui-react/src/components/loop_viewer/svg/SvgGenerator.js +++ b/ui-react/src/components/loop_viewer/svg/SvgGenerator.js @@ -59,16 +59,16 @@ class SvgGenerator extends React.Component { } shouldComponentUpdate(nextProps, nextState) { - return this.state.loopCache !== nextState.loopCache; + return this.state.loopCache !== nextProps.loopCache; } - componentWillReceiveProps(newProps) { - if (this.state.loopCache !== newProps.loopCache) { - this.setState({ - loopCache: newProps.loopCache, - }); - } - } + componentDidUpdate(prevProps) { + if (prevProps.loopCache !== this.props.loopCache) { + this.setState({ + loopCache: this.props.loopCache, + }); + } + } handleSvgClick(event) { console.debug("svg click event received"); @@ -233,10 +233,10 @@ class SvgGenerator extends React.Component { return ( <DivStyled onClick={this.handleSvgClick} > - <svg height={svgHeight} width={svgWidth} viewBox="0,0,{svgWidth},{svgHeight}" preserveAspectRatio="none"> - <svg x="-50" y="25"> - {allTheElements} - </svg> + <svg key="main" height={svgHeight} width={svgWidth} viewBox="0,0,{svgWidth},{svgHeight}" preserveAspectRatio="none"> + <svg key="content" x="-50" y="25"> + {allTheElements} + </svg> </svg> </DivStyled> ); |