Fix eclipse warnings in clamp

Fixed some of these warnings, just in policy-clamp-runtime:
- equals() with wrong argument type in junit
- remove unneeded "SuppressWarning"
- unused fields
- deprecated classes/methods

Fixed some sonars, too:
- use isEqualByComparingTo()
- method complexity: used eclipse to auto-extract methods

Fixed checkstyle issues:
- indentation level

Did not address all deprecation issues (e.g., SSLSocketFactory).

Issue-ID: POLICY-3200
Change-Id: Ibd92e5326854002dc0ca2d7b3b777699cafb5e98
Signed-off-by: Jim Hahn <jrh3@att.com>

1 files changed, 4 insertions, 4 deletions

diff --git a/participant/participant-intermediary/src/main/java/org/onap/policy/clamp/controlloop/participant/intermediary/handler/IntermediaryActivator.java b/participant/participant-intermediary/src/main/java/org/onap/policy/clamp/controlloop/participant/intermediary/handler/IntermediaryActivator.java
index d544915dd..5458f7c34 100644
--- a/participant/participant-intermediary/src/main/java/org/onap/policy/clamp/controlloop/participant/intermediary/handler/IntermediaryActivator.java
+++ b/participant/participant-intermediary/src/main/java/org/onap/policy/clamp/controlloop/participant/intermediary/handler/IntermediaryActivator.java
@@ -74,8 +74,8 @@ public class IntermediaryActivator extends ServiceManagerContainer implements Cl
 
         // @formatter:off
         addAction("Topic endpoint management",
-                () -> TopicEndpointManager.getManager().start(),
-                () -> TopicEndpointManager.getManager().shutdown());
+            () -> TopicEndpointManager.getManager().start(),
+            () -> TopicEndpointManager.getManager().shutdown());
 
         publishers.forEach(publisher ->
             addAction("Publisher " + publisher.getClass().getSimpleName(),
@@ -84,8 +84,8 @@ public class IntermediaryActivator extends ServiceManagerContainer implements Cl
 
         listeners.forEach(listener ->
             addAction("Listener " + listener.getClass().getSimpleName(),
-                    () -> msgDispatcher.register(listener.getType(), listener.getScoListener()),
-                    () -> msgDispatcher.unregister(listener.getType())));
+                () -> msgDispatcher.register(listener.getType(), listener.getScoListener()),
+                () -> msgDispatcher.unregister(listener.getType())));
 
         addAction("Topic Message Dispatcher", this::registerMsgDispatcher, this::unregisterMsgDispatcher);
         // @formatter:on