Age | Commit message (Collapse) | Author | Files | Lines |
|
The following rules are implemented to validate the version provided
in the POST payloads of policies and policy types:
1) If version field is not specified in POST payload, "406 - Not Acceptable"
would be returned along with the message "mandantory version field is missing".
2) If the version is not in the DB, we simply insert it.
3) If the version is in the DB, "406 - Not Acceptable" is returned along with
the message saying "specified version x.x.x" is already existing and the latest
version is x.x.x. It can force the user to create a newer version than the latest one.
4) The same versioning validation is applied to legacy types of policies too
so that everything is consistent.
Issue-ID: POLICY-2316
Change-Id: I395df0196a9d3073fd1f09060f943aeeb554d277
Signed-off-by: Chenfei Gao <cgao@research.att.com>
|
|
Test initialization and shutown of h2 database and REST server only done
once at beginning of all API unit tests. Duplicate tests removed, all
test done to persistent database and other minor improvements.
We need to check coverage after this review, ti may have dropped by a
few percent. We should design new tests to bring the coverage back up
again.
Issue-ID: POLICY-2297
Change-Id: I7ccb9835e01e08c284fdc4602e3a00e946b5e902
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
The type names were updated and added 2 new types.
Issue-ID: POLICY-2066
Change-Id: Ibbd149dec1809a9a815a5f6b64a8e7855fcc2010
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
|
|
Preloading native policy type for apex-pdp so that policies can be
created and deployed using this policy type.
Removed few test cases not working on windows.
Issue-ID: POLICY-2279
Change-Id: I8e462118ee21e92fcb862ef94a6d15aec1b893c6
Signed-off-by: ramverma <ram.krishna.verma@est.tech>
|
|
|
|
Issue-ID: POLICY-1689 Consolidate Policy Health Check into PAP
Change-Id: Ie7f8edf1d1a083c6c696824f249544959f72694d
Signed-off-by: Hengye <yehui.wang@est.tech>
|
|
The change to sonar cloud resulted in new issues being uncovered.
Addressed two of the three issues with this:
Remove this unused import...
Add at least one assertion to this test case.
The item left outstanding is:
Make sure that command line arguments are used safely here.
Issue-ID: POLICY-2206
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: Ie5dc339640102a5b4471e5b719338358ec3e0209
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Issue-ID: POLICY-2212, POLICY-2213
Change-Id: I03be8132699b5af9ea60a06cb0e1332c05886ad9
Signed-off-by: Chenfei Gao <cgao@research.att.com>
|
|
Issue-ID: POLICY-2210
Change-Id: I84b512a783c1fdc0834cf79bdce4c48a7803b884
Signed-off-by: Chenfei Gao <cgao@research.att.com>
|
|
Unused import.
Issue-ID: POLICY-2206
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: I1d443997a676d3833e60330c9a58a9715844efa2
|
|
Added a new endpoint to create multiple policies in one call
Added corresponding provider method
Added corresponding junit tests
Issue-ID: POLICY-1991
Change-Id: I09202ededfd88cf9f1ac62ea036e98e3b5d78f98
Signed-off-by: Chenfei Gao <cgao@research.att.com>
|
|
Issue-ID: POLICY-2101
Change-Id: I0860ff11231b6a649f52355d8d9333eec7d78826
Signed-off-by: Chenfei Gao <cgao@research.att.com>
|
|
This review adapts policy-api for the change in the structure
of the toasca service template from a list of maps to a plain map.
DUplication of policy types and policies removed and policy-models
examples used instead.
Issue-ID: POLICY-2047
Change-Id: Ie1fdeef79289348005314c5de9b2e37c0c45d786
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Modified json based on input from Chenfei.
Change-Id: Ibd70c5737713fee5dcd2370e02ef5f567d2a73b3
Issue-ID: POLICY-1847
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Issue-ID: POLICY-1771
Signed-off-by: Bilal A <bilal@research.att.com>
Change-Id: If85abb8280e28da7391bb4b4cb502473a404065b
|
|
Issue-ID: POLICY-1810
Change-Id: I47046fbbd7d319b58cabf57ff470ec0d5246c88a
Signed-off-by: Chenfei Gao <cgao@research.att.com>
|
|
Issue-ID: POLICY-1771
Signed-off-by: Bilal A <bilal@research.att.com>
Change-Id: I8ee41b6df32a97cebdc4e07782e564698d10154b
|
|
1) Adds tests for testing LegacyGuardPolicyProvider and
LegacyOperationalPolicyProvider
2) Fixes issue in LegacyGuardPolicyProvider and
LegacyOperationalPolicyProvider to handle
policy version number properly while deleting policies.
Issue-ID: POLICY-1771
Signed-off-by: Bilal A <bilal@research.att.com>
Change-Id: I01d48b5352e7e6da403faf1e4997d3550024755f
|
|
Issue-ID: POLICY-1771
Signed-off-by: Bilal A <bilal@research.att.com>
Change-Id: I8882d9aa6e1e56e9425224b9fdfba01552b5e993
|
|
This also entailed removing the local copy of RestServerParameters.
Change-Id: Ie5c581ab70aee60844d1660fe0a61290de6470ec
Issue-ID: POLICY-1652
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Issue-ID: POLICY-1771
Signed-off-by: Bilal A <bilal@research.att.com>
Change-Id: I8ea0729ca029c15edcb7564fa35c8811976ca6a8
|
|
Fixed breakages due to changes made in policy/common to satisfy
sonar.
Also modified the code to allocate ports for junit tests, writing
them into the config files.
Change-Id: Id31d19e0691f7450c3e4158090dac6f3c3849631
Issue-ID: POLICY-1791
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Changing ToStringTester from utils to utils-test.
Correcting the policy/common & policy/models version.
Change-Id: I33a590367732ff315a9b03aca917e4be5f1ae05e
Issue-ID: POLICY-1746
Signed-off-by: ramverma <ram.krishna.verma@est.tech>
|
|
Issue-ID: POLICY-1807
Change-Id: I143f3228fd5e23365c95ee13f2e639f9862fc33e
Signed-off-by: Chenfei Gao <cgao@research.att.com>
|
|
|
|
|
|
Per javadocs, getName() should generally be used instead of
Class.getCanonicalName(). This change only applies to classes; it
does not apply to File objects.
Change-Id: Ia1726f178f906bfdfbd056c50598228cff8e1a2d
Issue-ID: POLICY-1646
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
to increase code coverage
Issue-ID: POLICY-1791
Change-Id: Ie0a5027ad61224c44b30127348c4a81454549fc9
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
|
|
to increase code coverage
Issue-ID: POLICY-1791
Change-Id: I9d6632d995b4dfd014b51467a66b95d042d6113c
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
|
|
Per Jim's comment, version integer check should come first before
checking delete elibibility (i.e. checking if policy is deployed
in PDP group or not).
Issue-ID: POLICY-1777
Change-Id: Ibd3d8d05a40ef34c558a2e9389596396a69469fe
Signed-off-by: Chenfei Gao <cgao@research.att.com>
|
|
legacy db provider
Includes:
a) Modify legacy API endpoints to retrieve the latest version of legacy policies
b) Modify legacy policy providers to support newly added version enabled features in db provider
c) Fix corresponding junit test failures
Issue-ID: POLICY-1777
Change-Id: I641170b37e2929b5060414832d4b8395493cecdc
Signed-off-by: Chenfei Gao <cgao@research.att.com>
|
|
Includes:
a) Add legacy operational policy type and guard policy types into
preloading list.
b) Fix corresponding junit test failure.
Issue-ID: POLICY-1738
Change-Id: I071e898be31e62f47d427094f1e76069fafd0148
Signed-off-by: Chenfei Gao <cgao@research.att.com>
|
|
The default names were incorrect in the api path.
Issue-ID: POLICY-1704
Change-Id: Ib95a7954c6b4a6fef0e871dfd4130e600e03c957
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Includes:
a) Preload monitoring and optimization policy types when api
component starts up
b) Fix the failure unit testing delete policy type
c) Enhance several junit test cases to be irrespective of running orders
Issue-ID: POLICY-1441
Change-Id: Ia1ba17d58dfbc9a8ee12e789e3867b20111e9cd2
Signed-off-by: Chenfei Gao <cgao@research.att.com>
|
|
Add junit tests to improve code coverage to > 80%.
Modify db setting and remove db authorization from persistence.
Issue-ID: POLICY-1441
Change-Id: I6070ac9ba6adba836adeeb547610c27dccf577bd
Signed-off-by: Chenfei Gao <cgao@research.att.com>
|
|
Includes:
a) Close db connection using try-with-resource
b) Modify delete safety net for policy, policy type and legacy policies
c) Modify db persistence
d) Modify db setup in bootstrap config
e) Add unit tests for providers and endpoints
Issue-ID: POLICY-1441
Change-Id: Id89bc361c73380df61df35f01f296e47e936e9cf
Signed-off-by: Chenfei Gao <cgao@research.att.com>
|
|
Use filters to GET wildcard/latest/deployed policies
and policy types.
Junit tests for providers are coming in next patch/review.
Issue-ID: POLICY-1441
Change-Id: Iccd02f395d612ba95728d1bc5808ad16c6f386fe
Signed-off-by: Chenfei Gao <cgao@research.att.com>
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Includes:
a) Implement policy provider functions
b) Implement policy type provider functions
c) Implement legacy guard policy provider functions
d) Implement legacy operational policy provider functions
e) Modify API endpoints to align with provider functions
f) Hook up API statistics counter
Junit tests for providers and new endpoints will be in next patch/review.
Issue-ID: POLICY-1441
Change-Id: I113de95f6e0ea5f5436c072536f5e9a178988e5e
Signed-off-by: Chenfei Gao <cgao@research.att.com>
|
|
to increase code coverage
Issue-ID: POLICY-1606
Change-Id: I03b7680df972f3c809d57e6432e61c2422ecea60
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
|
|
to increase code coverage
Issue-ID: POLICY-1606
Change-Id: I23350df11457422eb6b56cb6e175dcea0ba2be14
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
|
|
Includes:
a) Organized swagger models into new rest.model package
b) Organized provider classes into new rest.provider package
c) Added policyType GET/POST/DELETE endpoints
d) Added policy GET/POST/DELETE endpoints
e) Added swagger annotations for the new endpoints
Issue-ID: POLICY-1515
Change-Id: Ia159a4cfebdad36cb1b4a5cc6456d07d2fde09ee
Signed-off-by: Chenfei Gao <cgao@research.att.com>
|
|
Includes:
1) Changed logging from FlexLogger to slf4j and used the logback.xml aligned with
v1.2 logging requirements.
2) Added https as a configurable parameter of api rest server.
3) Added aaf as a condfigurable parameter of api rest server.
4) Added AafFilter classes for healthcheck and statistics.
5) Added api statistics REST entry point.
6) Created related junit tests.
7) Packaged docker
Issue-ID: POLICY-1270
Change-Id: I638f61361bb052545e8597531ba3d58019bf1f24
Signed-off-by: Chenfei Gao <cgao@research.att.com>
|
|
Fixed the path for finding the src files.
Added eclipse lifecycle to ignore the oparent checkstyle
bug.
Cleaned up existing checkstyle issues.
Added entries into .gitignore to ignore debug logging
directories created.
Issue-ID: POLICY-1136
Change-Id: I684038babcb9723cfc4bef2b2a713425ae077599
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Define main pom xml and update to include main.
Add the main exception parameters rest
startstop classes. Add test cases. Modify comments
Issue-ID: POLICY-1066
Change-Id: I2e878a58eef4f021e3a9a991738194127edf4d16
Signed-off-by: krisjinka <kris.jinka@samsung.com>
Signed-off-by: krishnajinka <kris.jinka@samsung.com>
|