Age | Commit message (Collapse) | Author | Files | Lines |
|
Removed the legacy operational api's earlier but missed the provider.
Removing provider and related tests now.
Issue-ID: POLICY-2762
Change-Id: I902ad3939ba8b28b4ad182f666131a2c02cd98c4
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
|
|
Issue-ID: POLICY-2762
Change-Id: I8e4b3cb5968a691dd9ac3ad9a42ccd7d9fc7b963
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
|
|
Issue-ID: POLICY-2585
Signed-off-by: puthuparambil.aditya <aditya.puthuparambil@bell.ca>
Change-Id: Icabde6463105ed382c1e32b6f7c1319490a385b2
|
|
Addressed issues reported due to updates to the sonar rules:
- use assertEquals, assertNull, etc.
- use "<>"
- use "{}" place-holder
Issue-ID: POLICY-2680
Change-Id: I42d5e635e09bac6e520fc7aa386814ad617fc1f6
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Issue-ID: POLICY-2188
Change-Id: I8765849462cd866f2a3049a5a4a02bce17330e66
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
If a policy type can't be preloaded because it doesn't exist, log and
continue.
Issue-ID: POLICY-2487
Signed-off-by: Chris Ramstad <cramstad@ciena.com>
Change-Id: I2a26e660d7337b2db153491a6bb3373b1470cbee
|
|
Issue-ID: POLICY-2517
Change-Id: I430eaed1dbc2f81aa2d15af0ced3e879349a8bea
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
In BARE mode (default), just the policy definitions are returned, in
REFERENCED mode, the policy and all referenced policy and data types are
returned.
Issue-ID: POLICY-2377
Change-Id: Idc227d512d56945cc14dec0eae9264dbb3ca52a0
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Renamed the guard policy types per this review:
https://gerrit.onap.org/r/c/policy/models/+/103127
Issue-ID: POLICY-2243
Change-Id: I35ef95756483c869d374f36d0a1dfe6b588444c7
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
The deployed API has already been created in PAP as part of Policy Update Notifications work.
Removing the corresponding one from policy/api to make sure that all run time administration
of PdpGroup and deployed policies are done only via PAP.
Leaving the deployed API's in legacy controller as they will be removed together.
Issue-ID: POLICY-1941
Change-Id: Ibe131f1aab3ec6a0eec05a2c91b5a140efc61b72
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
|
|
Issue-ID: POLICY-2317
Change-Id: I5794e617ea4fb99caf6e7a974a4886e72605979c
Signed-off-by: Chenfei Gao <cgao@research.att.com>
|
|
This review adapts policy API for changes introduced for cascaded
returns on filtered gets in policy-models.
Issue-ID: POLICY-1402
Change-Id: I7593eb64cc497809f8485f6add40b6a64291a060
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Issue-ID: POLICY-1402
Change-Id: I3f97fbb4c11105118857d354970d6a3de1385f2d
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Knock on changes and some simplification of the code because the TOSCA
provider now does some of the checks that were in API, so those checks
are not needed in API any more. Various JUnit fixes.
Issue-ID: POLICY-1402
Change-Id: Ic3a08e415c8cce4f2aad4b5da2623e41280c4e66
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
The following rules are implemented to validate the version provided
in the POST payloads of policies and policy types:
1) If version field is not specified in POST payload, "406 - Not Acceptable"
would be returned along with the message "mandantory version field is missing".
2) If the version is not in the DB, we simply insert it.
3) If the version is in the DB, "406 - Not Acceptable" is returned along with
the message saying "specified version x.x.x" is already existing and the latest
version is x.x.x. It can force the user to create a newer version than the latest one.
4) The same versioning validation is applied to legacy types of policies too
so that everything is consistent.
Issue-ID: POLICY-2316
Change-Id: I395df0196a9d3073fd1f09060f943aeeb554d277
Signed-off-by: Chenfei Gao <cgao@research.att.com>
|
|
Change-Id: I2ff6af28eead0958e8bb2699e4b0ce91f1146f06
Issue-ID: POLICY-2315
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
|
|
Test initialization and shutown of h2 database and REST server only done
once at beginning of all API unit tests. Duplicate tests removed, all
test done to persistent database and other minor improvements.
We need to check coverage after this review, ti may have dropped by a
few percent. We should design new tests to bring the coverage back up
again.
Issue-ID: POLICY-2297
Change-Id: I7ccb9835e01e08c284fdc4602e3a00e946b5e902
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
|
|
Preloading native policy type for apex-pdp so that policies can be
created and deployed using this policy type.
Removed few test cases not working on windows.
Issue-ID: POLICY-2279
Change-Id: I8e462118ee21e92fcb862ef94a6d15aec1b893c6
Signed-off-by: ramverma <ram.krishna.verma@est.tech>
|
|
|
|
Issue-ID: POLICY-1689 Consolidate Policy Health Check into PAP
Change-Id: Ie7f8edf1d1a083c6c696824f249544959f72694d
Signed-off-by: Hengye <yehui.wang@est.tech>
|
|
The change to sonar cloud resulted in new issues being uncovered.
Addressed two of the three issues with this:
Remove this unused import...
Add at least one assertion to this test case.
The item left outstanding is:
Make sure that command line arguments are used safely here.
Issue-ID: POLICY-2206
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: Ie5dc339640102a5b4471e5b719338358ec3e0209
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Issue-ID: POLICY-2210
Change-Id: I84b512a783c1fdc0834cf79bdce4c48a7803b884
Signed-off-by: Chenfei Gao <cgao@research.att.com>
|
|
Needs to be available for policy creation.
Issue-ID: POLICY-1740
Change-Id: Id473492ce1ba923131ec3505ecd8f27b18e30013
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
This should be there - it has "matchable" metadata needed by
the XACML PDP optimization application.
Issue-ID: POLICY-2066
Change-Id: Id20996f3cee1b45360e47731bc3d6a4f9457275d
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Added a new endpoint to create multiple policies in one call
Added corresponding provider method
Added corresponding junit tests
Issue-ID: POLICY-1991
Change-Id: I09202ededfd88cf9f1ac62ea036e98e3b5d78f98
Signed-off-by: Chenfei Gao <cgao@research.att.com>
|
|
Issue-ID: POLICY-2101
Change-Id: I0860ff11231b6a649f52355d8d9333eec7d78826
Signed-off-by: Chenfei Gao <cgao@research.att.com>
|
|
This review adapts policy-api for the change in the structure
of the toasca service template from a list of maps to a plain map.
DUplication of policy types and policies removed and policy-models
examples used instead.
Issue-ID: POLICY-2047
Change-Id: Ie1fdeef79289348005314c5de9b2e37c0c45d786
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Modified json based on input from Chenfei.
Change-Id: Ibd70c5737713fee5dcd2370e02ef5f567d2a73b3
Issue-ID: POLICY-1847
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Issue-ID: POLICY-1810
Change-Id: I47046fbbd7d319b58cabf57ff470ec0d5246c88a
Signed-off-by: Chenfei Gao <cgao@research.att.com>
|
|
1) Adds tests for testing LegacyGuardPolicyProvider and
LegacyOperationalPolicyProvider
2) Fixes issue in LegacyGuardPolicyProvider and
LegacyOperationalPolicyProvider to handle
policy version number properly while deleting policies.
Issue-ID: POLICY-1771
Signed-off-by: Bilal A <bilal@research.att.com>
Change-Id: I01d48b5352e7e6da403faf1e4997d3550024755f
|
|
This also entailed removing the local copy of RestServerParameters.
Change-Id: Ie5c581ab70aee60844d1660fe0a61290de6470ec
Issue-ID: POLICY-1652
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Extracted some methods to address cyclomatic complexity.
Created super classes to address duplicate code.
Did not address code coverage.
Change-Id: I2ec07cdad9e671b0e239e2d4ae9395e89b9e4266
Issue-ID: POLICY-1791
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Fixed breakages due to changes made in policy/common to satisfy
sonar.
Also modified the code to allocate ports for junit tests, writing
them into the config files.
Change-Id: Id31d19e0691f7450c3e4158090dac6f3c3849631
Issue-ID: POLICY-1791
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Per javadocs, getName() should generally be used instead of
Class.getCanonicalName(). This change only applies to classes; it
does not apply to File objects.
Change-Id: Ia1726f178f906bfdfbd056c50598228cff8e1a2d
Issue-ID: POLICY-1646
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Add logging of POST requests received via the REST API.
Change-Id: I8c71df3a45b8a3369b48eee06165dd5034c115a6
Issue-ID: POLICY-1777
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Per Jim's comment, version integer check should come first before
checking delete elibibility (i.e. checking if policy is deployed
in PDP group or not).
Issue-ID: POLICY-1777
Change-Id: Ibd3d8d05a40ef34c558a2e9389596396a69469fe
Signed-off-by: Chenfei Gao <cgao@research.att.com>
|
|
legacy db provider
Includes:
a) Modify legacy API endpoints to retrieve the latest version of legacy policies
b) Modify legacy policy providers to support newly added version enabled features in db provider
c) Fix corresponding junit test failures
Issue-ID: POLICY-1777
Change-Id: I641170b37e2929b5060414832d4b8395493cecdc
Signed-off-by: Chenfei Gao <cgao@research.att.com>
|
|
policy deployed
Add groupState=ACTIVE and pdpState=ACTIVE to pdpGroupFilter for filtering
returned pdpGroup list with specified policy deployed in it.
Issue-ID: POLICY-1738
Change-Id: Ie777ab1f6438871b2034c8f2fe7a61595a3f633c
Signed-off-by: Chenfei Gao <cgao@research.att.com>
|
|
Includes:
a) Add legacy operational policy type and guard policy types into
preloading list.
b) Fix corresponding junit test failure.
Issue-ID: POLICY-1738
Change-Id: I071e898be31e62f47d427094f1e76069fafd0148
Signed-off-by: Chenfei Gao <cgao@research.att.com>
|
|
Fix api sonar bugs by logging exceptions in api controllers
Issue-ID: POLICY-1710
Change-Id: Ie591e0d4709c43f3e91aa7b94a1305d8814bd695
Signed-off-by: Chenfei Gao <cgao@research.att.com>
|
|
Change-Id: Iee60e74742dce9df03b5409356dcf2cb433c811c
Issue-ID: POLICY-1724
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
The default names were incorrect in the api path.
Issue-ID: POLICY-1704
Change-Id: Ib95a7954c6b4a6fef0e871dfd4130e600e03c957
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Includes:
a) Preload monitoring and optimization policy types when api
component starts up
b) Fix the failure unit testing delete policy type
c) Enhance several junit test cases to be irrespective of running orders
Issue-ID: POLICY-1441
Change-Id: Ia1ba17d58dfbc9a8ee12e789e3867b20111e9cd2
Signed-off-by: Chenfei Gao <cgao@research.att.com>
|
|
Add junit tests to improve code coverage to > 80%.
Modify db setting and remove db authorization from persistence.
Issue-ID: POLICY-1441
Change-Id: I6070ac9ba6adba836adeeb547610c27dccf577bd
Signed-off-by: Chenfei Gao <cgao@research.att.com>
|
|
Includes:
a) Close db connection using try-with-resource
b) Modify delete safety net for policy, policy type and legacy policies
c) Modify db persistence
d) Modify db setup in bootstrap config
e) Add unit tests for providers and endpoints
Issue-ID: POLICY-1441
Change-Id: Id89bc361c73380df61df35f01f296e47e936e9cf
Signed-off-by: Chenfei Gao <cgao@research.att.com>
|
|
Modify policy and policy type providers to better
support GET/CREATE policy/policy types.
Issue-ID: POLICY-1442
Change-Id: I7a513be4f9dbd5b48b85a948e3bda7b6c6ab7ddb
Signed-off-by: Chenfei Gao <cgao@research.att.com>
|
|
Use filters to GET wildcard/latest/deployed policies
and policy types.
Junit tests for providers are coming in next patch/review.
Issue-ID: POLICY-1441
Change-Id: Iccd02f395d612ba95728d1bc5808ad16c6f386fe
Signed-off-by: Chenfei Gao <cgao@research.att.com>
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Includes:
a) Implement policy provider functions
b) Implement policy type provider functions
c) Implement legacy guard policy provider functions
d) Implement legacy operational policy provider functions
e) Modify API endpoints to align with provider functions
f) Hook up API statistics counter
Junit tests for providers and new endpoints will be in next patch/review.
Issue-ID: POLICY-1441
Change-Id: I113de95f6e0ea5f5436c072536f5e9a178988e5e
Signed-off-by: Chenfei Gao <cgao@research.att.com>
|
|
Includes:
a) Added separate endpoints for legacy guard and ops policies
b) Added legacy policy providers
c) Added hotfix for models package name
d) Added new REST controller to http server properties
Issue-ID: POLICY-1515
Change-Id: Id69c88810efc8b76fccc62f386d6e189ba297b1e
Signed-off-by: Chenfei Gao <cgao@research.att.com>
|