summaryrefslogtreecommitdiffstats
path: root/main/src/main
AgeCommit message (Collapse)AuthorFilesLines
2020-02-19Changes for cascaded get in policy modelsliamfallon3-210/+20
This review adapts policy API for changes introduced for cascaded returns on filtered gets in policy-models. Issue-ID: POLICY-1402 Change-Id: I7593eb64cc497809f8485f6add40b6a64291a060 Signed-off-by: liamfallon <liam.fallon@est.tech>
2020-02-18Add changes for safe delete in policy-modelsliamfallon4-324/+10
Issue-ID: POLICY-1402 Change-Id: I3f97fbb4c11105118857d354970d6a3de1385f2d Signed-off-by: liamfallon <liam.fallon@est.tech>
2020-02-13Update API for changes in TOSCA providerliamfallon4-268/+73
Knock on changes and some simplification of the code because the TOSCA provider now does some of the checks that were in API, so those checks are not needed in API any more. Various JUnit fixes. Issue-ID: POLICY-1402 Change-Id: Ic3a08e415c8cce4f2aad4b5da2623e41280c4e66 Signed-off-by: liamfallon <liam.fallon@est.tech>
2020-01-13Added the new versioning validation for policy and policy typeChenfei Gao7-132/+573
The following rules are implemented to validate the version provided in the POST payloads of policies and policy types: 1) If version field is not specified in POST payload, "406 - Not Acceptable" would be returned along with the message "mandantory version field is missing". 2) If the version is not in the DB, we simply insert it. 3) If the version is in the DB, "406 - Not Acceptable" is returned along with the message saying "specified version x.x.x" is already existing and the latest version is x.x.x. It can force the user to create a newer version than the latest one. 4) The same versioning validation is applied to legacy types of policies too so that everything is consistent. Issue-ID: POLICY-2316 Change-Id: I395df0196a9d3073fd1f09060f943aeeb554d277 Signed-off-by: Chenfei Gao <cgao@research.att.com>
2020-01-09Changes related to persisiting data type of policy in dba.sreekumar1-4/+5
Change-Id: I2ff6af28eead0958e8bb2699e4b0ce91f1146f06 Issue-ID: POLICY-2315 Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
2020-01-02Speed up tests on policy-apiliamfallon3-900/+667
Test initialization and shutown of h2 database and REST server only done once at beginning of all API unit tests. Duplicate tests removed, all test done to persistent database and other minor improvements. We need to check coverage after this review, ti may have dropped by a few percent. We should design new tests to bring the coverage back up again. Issue-ID: POLICY-2297 Change-Id: I7ccb9835e01e08c284fdc4602e3a00e946b5e902 Signed-off-by: liamfallon <liam.fallon@est.tech>
2019-12-06Merge "Preloading native policy type for apex-pdp"Pamela Dragosh1-9/+2
2019-12-06Preloading native policy type for apex-pdpramverma1-9/+2
Preloading native policy type for apex-pdp so that policies can be created and deployed using this policy type. Removed few test cases not working on windows. Issue-ID: POLICY-2279 Change-Id: I8e462118ee21e92fcb862ef94a6d15aec1b893c6 Signed-off-by: ramverma <ram.krishna.verma@est.tech>
2019-12-05Merge "change HealthCheckReport URL from self to hostName"Jim Hahn1-3/+5
2019-12-05change HealthCheckReport URL from self to hostNameHengye1-3/+5
Issue-ID: POLICY-1689 Consolidate Policy Health Check into PAP Change-Id: Ie7f8edf1d1a083c6c696824f249544959f72694d Signed-off-by: Hengye <yehui.wang@est.tech>
2019-12-02Fix sonar issues in policy-apiJim Hahn1-1/+0
The change to sonar cloud resulted in new issues being uncovered. Addressed two of the three issues with this: Remove this unused import... Add at least one assertion to this test case. The item left outstanding is: Make sure that command line arguments are used safely here. Issue-ID: POLICY-2206 Signed-off-by: Jim Hahn <jrh3@att.com> Change-Id: Ie5dc339640102a5b4471e5b719338358ec3e0209 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-11-13Added changes to make the list of preloaded policy types configurableChenfei Gao3-30/+23
Issue-ID: POLICY-2210 Change-Id: I84b512a783c1fdc0834cf79bdce4c48a7803b884 Signed-off-by: Chenfei Gao <cgao@research.att.com>
2019-11-01Preload the SDNC Naming Policy typePamela Dragosh1-1/+2
Needs to be available for policy creation. Issue-ID: POLICY-1740 Change-Id: Id473492ce1ba923131ec3505ecd8f27b18e30013 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-10-21Add missing Optimization base policy typePamela Dragosh1-0/+1
This should be there - it has "matchable" metadata needed by the XACML PDP optimization application. Issue-ID: POLICY-2066 Change-Id: Id20996f3cee1b45360e47731bc3d6a4f9457275d Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-10-09Created a new simplified API for creating policiesChenfei Gao2-0/+77
Added a new endpoint to create multiple policies in one call Added corresponding provider method Added corresponding junit tests Issue-ID: POLICY-1991 Change-Id: I09202ededfd88cf9f1ac62ea036e98e3b5d78f98 Signed-off-by: Chenfei Gao <cgao@research.att.com>
2019-09-16Add changes to support application/yaml in apiChenfei Gao1-2/+2
Issue-ID: POLICY-2101 Change-Id: I0860ff11231b6a649f52355d8d9333eec7d78826 Signed-off-by: Chenfei Gao <cgao@research.att.com>
2019-09-05Knock on of changing policy types to mapliamfallon18-1584/+53
This review adapts policy-api for the change in the structure of the toasca service template from a list of maps to a plain map. DUplication of policy types and policies removed and policy-models examples used instead. Issue-ID: POLICY-2047 Change-Id: Ie1fdeef79289348005314c5de9b2e37c0c45d786 Signed-off-by: liamfallon <liam.fallon@est.tech>
2019-08-28Preload control loop coordination type in APIJim Hahn5-3/+42
Modified json based on input from Chenfei. Change-Id: Ibd70c5737713fee5dcd2370e02ef5f567d2a73b3 Issue-ID: POLICY-1847 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-08-08Add get deployed endpoints for legacy policiesChenfei Gao7-95/+379
Issue-ID: POLICY-1810 Change-Id: I47046fbbd7d319b58cabf57ff470ec0d5246c88a Signed-off-by: Chenfei Gao <cgao@research.att.com>
2019-07-31Policy API JUnit TestsBilal A2-2/+8
1) Adds tests for testing LegacyGuardPolicyProvider and LegacyOperationalPolicyProvider 2) Fixes issue in LegacyGuardPolicyProvider and LegacyOperationalPolicyProvider to handle policy version number properly while deleting policies. Issue-ID: POLICY-1771 Signed-off-by: Bilal A <bilal@research.att.com> Change-Id: I01d48b5352e7e6da403faf1e4997d3550024755f
2019-07-18Modify policy/api to use RestServer from commonJim Hahn4-340/+9
This also entailed removing the local copy of RestServerParameters. Change-Id: Ie5c581ab70aee60844d1660fe0a61290de6470ec Issue-ID: POLICY-1652 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-07-11Fix sonar issues in policy-apiJim Hahn8-521/+397
Extracted some methods to address cyclomatic complexity. Created super classes to address duplicate code. Did not address code coverage. Change-Id: I2ec07cdad9e671b0e239e2d4ae9395e89b9e4266 Issue-ID: POLICY-1791 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-07-08Fix api due to sonar changes in commonJim Hahn1-1/+2
Fixed breakages due to changes made in policy/common to satisfy sonar. Also modified the code to allocate ports for junit tests, writing them into the config files. Change-Id: Id31d19e0691f7450c3e4158090dac6f3c3849631 Issue-ID: POLICY-1791 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-06-17Change getCanonicalName() to getName() in apiJim Hahn2-4/+4
Per javadocs, getName() should generally be used instead of Class.getCanonicalName(). This change only applies to classes; it does not apply to File objects. Change-Id: Ia1726f178f906bfdfbd056c50598228cff8e1a2d Issue-ID: POLICY-1646 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-05-23Log POST requestsJim Hahn2-0/+76
Add logging of POST requests received via the REST API. Change-Id: I8c71df3a45b8a3369b48eee06165dd5034c115a6 Issue-ID: POLICY-1777 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-05-22Reserve version integer check and delete eligibility checkChenfei Gao2-2/+2
Per Jim's comment, version integer check should come first before checking delete elibibility (i.e. checking if policy is deployed in PDP group or not). Issue-ID: POLICY-1777 Change-Id: Ibd3d8d05a40ef34c558a2e9389596396a69469fe Signed-off-by: Chenfei Gao <cgao@research.att.com>
2019-05-21Modify legacy API and policy provider to support version enabled features in ↵Chenfei Gao3-19/+62
legacy db provider Includes: a) Modify legacy API endpoints to retrieve the latest version of legacy policies b) Modify legacy policy providers to support newly added version enabled features in db provider c) Fix corresponding junit test failures Issue-ID: POLICY-1777 Change-Id: I641170b37e2929b5060414832d4b8395493cecdc Signed-off-by: Chenfei Gao <cgao@research.att.com>
2019-05-10Add more filtering conditions to filter returned PdpGroups with specified ↵Chenfei Gao1-1/+3
policy deployed Add groupState=ACTIVE and pdpState=ACTIVE to pdpGroupFilter for filtering returned pdpGroup list with specified policy deployed in it. Issue-ID: POLICY-1738 Change-Id: Ie777ab1f6438871b2034c8f2fe7a61595a3f633c Signed-off-by: Chenfei Gao <cgao@research.att.com>
2019-05-07Preload legacy operational policy type and guard policy typesChenfei Gao5-1/+222
Includes: a) Add legacy operational policy type and guard policy types into preloading list. b) Fix corresponding junit test failure. Issue-ID: POLICY-1738 Change-Id: I071e898be31e62f47d427094f1e76069fafd0148 Signed-off-by: Chenfei Gao <cgao@research.att.com>
2019-05-02Fix api sonar bugs - logging exceptionsChenfei Gao2-0/+40
Fix api sonar bugs by logging exceptions in api controllers Issue-ID: POLICY-1710 Change-Id: Ie591e0d4709c43f3e91aa7b94a1305d8814bd695 Signed-off-by: Chenfei Gao <cgao@research.att.com>
2019-05-01Add version to preloaded policy typesJim Hahn10-10/+20
Change-Id: Iee60e74742dce9df03b5409356dcf2cb433c811c Issue-ID: POLICY-1724 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-04-26Fix legacy policy type names3.0.2-ONAPPamela Dragosh1-8/+8
The default names were incorrect in the api path. Issue-ID: POLICY-1704 Change-Id: Ib95a7954c6b4a6fef0e871dfd4130e600e03c957 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-04-16Preload policy types when api starts upChenfei Gao14-3/+1417
Includes: a) Preload monitoring and optimization policy types when api component starts up b) Fix the failure unit testing delete policy type c) Enhance several junit test cases to be irrespective of running orders Issue-ID: POLICY-1441 Change-Id: Ia1ba17d58dfbc9a8ee12e789e3867b20111e9cd2 Signed-off-by: Chenfei Gao <cgao@research.att.com>
2019-04-11Add junit tests for endpointsChenfei Gao2-7/+63
Add junit tests to improve code coverage to > 80%. Modify db setting and remove db authorization from persistence. Issue-ID: POLICY-1441 Change-Id: I6070ac9ba6adba836adeeb547610c27dccf577bd Signed-off-by: Chenfei Gao <cgao@research.att.com>
2019-04-10Modify delete safety net and DB lab setupChenfei Gao7-277/+259
Includes: a) Close db connection using try-with-resource b) Modify delete safety net for policy, policy type and legacy policies c) Modify db persistence d) Modify db setup in bootstrap config e) Add unit tests for providers and endpoints Issue-ID: POLICY-1441 Change-Id: Id89bc361c73380df61df35f01f296e47e936e9cf Signed-off-by: Chenfei Gao <cgao@research.att.com>
2019-04-09Modify policy provider to support GET/CREATEChenfei Gao3-55/+190
Modify policy and policy type providers to better support GET/CREATE policy/policy types. Issue-ID: POLICY-1442 Change-Id: I7a513be4f9dbd5b48b85a948e3bda7b6c6ab7ddb Signed-off-by: Chenfei Gao <cgao@research.att.com>
2019-04-05Incorporate filters in provider functionsChenfei Gao6-59/+154
Use filters to GET wildcard/latest/deployed policies and policy types. Junit tests for providers are coming in next patch/review. Issue-ID: POLICY-1441 Change-Id: Iccd02f395d612ba95728d1bc5808ad16c6f386fe Signed-off-by: Chenfei Gao <cgao@research.att.com> Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-04-03Implement policy provider functionsChenfei Gao9-340/+847
Includes: a) Implement policy provider functions b) Implement policy type provider functions c) Implement legacy guard policy provider functions d) Implement legacy operational policy provider functions e) Modify API endpoints to align with provider functions f) Hook up API statistics counter Junit tests for providers and new endpoints will be in next patch/review. Issue-ID: POLICY-1441 Change-Id: I113de95f6e0ea5f5436c072536f5e9a178988e5e Signed-off-by: Chenfei Gao <cgao@research.att.com>
2019-03-17Add API endpoints for legacy policiesChenfei Gao7-44/+878
Includes: a) Added separate endpoints for legacy guard and ops policies b) Added legacy policy providers c) Added hotfix for models package name d) Added new REST controller to http server properties Issue-ID: POLICY-1515 Change-Id: Id69c88810efc8b76fccc62f386d6e189ba297b1e Signed-off-by: Chenfei Gao <cgao@research.att.com>
2019-03-17Add test policytype and policiesPamela Dragosh2-2/+2
Some example policies for vDNS, vFW and vCPE use cases using DCAE TCA. The .input are the expected REST body from the calling client (eg. CLAMP). While the .output are the expected REST body for the return response from policy. The .tosca.yaml are what the DBAO will look like internally. Upgraded to support policy/model merge. Fixed missing tca_policy field in monitoring policies. Update for policy-id. Issue-ID: POLICY-1273 Change-Id: Ib087b184c3ac9a058fe600c6c8a28cca3a71fbea Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-03-15Hotfix for compilation errorsChenfei Gao4-1069/+1077
Added hotfix for compilation errors due to model package name change. Issue-ID: POLICY-1515 Change-Id: Ia58671234bc5a5cfe201ee448d38adca870333b3 Signed-off-by: Chenfei Gao <cgao@research.att.com>
2019-03-07Add code to follow ONAP API CVS guidelinesChenfei Gao3-81/+481
Includes: a) Added custom headers of versioning info into API response. b) Added custom header of requestID into API response for fulfilling logging v1.2 requirements by copying from client's request header. If no requestID is contained in client's request header, API server will randomly generate one and include it in response header. c) Added extension annotations into swagger to comply with swagger 2.0 spec extension requirements posted in the table of ONAP API CVS guidelines wiki page. d) Updated the package name of TOSCA model POJOs. Issue-ID: POLICY-1270 Change-Id: Ia9e0f18c088604636008201fe5a149dc5fa21de3 Signed-off-by: Chenfei Gao <cgao@research.att.com>
2019-02-27Add more endpoints and swagger annotationsChenfei Gao7-575/+778
Includes: a) Organized swagger models into new rest.model package b) Organized provider classes into new rest.provider package c) Added policyType GET/POST/DELETE endpoints d) Added policy GET/POST/DELETE endpoints e) Added swagger annotations for the new endpoints Issue-ID: POLICY-1515 Change-Id: Ia159a4cfebdad36cb1b4a5cc6456d07d2fde09ee Signed-off-by: Chenfei Gao <cgao@research.att.com>
2019-02-07Add changes to basic structure of api componentChenfei Gao14-42/+933
Includes: 1) Changed logging from FlexLogger to slf4j and used the logback.xml aligned with v1.2 logging requirements. 2) Added https as a configurable parameter of api rest server. 3) Added aaf as a condfigurable parameter of api rest server. 4) Added AafFilter classes for healthcheck and statistics. 5) Added api statistics REST entry point. 6) Created related junit tests. 7) Packaged docker Issue-ID: POLICY-1270 Change-Id: I638f61361bb052545e8597531ba3d58019bf1f24 Signed-off-by: Chenfei Gao <cgao@research.att.com>
2018-09-25Clean up checkstyle declarationPamela Dragosh8-31/+26
Fixed the path for finding the src files. Added eclipse lifecycle to ignore the oparent checkstyle bug. Cleaned up existing checkstyle issues. Added entries into .gitignore to ignore debug logging directories created. Issue-ID: POLICY-1136 Change-Id: I684038babcb9723cfc4bef2b2a713425ae077599 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-09-03Add basic main structure for policy-apiKrishnajinka12-0/+1197
Define main pom xml and update to include main. Add the main exception parameters rest startstop classes. Add test cases. Modify comments Issue-ID: POLICY-1066 Change-Id: I2e878a58eef4f021e3a9a991738194127edf4d16 Signed-off-by: krisjinka <kris.jinka@samsung.com> Signed-off-by: krishnajinka <kris.jinka@samsung.com>