Age | Commit message (Collapse) | Author | Files | Lines |
|
policy/apex-pdp updated to its latest own and reference snapshots
*** This commit is generated by a PF release script ***
Issue-ID: POLICY-4570
Signed-off-by: saul.gill <saul.gill@est.tech>
Change-Id: Ie8c858d0026057a7e9d756a1b8481bc0337ba00d
|
|
Issue-ID: POLICY-4482
Change-Id: Ifc4039feaac82a1fa4bf1f2eb602f79c7a268b9f
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
policy/apex-pdp updated to its latest own and reference snapshots
*** This commit is generated by a PF release script ***
Issue-ID: POLICY-4484
Signed-off-by: liamfallon <liam.fallon@est.tech>
Change-Id: Ia964f8a4e9fceb9f38f4b560b641af10cda312da
|
|
policy/apex-pdp updated to its latest own and reference snapshots
*** This commit is generated by a PF release script ***
Issue-ID: POLICY-4408
Signed-off-by: liamfallon <liam.fallon@est.tech>
Change-Id: I3463647a8a3689518769a5fe5aaab2cfea8438e7
|
|
policy/apex-pdp updated to its latest own and reference snapshots
*** This commit is generated by a PF release script ***
Issue-ID: POLICY-4408
Signed-off-by: liamfallon <liam.fallon@est.tech>
Change-Id: Ic5da8f09888e81bfe6b0132c8fd725a3a4a40aed
|
|
policy/apex-pdp updated to its latest own and reference snapshots
*** This commit is generated by a PF release script ***
Issue-ID: POLICY-4343
Signed-off-by: liamfallon <liam.fallon@est.tech>
Change-Id: Ib4d723d5d687714011e76f22edf6a6c6f44aad5b
|
|
policy/apex-pdp updated to its latest own and reference snapshots
*** This commit is generated by a PF release script ***
Issue-ID: POLICY-4073
Signed-off-by: liamfallon <liam.fallon@est.tech>
Change-Id: I36c398ac9f30480b55e7ad15b3fb4161d8999206
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
policy/apex-pdp updated to its latest own and reference snapshots
*** This commit is generated by a PF release script ***
Issue-ID: POLICY-4089
Signed-off-by: liamfallon <liam.fallon@est.tech>
Change-Id: If859b088c5975c8dda67c34f335658c98341be57
|
|
policy/apex-pdp updated to its latest own and reference snapshots
*** This commit is generated by a PF release script ***
Issue-ID: POLICY-4089
Signed-off-by: liamfallon <liam.fallon@est.tech>
Change-Id: Ida537dd5acbd299893f3e30bac84146e134d3a0f
|
|
policy/apex-pdp updated to its latest own and reference snapshots
*** This commit is generated by a PF release script ***
Issue-ID: POLICY-3982
Signed-off-by: liamfallon <liam.fallon@est.tech>
Change-Id: I838a8d4d6365de1df2feda9d7ba7ffefbfd82c4f
|
|
XML event protocol was removed as jax-rs dependencies were removed in
Jakarta.
Issue-ID: POLICY-3982
Change-Id: I5e8881ae8062fd46b46a1ec655e1210b8ccf2fbf
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
The Apex model modules were all collapsed into a single module in
Jakarta.
Issue-ID: POLICY-3982
Change-Id: Ibeebb7c89ca6057ce2f9333d14183e9da75e11a1
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
This is the final review in the refactoring of the model code in
apex-pdp.
The core-messaging and core-infrastructure modules are unused in
apex-pdp except for websocket communication. Websocket communication is
also not used in any deployment.
This review:
- removes the core-mesaging module, which had an apex-specific websocket
implementation, except for the MessageException class, which is moved
to the base core module
- removes the core-infrastructure module, except for the ThreadUtils
class, which is moved to the base core module
- removes the websocket event protocol, which used core-messaging but is
not used in any deployment
- collapses all three "core" submodules into a single module
- Updates dependencies where needed
Issue-ID: POLICY-1820
Change-Id: Ieae30063e99570e61943372d3fa23b77a211462c
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
This review collapses all the code in six podel submodules into a single
model module. There are no code changes, just files moved around.
This change reduces the complexity of the code structure and speeds up
the build.
Issue-ID: POLICY-1820
Change-Id: Ifb644e8ec85ae6d0987378f4616fbc8a8858a9a8
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
This review converst apex-pdp to use GSON for JSON handling. In order to
preserve backward compatibility with the JAXB format of JSON, custom
handling of maps was required. Therefore, the policy-common
StandardCoder could not be used.
There are a lot of small changes, removing annotations from concepts and
tweaking of test data. However, this cleans up the code base so it is
worth doing.
Issue-ID: POLICY-1820
Change-Id: I213fa64f6d7f3f1df8d10f111d9fbedbe80f9fe0
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
*** This commit is generated by a PF release script ***
policy/apex-pdp is update from 2.7.0-SNAPSHOT to 2.7.1-SNAPSHOT
Issue-ID: POLICY-3827
Signed-off-by: liamfallon <liam.fallon@est.tech>
Change-Id: I334dda447490f6c3e848be7b58f4a5119ae70ead
|
|
Change-Id: I8ead26be4968b94980dcafd269c7ab32022b34d0
Issue-ID: POLICY-3696
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
|
|
Change-Id: I0db6ab5efb0595cba86ce9cbaaafab88349818ff
Issue-ID: POLICY-3696
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
|
|
Change-Id: Ie39d324e02a302b882318d46735a727322ce409d
Issue-ID: POLICY-3587
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
|
|
Fixed:
- use "var"
- use assertEquals instead of assertTrue(xxx.equals())
- separate assertions
Issue-ID: POLICY-3093
Change-Id: Id4db62626948681cd267e68a56dda65fa355c6f8
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Updated examples thru integration-executor-test.
Issue-ID: POLICY-3391
Change-Id: Idc707146a646d05720675a787761c199484048e9
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
1) Remove the usage of inputField and outputField from Task definition.
2) Fix issues around populating events to task in case of State
Finalizer Logic.
Change-Id: Ief17f400729410b83c6b7c665980d443e0cf6f28
Issue-ID: POLICY-3336
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
|
|
Replacing local-variable type inference
Issue-ID: POLICY-3093
Change-Id: I715231d6cf71d13c87b260b9f903910f9a5c434f
Signed-off-by: lapentafd <francesco.lapenta@est.tech>
|
|
Issue-ID: POLICY-3105
Change-Id: I53abd7e9cf8c1425d115b0bb917db6389e9ded92
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Change-Id: I291f968367b1f864bb417a72fd0bdb22a07ba0f7
Issue-ID: POLICY-3127
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
|
|
Change-Id: I761ded255a97128f858d3a7ce95f2479b6208a4e
Issue-ID: POLICY-3088
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
|
|
Addressed the following issues:
- initialize mocks before use
- use parameterized queries
- Random() is not secure
- provide parameterized type for generics
- unused imports
- constructor visibility
- use compute() instead of containsKey()/put()
- make final fields static
- rename constants to all upper case
- no assert() in Thread.run() methods
- nested try
- nested if/else
- too many break/continue
- use try-with-resources
- repeatable annotations
- overlapping characters in reg ex
- hashcode is not sufficient in compareTo()
- need equals() with compareTo()
- make class an interface
- use parameterized test
- multiple calls in assert()
- log or re-throw
- use different type of lambda
- use parameterized logging
- use StringBuilder instead of concatenation
- use StandardCharsets.UTF_8
Issue-ID: POLICY-2906
Change-Id: I2cf8c885e3e22c2c6cbe6403a34906928afad022
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
This review makes the default URL and userid for JMS null, the actual
values must be specified as parameters.
Issue-ID: POLICY-3035
Change-Id: I9c06d94d8816092425e2df58b849d837ad953fb2
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Issue-ID: POLICY-2875
Change-Id: Ibb0e9a243bf92f0255cb5c145d31ccddb988fdf5
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
|
|
Change-Id: I5e2cd92ee3620dea4070d9fa3aeb5ffd65f9412c
Issue-ID: POLICY-2869
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
|
|
Issue-ID: POLICY-2839
Change-Id: Ia7c847b3dafd28958d5df209af95cac19fa480a0
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
|
|
Change-Id: Idde5050b425eb1bebe312e80e795c21513367a1b
Issue-ID: POLICY-2789
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
|
|
Legacy format support is removed, and Tosca format support is added.
Change-Id: I3cfc181ccb5471a5d224c0162af18c1fa0fdbc70
Issue-ID: POLICY-2812
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
|
|
Change replaceAll() with repalce() in apex-pdp/plugins and
apex-pdp/testsuites
Issue-ID: POLICY-2722
Signed-off-by: JvD_Ericsson <jeff.van.dam@est.tech>
Change-Id: Ib9d5256c050197b06f9df9c4cbb7562be081283c
|
|
apex-pdp had an in-line docuemntation build system built on asciidoc. It
has proven to be very difficult to maintain and keep up to date and it
is incompatible with the ONAP official RST/ReadTheDocs docuementation
system.
In the Dublin release, we converted the asciidoc documentation to RST
format, and hae been updating the RST documentation since. The asciidoc
docuemntation system is now so out of date that it is being removed.
In this change, the "site" directory is removed from all modules in
apex-pdp and a profile called "apexSite" is removed from the pom.xml
file in all modules.
Issue-ID: POLICY-2686
Change-Id: I645f3ed101159d356cd90e619cef791067ad5eb5
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Issue-ID: POLICY-2695
Change-Id: I15b489de9ca2614e3a6c94b450a3d6397d17d4ff
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
|
|
Replaced try/catch blocks in apex-pdp with assertj assertions
Issue-ID: POLICY-2451
Change-Id: I83375b9e0f38d399b84bb68ce5d441e1cec73ef5
Signed-off-by: waynedunican <wayne.dunican@est.tech>
|
|
Issue-ID: POLICY-2188
Change-Id: I56bbf3aa3bd9e1ef433cc93ad2be0c54d141a2a5
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Issue-ID: POLICY-2514
Change-Id: I764cfe41ed8cf8ffebd4ff076d0b76b79d61e142
Signed-off-by: RossC <ross.carter@est.tech>
|
|
Issue-ID: POLICY-2514
Change-Id: I5b130b052150eb0e51759c751b83ab9d6f199759
Signed-off-by: RossC <ross.carter@est.tech>
|
|
|
|
Change-Id: Ic668ab20498bdc41edc78f52c7ce9d89a1385f19
Issue-ID: POLICY-2378
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
|
|
Issue-ID: POLICY-1913
Signed-off-by: huaxing <huaxing.jin@est.tech>
Change-Id: Id1a9a6b6f7a9c8c74dd69bd0d30af05162a92cd1
|
|
Change-Id: I59b93fccb0f3a41f8db753d1e8e2978bbb51e9a0
Issue-ID: POLICY-2378
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
|
|
Integation unit tests resultd in StackOverflowException errors in the
Graal Javascript interpreter. Following extensive testing and
trouobleshooting, it proved very difficult to fix these issues in Graal
as the stck overflow errors were occurring in native class instantiation
methods being invoked by Grall on the JVM.
The alternative Rhino Javascript engine is developed by mozilla, and was
incorporated into the Java 6 JVM and evolved into Nashorn in the Java 8
JVM. Oracle dropped Nashorn in Java 11. However, in parallel, Rhino
development has continued.
This review brings in the Rhino javascript engine into apex-pdp as the
replacement for Nashorn and instead of Graal. Graal seems to be pretty
unstable as yet so we may bring it in in future releases but for now
Rhino is a more stable and reliable alternative.
Issue-ID: POLICY-2106
Change-Id: I0edeff3b0bee404b38e3ebe22001a6e3375a44dc
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Change-Id: If76ddc860b67e0d8dcd4c48bacb5436ffc773faa
Issue-ID: POLICY-1913
Signed-off-by: aditya.puthuparambil <aditya.puthuparambil@est.tech>
|
|
Graal enforces Javascript more strictly than Nashorn does. This review
changes the tests in apex-pdp to comply with the stricter -Javascript
checking, re-enabling the integration test module.
- All log calls must be passed as strings, using toString()
- Byte/Float/Long Java types not supported in Javascript
Disable integration tests so that other changes can be brought in.
JMS integration test is disabled for now, it will be re-enabled in a
review shortly.
Issue-ID: POLICY-2106
Change-Id: I14bdb930eff735e862b51802cf72e4793cec3699
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
A number of Java 11, checkstyle, and SONAR warnings have crept into the
Apex codebase over the last number of reviews. This change fixes those
issues.
Issue-ID: POLICY-1913
Change-Id: I2afd607e80f48323355380fb2fe5e048e18879f9
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
The laest Eclipse checkstyle version 8.26.0 does more thorough checking
and identified a number of small issues in the apex-pdp codebase. This
review fixes those issues.
Issue-ID: POLICY-1913
Change-Id: I30ba25e3e425c6d54c77f925e8da3ab841a8357c
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Issue-ID: POLICY-1861
Change-Id: Iccbdcbc5b5978305c56ab74c01a52a562697bee1
Signed-off-by: liamfallon <liam.fallon@est.tech>
|