Age | Commit message (Collapse) | Author | Files | Lines |
|
|
|
policy/apex-pdp updated to its latest own and reference snapshots
*** This commit is generated by a PF release script ***
Issue-ID: POLICY-4408
Signed-off-by: liamfallon <liam.fallon@est.tech>
Change-Id: Ic5da8f09888e81bfe6b0132c8fd725a3a4a40aed
|
|
Issue-ID: POLICY-4134
Signed-off-by: Sirisha_Manchikanti <sirisha.manchikanti@est.tech>
Change-Id: I373140b42e3f22df3083572b9b55f1da711aa81b
|
|
policy/apex-pdp updated to its latest own and reference snapshots
*** This commit is generated by a PF release script ***
Issue-ID: POLICY-4343
Signed-off-by: liamfallon <liam.fallon@est.tech>
Change-Id: Ib4d723d5d687714011e76f22edf6a6c6f44aad5b
|
|
Issue-ID: POLICY-4045
Change-Id: I6e3a73e243614108cfd9ea6a6967cb983a006ee4
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
policy/apex-pdp updated to its latest own and reference snapshots
*** This commit is generated by a PF release script ***
Issue-ID: POLICY-4073
Signed-off-by: liamfallon <liam.fallon@est.tech>
Change-Id: I36c398ac9f30480b55e7ad15b3fb4161d8999206
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
policy/apex-pdp updated to its latest own and reference snapshots
*** This commit is generated by a PF release script ***
Issue-ID: POLICY-4089
Signed-off-by: liamfallon <liam.fallon@est.tech>
Change-Id: If859b088c5975c8dda67c34f335658c98341be57
|
|
policy/apex-pdp updated to its latest own and reference snapshots
*** This commit is generated by a PF release script ***
Issue-ID: POLICY-4089
Signed-off-by: liamfallon <liam.fallon@est.tech>
Change-Id: Ida537dd5acbd299893f3e30bac84146e134d3a0f
|
|
When a policy is deployed & undeployed, and then on doing
PDP_STATE_CHANGE to passive and then active, previously undeployed
policies are taken from memory and tried to be deployed. Any undeployed
policies should be cleared from the engine memory.
This is fixed here.
Change-Id: I8f6fbc64d29bd8d89e906376d0770d375ffd8b82
Issue-ID: POLICY-4087
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
|
|
1. APEX engine metrics were being initialized to 0 in the
constructor which caused them to reset to 0. Hence, initialization
is removed, and updates are done to metrics only upon:
engineStart/Stop, executionEnter/Exit stages.
2. APEX engine Uptime was only updated when engine stopped,
hence always 0. Also, uptime is redundant since it can be derived
from lastStart timestamp and hence is removed as a metric.
3. Fixed a corner case bug which occurs when all
policies are undeployed the counters are not correct.
4. Fix Unit tests
Issue-ID: POLICY-4044
Signed-off-by: Rashmi Pujar <rashmi.pujar1@bell.ca>
Change-Id: I4d875ff288cf8c242a1851eb105e56dc69b97883
|
|
Batch deploy/undeploy operations will now increment
pdpa_policy_deployments_total counter by the total
number of policies as present in the request.
Issue-ID: POLICY-4043
Signed-off-by: Rashmi Pujar <rashmi.pujar1@bell.ca>
Change-Id: I9ea34d11f5952213b9e72d121ab85dcbd0b8dfc9
|
|
policy/apex-pdp updated to its latest own and reference snapshots
*** This commit is generated by a PF release script ***
Issue-ID: POLICY-3982
Signed-off-by: liamfallon <liam.fallon@est.tech>
Change-Id: I838a8d4d6365de1df2feda9d7ba7ffefbfd82c4f
|
|
Apex policyModel had been provided under policy properties for apex-pdp.
Additional support included to retrieve the policyModel from metadata if PAP supplied it
as metadataSet.
Issue-ID: POLICY-3834
Signed-off-by: zrrmmua <ramesh.murugan.iyer@est.tech>
Change-Id: Ic810d78cf01c507c5b4d167f28ae6f7729132238
|
|
This is the final review in the refactoring of the model code in
apex-pdp.
The core-messaging and core-infrastructure modules are unused in
apex-pdp except for websocket communication. Websocket communication is
also not used in any deployment.
This review:
- removes the core-mesaging module, which had an apex-specific websocket
implementation, except for the MessageException class, which is moved
to the base core module
- removes the core-infrastructure module, except for the ThreadUtils
class, which is moved to the base core module
- removes the websocket event protocol, which used core-messaging but is
not used in any deployment
- collapses all three "core" submodules into a single module
- Updates dependencies where needed
Issue-ID: POLICY-1820
Change-Id: Ieae30063e99570e61943372d3fa23b77a211462c
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
This review collapses all the code in six podel submodules into a single
model module. There are no code changes, just files moved around.
This change reduces the complexity of the code structure and speeds up
the build.
Issue-ID: POLICY-1820
Change-Id: Ifb644e8ec85ae6d0987378f4616fbc8a8858a9a8
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
|
|
Issue-ID: POLICY-3760
Signed-off-by: Rashmi Pujar <rashmi.pujar1@bell.ca>
Change-Id: I0fb59e8d9c95fd81a1754bb769705ef753b9022d
|
|
|
|
This review converst apex-pdp to use GSON for JSON handling. In order to
preserve backward compatibility with the JAXB format of JSON, custom
handling of maps was required. Therefore, the policy-common
StandardCoder could not be used.
There are a lot of small changes, removing annotations from concepts and
tweaking of test data. However, this cleans up the code base so it is
worth doing.
Issue-ID: POLICY-1820
Change-Id: I213fa64f6d7f3f1df8d10f111d9fbedbe80f9fe0
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Testing of these metrics will be covered in CSIT.
Issue-ID: POLICY-3845
Signed-off-by: Rashmi Pujar <rashmi.pujar1@bell.ca>
Change-Id: I8aed49d113f071ab33691f8cf1df624f3358386a
|
|
In order to expose the processing status of a TOSCA policy
to APEX-PDP, a new header field for APEX concept "event"
has been introduced to track this within an APEX policy
implementation. This field will be leveraged to extract
the TOSCA policy execution metrics. Note, that the field is
marked as optional for backward compatibility.
Unit tests have been augmented to test for the field wherever
applicable and the default empty value is retained for the others.
"example-grpc" module has been updated to include this field.
Exposing the TOSCA policy execution metrics is outside the
scope of this patch since the current changes are already
very large owing to the atomic nature of the change introduced.
Issue-ID: POLICY-3845
Signed-off-by: Rashmi Pujar <rashmi.pujar1@bell.ca>
Change-Id: Ief6d70f9abcfc8414e10aa51a27815ee9028e4c8
|
|
Added counters for:
- Policy deploy/undeploy requests total
- Policy deploy/undeploy successful requests total
- Policy deploy/undeploy failed requests total
Cleaned up unused method resetAllStatistics.
Fixed some checkstyle warnings
Update to latest snapshot for parent, and common modules
Depends on https://gerrit.onap.org/r/c/policy/parent/+/125974 for build to pass.
Issue-ID: POLICY-3760
Change-Id: I4a9447c9caea7a018dba86057b9dae3871910709
Signed-off-by: Rashmi Pujar <rashmi.pujar1@bell.ca>
|
|
*** This commit is generated by a PF release script ***
policy/apex-pdp is update from 2.7.0-SNAPSHOT to 2.7.1-SNAPSHOT
Issue-ID: POLICY-3827
Signed-off-by: liamfallon <liam.fallon@est.tech>
Change-Id: I334dda447490f6c3e848be7b58f4a5119ae70ead
|
|
Change-Id: I8ead26be4968b94980dcafd269c7ab32022b34d0
Issue-ID: POLICY-3696
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
|
|
Change-Id: I0db6ab5efb0595cba86ce9cbaaafab88349818ff
Issue-ID: POLICY-3696
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
|
|
Change-Id: Ie39d324e02a302b882318d46735a727322ce409d
Issue-ID: POLICY-3587
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
|
|
Fixed sonar security issues:
- set permissions of temporary files
Issue-ID: POLICY-3093
Change-Id: I1dfc87f22975fa950cfcfc47196fad55d6cbf277
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Fixed:
- use "var"
- use assertEquals instead of assertTrue(xxx.equals())
- separate assertions
Issue-ID: POLICY-3093
Change-Id: Id4db62626948681cd267e68a56dda65fa355c6f8
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Fixed services-engine thru utilities.
Fixed:
- use "var"
- use Files.delete()
- only one method call in assert()
Issue-ID: POLICY-3093
Change-Id: I6f62108c770c15e8b84bc51746066fefa409e0fc
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Fixed:
- deprecated mockito methods
- unused mocks
Issue-ID: POLICY-3093
Change-Id: I20d9aebb2a6390b2a3c95ae9ccc59b710b9e58ce
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Also added lombok to test classes.
Issue-ID: POLICY-3391
Change-Id: I9ecf479f3861a2e5211b037e885029d1719b6a56
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Issue-ID: POLICY-3531
Change-Id: I1460333fdd2ebeb96aaa3b5d3186d2bd1eda2d71
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Change-Id: I0f0742474a5b242ebe71c0e5ab62bc2b1d0de1b9
Issue-ID: POLICY-3538
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
|
|
Change-Id: I8e0089cdd16f8e5f8db70db9c678fb598521158b
Issue-ID: POLICY-3539
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
|
|
Updated projects: services-engine through utilities
Issue-ID: POLICY-3391
Change-Id: I35ebb40d86e9bda360f7819516290b3fea88335c
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
When multiple policies are expecting event on the same topic/endpoint,
a lot of event parsing failure log messages are generated
unnecessarily. With this change, only a 1 line message will
be printed if an event cannot be parsed, and the detailed messages
will be available at debug level.
Change-Id: If1e7460ef5ed86fd470396f1e2ed8cc3c8af70c4
Issue-ID: POLICY-3499
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
|
|
Issue-ID: POLICY-3383
Change-Id: Ie9c5c7178c4c4302a0ba63ab42732f7157d302f8
Signed-off-by: adheli.tavares <adheli.tavares@est.tech>
|
|
|
|
Used name generator for apex-pdp instance id.
Issue-ID: POLICY-3410
Change-Id: Ifcb216d45fba7d6b10043f39fcb299daffe86b69
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
This review addresses two main changes:
1) inputFields and outputFields are not tied to task definition anymore.
Instead inputEvent and outputEvents associated to a task is populated
as part of the policy state definition, as the state definition have
the information anyway.
- Clean up of the usage of inputFields and outputFields in task
definition will happen in a future review
- inputFields and outputFields defined in task definition in
policies until honolulu will not make the policy invalid as the
changes are done in backward compatible way.
2) Multiple output events can come out of a final state now.
- Define another policy state output with the relevant eventName in
the command file
- In the task logic, create a map to store the fields of the relevant
outputEvent, and then just call
"executor.addFieldsToOutput(<the_map_of_fields>)"
These 2 steps are enough to send multiple events to relevant
components as per the apex configuration.
Change-Id: Id88ca402704106404f529e595e1a76f6bf167876
Issue-ID: POLICY-3336
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
|
|
Issue-ID: POLICY-3206
Change-Id: I3873c85aab577e85a9ae6b610c3871ee4de6ea53
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Test refactoring and local-variable type inference replaced
Issue-ID: POLICY-3093
Change-Id: I0c5506f27ea53da7740acce87a25060ba2bce7f4
Signed-off-by: lapentafd <francesco.lapenta@est.tech>
|
|
Following items are fixed.
1) When in PASSIVE state, any policiesToBeUndeployed received
in PDP_UPDATE message are not handled.
2) APEX policy deployment fails when policiesToBeUndeployed
and policiesToBeDeployed come together in PDP_UPDATE message from PAP.
3) Improve response messages after deployment/undeployment.
Change-Id: I8f9c802db4b19c43881c734570b65ad66b3867d5
Issue-ID: POLICY-3332
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
|
|
|
|
- Increase code coverage for service engine events
Issue-ID: POLICY-3092
Signed-off-by: arkadiusz.adamski <aadamski@est.tech>
Change-Id: I40bda05fc53168d86ec4ac1c72b69a1badb02b38
|
|
- Increase code coverage for file carrier plugin in service engine
Issue-ID: POLICY-3092
Signed-off-by: arkadiusz.adamski <aadamski@est.tech>
Change-Id: I8c08ee55c9d31792e35a1acc79330c8eef42af56
|
|
|
|
Removed GroupValidationResult, replacing it with BeanValidationResult.
Modified the ParameterGroup subclasses to use BeanValidator, adding
annotations where needed to trigger the validations that had been
automatically performed by GroupValidationResult.
Issue-ID: POLICY-2059
Change-Id: I2c0c01fac355e6cde4d8d6998dc42f8a2e2ebb65
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
|
|
Remove scanning of policy list from apex engine. Use the
policiesToBeDeployed and policiesToBeUndeployed lists from PDP_UPDATE
message instead.
Issue-ID: POLICY-3170
Change-Id: Icdde66ef87d9feab83ccb1cf99a64d7870bcaaaa
Signed-off-by: waynedunican <wayne.dunican@est.tech>
|