Age | Commit message (Collapse) | Author | Files | Lines |
|
This review fixes an issue identified during testing the changes done
for improving multiple policy handling in APEX.
Changes done to a few test files in the previous review are reverted as
well.
Change-Id: I98324da708239d314aadd4c45dc377137fd552ba
Issue-ID: POLICY-2883
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
|
|
Change-Id: Ic4adf5bd8876dc31fc93993298e90389baaa2c39
Issue-ID: POLICY-2883
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
|
|
The policy models tosca classes ToscaPolicyIdentifier and
ToscaPolicyIdentifierOptVersion can be used to identify any TOSCA
concept, not just TOSCA policies so they are renamed to
ToscaConceptIdentifier and ToscaCinceptIdentifierOptVersion
respectively.
The class ToscaPolicyTypeIdentifier is redundant and is replaced by
ToscaConceptIdentifier.
Issue-ID: POLICY-2900
Change-Id: I5df89d023949cdf0f649951dbbd81a0b30f44ef6
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
The legacy operational policy type for apex has been removed in Guilin release.
Removing it fron supported policy type and other places in apex-pdp.
Issue-ID: POLICY-2857
Change-Id: I41d58bf7e82292e11ff752f61dbe9be96a8a7af4
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
|
|
Issue-ID: POLICY-2827
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I7cde8197621ccc3d366baab952243c7b7894a29b
|
|
Legacy format support is removed, and Tosca format support is added.
Change-Id: I3cfc181ccb5471a5d224c0162af18c1fa0fdbc70
Issue-ID: POLICY-2812
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
|
|
Change-Id: I1d36c28cfb07881ebede1cf918140397b076512c
Issue-ID: POLICY-2753
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
|
|
Fixed the sonar issues relating to Printf format being used for logging
instead of String concatenation
Issue-ID: POLICY-2773
Change-Id: I38db8d1df077fd7102f6c4f9b33685f2914bd624
Signed-off-by: waynedunican <wayne.dunican@est.tech>
|
|
Ensure assertions are present in test cases
Issue-ID: POLICY-2706
Change-Id: I3673a7668564401d2136450b0bdd7a013605dd7c
Signed-off-by: waynedunican <wayne.dunican@est.tech>
|
|
apex-pdp/testsuites
Replace assertTrue with assertEquals and assertFalse with
assertNotEquals in apex-pdp/model, apex-pdp/plugins, apex-pdp/services
and apex-pdp/testsuites
Issue-ID: POLICY-2690
Change-Id: If088371cf012d5648e04ade2aa4d49b38945f6d2
Signed-off-by: JvD_Ericsson <jeff.van.dam@est.tech>
|
|
Replaced try/catch blocks with assertj assertions in apex-pdp. Last
batch of changes
Issue-ID: POLICY-2451
Change-Id: I39bd02fdbd8389818dcf1b786189c1e344ddcea5
Signed-off-by: waynedunican <wayne.dunican@est.tech>
|
|
Change-Id: I0da222e592e6e29f0afca4a1515d8f126fe91cbb
Issue-ID: POLICY-2623
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
|
|
Issue-ID: POLICY-2188
Change-Id: I56bbf3aa3bd9e1ef433cc93ad2be0c54d141a2a5
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Issue-ID: POLICY-2402
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I6bd157d80a0aa1604e634ec561ee76e8197e97df
|
|
Change-Id: If76ddc860b67e0d8dcd4c48bacb5436ffc773faa
Issue-ID: POLICY-1913
Signed-off-by: aditya.puthuparambil <aditya.puthuparambil@est.tech>
|
|
apex-pdp
Change-Id: I6de1fd31c2e73814a546b05ee71419fded4a3357
Issue-ID: POLICY-2147
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
|
|
Currently APEX specific information is placed under properties|content in ToscaPolicy.
Avoid keeping under "content" and keep the information directly under properties.
Change-Id: Ic437271c9a2d71104013b5568af5525df4a4bb56
Issue-ID: POLICY-2332
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
|
|
|
|
Apex to populate the PdpStatistics data in every heartbeat sent to PAP
Issue-ID: POLICY-2302
Change-Id: I2d3a6c1e8605d53bf754a135980527bd50762abd
Signed-off-by: shaoqiu <tim.huang@est.tech>
|
|
|
|
|
|
Change-Id: If8167c837d7d28ec9049b00ff6ca314eb4199930
Issue-ID: POLICY-2279
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
|
|
Change-Id: Iafd2e2625cfabd89480ca1807eb1607788b30899
Issue-ID: POLICY-2235
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
|
|
The laest Eclipse checkstyle version 8.26.0 does more thorough checking
and identified a number of small issues in the apex-pdp codebase. This
review fixes those issues.
Issue-ID: POLICY-1913
Change-Id: I30ba25e3e425c6d54c77f925e8da3ab841a8357c
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Change-Id: If0ad9c6b3a0f19ff3711d6230eb64e0dca1c1ef1
Issue-ID: POLICY-2272
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
|
|
Change-Id: I6cff921bdc65fe505c0b5e7dba94a6cf9aa3ba91
Issue-ID: POLICY-2234
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
|
|
Change-Id: I73fad5bf76ed6b4979f5ab76013f204ea82da30b
Issue-ID: POLICY-2215
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
|
|
Change-Id: Ifaedc5074bcc51a5d495e342feae89b6a2aac1cf
Issue-ID: POLICY-1626
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
|
|
Issue-ID: POLICY-1988
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I576cf60ef4915f9e79246c42f0dd90710a244f47
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
|
|
engine failure
PDP-A goes to ACTIVE state even when the APEX engine failed to start.
This is fixed.
Change-Id: Iad4b45abf257f68267dd2526a624dc6d882c84af
Issue-ID: POLICY-1980
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
|
|
Replaced ParameterUtils with the use of the new
addTopic(TopicParameterGroup) method.
Issue-ID: POLICY-1953
Signed-off-by: jrh3 <jrh3@att.com>
Change-Id: Ie1952c3bdf6d40834261029141ccb21edcdc1ad7
|
|
Fixed breakages due to changes made in policy/common to satisfy
sonar.
Issue-ID: POLICY-1791
Signed-off-by: jrh3 <jrh3@att.com>
Change-Id: I79ee847db2fc3c5af992af85b78ccaa587328463
|
|
Upgraded the versions of avro, jquery and jgroups to versions
in order to remove security vulnerabilities.
Issue-ID: POLICY-1074
Change-Id: I412b9c951b061b19e6ae6edacf7b3785d4c7869b
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
|
|
1) The properties in the topic.properties file is moved into overall
config json file and the topic.properties file is removed.
2) Common parameters such as RestServer and Topic related parameters
from policy-common is used.
Change-Id: Ifc25185c8f717c95a226b2db25c1a8e96b9bbff9
Issue-ID: POLICY-1744
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
|
|
Copyright headers not changed as this review only amends comments.
Issue-ID: POLICY-1791
Change-Id: Icbeb2c6e591b3b160ae102bb67aef2d407924a4d
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Change-Id: Ifcd8866e65a7bc1238d5a4137f7bad288a5bfb3b
Issue-ID: POLICY-1861
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
|
|
Enable maven-checkstyle-plugin in apex-pdp/pom.xml to fail the build at warning level.
Fix all the existing check style issues in the component.
Change-Id: I4de9c1bd9ca5a2876de9086d2d3526cbdc25c080
Issue-ID: POLICY-1732
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
|
|
In APEX, the policy model currently needs to be escaped, otherwise
causes json formatting issues. This is fixed.
Change-Id: If9d5043acef0b175494be797fc7acd9c6c4f4494
Issue-ID: POLICY-1839
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
|
|
Recent change in JpaToscaPolicy require corresponding changes in PDP-A as the code
was expecting a simple string earlier. This review contains the changes to fix
this
Change-Id: I3bbae264800b2c8bb8bdd61eae7b171028a85bc3
Issue-ID: POLICY-1739
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
|
|
Changing the supportedPolicyTypes in apex-pdp configuration files
to "onap.policies.controlloop.operational.Apex"
Change-Id: Ie92d5284fbd80da48318ce7863471876ccb380bb
Issue-ID: POLICY-1632
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
|
|
PDP-A state will now change to ACTIVE even when the policy list is
empty.
When the state is ACTIVE and PAP sends a PDP_UPDATE with policies, PDP-A
will start executing the policies.
Change-Id: Icb5b139939698920d4fa3991dcca33536c6caefc
Issue-ID: POLICY-1674
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
|
|
Add configurtion files that work with the DMaaP simulator.
Issue-ID: POLICY-1643
Change-Id: I719f9db4ec5273a32ba350811eb39b4238002341
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Changing the PdpUpdate already handled check back to previous code.
Change-Id: Icc195b5a8609fba8601dc151f62fdaf0c67b7be0
Issue-ID: POLICY-1632
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
|
|
1) Changes to add RestServer to the PDP-A for healthcheck.
2) Adding Junit testcases.
3) Fixing some sonar issues.
4) Fixing checkstyle issues.
Change-Id: I03530190c733432d219284dda9d9d4cc32ab0773
Issue-ID: POLICY-1632
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
|
|
1) Added the code for packaging PDP-A.
2) Updating the package names.
3) Updating the dependencies in services-onappf. Some dependencies can
be removed as they are brought in while packaging.
4) Some other minor changes.
Change-Id: Idf62d7854f3435806a9e8aa975138fbfd45e3ea8
Issue-ID: POLICY-1632
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
|
|
1) Updating pom file of services-onappf to fix dependency related
issues.
2) Some changes to accomodate recent updates.
3) Fix for some issues identified during testing.
Change-Id: I8150ed9858902ebbe12321a793770df3fdc7e773
Issue-ID: POLICY-1453
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
|
|
1) Adding listeners and handlers for PdpUpdate messages.
2) Adding listeners and handlers for PdpStateChange messages.
3) Some changes to accomodate recent changes in the models.
4) Test cases.
Change-Id: I66644d94fd2a242738d9b0f78e5d0ece76342057
Issue-ID: POLICY-1453
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
|
|
1) Adding handlers to create and send pdp status messages from apex-pdp.
2) Changes to read initial pdp status parameters from configuration
file.
3) Adding test cases.
Change-Id: Id2d1caa8abc124865a9ef8fbfe4d9f751e4491b5
Issue-ID: POLICY-1452
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
|
|
1) Adding services-onappf module to apex-pdp.
2) Following the code base from policy/pap to build the module.
3) Currently PAP is using property & configuration file for bootstrap.
Continuing the same in this module as well.
4) Adding relevant test cases.
Change-Id: Id9740ea60ae3ecbd88e5d6d3586ee0dde1054cca
Issue-ID: POLICY-1452
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
|