aboutsummaryrefslogtreecommitdiffstats
path: root/plugins
AgeCommit message (Collapse)AuthorFilesLines
2022-08-01Adding JSON Schema support in APEX-PDPa.sreekumar13-3/+815
More details can be found here: https://wiki.onap.org/display/DW/JSON+Schema+support+in+APEX-PDP A separate review will be raised as part of POLICY-4292 with a reference example on how to use the JSON Schema. Change-Id: I903d48969c6c5a24c63b8465b2412ed0b75b9351 Issue-ID: POLICY-4291 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca> (cherry picked from commit c354fba3fb87ebe21a7fbb2a15268ccc9d033fbd)
2022-04-28Update snapshot and/or references of policy/apex-pdp to latest snapshotsliamfallon27-27/+27
policy/apex-pdp updated to its latest own and reference snapshots *** This commit is generated by a PF release script *** Issue-ID: POLICY-4089 Signed-off-by: liamfallon <liam.fallon@est.tech> Change-Id: If859b088c5975c8dda67c34f335658c98341be57
2022-04-22Upgrade dependencies for JRuby for securityliamfallon1-1/+10
Issue-ID: POLICY-4070 Change-Id: I7ad7c3f6a98e7e3cac83cbe06a8111173a6bffe2 Signed-off-by: liamfallon <liam.fallon@est.tech>
2022-04-13Update dependencies for securityliamfallon2-2/+2
Secure versions of Hazelcast and activeMQ are available. Issue-ID: POLICY-4070 Change-Id: I78ccef19af1e1cc212c3327a26ef44259c49ff90 Signed-off-by: liamfallon <liam.fallon@est.tech>
2022-04-12Update snapshot and/or references of policy/apex-pdp to latest snapshotsliamfallon27-27/+27
policy/apex-pdp updated to its latest own and reference snapshots *** This commit is generated by a PF release script *** Issue-ID: POLICY-4089 Signed-off-by: liamfallon <liam.fallon@est.tech> Change-Id: Ida537dd5acbd299893f3e30bac84146e134d3a0f
2022-03-11Update snapshot and/or references of policy/apex-pdp to latest snapshotsliamfallon27-27/+27
policy/apex-pdp updated to its latest own and reference snapshots *** This commit is generated by a PF release script *** Issue-ID: POLICY-3982 Signed-off-by: liamfallon <liam.fallon@est.tech> Change-Id: I838a8d4d6365de1df2feda9d7ba7ffefbfd82c4f
2022-02-11Remove apex-pdp unused core modulesliamfallon11-708/+7
This is the final review in the refactoring of the model code in apex-pdp. The core-messaging and core-infrastructure modules are unused in apex-pdp except for websocket communication. Websocket communication is also not used in any deployment. This review: - removes the core-mesaging module, which had an apex-specific websocket implementation, except for the MessageException class, which is moved to the base core module - removes the core-infrastructure module, except for the ThreadUtils class, which is moved to the base core module - removes the websocket event protocol, which used core-messaging but is not used in any deployment - collapses all three "core" submodules into a single module - Updates dependencies where needed Issue-ID: POLICY-1820 Change-Id: Ieae30063e99570e61943372d3fa23b77a211462c Signed-off-by: liamfallon <liam.fallon@est.tech>
2022-02-10Collapse apex-pdp maven model submodulesliamfallon1-2/+1
This review collapses all the code in six podel submodules into a single model module. There are no code changes, just files moved around. This change reduces the complexity of the code structure and speeds up the build. Issue-ID: POLICY-1820 Change-Id: Ifb644e8ec85ae6d0987378f4616fbc8a8858a9a8 Signed-off-by: liamfallon <liam.fallon@est.tech>
2022-02-08Remove JAXB and XML, use GSON for JSONliamfallon11-1239/+1
This review converst apex-pdp to use GSON for JSON handling. In order to preserve backward compatibility with the JAXB format of JSON, custom handling of maps was required. Therefore, the policy-common StandardCoder could not be used. There are a lot of small changes, removing annotations from concepts and tweaking of test data. However, this cleans up the code base so it is worth doing. Issue-ID: POLICY-1820 Change-Id: I213fa64f6d7f3f1df8d10f111d9fbedbe80f9fe0 Signed-off-by: liamfallon <liam.fallon@est.tech>
2022-02-03Remove direct DB Load/Save from apex-pdpliamfallon11-827/+1
This review is part of a series of reviews to move the apex-pdp state machine model to use the base model types in policy models. Persistence of policies for apex-pdp is now implemented in PAP and API. The historic direct load and save functionality for APEX policy state machine models to and from databases is no longer used and no longer supported. This revmoves the DAO code from apex-pdp and the associated handling and test code. The next review will remove the JPA annotations. Subsequent reviews will mvoe the mdoel across to use the policy models base model types. Issue-ID: POLICY-1820 Change-Id: Iabf034b40a413d32fe62091fe3446f52ec30d3af Signed-off-by: liamfallon <liam.fallon@est.tech>
2022-01-24Add TOSCA policy status header field to APEX event create CLIRashmi Pujar7-29/+58
In order to expose the processing status of a TOSCA policy to APEX-PDP, a new header field for APEX concept "event" has been introduced to track this within an APEX policy implementation. This field will be leveraged to extract the TOSCA policy execution metrics. Note, that the field is marked as optional for backward compatibility. Unit tests have been augmented to test for the field wherever applicable and the default empty value is retained for the others. "example-grpc" module has been updated to include this field. Exposing the TOSCA policy execution metrics is outside the scope of this patch since the current changes are already very large owing to the atomic nature of the change introduced. Issue-ID: POLICY-3845 Signed-off-by: Rashmi Pujar <rashmi.pujar1@bell.ca> Change-Id: Ief6d70f9abcfc8414e10aa51a27815ee9028e4c8
2021-11-29Update snapshot of policy/apex-pdp to 2.7.1-SNAPSHOTliamfallon32-32/+32
*** This commit is generated by a PF release script *** policy/apex-pdp is update from 2.7.0-SNAPSHOT to 2.7.1-SNAPSHOT Issue-ID: POLICY-3827 Signed-off-by: liamfallon <liam.fallon@est.tech> Change-Id: I334dda447490f6c3e848be7b58f4a5119ae70ead
2021-10-19HTTP code filter for RestClientProducerlapentafd3-8/+41
RestClient producer can now consider 2xx response status as success Issue-ID: POLICY-3743 Change-Id: I40c4dce01b437ea6b9f9bbc317835657cb7ebc8a Signed-off-by: lapentafd <francesco.lapenta@est.tech>
2021-10-14Bump policy/apex-pdp to Jakarta 2.7.0-SNAPSHOTa.sreekumar32-32/+32
Change-Id: I8ead26be4968b94980dcafd269c7ab32022b34d0 Issue-ID: POLICY-3696 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2021-10-14Bump policy/apex-pdp to 2.6.2-SNAPSHOTa.sreekumar32-32/+32
Change-Id: I0db6ab5efb0595cba86ce9cbaaafab88349818ff Issue-ID: POLICY-3696 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2021-09-15Bump apex-pdp to 2.6.1-SNAPSHOTa.sreekumar32-32/+32
Change-Id: Ie39d324e02a302b882318d46735a727322ce409d Issue-ID: POLICY-3587 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2021-08-27Fix sonars in apex-pdp #2Jim Hahn25-82/+83
plugins-events thru plugins-persistence-jpa-eclipselink Fixed: - use "var" - disambiguate method parameter types - rename parameter Issue-ID: POLICY-3093 Change-Id: Ife5897015be495403e731754d5862b803a217c87 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-08-27Address eclipse warnings in apex-pdpJim Hahn6-49/+13
Fixed: - deprecated mockito methods - unused mocks Issue-ID: POLICY-3093 Change-Id: I20d9aebb2a6390b2a3c95ae9ccc59b710b9e58ce Signed-off-by: Jim Hahn <jrh3@att.com>
2021-08-24Use CompareToBuilderJim Hahn5-217/+37
Also added lombok to test classes. Issue-ID: POLICY-3391 Change-Id: I9ecf479f3861a2e5211b037e885029d1719b6a56 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-08-06Use lombok in apex-pdp #3Jim Hahn26-747/+131
Updated plugins thru plugins-persistence-jpa-eclipselink. Issue-ID: POLICY-3391 Change-Id: Id7a5aeca8bb45c7a089f0b9d49c9ecd4bc8a7178 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-07-29Improve APEX logging for irrelevant eventsa.sreekumar2-2/+3
When multiple policies are expecting event on the same topic/endpoint, a lot of event parsing failure log messages are generated unnecessarily. With this change, only a 1 line message will be printed if an event cannot be parsed, and the detailed messages will be available at debug level. Change-Id: If1e7460ef5ed86fd470396f1e2ed8cc3c8af70c4 Issue-ID: POLICY-3499 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2021-07-02Cleanup input & outputFields from Task definitiona.sreekumar1-5/+2
1) Remove the usage of inputField and outputField from Task definition. 2) Fix issues around populating events to task in case of State Finalizer Logic. Change-Id: Ief17f400729410b83c6b7c665980d443e0cf6f28 Issue-ID: POLICY-3336 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2021-06-29Merge "Changes to support multiple outputs from a state"Jim Hahn8-22/+52
2021-06-28Changes to support multiple outputs from a statea.sreekumar8-22/+52
This review addresses two main changes: 1) inputFields and outputFields are not tied to task definition anymore. Instead inputEvent and outputEvents associated to a task is populated as part of the policy state definition, as the state definition have the information anyway. - Clean up of the usage of inputFields and outputFields in task definition will happen in a future review - inputFields and outputFields defined in task definition in policies until honolulu will not make the policy invalid as the changes are done in backward compatible way. 2) Multiple output events can come out of a final state now. - Define another policy state output with the relevant eventName in the command file - In the task logic, create a map to store the fields of the relevant outputEvent, and then just call "executor.addFieldsToOutput(<the_map_of_fields>)" These 2 steps are enough to send multiple events to relevant components as per the apex configuration. Change-Id: Id88ca402704106404f529e595e1a76f6bf167876 Issue-ID: POLICY-3336 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2021-06-25Fix sonar issues in apex plugins and testsuiteslapentafd1-14/+13
Replacing local-variable type inference Issue-ID: POLICY-3093 Change-Id: I715231d6cf71d13c87b260b9f903910f9a5c434f Signed-off-by: lapentafd <francesco.lapenta@est.tech>
2021-06-23Sonar Issues in Apex plugins-contextlapentafd7-51/+55
Replacing local-variable type inference, and checkstyle fix Refactor lambda expression to have one invocation to throw exception Issue-ID: POLICY-3093 Change-Id: I6f89793a3652c50897d7f8e0fda35fffba903acc Signed-off-by: lapentafd <francesco.lapenta@est.tech>
2021-05-10Support ':' in Apex Event Avro schema fieldnamesJohnKeeney4-10/+124
Similar to '.' (_DoT_) and '-' (_Dash_), the ':' (_ColoN_) character can now be used in Apex Event Field names specified using Avro Schema Change-Id: I320058441a1a1a544b9f1619e45c96e71e5aa9e3 Signed-off-by: JohnKeeney <john.keeney@est.tech> Issue-ID: POLICY-3301 Signed-off-by: JohnKeeney <john.keeney@est.tech>
2021-05-04Merge "Remove GroupValidationResult"Jim Hahn11-134/+117
2021-05-03Remove GroupValidationResultJim Hahn11-134/+117
Removed GroupValidationResult, replacing it with BeanValidationResult. Modified the ParameterGroup subclasses to use BeanValidator, adding annotations where needed to trigger the validations that had been automatically performed by GroupValidationResult. Issue-ID: POLICY-2059 Change-Id: I2c0c01fac355e6cde4d8d6998dc42f8a2e2ebb65 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-04-28Changes to retain executionProperties per event flow for better context handlinga.sreekumar3-19/+6
Change-Id: I11668e9222dd9c61cc3096fa5c754c8702a781bf Issue-ID: POLICY-3227 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2021-04-21Changes to support Kafka over SSL in APEXa.sreekumar2-2/+17
The Kafka plugin in APEX-PDP already has a field "kafkaProperties" that can take in any properties required for the Kafka client. This is apt to store the SSL related properties as they could change based on the server implementation. To make the communication possible, the only change required in APEX is to allow a property to have an empty value. For e.g., to disable the server host name verification, ssl.endpoint.identification.algorithm must to be explicitly set to an empty string on the client. Change-Id: If3adaeaf11e5fbbd2aff582b5d4ba7824017ea8a Issue-ID: POLICY-3194 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2021-04-21Merge "Code coverage for plugins jms event carrier"Liam Fallon4-65/+880
2021-04-20Code coverage for plugins jms event carrierarkadiusz.adamski4-65/+880
- Increase code coverage for plugins jms event carrier Issue-ID: POLICY-3109 Signed-off-by: arkadiusz.adamski <aadamski@est.tech> Change-Id: I28dd8c5b32eb91f8f5047916e8899439d4c62374
2021-04-15Code coverage for jms protocol event pluginarkadiusz.adamski5-3/+420
- Increase code coverage for jms protocol event plugin Issue-ID: POLICY-3092 Signed-off-by: arkadiusz.adamski <aadamski@est.tech> Change-Id: I615d56736b548b3d5f552ae1becac771d445b477
2021-03-19Fixing parallel event execution problem in APEX-PDP REST layera.sreekumar1-26/+21
Parallel event execution in APEX was resulting in incorrect dynamic REST url. This issue is fixed in this review. Change-Id: Id8a28c001a7fd7915df1f5909109bb369667ab40 Issue-ID: POLICY-3019 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2021-03-18Merge "Increase code coverage"Liam Fallon8-38/+232
2021-03-16Increase code coveragearkadiusz.adamski8-38/+232
- increased test coverage in plugins-event-carrier-restserver package Issue-ID: POLICY-3092 Change-Id: I10ad7f0dd24293de6ce426553c7bc7a2fe3be013 Signed-off-by: arkadiusz.adamski <aadamski@est.tech>
2021-03-15Merge "Increase code coverage"Ram Krishna Verma2-1/+96
2021-03-15Increase code coveragearkadiusz.adamski2-1/+96
- increased test coverage in the event.protocol.xml package Issue-ID: POLICY-3092 Change-Id: Ie68f8acf49d258536ddc23a14d05302273687634 Signed-off-by: arkadiusz.adamski <aadamski@est.tech>
2021-03-12Bump apex-pdp to 2.6.0-SNAPSHOTliamfallon32-32/+32
Issue-ID: POLICY-3105 Change-Id: I53abd7e9cf8c1425d115b0bb917db6389e9ded92 Signed-off-by: liamfallon <liam.fallon@est.tech>
2021-03-10Bump apex-pdp to 2.5.2-SNAPSHOTa.sreekumar32-32/+32
Change-Id: I291f968367b1f864bb417a72fd0bdb22a07ba0f7 Issue-ID: POLICY-3127 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2021-02-24Bump apex-pdp to 2.5.1-SNAPSHOTa.sreekumar32-32/+32
Change-Id: I761ded255a97128f858d3a7ce95f2479b6208a4e Issue-ID: POLICY-3088 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2021-02-18Fix sonars in apex-pdpJim Hahn6-220/+117
Addressed the following issues: - initialize mocks before use - use parameterized queries - Random() is not secure - provide parameterized type for generics - unused imports - constructor visibility - use compute() instead of containsKey()/put() - make final fields static - rename constants to all upper case - no assert() in Thread.run() methods - nested try - nested if/else - too many break/continue - use try-with-resources - repeatable annotations - overlapping characters in reg ex - hashcode is not sufficient in compareTo() - need equals() with compareTo() - make class an interface - use parameterized test - multiple calls in assert() - log or re-throw - use different type of lambda - use parameterized logging - use StringBuilder instead of concatenation - use StandardCharsets.UTF_8 Issue-ID: POLICY-2906 Change-Id: I2cf8c885e3e22c2c6cbe6403a34906928afad022 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-02-11Changes related to multi policy handling improvement in APEXa.sreekumar1-19/+30
This review fixes an issue identified during testing the changes done for improving multiple policy handling in APEX. Changes done to a few test files in the previous review are reverted as well. Change-Id: I98324da708239d314aadd4c45dc377137fd552ba Issue-ID: POLICY-2883 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2021-02-10Remove URL and useerid from JMS pluginliamfallon2-38/+50
This review makes the default URL and userid for JMS null, the actual values must be specified as parameters. Issue-ID: POLICY-3035 Change-Id: I9c06d94d8816092425e2df58b849d837ad953fb2 Signed-off-by: liamfallon <liam.fallon@est.tech>
2021-02-08Remove security credentials from JMS pluginliamfallon4-26/+40
The default security credential of "password" was encoded in a constant in the JMS plugin parameters file. This commit removes these credentials and defaults the credentials to null. Issue-ID: POLICY-3035 Change-Id: I6313340e64c893c4f99de78d9dd448ac53d81246 Signed-off-by: liamfallon <liam.fallon@est.tech>
2021-01-28Improve handling of multiple policy in APEX PDPa.sreekumar1-18/+6
Change-Id: Ic4adf5bd8876dc31fc93993298e90389baaa2c39 Issue-ID: POLICY-2883 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2021-01-20Merge "Add logs for REST request/response in APEX"Ram Krishna Verma5-16/+29
2021-01-20Update Hazelcast version, remove security vulnerabilityliamfallon2-9/+11
Security vulnerabillitles were flagged in CLM in Hazelcast version 3.11-BETA-1. Hazelcast version 4.1.1 removes that vulnerability. The lock handling is slightly different in version 4.1.1 and the old ILock class is removed. The code is updated to use the new FencedLock locks. Issue-ID: POLICY-2943 Change-Id: I0cb7d3cb279fed17b3f8758e55902703491f4b5c Signed-off-by: liamfallon <liam.fallon@est.tech>
2021-01-20Add logs for REST request/response in APEXa.sreekumar5-16/+29
Change-Id: Ibf2cf19a1ec91473d8c655b87a712aa8738848c8 Issue-ID: POLICY-3003 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>