summaryrefslogtreecommitdiffstats
path: root/plugins/plugins-executor
AgeCommit message (Collapse)AuthorFilesLines
2020-03-09Use Rhino javascript executor in apex-pdpliamfallon12-94/+129
Integation unit tests resultd in StackOverflowException errors in the Graal Javascript interpreter. Following extensive testing and trouobleshooting, it proved very difficult to fix these issues in Graal as the stck overflow errors were occurring in native class instantiation methods being invoked by Grall on the JVM. The alternative Rhino Javascript engine is developed by mozilla, and was incorporated into the Java 6 JVM and evolved into Nashorn in the Java 8 JVM. Oracle dropped Nashorn in Java 11. However, in parallel, Rhino development has continued. This review brings in the Rhino javascript engine into apex-pdp as the replacement for Nashorn and instead of Graal. Graal seems to be pretty unstable as yet so we may bring it in in future releases but for now Rhino is a more stable and reliable alternative. Issue-ID: POLICY-2106 Change-Id: I0edeff3b0bee404b38e3ebe22001a6e3375a44dc Signed-off-by: liamfallon <liam.fallon@est.tech>
2020-03-03use policy/parent awaitilityPamela Dragosh1-2/+1
use common version Issue-ID: POLICY-2381 Change-Id: Id231aa8709b3c4515fcac80b82d53fb8ed45eaf0 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-03-01Switch apex to Graal javascript engineliamfallon16-319/+2003
This is the main review to switch out the Nashorn Javascript interpreter and switch in the Graal javascript interpreter for apex Javascript tasks. The Graal Javascript dialect differs slightly from Nashorn in the way it accesses information passed over from the Java world so Javascript tasks need to be converted. Subsequent reviews will convert the JUnit tests marked @Ignore in previous reviews to this one and will convert the Javascript tasks into a format Graal can handle. Subsequent reviews will also convert the examples over to Graal format. Issue-ID: POLICY-2106 Change-Id: Ief582a36539e8a87724c17fb7e56864d5e471c07 Signed-off-by: liamfallon <liam.fallon@est.tech>
2020-02-26Fix Java 11/Checkstyle/Sonar warningsliamfallon3-7/+12
A number of Java 11, checkstyle, and SONAR warnings have crept into the Apex codebase over the last number of reviews. This change fixes those issues. Issue-ID: POLICY-1913 Change-Id: I2afd607e80f48323355380fb2fe5e048e18879f9 Signed-off-by: liamfallon <liam.fallon@est.tech>
2019-11-15Fix JRuby interpreter shutdown issueliamfallon5-29/+59
The new version of JRuby fixes this issue. Also amended unit test to check for shutdown and immediate recreation of JRuby interpreter. Issue-ID: POLICY-1276 Change-Id: I723e0396985d3163b483e52fdaceb4b4fab7274b Signed-off-by: liamfallon <liam.fallon@est.tech>
2019-09-16Merge "Disable Jython Excutor for security"Liam Fallon2-2/+3
2019-09-14Disable Jython Excutor for securityliamfallon2-2/+3
The Jython interpreter pulls in many dependencies that are flagged as having security problems. We will disable Python support in apex-pdp until Frankfurt, users can compile from source if they wish to re-enable python support. Issue-ID: POLICY-1509 Change-Id: I84215ba8d1009cb7af99cd98ba19008fdff5c378 Signed-off-by: liamfallon <liam.fallon@est.tech>
2019-09-12Bump version in apex-pdp masterjrh36-6/+6
Also added defaultbranch to the .gitreview file to make it easier to change it when apex-pdp is branched in the future. Issue-ID: POLICY-2045 Signed-off-by: jrh3 <jrh3@att.com> Change-Id: Ib2570fd395aae38862299f2193b07ab06e32ace5
2019-08-07Bump version of apex-pdpjrh36-6/+6
Issue-ID: POLICY-1965 Signed-off-by: jrh3 <jrh3@att.com> Change-Id: Icd437f10c4d991030652ffa1abf48b7b5738145c
2019-07-10Add integration tests for executor propertiesliamfallon15-53/+80
Added integration test that sets properties in a dummy plugin and amends them in tasks in a policy. Variosu tests added to check combinations of where properties are set in plugins or in tasks or both. Implementaiton changed to: - Always pass in a Properies object, the properties object coming into the policy cannot be null because the task/TSL/SFL may wish to set it - Fix a bug where the properties were not passed from the ApexEvent to the engine event in the ApexEventUnmarshaller class Issue-ID: POLICY-1743 Change-Id: I6aa152b28d46cf3cc6fa56a1a95b76a8e55f5a49 Signed-off-by: liamfallon <liam.fallon@est.tech>
2019-06-28Bump apex-pdp to 2.2.1-SNAPSHOTPamela Dragosh6-6/+6
Released 2.2.0 Issue-ID: POLICY-1737 Change-Id: I144a3c07d3eaf8c53d339eecedf2b3d8d3ce3c7e Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-06-26Add passthrough properties for APEX engineliamfallon30-130/+166
APEX event receiver and sender plugins sometimes need to exchange information with tasks, especially in the case of REST communication. This change enables passthrough of Properties from the event carrier technology plugins to APEX task, task selection, and state finalizer logics. Apologies for the size of the review but this change involves passinng the properties through all the APEX components, hence the large number of small changes. Issue-ID: POLICY-1742 Change-Id: I219fd69550f06702ef64adbb165fe7baac422e96 Signed-off-by: liamfallon <liam.fallon@est.tech>
2019-06-21Replace uses of getCanonicalName() with getName() in APEXa.sreekumar5-15/+15
Change-Id: Ifcd8866e65a7bc1238d5a4137f7bad288a5bfb3b Issue-ID: POLICY-1861 Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
2019-05-30Bump apex-pdp to version 2.2.0Jim Hahn6-6/+6
Issue-ID: POLICY-1747 Signed-off-by: Jim Hahn <jrh3@att.com> Change-Id: Iba1c6a80917a37cc63e2250a32df40046df9ee4f
2019-05-16Step snapshot version of apex-pdpliamfallon6-6/+6
Issue-ID: POLICY-1630 Change-Id: I6dfce7eb33d9bc41caabf6b8842377b486de672d Signed-off-by: liamfallon <liam.fallon@est.tech>
2019-03-19Fix checkstyle/Sonar issues on juint/sonar fixesliamfallon19-27/+39
Recent changes to increase code coverage and fox Sonar bugs have introduced checkstyle and further Sonar issues. This review cleans those up. Issue-ID: POLICY-1523 Change-Id: I829217ef77d52e57f9713cfeee5b122e1f25efbc Signed-off-by: liamfallon <liam.fallon@est.tech>
2019-03-19Use Assertions class from policy-commonliamfallon3-3/+6
Change import line in all classes that use the Assertions class, there are a lot of them. Issue-ID: POLICY-1264 Change-Id: I8480264be4e36348b3fc63acf1bc36e9c9dd250b Signed-off-by: liamfallon <liam.fallon@est.tech>
2019-03-06Increase test coverage for plugins-executor-jsHengye7-70/+535
Add junit test cases into apex-pdp/plugins/plugins-executor-javascript Issue-ID: POLICY-1523 Change-Id: Ie8017be2f7507fdb641a4020e13152c656cadf04 Signed-off-by: Hengye <yehui.wang@est.tech>
2019-03-01Merge "Increase test coverage for plugins-executor-mvel"Pamela Dragosh7-15/+496
2019-03-01Merge "Increase test coverage for plugins-executor-jruby"Pamela Dragosh7-15/+416
2019-02-28Increase test coverage for plugins-executor-jythonning.xi7-63/+506
Add junit test cases into apex-pdp/plugins/plugins-executor-jython Issue-ID: POLICY-1523 Change-Id: I2545a9cefc6b4b9a53200b98081ddd8bc8274b40 Signed-off-by: ning.xi <ning.xi@est.tech>
2019-02-28Increase test coverage for plugins-executor-jrubyshaoqiu7-15/+416
Add junit test cases into apex-pdp/plugins/plugins-executor-jruby Issue-ID: POLICY-1523 Change-Id: I2ed06a69cf991d744aa5c4c69f605fdf1dca6524 Signed-off-by: shaoqiu <tim.huang@est.tech>
2019-02-28Increase test coverage for plugins-executor-mvelHengye7-15/+496
Add junit test cases into apex-pdp/plugins/plugins-executor-mvel Issue-ID: POLICY-1523 Change-Id: I74d47974a326c7fbd53a0b7d88262ef1dbd54c8c Signed-off-by: Hengye <yehui.wang@est.tech>
2018-12-08Fix checkstyle issuesliamfallon4-5/+25
Some minor line length and formatting checkstyle warnings fixed. Change-Id: Ib92069bbdb444560083e6d0dbf5d16a3ab824d82 Issue-ID: POLICY-1074 Signed-off-by: liamfallon <liam.fallon@est.tech>
2018-12-04Add unit test for Java executorliamfallon10-26/+603
Code coverage in the Apex-PDP plugins is very low. JUnit coverage will be increased for the Plugins over the Dublin design timeline. Issue-ID: POLICY-1379 Change-Id: Ie70ab5a9be650818cb330ec5be2a89a5db6153c5 Signed-off-by: liamfallon <liam.fallon@est.tech>
2018-11-01Upgrade Jython for security, add doc warningliamfallon2-2/+8
Upgrading Jython to use a full release version. This will probably noit remove security problem but upgrades Jython to the most popular version. A warning is added telling developers to check extra pcakages in the Jython plugin documentation. Issue-ID: POLICY-1065 Change-Id: I83275204c1905bd48dd5ea58e98dcbbd9c47195f Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-10-31Set new master version for Dublinliamfallon6-18/+12
Issue-ID: POLICY-1232 Change-Id: If43c40e9e13bd9387e2b6ee876717f8413a17e34 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-10-24Fix refering to snapshot in policy/apex-pdp2.0.1ramverma6-6/+6
Issue-ID: POLICY-1213 Change-Id: I9187462aa470cff6ca7adc750c8a666bf8e15429 Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
2018-09-22Fix sonar problems in Apexliamfallon2-36/+61
Fixed some easy to resolve Sonar issues. Issue-ID: POLICY-1034 Change-Id: Ia8e4606bd4307daca499b4a74c96135211e572fd Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-09-19Fix license issue with Hibernate dependencyliamfallon1-1/+1
Change-Id: I0f0ce81661c505a7df4b6199c6d0baf7a9d0ce3e Issue-ID: POLICY-1059 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-09-18remove license issuesliamfallon1-0/+24
Change the versions of some second order dependencies to mitigate license issues. Change-Id: I39745ec1eb7c72fb481a4adafc2805e4bbbd8386 Issue-ID: POLICY-1059 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-09-16Fix Sonar issues in apexliamfallon3-3/+3
Fixing various Sonar issues in apex. Issue-ID: POLICY-1034 Change-Id: Ie693637d75bd7e38c71b7ba04886fb75636276ed Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-09-14Try new version of JRubyliamfallon1-30/+2
We had to use an old versino of JRuby due to security issues. A new version of JRuby was released in May, it seems to have a lower vulnerability level when tested using the "pom" test. Raising this review to check it in CLM. Change-Id: I77bf8bae4f7efe66d7e244d0ff9a52432b00a5ce Issue-ID: POLICY-1065 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-09-13Sonar/Checkstyle in service/pluginsliamfallon16-70/+75
Sonar and Checkstyle changes in plugins and services, and knock on changes Issue-ID: POLICY-1034 Change-Id: Iff7df74e54fce2c661dcc2fae75ae93d4cacfe5b Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-09-06Fix package of apex examples and documentsliamfallon1-6/+2
The examples are not packaged correctly in the apex build and the client wars are missing The links and location of the documents are corrected. Some POM duplicate dependencies removed. Javadoc warnings removed. Issue-ID: POLICY-867 Change-Id: I555c29191c61c0a9887365d95005dbc584eddf04 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-09-04Merge "Fix checkstyle issues in apex model basic"Jorge Hernandez14-68/+68
2018-09-04Dependency version changes for securityliamfallon1-2/+2
Versions of Jython and hazelcast changed to more secure versions. Change-Id: Iad918705170846b8813512c4bd8087ba429f6e82 Issue-ID: POLICY-1065 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-09-04Fix checkstyle issues in apex model basicliamfallon14-68/+68
CHeckstyle issues in apex model basic and knock on changes in other apex modules. Issue-ID: POLICY-1034 Change-Id: I65823f5e2e344526abc74b0812877113acb056ec Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-08-20Updating docs for Plugins moduleDinh Danh Le6-24/+0
Change-Id: Ia0837cf2f86c42eea71c3f71e8cd99d684912485 Signed-off-by: Dinh Danh Le <dinh.danh.le@ericsson.com> Issue-ID: POLICY-867
2018-08-05Adding Apex docs for Plugins moduleDinh Danh Le36-1/+1158
Change-Id: Icf68473b472a5896972de5b07b275682a77a1c9f Signed-off-by: Dinh Danh Le <dinh.danh.le@ericsson.com> Issue-ID: POLICY-867
2018-07-10Change JNR and DOM4J license versionsliamfallon1-0/+22
Change the JNR and DOM4J licenses to versions that are approved by the Linux Foundataion. Issue-ID: POLICY-905 Change-Id: I11fb2356bf90db27d16fe57ab70a910dac09459b Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-07-10Adding executor integration testswaqas.ikram3-12/+12
Change-Id: I292315164fbfb3650f6d21ede6edb264a7fd8ee3 Issue-ID: POLICY-865 Signed-off-by: waqas.ikram <waqas.ikram@ericsson.com>
2018-07-10Change JRuby and Websocket versionliamfallon1-1/+1
Change the versions of JRuby and Java Websockets to versions that are approved by the Linux Foundation. Issue-ID: POLICY-905 Change-Id: I804ab1e9871bb573647035f47e674f472aba5528 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-07-06Fix Javadoc errorsliamfallon1-3/+3
Path changes and changes due to mitigation of security violations caused some links in the Javadoc not to work any more. This changes fixes the javadoc. Issue-ID: POLICY-954 Change-Id: Ic9db2627fb1ffad69c8acadc7b975bc40864caaf Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-06-26Upgrade version of Jython to remove vulnerabilityliamfallon4-5/+8
Upgrade version of Jython from 2.2.1 to 2.7.1 to fix security vulnerability. Change-Id: I605b02483431b057f0ffa6017a5726ef8e1834d3 Issue-ID: POLICY-905 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-06-21Reduce level of vulnerability on JRuby pluginliamfallon1-3/+17
The JRuby plugin was using an old version of JRuby. The version of JRuby is updated to the latest version, which reduces the security vulnerability level. Some JRuby libraries that are not used in the APEX PDP and that themselves have security vulnerabilities are excluded. Issue-ID: POLICY-905 Change-Id: I1c9d40c505849d8cab2778a4993dec9148504599 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-06-11Adding plugin-executor module to apex-pdpramverma25-33/+2022
Change-Id: I711eaaff3707aa6398c26f1a124fedeb1d0e11f4 Issue-ID: POLICY-862 Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
2018-06-08Adding plugins-event module to apex-pdpramverma7-0/+552
Adding plugins-event module to apex-pdp Fix a minor bug in TextFileUtils Change-Id: I393c5f5809d078850d6669d22759ba9fa1b4f0e6 Issue-ID: POLICY-862 Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>