Age | Commit message (Collapse) | Author | Files | Lines |
|
The change in policy-models to use custom queries means that the named
queries used in apex examples must be updated to use custom queries.
This review is the first of two reviews to implement this change. I
thcnages the A&AI simulator, which will allow the apex-pdp to build
again. A further change will bring in the policy changes to get the
example implementation fixed.
Issue-ID: POLICY-2125
Change-Id: I833c351b43995e648288cdf1c87c0abbe7a671cc
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Change-Id: I73fad5bf76ed6b4979f5ab76013f204ea82da30b
Issue-ID: POLICY-2215
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
|
|
The changes in policy-models for appclcm had knock-on impacts on the
apex-pdp example policies. This patch fixes the vCPE policy to comply
with the new APPCLCM POJOs.
Issue-ID: POLICY-2043
Change-Id: Ieebc2cf97a05efde560a2f5a819924ff63dfd695
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
There is no need to have Jersey dependencies in the PDP POMs as they are
inherited from the policy-endpoints POM.
Issue-ID: POLICY-2209
Change-Id: I5c53e7b29f4df25fd730f7a521e149e4ee70d964
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Add a common version of Jersey for all Policy Framework components.
Issue-ID: POLICY-2209
Change-Id: I6282bc9938cbb63ddf3bf85e488f7b6be0dbdfc3
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
The APPC implementation was changed in a recent review, this review
fixes the apex vcpe example to use this new model.
Also fixes an an issue in the CLI editor where escape characters are not
now required in example JSON.
Issue-ID: POLICY-2043
Change-Id: Id251948c9de27f73ba48cec498e68a43f71c4062
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Issue-ID: POLICY-1915
Change-Id: I8702a8b54e158dfd0ac08140ca083f14f23963a2
Signed-off-by: Henry.Sun <henry.a.sun@est.tech>
|
|
Change-Id: I30e7d162a2aecdfe5c51e920b48d659130ae74e4
Issue-ID: POLICY-2127
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
|
|
Also added defaultbranch to the .gitreview file to make it easier
to change it when apex-pdp is branched in the future.
Issue-ID: POLICY-2045
Signed-off-by: jrh3 <jrh3@att.com>
Change-Id: Ib2570fd395aae38862299f2193b07ab06e32ace5
|
|
Issue-ID: POLICY-1965
Signed-off-by: jrh3 <jrh3@att.com>
Change-Id: Icd437f10c4d991030652ffa1abf48b7b5738145c
|
|
Added integration test that sets properties in a dummy plugin and amends
them in tasks in a policy. Variosu tests added to check combinations of
where properties are set in plugins or in tasks or both.
Implementaiton changed to:
- Always pass in a Properies object, the properties object coming into
the policy cannot be null because the task/TSL/SFL may wish to set it
- Fix a bug where the properties were not passed from the ApexEvent to
the engine event in the ApexEventUnmarshaller class
Issue-ID: POLICY-1743
Change-Id: I6aa152b28d46cf3cc6fa56a1a95b76a8e55f5a49
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
|
|
Use lombok on fields in EnEvent.
Remove unnecessary code in BBS WebClient class
Address Sonar issue in Execurot class
Issue-ID: POLICY-1791
Change-Id: If07dc4529b121f8bfcd6ab1ae6c9def4774f9f4d
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Released 2.2.0
Issue-ID: POLICY-1737
Change-Id: I144a3c07d3eaf8c53d339eecedf2b3d8d3ce3c7e
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Copyright headers not changed as this review only amends comments.
Issue-ID: POLICY-1791
Change-Id: Icbeb2c6e591b3b160ae102bb67aef2d407924a4d
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
BBS Java code introduced Sonar issues, these are resolved.
Also fixed checkstyle errors in other classes.
Also fiexed "unexpected type" eclipse errors.
Issue-ID: POLICY-1791
Change-Id: I3931051f0944c6d53745c8dd1db7cca4ee118f1c
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Enable maven-checkstyle-plugin in apex-pdp/pom.xml to fail the build at warning level.
Fix all the existing check style issues in the component.
Change-Id: I4de9c1bd9ca5a2876de9086d2d3526cbdc25c080
Issue-ID: POLICY-1732
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
|
|
Issue-ID: POLICY-1835
Signed-off-by: s00370346 <swarup.nayak1@huawei.com>
Change-Id: I47473444b58fa3b064ba142ce13c5e3520adb8c7
|
|
Issue-ID: POLICY-1831
Signed-off-by: s00370346 <swarup.nayak1@huawei.com>
Change-Id: Ib1e60287c6209e1f16764d071e28facc75a12c6e
|
|
Issue-ID: POLICY-1747
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: Iba1c6a80917a37cc63e2250a32df40046df9ee4f
|
|
Issue-ID: POLICY-1630
Change-Id: I6dfce7eb33d9bc41caabf6b8842377b486de672d
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Issue-ID: POLICY-1734
Change-Id: I8d209afb67e9b46a7db516fce76977e679d7ab7b
Signed-off-by: s00370346 <swarup.nayak1@huawei.com>
|
|
Issue-ID: DCAEGEN2-1237
Change-Id: Ibc1b5a221af5eb28799764498b2751d99f5764f3
Signed-off-by: s00370346 <swarup.nayak1@huawei.com>
|
|
Issue-ID: DCAEGEN2-1237
Change-Id: I739f8e55113793f5cd4d3b70e0a1296d775bb414
Signed-off-by: s00370346 <swarup.nayak1@huawei.com>
|
|
|
|
This review removes more links to the Zookeeper version 3.5.4-beta with
Zookeeper version 3.4.14.
It also replaces the Derby in-memory database with the H2 in memory
database for unit tests.
Issue-ID: POLICY-1540
Change-Id: Ic44f2e866644114b7c0cf66aac7e528017b8206b
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Issue-ID: DCAEGEN2-1237
Change-Id: I81831f6498b6c47c0a43215e0445c791b12dac6e
Signed-off-by: s00370346 <swarup.nayak1@huawei.com>
|
|
This review uses POJOs rather than Avro schema to unmarshal
and marshal events from and to DMaaP.
The POJO classes for interacting with DMaaP have been moved into
a common policy module.
This review is now ready for full review (finally!).
Issue-ID: POLICY-954
Change-Id: Ibb89d8af5b9006821e6a0a756e16bbe3815af15a
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: Liam Fallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
APEX rejects all HTTP responses except 200. This change accepts
any HTTP 2xx response code as a valid response.
Issue-ID: POLICY-1289
Change-Id: Ief681ba4dac1ef3ff5f257dd931569bd2274d017
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Existing context is cleared when a model upgrade is carried out
on an Apex PDP. The clear() method is called in error on the
Apex engine during the upgrade.
This change also has some small updates to the DecisionMaker example,
which is used to test this feature.
Issue-ID: POLICY-1395
Change-Id: I547a3a60712d1572d9daadf5eab4afcae2a5c321
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Added an example of how to configure HTTPS for an Apex policy.
Issue-ID: POLICY-1222
Change-Id: Iea8a8accac32f6d25c64a8324e202ad5e6221c7a
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Some minor line length and formatting checkstyle warnings fixed.
Change-Id: Ib92069bbdb444560083e6d0dbf5d16a3ab824d82
Issue-ID: POLICY-1074
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Remove unused imports
Add @FunctionalInterface annotation
Reduce the complexity of some methods
Change-Id: If519c31b113233361fbb935121fe6494263ac957
Issue-ID: POLICY-1074
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Make test classes name consistence by putting 'Test' at end
Issue-ID: POLICY-1263
Change-Id: I0179388d84826e698276a1995dd8173a40b5fd2b
Signed-off-by: Parshad Patel <pars.patel@samsung.com>
|
|
There were many copies of test policies and examples
strewn through the Apex unit tests. This change cleans
up the unit tests so that a single version of all example
policies is used in all tests.
Also added a new relative file root command line parameter
to Apex to allow the root of relative paths in configuration
files to be set.
Apologies for the size of this review but unfortunately
all of this must be done in one shot.
Issue-ID: POLICY-1252
Change-Id: Ibbb18fbf18e3897a1c61301d0a65e62bc643a0e9
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
Issue-ID: POLICY-1232
Change-Id: If43c40e9e13bd9387e2b6ee876717f8413a17e34
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
Issue-ID: POLICY-1213
Change-Id: I9187462aa470cff6ca7adc750c8a666bf8e15429
Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
|
|
When the checkstyle changes were made in the java code
the .TRUE and .FALSE values were changed to .isTrue and
.isFalse to comply with checkstyle. THis change needs to
be propogated into example scripts.
Issue-ID: POLICY-103
Change-Id: I419b5f398ef4f43b1b877d52bbe4ec638870f31d
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
Although the Apex engine service is called by the policy engine
tests and the various interface tests, the test coverage on these
classes is not showing up in Sonar. In any event it is better
that specific JUint is done for them.
Issue-ID: POLICY-1034
Change-Id: I0028c7e5e870c18649870536cf3691fce2ab689c
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
Fixed some easy to resolve Sonar issues.
Issue-ID: POLICY-1034
Change-Id: Ia8e4606bd4307daca499b4a74c96135211e572fd
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
Checkstyle changes to some class names must be propgated
into example configurations and name changes meant some
examples were not being packaged.
Issue-ID: POLICY-1034
Change-Id: I5485fc2ffc22c496bbae9465e1c3b09c4feade97
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
Eclipse sonarlint does not check for exception dropping by default,
it must be configured. This commit addresses exception dropping in
apex.
Change-Id: I406838990b3424c2912124b25d7326502cacc96c
Issue-ID: POLICY-1034
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
Sweep through Apex codebase to fix most ceheckstyle and
straightforward sonar issues.
Issue-ID: POLICY-1034
Change-Id: I149d9a94ad893affc93573e8de5e3304b6bdde2d
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
Sonar and Checkstyle changes in plugins and services, and
knock on changes
Issue-ID: POLICY-1034
Change-Id: Iff7df74e54fce2c661dcc2fae75ae93d4cacfe5b
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
Checkstyle and sonar changes in the model, contexot
and core modules.
Issue-ID: POLICY-1034
Change-Id: I2d40bc877f3a548844470fc290fc89d63fa465ae
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
The install script for apex did not coreate the soft link for apex
correctly.
One of the example json files was named incorrectlu.
Issue-ID: POLICY-954
Change-Id: If7923e2287aebb956bd4bc9ed4b26b23a40d048b
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
The examples are not packaged correctly in the apex build
and the client wars are missing
The links and location of the documents are corrected.
Some POM duplicate dependencies removed.
Javadoc warnings removed.
Issue-ID: POLICY-867
Change-Id: I555c29191c61c0a9887365d95005dbc584eddf04
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
Change-Id: Iad533f3987792d8713426234f3277c1ef6b72284
Issue-ID: POLICY-1034
Signed-off-by: Dinh Danh Le <dinh.danh.le@ericsson.com>
|
|
CHeckstyle issues in apex model basic and knock on changes
in other apex modules.
Issue-ID: POLICY-1034
Change-Id: I65823f5e2e344526abc74b0812877113acb056ec
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
Switch parameter handling in apex to use
the ONAP PF common parameter service
Change-Id: Id318d19c726b18b1a69c630fa81ca7d695355e9c
Issue-ID: POLICY-954
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|