Age | Commit message (Collapse) | Author | Files | Lines |
|
Signed-off-by: Henry.Sun <henry.a.sun@est.tech>
Change-Id: I305771ddef42bd3032ad52f4c5ecd55b01ed5a1a
Issue-ID: POLICY-1914
Signed-off-by: Henry.Sun <henry.a.sun@est.tech>
|
|
A number of Java 11, checkstyle, and SONAR warnings have crept into the
Apex codebase over the last number of reviews. This change fixes those
issues.
Issue-ID: POLICY-1913
Change-Id: I2afd607e80f48323355380fb2fe5e048e18879f9
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Issue-ID: POLICY-2355
Change-Id: I67f0ca2ced9cbe37a3d00d9f312101e756454107
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
|
|
This class was moved to policy-common some time ago. Removing it in
apex-pdp.
Issue-ID: POLICY-1913
Change-Id: I982fbd799334b34f1526e19f339236b52205b91e
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
The laest Eclipse checkstyle version 8.26.0 does more thorough checking
and identified a number of small issues in the apex-pdp codebase. This
review fixes those issues.
Issue-ID: POLICY-1913
Change-Id: I30ba25e3e425c6d54c77f925e8da3ab841a8357c
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Issue-ID: POLICY-1861
Change-Id: Iccbdcbc5b5978305c56ab74c01a52a562697bee1
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
There is no need to have Jersey dependencies in the PDP POMs as they are
inherited from the policy-endpoints POM.
Issue-ID: POLICY-2209
Change-Id: I5c53e7b29f4df25fd730f7a521e149e4ee70d964
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Add a common version of Jersey for all Policy Framework components.
Issue-ID: POLICY-2209
Change-Id: I6282bc9938cbb63ddf3bf85e488f7b6be0dbdfc3
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Jquery 3.3.1 is embedded in jquery-ui 1.12.1. This review replaces the
embedded jquery with version 3.4.1. This change is to remove security
vulnerabilities in jquery 3.3.1.
Issue-ID: POLICY-2083
Change-Id: I132dd83d2fc5add7df9988e21c663c17c5993aeb
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Also added defaultbranch to the .gitreview file to make it easier
to change it when apex-pdp is branched in the future.
Issue-ID: POLICY-2045
Signed-off-by: jrh3 <jrh3@att.com>
Change-Id: Ib2570fd395aae38862299f2193b07ab06e32ace5
|
|
Unit tests introduced some checkstyle warnings, this review resolves
those warnings.
Issue-ID: POLICY-1942
Change-Id: I16438621c1db0adfbe70bc8b237d05bd7cc72697
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Issue-ID: POLICY-1962
Change-Id: Ic10b0edc9364624161f71935f51f4411fe67c882
Signed-off-by: ning.xi <ning.xi@est.tech>
|
|
Issue-ID: POLICY-1965
Signed-off-by: jrh3 <jrh3@att.com>
Change-Id: Icd437f10c4d991030652ffa1abf48b7b5738145c
|
|
Coverity-scan: CID-229736
Issue-ID: POLICY-1961
Signed-off-by: Artem Naluzhnyy <A.Naluzhnyy@samsung.com>
Change-Id: I6149f2c13d6721a5e026bf8ceb901c2d20913f82
|
|
Upgraded the versions of avro, jquery and jgroups to versions
in order to remove security vulnerabilities.
Issue-ID: POLICY-1074
Change-Id: I412b9c951b061b19e6ae6edacf7b3785d4c7869b
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Released 2.2.0
Issue-ID: POLICY-1737
Change-Id: I144a3c07d3eaf8c53d339eecedf2b3d8d3ce3c7e
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Copyright headers not changed as this review only amends comments.
Issue-ID: POLICY-1791
Change-Id: Icbeb2c6e591b3b160ae102bb67aef2d407924a4d
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Enable maven-checkstyle-plugin in apex-pdp/pom.xml to fail the build at warning level.
Fix all the existing check style issues in the component.
Change-Id: I4de9c1bd9ca5a2876de9086d2d3526cbdc25c080
Issue-ID: POLICY-1732
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
|
|
Issue-ID: POLICY-1747
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: Iba1c6a80917a37cc63e2250a32df40046df9ee4f
|
|
Issue-ID: POLICY-1630
Change-Id: I6dfce7eb33d9bc41caabf6b8842377b486de672d
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Change import line in all classes that use
the Assertions class, there are a lot of them.
Issue-ID: POLICY-1264
Change-Id: I8480264be4e36348b3fc63acf1bc36e9c9dd250b
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Issue-ID: POLICY-1074
Change-Id: I88dc888b2a374b38499241f578a36dd116e2b85b
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Make test classes name consitence by adding 'Support' or 'Dummy' at start of util or dummy type of test classes
Issue-ID: POLICY-1263
Change-Id: I1dc1a7f174660a90664ebdcff2ea79ed30aa465c
Signed-off-by: Parshad Patel <pars.patel@samsung.com>
|
|
Change-Id: Ibc07c20fa8ac1018443a3c061613fdaecc5efb83
Issue-ID: POLICY-1280
Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
|
|
Make test classes name consistence by putting 'Test' at end
Issue-ID: POLICY-1263
Change-Id: I0179388d84826e698276a1995dd8173a40b5fd2b
Signed-off-by: Parshad Patel <pars.patel@samsung.com>
|
|
Parent versions in some POMs only called on the test profile
were incorrect
Warnings in Eclipse on POM including from outside its project
are fixed
Some checkstyle fixes
Some javadoc warnings fixed
Issue-ID: POLICY-954
Change-Id: I640bc842dc79a9fa580015abb9a76c84a7845efe
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
There were many copies of test policies and examples
strewn through the Apex unit tests. This change cleans
up the unit tests so that a single version of all example
policies is used in all tests.
Also added a new relative file root command line parameter
to Apex to allow the root of relative paths in configuration
files to be set.
Apologies for the size of this review but unfortunately
all of this must be done in one shot.
Issue-ID: POLICY-1252
Change-Id: Ibbb18fbf18e3897a1c61301d0a65e62bc643a0e9
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
Issue-ID: POLICY-1232
Change-Id: If43c40e9e13bd9387e2b6ee876717f8413a17e34
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
Issue-ID: POLICY-1213
Change-Id: I9187462aa470cff6ca7adc750c8a666bf8e15429
Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
|
|
Removed PowerMock from tests becasue coverage of PowerMock is not counted
by JaCoCO. It was easier to remove PowerMock than to try and hack the build
get PowerMock coverage counted.
Issue-ID: POLICY-1034
Change-Id: Ifc3e1ff93b2bfcb5619a5af6dec320d2de992f87
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
Coverage for the client monitoring module.
Issue-ID: POLICY-1034
Change-Id: I6bb6dab26ce0572923c3d451a3b5f4745d40d088
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
Fixed some easy to resolve Sonar issues.
Issue-ID: POLICY-1034
Change-Id: Ia8e4606bd4307daca499b4a74c96135211e572fd
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
Issue-ID: POLICY-1034
Change-Id: Ifa08c7a31b4fe19eb62c2035b67b6f5cad313b5f
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
Change-Id: If12bd289d9c8a22b86b4a9c9bff21c1a9d42a3d1
Issue-ID: POLICY-954
Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
|
|
Fixing various Sonar issues in apex.
Issue-ID: POLICY-1034
Change-Id: Ie693637d75bd7e38c71b7ba04886fb75636276ed
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
Eclipse sonarlint does not check for exception dropping by default,
it must be configured. This commit addresses exception dropping in
apex.
Change-Id: I406838990b3424c2912124b25d7326502cacc96c
Issue-ID: POLICY-1034
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
Sweep through Apex codebase to fix most ceheckstyle and
straightforward sonar issues.
Issue-ID: POLICY-1034
Change-Id: I149d9a94ad893affc93573e8de5e3304b6bdde2d
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
Sonar and Checkstyle changes in plugins and services, and
knock on changes
Issue-ID: POLICY-1034
Change-Id: Iff7df74e54fce2c661dcc2fae75ae93d4cacfe5b
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
Checkstyle and sonar changes in the model, contexot
and core modules.
Issue-ID: POLICY-1034
Change-Id: I2d40bc877f3a548844470fc290fc89d63fa465ae
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
Fix checkstyle warnings in the apex mode
and knock on changes.
Issue-ID: POLICY-1034
Change-Id: I10537e4288e9cad5ef18165ed2cdc1d3ab3139c1
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
The examples are not packaged correctly in the apex build
and the client wars are missing
The links and location of the documents are corrected.
Some POM duplicate dependencies removed.
Javadoc warnings removed.
Issue-ID: POLICY-867
Change-Id: I555c29191c61c0a9887365d95005dbc584eddf04
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
CHeckstyle issues in apex model basic and knock on changes
in other apex modules.
Issue-ID: POLICY-1034
Change-Id: I65823f5e2e344526abc74b0812877113acb056ec
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
Change-Id: I820e70463e1715a342d78fa9d413638068a05125
Signed-off-by: Dinh Danh Le <dinh.danh.le@ericsson.com>
Issue-ID: POLICY-867
|
|
Change-Id: I3263a833cc9dd6d86afdf2ae53de0e53c92850c9
Signed-off-by: Dinh Danh Le <dinh.danh.le@ericsson.com>
Issue-ID: POLICY-1034
|
|
Common ResourceUtil class replaces specific one in APEX
Managed dependency version clashes removed in POMs
Dependency versions with security vulnerabilities changed for
zookeeper
kafka
infinispan
Change-Id: I3c4b367cb5556b2dc255ab62c84f85738165eb81
Issue-ID: POLICY-954
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
Changed the Console class to use logger only for printing stack trace,
as the class is meant to be used for CLI usage.
Changed the CLIParser to use Console class for printing messages.
Changed the client-editor to be hosted on localhost by default, to follow
the same what others clients (deployment, monitoring & client full) are doing.
Change-Id: I6565b4b35a93b3708b926bfee04d79ead6b5346e
Issue-ID: POLICY-954
Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
|
|
Minor change was needed in the .css file to correct a visual error.
Change-Id: If84a95c079b34e3395da0864ba4009fbd13640c9
Issue-ID: POLICY-954
Signed-off-by: Ronan Kenny <ronan.kenny@ericsson.com>
|
|
Change-Id: I7ecabd3705de4a5352d5a98d1ab3a01677172651
Issue-ID: POLICY-954
Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
|
|
The version of jquery used in the APEX client was old
and had a security vulnerability. THis review updates the
versino of jquery to a newere version that does not have
a vulnerability.
Issue-ID: POLICY-905
Change-Id: Iefa5202ca80ba03d3a6ab84a693fa8d3da21c536
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
Change-Id: I99290a3dec61b3ce0f4d5fd33d6b429d091b48ca
Issue-ID: POLICY-954
Signed-off-by: waqas.ikram <waqas.ikram@ericsson.com>
|