aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2018-10-08Remove Sonar Vulnerabilitliamfallon1-1/+1
The coverage review for teh Apex engine introduced a vulnerability flag in Sonar. This review fixes that vulnerability Change-Id: Ie90c61a22c79604513ff2393a768a22ec9542484 Issue-ID: POLICY-1034 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-10-08Merge "Unit test for Apex engine"Pamela Dragosh34-71/+3715
2018-10-07Unit test for Apex engineliamfallon34-71/+3715
Coverage for unit test of engie state and state machine handling. Added coverage of the facade and executor context classes Added coverage for executors Added coverage for the remainder of the core engine Issue-ID: POLICY-1034 Change-Id: I85c66005dfdffdf2b4ee5672473a3ae4823d0d9c Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-10-05JUnit for apex Admin Protocol listenerliamfallon9-13/+669
Added coverage for this package. i Issue-ID: POLICY-1034 Change-Id: I2e4b51983eec245eb9f105587d15f853656ce35a Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-10-05Fix sonar bugs in apex-pdpramverma2-2/+8
Change-Id: I1ab9b9d9b0b8d1655301959d7d6b9ab3cc87eba3 Issue-ID: POLICY-954 Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
2018-10-05Set pretty print on JSON creationliamfallon1-1/+1
Pretty printing was set off, making debugging of JSON messages more difficult. Issue-ID: POLICY-954 Change-Id: Ifcc32cdba822f2bfc105c99cc3dc85ee05a89f6f Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-10-04Fix creation of sub Avro itemsliamfallon7-30/+186
When an Avro object is created, nested sub avro objects are not created automatically. This change allows invocation of a method to create sub objects of Avro objects. Issue-ID: POLICY-954 Change-Id: Ie510867f2631ba6a8c6f5452c08aef5db67e8997 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-10-03Add unit test for core events and contextliamfallon12-24/+1287
This code is covered by feature testing but does not show up in Sonar. These unit tests give coverage on engine modules. Issue-ID: POLICY-1034 Change-Id: Ib7a288bcb9729ec88346cc8047e38f3a58f9a97c Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-10-03Add Unit Test for Admin Protocol messagesliamfallon19-111/+818
Issue-ID: POLICY-1034 Change-Id: Ie07d5036ab328ab51843694a3b2a6bac87920f2e Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-10-01Add JUnit for test conceptsliamfallon7-56/+984
JUnit test for test concepts. Issue-ID: POLICY-1034 Change-Id: Ia2cd896272d4278d842d19d21237edcdca54a1f8 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-10-01Refactor monitoring REST tests to remove PowerMockliamfallon4-43/+184
Removed PowerMock from tests becasue coverage of PowerMock is not counted by JaCoCO. It was easier to remove PowerMock than to try and hack the build get PowerMock coverage counted. Issue-ID: POLICY-1034 Change-Id: Ifc3e1ff93b2bfcb5619a5af6dec320d2de992f87 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-09-30Unit test for client monitoringliamfallon10-3/+759
Coverage for the client monitoring module. Issue-ID: POLICY-1034 Change-Id: I6bb6dab26ce0572923c3d451a3b5f4745d40d088 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-09-28Add JUnit for cli-codegenliamfallon4-0/+7269
The cli-codegen tool did not have any unit tests. Issue-ID: POLICY-1034 Change-Id: If9d3924adea703b165b360e314ea3cb417a91d21 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-09-28Add unit test for core distributionliamfallon11-134/+7673
JUnit for the batch deployer and deploy facade. Issue-ID: POLICY-1034 Change-Id: I3959578ba8666d64b48bbe4ee9aeab27b92d77ae Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-09-27Unit test for core deploymentliamfallon8-61/+476
This module was not covered by unit test. Issue-ID: POLICY-1034 Change-Id: I700d43c0bde58c2b236f46994f380e20116418d9 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-09-27Add JUnit for web service client toolliamfallon6-59/+283
JUnit, SOnar fixes, and some minor bug fixes. Issue-ID: POLICY-1034 Change-Id: I72f46e944051f7d65d6b106afe33c759975283af Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-09-27Add missing example policy models to installliamfallon2-2/+29
The policy models for the decision maker, periodic, and vCPE examples were not included in the install because the policy model json files are generated from CLI commands. THis review installs the generated policy models. Issue-ID: POLICY-954 Change-Id: Ie2076ddfb6199dac0c8b272de8d7c47f1652485e Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-09-27Add unit test for Apex command line toolsliamfallon21-128/+23036
THere was no unit test for the command line tools. This review adds unit test and also fixes a few small bugs that showed up when uit test was run. Issue-ID: POLICY-1034 Change-Id: Ic19aacdb168fb5a6faa0cd83ed22ccfcedaa51f5 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-09-26Allow custom JSON adapter specificationliamfallon13-95/+822
In order to decode and encode complex Java POJOs with GSON, type adapters must be specified. This change allows specification of GSON type adapters for decoding and encoding of JSON in apex. Issue-ID: POLICY-954 Change-Id: Ib402d4e82c4f22fa4d532c016f77fb8e7bb568d3 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-09-26Fix boolean constants in examplesliamfallon26-60/+60
When the checkstyle changes were made in the java code the .TRUE and .FALSE values were changed to .isTrue and .isFalse to comply with checkstyle. THis change needs to be propogated into example scripts. Issue-ID: POLICY-103 Change-Id: I419b5f398ef4f43b1b877d52bbe4ec638870f31d Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-09-26Add JUnit for engine serviceliamfallon14-812/+9267
Although the Apex engine service is called by the policy engine tests and the various interface tests, the test coverage on these classes is not showing up in Sonar. In any event it is better that specific JUint is done for them. Issue-ID: POLICY-1034 Change-Id: I0028c7e5e870c18649870536cf3691fce2ab689c Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-09-25JUnit for evaluation test model generatorliamfallon4-4/+177
Issue-ID: POLICY-1034 Change-Id: Ic8f9971d612dd5500c73f95e5cbbb786c5ad51f3 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-09-25Fix sonar issues in Command line editorliamfallon4-168/+258
THe Apex command line editor had issues in teh way its loops for processing commands were written. The loops are simplified in this review. Issue-ID: POLICY-1034 Change-Id: If684a57de79bd56211e1ca3e8c446bd9698666be Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-09-23Fix more sonar issuesliamfallon2-138/+248
These are the last few easy to fix issues. Most remaining issues are to do with code coverage. Othersare due tot he way script interpreters work and will have to be exempted. Issue-ID: POLICY-1034 Change-Id: Ie1d1def43d33ef78a13d7f9b43ae4e22ef00cb5b Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-09-22Fix sonar problems in Apexliamfallon51-541/+956
Fixed some easy to resolve Sonar issues. Issue-ID: POLICY-1034 Change-Id: Ia8e4606bd4307daca499b4a74c96135211e572fd Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-09-20Fix bug with POJO events in APexliamfallon24-94/+1511
When an envet should be decoded entirely into a POJO and is too complex for Avro, apex decoding breaks. This reviuew fixes thsi issue. Issue-ID: POLICY-1034 Change-Id: Iccd739c4bb5c1645a2a7165f5bbfdfd4b964d79e Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-09-20Refactor Editor REST servletliamfallon38-2089/+3551
Issue-ID: POLICY-1034 Change-Id: Ifa08c7a31b4fe19eb62c2035b67b6f5cad313b5f Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-09-19Fix examples broken by checkstyle changesliamfallon27-59/+59
Checkstyle changes to some class names must be propgated into example configurations and name changes meant some examples were not being packaged. Issue-ID: POLICY-1034 Change-Id: I5485fc2ffc22c496bbae9465e1c3b09c4feade97 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-09-19Fix license issue with Hibernate dependencyliamfallon1-1/+1
Change-Id: I0f0ce81661c505a7df4b6199c6d0baf7a9d0ce3e Issue-ID: POLICY-1059 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-09-18Merge "remove license issues"Pamela Dragosh6-17/+64
2018-09-18remove license issuesliamfallon6-17/+64
Change the versions of some second order dependencies to mitigate license issues. Change-Id: I39745ec1eb7c72fb481a4adafc2805e4bbbd8386 Issue-ID: POLICY-1059 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-09-18Fix issue in apex client editorramverma1-2/+2
Change-Id: If12bd289d9c8a22b86b4a9c9bff21c1a9d42a3d1 Issue-ID: POLICY-954 Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
2018-09-17Fix sonar issues in apex utiltiesliamfallon8-179/+314
This change fixes Sonar issues in apex command line utilities. Issue-ID: POLICY-1034 Change-Id: Ib63a3d4107260c5909405e6f0d899279da869028 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-09-17Merge "Re-implement Kafka tests that periodically fail"Jorge Hernandez9-230/+107
2018-09-16Fix Sonar issues in apexliamfallon56-335/+352
Fixing various Sonar issues in apex. Issue-ID: POLICY-1034 Change-Id: Ie693637d75bd7e38c71b7ba04886fb75636276ed Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-09-15Re-implement Kafka tests that periodically failliamfallon9-230/+107
The Kafla integration tests fail, this change re-implements the tests using a test framework from salesforce.com i Issue-ID: POLICY-1034 Change-Id: Iffcc9e0a9f419c8ec439771be7a7a58faa2f9860 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-09-14Fix exception not logged or rethrownliamfallon50-202/+318
Eclipse sonarlint does not check for exception dropping by default, it must be configured. This commit addresses exception dropping in apex. Change-Id: I406838990b3424c2912124b25d7326502cacc96c Issue-ID: POLICY-1034 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-09-14Merge "Try new version of JRuby"Pamela Dragosh1-30/+2
2018-09-14Merge "Address sonar/Checkstyle Issues"Jorge Hernandez154-2547/+4095
2018-09-14Try new version of JRubyliamfallon1-30/+2
We had to use an old versino of JRuby due to security issues. A new version of JRuby was released in May, it seems to have a lower vulnerability level when tested using the "pom" test. Raising this review to check it in CLM. Change-Id: I77bf8bae4f7efe66d7e244d0ff9a52432b00a5ce Issue-ID: POLICY-1065 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-09-14Updated examples for renamed parameter classesmmis26-59/+59
Parameter classes were renamed to correct camel case names, hence the references to those parameter classes in the example config files needs to be updated Issue-ID: POLICY-1034 Change-Id: Ie388d6e25cf4bbec6984d4386cdeb19a7a3916c0 Signed-off-by: mmis <michael.morris@ericsson.com>
2018-09-13Address sonar/Checkstyle Issuesliamfallon154-2547/+4095
Sweep through Apex codebase to fix most ceheckstyle and straightforward sonar issues. Issue-ID: POLICY-1034 Change-Id: I149d9a94ad893affc93573e8de5e3304b6bdde2d Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-09-13Sonar/Checkstyle in service/pluginsliamfallon257-2276/+3481
Sonar and Checkstyle changes in plugins and services, and knock on changes Issue-ID: POLICY-1034 Change-Id: Iff7df74e54fce2c661dcc2fae75ae93d4cacfe5b Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-09-12Sonar/Checkstyle in model/context/coreliamfallon112-1878/+1947
Checkstyle and sonar changes in the model, contexot and core modules. Issue-ID: POLICY-1034 Change-Id: I2d40bc877f3a548844470fc290fc89d63fa465ae Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-09-12Merge "Fix soft stop and start of engine"Pamela Dragosh7-118/+203
2018-09-12Fix soft stop and start of engineliamfallon7-118/+203
Stopping an apexc engine is a soft stop, allowing the engine to be restarted again. However, when a model upgrade is carried out the engine must be stopped and cleared to clear the previous model, loaded with the new model and started again. THis handling must work over the Web Socket admin interface and also when apex is started as a service. This change fixes the handling so that it is consistent and works the same when apex is stopped/started/upgraded from the command line or over the management web socket interface Issue-ID: POLICY-1101 Change-Id: I1fe619641cb6ecd34d0669b4b7df105280e5e2c0 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-09-12Fix build failsliamfallon3-2/+4
Apex end to end tests often fail because the tests are not tuned correctly for Jenkins. The JRuby test needs a delay to allow the first test to completely clear dowm The volume of events sent in the Kafka tests is reduced from 100 to 10 The dom4j version is also changed back to 1.6.1 because 1.6 has the same security issues. Issue-ID: POLICY-954 Change-Id: Id38bf9fe526942870181bfd9c0762f0a471c0c02 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-09-12Merge "Updated example config for CSIT test"Liam Fallon1-4/+4
2018-09-11Use parent version of websocketliamfallon2-2/+0
Two conflicting versions of the websocket library were being used, causing an exception to be thrown on apex shutdown. Using the common version of websocket solves this issue. Issue-ID: POLICY-954 Change-Id: Id1a004b1f09931b53ec389c776f74c58f7b29e99 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-09-11Merge "Fix install script/examples on apex"Pamela Dragosh6-17/+17