aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2022-02-11Remove apex-pdp unused core modulesliamfallon162-5951/+55
This is the final review in the refactoring of the model code in apex-pdp. The core-messaging and core-infrastructure modules are unused in apex-pdp except for websocket communication. Websocket communication is also not used in any deployment. This review: - removes the core-mesaging module, which had an apex-specific websocket implementation, except for the MessageException class, which is moved to the base core module - removes the core-infrastructure module, except for the ThreadUtils class, which is moved to the base core module - removes the websocket event protocol, which used core-messaging but is not used in any deployment - collapses all three "core" submodules into a single module - Updates dependencies where needed Issue-ID: POLICY-1820 Change-Id: Ieae30063e99570e61943372d3fa23b77a211462c Signed-off-by: liamfallon <liam.fallon@est.tech>
2022-02-10Collapse apex-pdp maven model submodulesliamfallon225-777/+43
This review collapses all the code in six podel submodules into a single model module. There are no code changes, just files moved around. This change reduces the complexity of the code structure and speeds up the build. Issue-ID: POLICY-1820 Change-Id: Ifb644e8ec85ae6d0987378f4616fbc8a8858a9a8 Signed-off-by: liamfallon <liam.fallon@est.tech>
2022-02-10Merge "rename metrics as per global constants for prometheus"Liam Fallon6-71/+82
2022-02-09rename metrics as per global constants for prometheusRashmi Pujar6-71/+82
Issue-ID: POLICY-3760 Signed-off-by: Rashmi Pujar <rashmi.pujar1@bell.ca> Change-Id: I0fb59e8d9c95fd81a1754bb769705ef753b9022d
2022-02-09Merge "Remove JAXB and XML, use GSON for JSON"Jorge Hernandez160-25576/+28120
2022-02-08Remove JAXB and XML, use GSON for JSONliamfallon160-25576/+28120
This review converst apex-pdp to use GSON for JSON handling. In order to preserve backward compatibility with the JAXB format of JSON, custom handling of maps was required. Therefore, the policy-common StandardCoder could not be used. There are a lot of small changes, removing annotations from concepts and tweaking of test data. However, this cleans up the code base so it is worth doing. Issue-ID: POLICY-1820 Change-Id: I213fa64f6d7f3f1df8d10f111d9fbedbe80f9fe0 Signed-off-by: liamfallon <liam.fallon@est.tech>
2022-02-07Expose APEX policy execution metricsRashmi Pujar1-2/+42
Testing of these metrics will be covered in CSIT. Issue-ID: POLICY-3845 Signed-off-by: Rashmi Pujar <rashmi.pujar1@bell.ca> Change-Id: I8aed49d113f071ab33691f8cf1df624f3358386a
2022-02-04Remove JPA annotations from apex-pdp codeliamfallon35-602/+49
This review is part of a series of reviews to move the apex-pdp state machine model to use the base model types in policy models. Persistence of policies for apex-pdp is now implemented in PAP and API. The historic direct load and save functionality for APEX policy state machine models to and from databases is no longer used and no longer supported. This commit removes JPA annotations form apex-pdp code. Subsequent reviews will mvoe the mdoel across to use the policy models base model types. Issue-ID: POLICY-1820 Change-Id: I91a45a0ca6c88f9ba4b201bad920065f95ffb31e Signed-off-by: liamfallon <liam.fallon@est.tech>
2022-02-03Remove direct DB Load/Save from apex-pdpliamfallon64-4137/+265
This review is part of a series of reviews to move the apex-pdp state machine model to use the base model types in policy models. Persistence of policies for apex-pdp is now implemented in PAP and API. The historic direct load and save functionality for APEX policy state machine models to and from databases is no longer used and no longer supported. This revmoves the DAO code from apex-pdp and the associated handling and test code. The next review will remove the JPA annotations. Subsequent reviews will mvoe the mdoel across to use the policy models base model types. Issue-ID: POLICY-1820 Change-Id: Iabf034b40a413d32fe62091fe3446f52ec30d3af Signed-off-by: liamfallon <liam.fallon@est.tech>
2022-01-27Remove references to MariaDB from resource fileswaynedunican3-26/+44
Issue-ID: POLICY-2086 Change-Id: If38af6a319211c96f8be94f32551dc00b91d6ed1 Signed-off-by: Wayne Dunican <wayne.dunican@est.tech>
2022-01-26Merge "Fix intermittent build test error"Liam Fallon1-2/+2
2022-01-25Fix intermittent build test errorsaul.gill1-2/+2
Error visible intermittently in CLM builds Changed running order of assertions to fix Intermittent error no loger observed Issue-ID: POLICY-3893 Change-Id: I27e2c33f298e10f8b9dda85a015258db105043b7 Signed-off-by: saul.gill <saul.gill@est.tech>
2022-01-25Merge "Add TOSCA policy status header field to APEX event create CLI"Liam Fallon42-183/+439
2022-01-24Add TOSCA policy status header field to APEX event create CLIRashmi Pujar42-183/+439
In order to expose the processing status of a TOSCA policy to APEX-PDP, a new header field for APEX concept "event" has been introduced to track this within an APEX policy implementation. This field will be leveraged to extract the TOSCA policy execution metrics. Note, that the field is marked as optional for backward compatibility. Unit tests have been augmented to test for the field wherever applicable and the default empty value is retained for the others. "example-grpc" module has been updated to include this field. Exposing the TOSCA policy execution metrics is outside the scope of this patch since the current changes are already very large owing to the atomic nature of the change introduced. Issue-ID: POLICY-3845 Signed-off-by: Rashmi Pujar <rashmi.pujar1@bell.ca> Change-Id: Ief6d70f9abcfc8414e10aa51a27815ee9028e4c8
2022-01-18Update to SECCOM recommended dependenciesliamfallon2-1/+18
SECCOM has issued a directive on which dependencies should be used, see this wiki page: https://wiki.onap.org/display/SV/Jakarta+Policy This is the policy parent review to comply with the SECCOM directive. Zookeeper is added as a test dependency, it is no longer pulled in as a transitive dependency by Kafka. Issue-ID: POLICY-3849 Change-Id: Id504b308cd4e806e9e2e9489842abf1a7f93b9dc Signed-off-by: liamfallon <liam.fallon@est.tech>
2022-01-12Add newline to end of POM fileliamfallon1-2/+2
If the new line is not there, then it breaks the release scripts because the line count is off. Issue-ID: POLICY-3835 Change-Id: Ie18070c844d8138b7c6eb4dd74b1c46cfe132846 Signed-off-by: liamfallon <liam.fallon@est.tech>
2022-01-12Merge "Prometheues metrics for APEX engine stats"Liam Fallon6-23/+234
2022-01-10Prometheues metrics for APEX engine statsRashmi Pujar6-23/+234
Issue-ID: POLICY-3846 Signed-off-by: Rashmi Pujar <rashmi.pujar1@bell.ca> Change-Id: I385446683372548f3fed6d609a9e85633ec2916d
2022-01-06Exclude log4j test dependencyliamfallon1-2/+6
There is a transitive test dependency in apex-pdp on log4j, doesn't show up in the CLM reports (because it is a test dependency). Removing the dependency. Issue-ID: POLICY-3862 Change-Id: Ic9121cf4405678efcf805f711ccb9f36269178d3 Signed-off-by: liamfallon <liam.fallon@est.tech>
2021-12-03Merge "Prometheus metrics for policy deploy/undeploy requests for APEX"Liam Fallon5-116/+54
2021-12-02Update snapshot and/or references of policy/apex-pdp to latest snapshotsliamfallon1-3/+3
*** This commit is generated by a PF release script *** policy/apex-pdp updated to its latest own and reference snapshots Issue-ID: POLICY-3827 Signed-off-by: liamfallon <liam.fallon@est.tech> Change-Id: Ifbca56e3e4f3d166e633a2c56f55615aa4bfec6b
2021-11-30Prometheus metrics for policy deploy/undeploy requests for APEXRashmi Pujar5-119/+57
Added counters for: - Policy deploy/undeploy requests total - Policy deploy/undeploy successful requests total - Policy deploy/undeploy failed requests total Cleaned up unused method resetAllStatistics. Fixed some checkstyle warnings Update to latest snapshot for parent, and common modules Depends on https://gerrit.onap.org/r/c/policy/parent/+/125974 for build to pass. Issue-ID: POLICY-3760 Change-Id: I4a9447c9caea7a018dba86057b9dae3871910709 Signed-off-by: Rashmi Pujar <rashmi.pujar1@bell.ca>
2021-11-29Update snapshot of policy/apex-pdp to 2.7.1-SNAPSHOTliamfallon81-81/+81
*** This commit is generated by a PF release script *** policy/apex-pdp is update from 2.7.0-SNAPSHOT to 2.7.1-SNAPSHOT Issue-ID: POLICY-3827 Signed-off-by: liamfallon <liam.fallon@est.tech> Change-Id: I334dda447490f6c3e848be7b58f4a5119ae70ead
2021-11-26Release docker images for policy/apex-pdp: 2.7.0liamfallon1-0/+8
*** This commit is generated by a PF release script *** This commit releases the docker images for repo policy/apex-pdp. Issue-ID: POLICY-3827 Signed-off-by: liamfallon <liam.fallon@est.tech> Change-Id: I97c7fdc4118f24c1f72b1028b7d734ccffd5ad7b
2021-11-26Release policy/apex-pdp: 2.7.0liamfallon1-0/+5
*** Release Phase 8: This commit is generated by a PF release script *** This is the eigth phase in releasing images, it releases policy/apex-pdp. Issue-ID: POLICY-3827 Signed-off-by: liamfallon <liam.fallon@est.tech> Change-Id: I4df10a4c1331f0f2309282743af8455001c8af9f
2021-11-25Update parent,common.models and docker referencesliamfallon1-1/+1
*** Release Phase 7: This commit is generated by a PF release script *** This is the seventh release phase, it updates parent, common and models references in policy/apex-pdp. Issue-ID: POLICY-3827 Signed-off-by: liamfallon <liam.fallon@est.tech> Change-Id: I501aab4ddf6dbf2ed6700f2ecbf7da80ecaadf3d
2021-11-25Update parent and common referencesliamfallon1-3/+3
*** Release Phase 7: This commit is generated by a PF release script *** This is the seventh release phase, it updates parent, common and models references in policy/apex-pdp. Issue-ID: POLICY-3827 Signed-off-by: liamfallon <liam.fallon@est.tech> Change-Id: I78c4e212e6c330d8a1549038f4c1ec47d6f2b4df
2021-10-25Point to snapshot dependencyRam Krishna Verma1-3/+3
Issue-ID: POLICY-3788 Change-Id: Ia18be8148b1565dff8cb240026ac0ccf280df169 Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2021-10-19HTTP code filter for RestClientProducerlapentafd3-8/+41
RestClient producer can now consider 2xx response status as success Issue-ID: POLICY-3743 Change-Id: I40c4dce01b437ea6b9f9bbc317835657cb7ebc8a Signed-off-by: lapentafd <francesco.lapenta@est.tech>
2021-10-14Bump policy/apex-pdp to Jakarta 2.7.0-SNAPSHOTa.sreekumar81-82/+82
Change-Id: I8ead26be4968b94980dcafd269c7ab32022b34d0 Issue-ID: POLICY-3696 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2021-10-14Bump policy/apex-pdp to 2.6.2-SNAPSHOTa.sreekumar81-81/+81
Change-Id: I0db6ab5efb0595cba86ce9cbaaafab88349818ff Issue-ID: POLICY-3696 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2021-10-14Release apex-pdp 2.6.1 docker artifactsa.sreekumar1-0/+8
Change-Id: I9cca081a9274922b79c87a1b0e8a96e66d9c4154 Issue-ID: POLICY-3696 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2021-10-13Release apex-pdp 2.6.1 maven artifactsa.sreekumar1-0/+5
Change-Id: Id9ab217d3623f0726840895e31cb0b1c8fd7fbc7 Issue-ID: POLICY-3696 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2021-10-13Update parent/common/models/docker referencesliamfallon2-4/+4
Issue-ID: POLICY-3696 Change-Id: If4c5290890639fdf99de37501a134f820c92696b Signed-off-by: liamfallon <liam.fallon@est.tech>
2021-10-08APEX-PDP S3P changes for Istanbula.sreekumar6-1310/+11102
Change-Id: I58f564ef19df39f2c0fff64a72c9f083faf88556 Issue-ID: POLICY-3655 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2021-09-15Bump apex-pdp to 2.6.1-SNAPSHOTa.sreekumar81-81/+81
Change-Id: Ie39d324e02a302b882318d46735a727322ce409d Issue-ID: POLICY-3587 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2021-09-15Release apex-pdp 2.6.0 docker imagea.sreekumar1-0/+8
Change-Id: I499837227ddf4ad3df0366763d4aa73c489db78a Issue-ID: POLICY-3587 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2021-09-15Release apex-pdp 2.6.0 maven artifactsa.sreekumar1-0/+5
Change-Id: I9a5887991442b40865be818fb876acea104de776 Issue-ID: POLICY-3587 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2021-09-13Use released common and modelsliamfallon1-2/+2
Issue-ID: POLICY-3587 Change-Id: I11a84934a1a0fc515bf0ae9af9105ba7df19549e Signed-off-by: liamfallon <liam.fallon@est.tech>
2021-09-09Remove blank line from INFO.yamlliamfallon1-1/+0
Issue-ID: POLICY-3587 Change-Id: If2a9cffb84f8b3d8117a4a9cb338cb1b8964b6cf Signed-off-by: liamfallon <liam.fallon@est.tech>
2021-09-09Point at released policy-parentliamfallon1-1/+1
Issue-ID: POLICY-3587 Change-Id: Iea42a1c281ffd3578a05e3601c0db9836c9d6dfc Signed-off-by: liamfallon <liam.fallon@est.tech>
2021-09-08Update INFO.yamlliamfallon1-11/+15
Update the INFO.yaml file with latest information. Issue-ID: POLICY-3552 Change-Id: Ic6842a0325f2f9d45fa769b75baefb0960e872e1 Signed-off-by: liamfallon <liam.fallon@est.tech>
2021-09-07Use managed version of commons-codecliamfallon1-6/+0
apex-pdp was using a very old version of commons-codec. This change enables it to use the version of commons-codec managed from policy parent. Issue-ID: POLICY-3590 Change-Id: Ic29e46b61107719df5aaad00ee923de056fe7bac Signed-off-by: liamfallon <liam.fallon@est.tech>
2021-09-02Fix sonar security issues in apex-pdpJim Hahn3-4/+5
Fixed sonar security issues: - set permissions of temporary files Issue-ID: POLICY-3093 Change-Id: I1dfc87f22975fa950cfcfc47196fad55d6cbf277 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-09-01Fix sonars in apex-pdp #3Jim Hahn13-36/+42
Fixed: - use "var" - use assertEquals instead of assertTrue(xxx.equals()) - separate assertions Issue-ID: POLICY-3093 Change-Id: Id4db62626948681cd267e68a56dda65fa355c6f8 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-08-31Fix sonar issues in apex-pdpRam Krishna Verma18-49/+64
Issue-ID: POLICY-3077 Change-Id: Id5e7c2ddada2bac3b73fe543f9adade6f9b83e6c Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2021-08-30Merge "Fix sonars in apex-pdp #2"Jim Hahn25-82/+83
2021-08-30Use latest policy-parent snapshotliamfallon1-1/+1
The parent snapshot enables the latest version of netty. Issue-ID: POLICY-3590 Change-Id: I273c7e25988f6190d761ba4300eb56c9f02e3cee Signed-off-by: liamfallon <liam.fallon@est.tech>
2021-08-27Fix sonars in apex-pdp #2Jim Hahn25-82/+83
plugins-events thru plugins-persistence-jpa-eclipselink Fixed: - use "var" - disambiguate method parameter types - rename parameter Issue-ID: POLICY-3093 Change-Id: Ife5897015be495403e731754d5862b803a217c87 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-08-27Address more sonars in apex-pdpJim Hahn32-153/+169
Fixed services-engine thru utilities. Fixed: - use "var" - use Files.delete() - only one method call in assert() Issue-ID: POLICY-3093 Change-Id: I6f62108c770c15e8b84bc51746066fefa409e0fc Signed-off-by: Jim Hahn <jrh3@att.com>