Age | Commit message (Collapse) | Author | Files | Lines |
|
Change-Id: I17e2e093421733fc94a3de8f5946b867b3b73ba9
Issue-ID: POLICY-3088
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
|
|
Issue-ID: POLICY-3069
Change-Id: Ib30782485652ec693d2dbea79514183c7cfbb0c4
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
|
|
Change-Id: I947207f10cfd3bc54193ee7c8d356ad40587f072
Issue-ID: POLICY-2526
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
|
|
Addressed the following issues:
- initialize mocks before use
- use parameterized queries
- Random() is not secure
- provide parameterized type for generics
- unused imports
- constructor visibility
- use compute() instead of containsKey()/put()
- make final fields static
- rename constants to all upper case
- no assert() in Thread.run() methods
- nested try
- nested if/else
- too many break/continue
- use try-with-resources
- repeatable annotations
- overlapping characters in reg ex
- hashcode is not sufficient in compareTo()
- need equals() with compareTo()
- make class an interface
- use parameterized test
- multiple calls in assert()
- log or re-throw
- use different type of lambda
- use parameterized logging
- use StringBuilder instead of concatenation
- use StandardCharsets.UTF_8
Issue-ID: POLICY-2906
Change-Id: I2cf8c885e3e22c2c6cbe6403a34906928afad022
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
The GsonXxxAdapters were removed from the models Serialization classes
and replaced with type adapters from common. Modified the code to refer
to the new adapters.
Without this fix, examples-onap-vcpe will not compile. Could that be
the cause of the apex-pdp standalone issue, POLICY-3066?
Allow TypeAdapter in lieu of JsonSerializer/Deserializer adapters in
config files.
Note: examples-ona-bbs refers to the following, which were removed
several releases ago (during the actor re-write?):
- appclcm.util.Serialization$RequestAdapter & Serialization$ResponseAdapter
Issue-ID: POLICY-2905
Change-Id: Ia57e0346343614cbd4a1cffd9c8393f207284244
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
The kafka_2.12 jar depends on jackson-module-scala, but the default
version does not work with the version of jackson used by policy.
Modified the dependency tree to include a version that does work.
Issue-ID: POLICY-3005
Change-Id: I06fd5b99d6e5c1053e17a754f22f815062f907b2
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
move csit to policy/apex-pdp repo
Issue-ID: POLICY-2895
Change-Id: I73bd2f59c09f4ae213cab9b1dd2a83e909b218c6
Signed-off-by: Taka Cho <takamune.cho@att.com>
|
|
This review fixes an issue identified during testing the changes done
for improving multiple policy handling in APEX.
Changes done to a few test files in the previous review are reverted as
well.
Change-Id: I98324da708239d314aadd4c45dc377137fd552ba
Issue-ID: POLICY-2883
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
|
|
This review makes the default URL and userid for JMS null, the actual
values must be specified as parameters.
Issue-ID: POLICY-3035
Change-Id: I9c06d94d8816092425e2df58b849d837ad953fb2
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
The default security credential of "password" was encoded in a constant
in the JMS plugin parameters file. This commit removes these credentials
and defaults the credentials to null.
Issue-ID: POLICY-3035
Change-Id: I6313340e64c893c4f99de78d9dd448ac53d81246
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Change-Id: Ic4adf5bd8876dc31fc93993298e90389baaa2c39
Issue-ID: POLICY-2883
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
|
|
|
|
Security vulnerabillitles were flagged in CLM in Hazelcast
version 3.11-BETA-1. Hazelcast version 4.1.1 removes that vulnerability.
The lock handling is slightly different in version 4.1.1 and the old
ILock class is removed. The code is updated to use the new FencedLock
locks.
Issue-ID: POLICY-2943
Change-Id: I0cb7d3cb279fed17b3f8758e55902703491f4b5c
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Change-Id: Ibf2cf19a1ec91473d8c655b87a712aa8738848c8
Issue-ID: POLICY-3003
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
|
|
Fixing the comments from previous review - https://gerrit.onap.org/r/c/policy/apex-pdp/+/116833
Issue-ID: POLICY-2885
Change-Id: I85474b365d92771e6e1b56bba95bde6e319d4ec2
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
|
|
Change-Id: If0c93bfea08025c6c10e3f4572a14088990f415f
Issue-ID: POLICY-2885
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
|
|
|
|
Change-Id: I88c8f2eea9cb295e422d20222df21a46ef84cd4e
Issue-ID: POLICY-2885
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
|
|
use jre base 2.2.0
Issue-ID: POLICY-2917
Change-Id: I75ae9f401c3665cfad6bc9657511e8c59fe09d02
Signed-off-by: Taka Cho <takamune.cho@att.com>
|
|
The policy models tosca classes ToscaPolicyIdentifier and
ToscaPolicyIdentifierOptVersion can be used to identify any TOSCA
concept, not just TOSCA policies so they are renamed to
ToscaConceptIdentifier and ToscaCinceptIdentifierOptVersion
respectively.
The class ToscaPolicyTypeIdentifier is redundant and is replaced by
ToscaConceptIdentifier.
Issue-ID: POLICY-2900
Change-Id: I5df89d023949cdf0f649951dbbd81a0b30f44ef6
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
|
|
Large volume exception messages should not be repeated in log messages
or in rethrown exceptions.
Jira-Link: https://jira.onap.org/browse/POLICY-2885
Issue-ID: POLICY-2885
Signed-off-by: gregory.hayes <gregory.hayes@est.tech>
Change-Id: I345531d3a7640cc5ad9dbfc367052b9c8cc19387
|
|
bash scripts convert to ash
Issue-ID: POLICY-2847
Change-Id: I4617223d4914820797f5ea121f75ee5f69a6ba40
Signed-off-by: Taka Cho <takamune.cho@att.com>
|
|
|
|
|
|
The Apex CLI editor closes its input and output when it completes. This is correct behaviour when the input and output are files. However, if the input and output are tied to standard input, output, and error then if there are subsequent actions in the JVM (Such as continuing to run Apex as we do in tests), then any output such as logging is lost.
This fix checks for standard input/output/error before closing the input
and output.
Issue-ID: POLICY-2897
Change-Id: Ifa20b62511f770197f30c4a817212a92876dd6a6
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
The JSON.stringify() call in the Rhino Javascript interpreter is not
working correctly. A previous patch introduced a method into the Apex
execution context to provide an alternative method for stringifying
JSON.
This patch updates the vCPE example in apex to use that new method.
Issue-ID: POLICY-2463
Change-Id: I85cc33dc4633b1b6f4c4db3d5ad8579c66d7c18c
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
The JSON.stringify() call in the Rhino Javascript interpreter is not
working correctly. A previous patch introduced a method into the Apex
execution context to provide an alternative method for stringifying
JSON.
This patch updates the gRPC example in apex to use that new method.
Issue-ID: POLICY-2463
Change-Id: I7f789c000d53dec60020fda2a6fccd71ef18edc3
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
The Rhino JSON.Stringify() method does not work well. This patch allows
the user to call schema specific or generic JSON conversion using the
schema handling in Apex or not as the developer chooses.
Added a single argument stringify2Json() method.
Issue-ID: POLICY-2463
Change-Id: I9ec1e0dea2f6cd153b73b2eace63d8806674884d
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Update to apexPdpStabilityTestPlan.jmx file
Issue-ID: POLICY-2831
Change-Id: I76764e0614a523f2e58df04eed01111c59623e09
Signed-off-by: waynedunican <wayne.dunican@est.tech>
|
|
Issue-ID: POLICY-2875
Change-Id: I8a7dbd9a1f8fbd88a94a85491304e0f75a05969c
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
|
|
Issue-ID: POLICY-2875
Change-Id: Ibb0e9a243bf92f0255cb5c145d31ccddb988fdf5
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
|
|
Change-Id: I5e2cd92ee3620dea4070d9fa3aeb5ffd65f9412c
Issue-ID: POLICY-2869
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
|
|
Change-Id: I08f7984cbc4f3b00f1720f21f27b6d019f90490e
Issue-ID: POLICY-2869
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
|
|
Change-Id: I57e11b3993c2b97450ba8cd82872bcce466c2ee5
Issue-ID: POLICY-2869
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
|
|
Issue-ID: POLICY-2869
Change-Id: I9880a3571da66390999f174ea2101a5e93280ac2
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
|
|
Apex documentation has now all been ported to use the ONAP recommended
rst format. This review removes the old asciidoc documents.
Issue-ID: POLICY-2824
Change-Id: I562bd344cb7d6ff36e7d54bdb8f95e3b656468f8
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Issue-ID: POLICY-2839
Change-Id: Ia7c847b3dafd28958d5df209af95cac19fa480a0
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
|
|
Issue-ID: POLICY-2839
Change-Id: I5b7ee8e97fd47896877e3eadc8ebb61e60b082fa
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
|
|
Issue-ID: POLICY-2839
Change-Id: I003109f4b999efaf57aba8a880f1800438baddf6
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
|
|
Issue-ID: POLICY-2839
Change-Id: Icb05b2c63cf760f8b8e02731e235041d7430a06e
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
|
|
The legacy operational policy type for apex has been removed in Guilin release.
Removing it fron supported policy type and other places in apex-pdp.
Issue-ID: POLICY-2857
Change-Id: I41d58bf7e82292e11ff752f61dbe9be96a8a7af4
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
|
|
Change-Id: I6ee50fb455424ae1f241b7a12d1cdbf0e6ee4011
Issue-ID: POLICY-2815
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
|
|
Issue-ID: POLICY-2827
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I7cde8197621ccc3d366baab952243c7b7894a29b
|
|
This review basically just removes all "policyModelFileName" occurences
which are not used anymore.
Change-Id: Ibac8ec776dd989a5d677ff27a99eb7a36110773f
Issue-ID: POLICY-2835
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
|
|
Issue-ID: POLICY-2819
Change-Id: I28b4c8acdef0302b6419a07c4445d60c398c4f73
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Change-Id: Idde5050b425eb1bebe312e80e795c21513367a1b
Issue-ID: POLICY-2789
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
|
|
Change-Id: Ief1025869ee480fe0d43063c2590d74c6de2c77d
Issue-ID: POLICY-2789
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
|