Age | Commit message (Collapse) | Author | Files | Lines |
|
The prepare() and cleanup() method were not called on state finalizers
for states. This review adds calls for them.
Issue-ID: POLICY-2450
Change-Id: I27aec4dea51f3e22b5922c04c7b7b974fca24292
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
|
|
Added tests to check threads start, execute, and stop correctly and
fixed JavescriptExecutor class to handle startup and shutdown correctly
without hanging.
Issue-ID: POLICY-2106
Change-Id: I9ab41023aae2ab1cbcaea53fdf5d48eccd90a2f1
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
When running the gRPC tests in a slow or overloaded environment, the
timeupts must be set longer.
Issue-ID: POLICY-2106
Change-Id: Id152f1f82ef47f646c7b0488b4486425c6816e31
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Issue-ID: POLICY-2378
Change-Id: Ie85ef583e8f0732a3b716b9e9b8947fb349522c7
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
|
|
Issue-ID: POLICY-2378
Change-Id: Iffbed4a039e9a645cc081f09997aeedf0dba4056
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Change-Id: I59b93fccb0f3a41f8db753d1e8e2978bbb51e9a0
Issue-ID: POLICY-2378
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
|
|
Change-Id: I7ad38253cab457f92912e17ea9eaf8300347f62e
Issue-ID: POLICY-2378
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
|
|
Change-Id: Id23e5c848b6a338f09bbaecbf89e184e4e9f4e4f
Issue-ID: POLICY-2378
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
|
|
This change ignores the tests that are hanging in Jenkins until the Apex
images are released. Once the images are released we'll fix these tests.
Issue-ID: POLICY-2106
Change-Id: I6a733896da044d3f24443ac202d6122a341db135
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
It is possible that the initiation and especially shutdown happens so
fast that the execution thread counts down the latch before the caller
calls await(), in which case the Javascript Rhino thread will hang. This
review adds a timeout on the await calls.
Issue-ID: POLICY-2106
Change-Id: Icfc6d4b478cca62522461c25d61ce9ee7328684a
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
This change:
- Removes separate packaging of the three clients
- Reduces the size of the combined client by suppressing unused
dependencies
- Removes the Servlet code from the Docker packaging
- Removes the client WARs from the docker package
Issue-ID: POLICY-2443
Change-Id: If0a0c2dddc3f05f2815b84ae04fcc029b1c4fe08
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
When a policy is loaded, a separate thread is spawned for each
Javascript script executor. This allows us to precompile the Javascript
scripts and also to have a larger stack available for script execution.
Issue-ID: POLICY-2106
Change-Id: I97323aafb623ba537ac1889b3c9504b345b4f67e
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Issue-ID: POLICY-2378
Change-Id: Ie1803786c6bbc636ef0f98a1c158aa17b6292e84
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Change-Id: I8361eb0cbe74c3548ca98f3005bc37f5a1f91747
Issue-ID: POLICY-2436
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
|
|
|
|
Issue-ID: POLICY-2424
Signed-off-by: aditya.puthuparambil <aditya.puthuparambil@est.tech>
Change-Id: I92491c904b65a0db93c9e6eaba676c653c276175
|
|
Issue-ID: POLICY-2402
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I6bd157d80a0aa1604e634ec561ee76e8197e97df
|
|
Some minor checkstyle and eclipse warnings have crept into the code in
the last few weeks. This review cleams them up.
Issue-ID: POLICY-1913
Change-Id: Ib5f103bc28c71a6c4db05ea05719eff41bb38914
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
|
|
|
|
All examples are converted to Rhino Javascript from Nashorn Javascript.
Issue-ID: POLICY-2106
Change-Id: Ia6fec5b57b1e6131799b4b069968e4766ce54c96
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
|
|
Change-Id: I21d9253f41eee9b958e8fb723f6c19f266502cef
Issue-ID: POLICY-1656
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
|
|
Minor changes to Javascript source for execution under the Rhino script
engine.
Issue-ID: POLICY-2106
Change-Id: Ib7e30ce0067a11ea1bb3ca8d197c796dba9ea091
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Issue-ID: POLICY-1913
Signed-off-by: aditya.puthuparambil <aditya.puthuparambil@est.tech>
Change-Id: Ic86e04776c9300e37134210cd9db5b6d7e6a5a9e
|
|
|
|
Integation unit tests resultd in StackOverflowException errors in the
Graal Javascript interpreter. Following extensive testing and
trouobleshooting, it proved very difficult to fix these issues in Graal
as the stck overflow errors were occurring in native class instantiation
methods being invoked by Grall on the JVM.
The alternative Rhino Javascript engine is developed by mozilla, and was
incorporated into the Java 6 JVM and evolved into Nashorn in the Java 8
JVM. Oracle dropped Nashorn in Java 11. However, in parallel, Rhino
development has continued.
This review brings in the Rhino javascript engine into apex-pdp as the
replacement for Nashorn and instead of Graal. Graal seems to be pretty
unstable as yet so we may bring it in in future releases but for now
Rhino is a more stable and reliable alternative.
Issue-ID: POLICY-2106
Change-Id: I0edeff3b0bee404b38e3ebe22001a6e3375a44dc
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Change-Id: Icb465fdcf5a580f599a111ed3c5d3510f5346f64
Issue-ID: POLICY-1913
Signed-off-by: aditya.puthuparambil <aditya.puthuparambil@est.tech>
|
|
|
|
Change-Id: Iee8fdca9f23b432188a61054fe177283fdddc1ba
Issue-ID: POLICY-1656
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
|
|
Change-Id: If76ddc860b67e0d8dcd4c48bacb5436ffc773faa
Issue-ID: POLICY-1913
Signed-off-by: aditya.puthuparambil <aditya.puthuparambil@est.tech>
|
|
|
|
|
|
|
|
Graal enforces Javascript more strictly than Nashorn does. This review
changes the tests in apex-pdp to comply with the stricter -Javascript
checking, re-enabling the integration test module.
- All log calls must be passed as strings, using toString()
- Byte/Float/Long Java types not supported in Javascript
Disable integration tests so that other changes can be brought in.
JMS integration test is disabled for now, it will be re-enabled in a
review shortly.
Issue-ID: POLICY-2106
Change-Id: I14bdb930eff735e862b51802cf72e4793cec3699
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Signed-off-by: Henry.Sun <henry.a.sun@est.tech>
Change-Id: I305771ddef42bd3032ad52f4c5ecd55b01ed5a1a
Issue-ID: POLICY-1914
Signed-off-by: Henry.Sun <henry.a.sun@est.tech>
|
|
Change-Id: I586153244dbd97a41e9b9d616ee9a84327b7c2da
Issue-ID: POLICY-1656
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
|
|
use common version
Issue-ID: POLICY-2381
Change-Id: Id231aa8709b3c4515fcac80b82d53fb8ed45eaf0
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
|
|
|
|
Change-Id: I8ac07eede6758c84a4a9ca505382f215d531cf47
Issue-ID: POLICY-1913
Signed-off-by: aditya.puthuparambil <aditya.puthuparambil@est.tech>
|
|
policy/docker is released.
Issue-ID: POLICY-2378
Change-Id: If3ed5a595f9e6138c18ed8d7386e07a776d7c903
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
This is the main review to switch out the Nashorn Javascript interpreter
and switch in the Graal javascript interpreter for apex Javascript
tasks.
The Graal Javascript dialect differs slightly from Nashorn in the way it
accesses information passed over from the Java world so Javascript
tasks need to be converted.
Subsequent reviews will convert the JUnit tests marked @Ignore in
previous reviews to this one and will convert the Javascript tasks into
a format Graal can handle. Subsequent reviews will also convert the
examples over to Graal format.
Issue-ID: POLICY-2106
Change-Id: Ief582a36539e8a87724c17fb7e56864d5e471c07
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
|
|
Change-Id: I5d01766ffb0104f632bebc9b553e7dca83b4829f
Issue-ID: POLICY-2364
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
|
|
|
|
A number of Java 11, checkstyle, and SONAR warnings have crept into the
Apex codebase over the last number of reviews. This change fixes those
issues.
Issue-ID: POLICY-1913
Change-Id: I2afd607e80f48323355380fb2fe5e048e18879f9
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Issue-ID: POLICY-1884
Change-Id: I7774dfdc7d7edcc0409a817bfd21ddacec21d085
Signed-off-by: ning.xi <ning.xi@est.tech>
|