aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2020-03-11Fix minor checkstyle/eclipse warningsliamfallon16-202/+142
Some minor checkstyle and eclipse warnings have crept into the code in the last few weeks. This review cleams them up. Issue-ID: POLICY-1913 Change-Id: Ib5f103bc28c71a6c4db05ea05719eff41bb38914 Signed-off-by: liamfallon <liam.fallon@est.tech>
2020-03-11Merge "Convert examples to Rhino Javascript format"Ram Krishna Verma51-3755/+367
2020-03-11Merge "Fixing the gRPC consumer side"Ram Krishna Verma5-83/+146
2020-03-11Convert examples to Rhino Javascript formatliamfallon51-3755/+367
All examples are converted to Rhino Javascript from Nashorn Javascript. Issue-ID: POLICY-2106 Change-Id: Ia6fec5b57b1e6131799b4b069968e4766ce54c96 Signed-off-by: liamfallon <liam.fallon@est.tech>
2020-03-11Merge "Sonar Security vulnerabilities fix"Ram Krishna Verma3-49/+58
2020-03-11Fixing the gRPC consumer sidea.sreekumar5-83/+146
Change-Id: I21d9253f41eee9b958e8fb723f6c19f266502cef Issue-ID: POLICY-1656 Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
2020-03-11Adapt vCPE example for Rhino Javascriptliamfallon26-104/+146
Minor changes to Javascript source for execution under the Rhino script engine. Issue-ID: POLICY-2106 Change-Id: Ib7e30ce0067a11ea1bb3ca8d197c796dba9ea091 Signed-off-by: liamfallon <liam.fallon@est.tech>
2020-03-11Sonar Security vulnerabilities fixaditya.puthuparambil3-49/+58
Issue-ID: POLICY-1913 Signed-off-by: aditya.puthuparambil <aditya.puthuparambil@est.tech> Change-Id: Ic86e04776c9300e37134210cd9db5b6d7e6a5a9e
2020-03-10Merge "Sonar Bug fix"Liam Fallon2-65/+69
2020-03-09Use Rhino javascript executor in apex-pdpliamfallon76-1158/+492
Integation unit tests resultd in StackOverflowException errors in the Graal Javascript interpreter. Following extensive testing and trouobleshooting, it proved very difficult to fix these issues in Graal as the stck overflow errors were occurring in native class instantiation methods being invoked by Grall on the JVM. The alternative Rhino Javascript engine is developed by mozilla, and was incorporated into the Java 6 JVM and evolved into Nashorn in the Java 8 JVM. Oracle dropped Nashorn in Java 11. However, in parallel, Rhino development has continued. This review brings in the Rhino javascript engine into apex-pdp as the replacement for Nashorn and instead of Graal. Graal seems to be pretty unstable as yet so we may bring it in in future releases but for now Rhino is a more stable and reliable alternative. Issue-ID: POLICY-2106 Change-Id: I0edeff3b0bee404b38e3ebe22001a6e3375a44dc Signed-off-by: liamfallon <liam.fallon@est.tech>
2020-03-09Sonar Bug fixaditya.puthuparambil2-65/+69
Change-Id: Icb465fdcf5a580f599a111ed3c5d3510f5346f64 Issue-ID: POLICY-1913 Signed-off-by: aditya.puthuparambil <aditya.puthuparambil@est.tech>
2020-03-06Merge "Adding gRPC plugin to dependencies in APEX"Liam Fallon1-2/+6
2020-03-05Adding gRPC plugin to dependencies in APEXa.sreekumar1-2/+6
Change-Id: Iee8fdca9f23b432188a61054fe177283fdddc1ba Issue-ID: POLICY-1656 Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
2020-03-05Fixing SONAR bug + code smelladitya.puthuparambil3-29/+29
Change-Id: If76ddc860b67e0d8dcd4c48bacb5436ffc773faa Issue-ID: POLICY-1913 Signed-off-by: aditya.puthuparambil <aditya.puthuparambil@est.tech>
2020-03-04Merge "replace test sleep() with awaitality package"Liam Fallon23-147/+144
2020-03-04Merge "Preparing integration tests for Graal Javascript"Pamela Dragosh47-2191/+283
2020-03-04Merge "GRPC support for APEX-CDS interaction"Pamela Dragosh10-1/+718
2020-03-04Preparing integration tests for Graal Javascriptliamfallon47-2191/+283
Graal enforces Javascript more strictly than Nashorn does. This review changes the tests in apex-pdp to comply with the stricter -Javascript checking, re-enabling the integration test module. - All log calls must be passed as strings, using toString() - Byte/Float/Long Java types not supported in Javascript Disable integration tests so that other changes can be brought in. JMS integration test is disabled for now, it will be re-enabled in a review shortly. Issue-ID: POLICY-2106 Change-Id: I14bdb930eff735e862b51802cf72e4793cec3699 Signed-off-by: liamfallon <liam.fallon@est.tech>
2020-03-04replace test sleep() with awaitality packageHenry.Sun23-147/+144
Signed-off-by: Henry.Sun <henry.a.sun@est.tech> Change-Id: I305771ddef42bd3032ad52f4c5ecd55b01ed5a1a Issue-ID: POLICY-1914 Signed-off-by: Henry.Sun <henry.a.sun@est.tech>
2020-03-03GRPC support for APEX-CDS interactiona.sreekumar10-1/+718
Change-Id: I586153244dbd97a41e9b9d616ee9a84327b7c2da Issue-ID: POLICY-1656 Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
2020-03-03use policy/parent awaitilityPamela Dragosh1-2/+1
use common version Issue-ID: POLICY-2381 Change-Id: Id231aa8709b3c4515fcac80b82d53fb8ed45eaf0 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-03-02Merge "FIxing Sonar issues in APEX"Jorge Hernandez2-11/+1
2020-03-02Merge "Switch apex to Graal javascript engine"Ram Krishna Verma21-341/+2025
2020-03-02FIxing Sonar issues in APEXaditya.puthuparambil2-11/+1
Change-Id: I8ac07eede6758c84a4a9ca505382f215d531cf47 Issue-ID: POLICY-1913 Signed-off-by: aditya.puthuparambil <aditya.puthuparambil@est.tech>
2020-03-01Point to docker 2.0.1Pamela Dragosh1-1/+1
policy/docker is released. Issue-ID: POLICY-2378 Change-Id: If3ed5a595f9e6138c18ed8d7386e07a776d7c903 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-03-01Switch apex to Graal javascript engineliamfallon21-341/+2025
This is the main review to switch out the Nashorn Javascript interpreter and switch in the Graal javascript interpreter for apex Javascript tasks. The Graal Javascript dialect differs slightly from Nashorn in the way it accesses information passed over from the Java world so Javascript tasks need to be converted. Subsequent reviews will convert the JUnit tests marked @Ignore in previous reviews to this one and will convert the Javascript tasks into a format Graal can handle. Subsequent reviews will also convert the examples over to Graal format. Issue-ID: POLICY-2106 Change-Id: Ief582a36539e8a87724c17fb7e56864d5e471c07 Signed-off-by: liamfallon <liam.fallon@est.tech>
2020-02-27Merge "Add integration tests for Parameter passing in APEX"Liam Fallon8-0/+682
2020-02-27Add integration tests for Parameter passing in APEXa.sreekumar8-0/+682
Change-Id: I5d01766ffb0104f632bebc9b553e7dca83b4829f Issue-ID: POLICY-2364 Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
2020-02-26Merge "Fix Java 11/Checkstyle/Sonar warnings"Jim Hahn56-694/+661
2020-02-26Fix Java 11/Checkstyle/Sonar warningsliamfallon56-694/+661
A number of Java 11, checkstyle, and SONAR warnings have crept into the Apex codebase over the last number of reviews. This change fixes those issues. Issue-ID: POLICY-1913 Change-Id: I2afd607e80f48323355380fb2fe5e048e18879f9 Signed-off-by: liamfallon <liam.fallon@est.tech>
2020-02-25remove duplication code in plugins-event producerning.xi6-198/+97
Issue-ID: POLICY-1884 Change-Id: I7774dfdc7d7edcc0409a817bfd21ddacec21d085 Signed-off-by: ning.xi <ning.xi@est.tech>
2020-02-24Merge "remove code duplication in plugins"Ram Krishna Verma8-321/+97
2020-02-24Merge "remove code duplication in plugin-event-carrier"Ram Krishna Verma5-367/+298
2020-02-21remove code duplication in pluginsshaoqiu8-321/+97
Remove consumer code duplication in plugins-event-carrier Issue-ID: POLICY-1884 Signed-off-by: shaoqiu <tim.huang@est.tech> Change-Id: I2d222436a97224e54a03c2501f4dc14d3f5f6ac0
2020-02-20Passing taskParameters from ApexConfig to policy logica.sreekumar10-197/+307
TaskParameters can be used to pass parameters from ApexConfig to the policy logic. In the config, these are optional. Usage as below: { "engineParameters": { "taskParameters": [ { "key": "ParameterKey1", "value": "ParameterValue1" }, { "taskId": "TaskIdVal", "key": "ParameterKey2", "value": "ParameterValue2" } ] } } In the taskLogic, taskParameters can be accessed as below: eg: executor.parameters.get("ParameterKey1")) If taskId is provided in ApexConfig for an entry, then that parameter is updated only for that particular task. Otherwise, the task parameter is added to all tasks. Change-Id: I9e1b3d3697428309e7d86db40b63ffe822935b69 Issue-ID: POLICY-2364 Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
2020-02-20remove code duplication in plugin-event-carrierning.xi5-367/+298
Issue-ID: POLICY-1884 Change-Id: I610d7ee34d640cc3a7d3381b24993ee9b6f76f2d Signed-off-by: ning.xi <ning.xi@est.tech>
2020-02-06Updating module names to resolve conflictsRam Krishna Verma13-44/+54
Issue-ID: POLICY-2355 Change-Id: I67f0ca2ced9cbe37a3d00d9f312101e756454107 Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2020-02-03Adding Tosca compliant operational policy type to default config file for ↵a.sreekumar1-0/+4
apex-pdp Change-Id: I6de1fd31c2e73814a546b05ee71419fded4a3357 Issue-ID: POLICY-2147 Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
2020-01-30Remove content section from ToscaPolicy properties in APEXa.sreekumar6-21/+27
Currently APEX specific information is placed under properties|content in ToscaPolicy. Avoid keeping under "content" and keep the information directly under properties. Change-Id: Ic437271c9a2d71104013b5568af5525df4a4bb56 Issue-ID: POLICY-2332 Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
2020-01-27Remove unnecessary sonar configPamela Dragosh1-2/+0
This is no longer needed now that it is pointing to latest policy/parent. BTW - I decided there were too many changes required for combining into one single .exec jacoco file. And it was not improving any of the numbers. This repo is very close to original numbers before the move to sonar cloud. Will investigate another time. Issue-ID: POLICY-2321 Change-Id: If2f3a762de943fb6f73709d9308333b8feda436e Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-01-23Remove apex-pdp TextFileUtils classliamfallon42-703/+596
This class was moved to policy-common some time ago. Removing it in apex-pdp. Issue-ID: POLICY-1913 Change-Id: I982fbd799334b34f1526e19f339236b52205b91e Signed-off-by: liamfallon <liam.fallon@est.tech>
2020-01-23Run apex-pdp in Java 11: base changesliamfallon22-500/+425
This change brings in the minimum changes to get apex-pdp running in Java 11. Other reviews will bring in changes to remove Java 11 warnings and to convert apex-pdp Javascript handling from the now deprecated nashorn engine. Issue-ID: POLICY-1581 Change-Id: I879bbae08d4e67aca3f1bfeedeca639d8dbbc281 Signed-off-by: liamfallon <liam.fallon@est.tech>
2020-01-20First sonar updatePamela Dragosh1-81/+2
Just updating this way gets apex to around 79%, which passes. Previously around 80%, when JDK11 is done I will fix it up and hopefully we will get it back to over 80%. Issue-ID: POLICY-2321 Change-Id: If3440e8c8c71f858adcc3f1b349da4e1048f8464 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-01-10Point to policy/models release versionHOCKLA1-2/+2
Issue-ID: POLICY-1592 Change-Id: I4a795fc1496f5608884a7b8bdad0c212c4321392 Signed-off-by: HOCKLA <ah999m@att.com>
2020-01-09Merge "Populate the PdpStatistics data in heartbeat"Jim Hahn16-37/+441
2020-01-09Merge "Enabling logback file to be loaded using oom configmap"Pamela Dragosh1-1/+6
2020-01-08Merge "Update vCPE example to use Avro schemas"Jorge Hernandez51-62/+2731
2020-01-08Enabling logback file to be loaded using oom configmapa.sreekumar1-1/+6
Change-Id: I746ee57003175ae9e3f903ee3e5948ed1875dceb Issue-ID: POLICY-2308 Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
2020-01-08Update vCPE example to use Avro schemasliamfallon51-62/+2731
THis change updates the vCPE example to show how the example can work towards the APPC using Avro schemas only. This means that Policies can be adapted to changes in controller APIs using Avro alone. This example works with the old and new format policy-models. Issue-ID: POLICY-2043 Change-Id: I42ac0eac5203eaa37316cf6c460c67f7e8d6deb2 Signed-off-by: liamfallon <liam.fallon@est.tech>
2020-01-08Populate the PdpStatistics data in heartbeatshaoqiu16-37/+441
Apex to populate the PdpStatistics data in every heartbeat sent to PAP Issue-ID: POLICY-2302 Change-Id: I2d3a6c1e8605d53bf754a135980527bd50762abd Signed-off-by: shaoqiu <tim.huang@est.tech>