aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2018-12-18Remove unused @throws warningsliamfallon5-14/+3
Previous checkstyle fixes rationalised the exceptions thrown by methods, however the javadoc comments were not updated. This review updates them. Issue-ID: POLICY-1263 Change-Id: I2746f30e76018ec4d0f1e74a6a415979b7874329 Signed-off-by: liamfallon <liam.fallon@est.tech>
2018-12-15Fix sonar test renaming issuesliamfallon24-84/+506
Renaming tests introduced Sonar issues: - Tests where coverage was <80% flagged as they are new code - Support test classes with names ending in "Test" flagged becasue they did not contain test cases Issue-ID: POLICY-1263 Change-Id: I17a4b27b2952a4978fab1c76579a013478b60ae1 Signed-off-by: liamfallon <liam.fallon@est.tech>
2018-12-11Add period after inheritDocliamfallon16-35/+35
Issue-ID: POLICY-1074 Change-Id: I88dc888b2a374b38499241f578a36dd116e2b85b Signed-off-by: liamfallon <liam.fallon@est.tech>
2018-12-11Merge "Remove unused parameter from test data"Pamela Dragosh15-53/+52
2018-12-11Remove unused parameter from test dataliamfallon16-53/+57
The "restRequestTimeout" parameter is not used in the current version of Apex, it was replaced by the "requestorTimeout" paramter. However, the parameter remained in the JSON data files. Also updated to improve output of messages during unit test. This review also sets the Jersey injection dependendy scope to "test" Issue-ID: POLICY-1074 Change-Id: I75f495f571c8101310bd1eaec01a305318346cd9 Signed-off-by: liamfallon <liam.fallon@est.tech>
2018-12-11Merge "Support HTTP headers in REST Client"Jorge Hernandez16-46/+2371
2018-12-08Fix checkstyle issuesliamfallon10-49/+66
Some minor line length and formatting checkstyle warnings fixed. Change-Id: Ib92069bbdb444560083e6d0dbf5d16a3ab824d82 Issue-ID: POLICY-1074 Signed-off-by: liamfallon <liam.fallon@est.tech>
2018-12-08Support HTTP headers in REST Clientliamfallon16-46/+2371
Fixed REST client plugin to supprot HTTP headers and add unit test to plugin. Change-Id: I6a71ab7f83ed2126b8600bb5e586f971dbdacdc0 Issue-ID: POLICY-1222 Signed-off-by: liamfallon <liam.fallon@est.tech>
2018-12-06Merge "Fix bugs in context flushing"Pamela Dragosh1-41/+52
2018-12-06Merge "Support HTTP headers in REST Requestor"Jorge Hernandez15-24/+1092
2018-12-05Fix bugs in context flushingliamfallon1-41/+52
The context flushing support in the context distributor can throw a concurrent exception when a lot of context is active and a flush takes place. This fix introduces proper synchronized access to the album maps. In addition, there was an incorrect cast in the call to the persist() method of the persistor. Change-Id: I6594ffed83a0b34251a0c5c7893d4abb17437fd4 Issue-ID: POLICY-1380 Signed-off-by: liamfallon <liam.fallon@est.tech>
2018-12-04Support HTTP headers in REST Requestorliamfallon15-24/+1092
Change-Id: Iea4211e7d3324f5ea6244f45c91241a4067d8d33 Issue-ID: POLICY-1222 Signed-off-by: liamfallon <liam.fallon@est.tech>
2018-12-04Add unit test for Java executorliamfallon10-26/+603
Code coverage in the Apex-PDP plugins is very low. JUnit coverage will be increased for the Plugins over the Dublin design timeline. Issue-ID: POLICY-1379 Change-Id: Ie70ab5a9be650818cb330ec5be2a89a5db6153c5 Signed-off-by: liamfallon <liam.fallon@est.tech>
2018-12-03Merge "Fix checkstyle/sonar issues"Jorge Hernandez7-82/+100
2018-12-03Merge "Rename test classes in apex-pdp"Pamela Dragosh14-29/+29
2018-12-03Fix checkstyle/sonar issuesliamfallon7-82/+100
Remove unused imports Add @FunctionalInterface annotation Reduce the complexity of some methods Change-Id: If519c31b113233361fbb935121fe6494263ac957 Issue-ID: POLICY-1074 Signed-off-by: liamfallon <liam.fallon@est.tech>
2018-12-03Use Parent Eclipselinkliamfallon2-2/+0
Issue-ID: POLICY-1360 Change-Id: I99a9e7bf60590fd0da5d7ba001e8ab322623fee6 Signed-off-by: liamfallon <liam.fallon@est.tech>
2018-12-03Rename test classes in apex-pdpParshad Patel14-29/+29
Make test classes name consitence by adding 'Support' or 'Dummy' at start of util or dummy type of test classes Issue-ID: POLICY-1263 Change-Id: I1dc1a7f174660a90664ebdcff2ea79ed30aa465c Signed-off-by: Parshad Patel <pars.patel@samsung.com>
2018-11-29Merge "Fixing issues in apex documents"Jorge Hernandez25-469/+529
2018-11-29Fixing issues in apex documentsramverma25-469/+529
Change-Id: Ibc07c20fa8ac1018443a3c061613fdaecc5efb83 Issue-ID: POLICY-1280 Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
2018-11-29Merge "Rename test classes in apex-pdp/model/basic-model"Pamela Dragosh21-80/+80
2018-11-28Rename test classes in apex-pdp/model/basic-modelParshad Patel21-80/+80
Make test classes name consitence by adding 'Support' or 'Dummy' at start of util or dummy type of test classes Issue-ID: POLICY-1263 Change-Id: Ia90e0ea73af16f6cde37692e98f1c4afc408dd2b Signed-off-by: Parshad Patel <pars.patel@samsung.com>
2018-11-26Merge "Fix sonar issue cli codegen"Jorge Hernandez5-71/+196
2018-11-25Fix sonar issue cli codegenKrishnakumar Jinka5-71/+196
Modify CodeGeneratorCliEditor to use param object for sonar issue fix Add javadoc for the method addEventDecl Method. Modify meth declaration. Run formatter Issue-ID: POLICY-1251 Change-Id: I4f95e868c047f54dff9cf991e8f4f60e8954c788 Signed-off-by: kris.jinka <kris.jinka@samsung.com>
2018-11-23Create label for architecture to refPamela Dragosh1-0/+2
Creating a label so other documentation in the architecture section can reference this PDP engine documentation. Issue-ID: POLICY-1163 Change-Id: Ida9caba405e36675f65843b1d49e79175634fa02 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-11-20Refactor Apex benchmark testsliamfallon86-7974/+4421
Apex performance tests are refactored and reorganised to be all in the one place and to be coherent. A test REST server that can generate events in batches is introduced and this can be configured to respond to REST calls from Apex with various batch sizes that can be varied for performance tests. Actual performance tests are added for the various executors in Apex. Change-Id: I692b41e1e4451e821a618c64dead5cc8e9685d08 Issue-ID: POLICY-812 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-11-20Rename test classes in apex-pdpParshad Patel42-64/+64
Make test classes name consistence under auth, model, plugins, testsuits, tools projects Issue-ID: POLICY-1263 Change-Id: I49ec9a9f5b457d6381e693de2c04ec0268ad1b02 Signed-off-by: Parshad Patel <pars.patel@samsung.com>
2018-11-19Rename test classes in apex-pdpParshad Patel62-72/+72
Make test classes name consistence by putting 'Test' at end Issue-ID: POLICY-1263 Change-Id: I0179388d84826e698276a1995dd8173a40b5fd2b Signed-off-by: Parshad Patel <pars.patel@samsung.com>
2018-11-16Fix timing and move testsliamfallon12-89/+344
The timings on the REST test are too short and time out on ONAP Jenkins The tests of the Apex service and Apex model upgrade are not benchmark tests so are moved to Integration. Issue-ID: POLICY-1251 Change-Id: I2672d01042b33fe0cce5223005295e3b1aa26e7a Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-11-15Fix checkstyle warnings in AxState/Codegenliamfallon4-321/+265
Recent checkins introduced some very minor checkstyle warnings, this review fixes those. Change-Id: Ie7784ad22a748017e1647be0e23dc9d3fe100cf0 Issue-ID: POLICY-1251 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-11-15Merge "Use param obj for contxt album decln"Jorge Hernandez4-26/+177
2018-11-15Merge "Refactored Asynchronous tests to integration"Jorge Hernandez21-4980/+235
2018-11-15Refactored Asynchronous tests to integrationliamfallon21-4980/+235
Moved the tests of asynchronous and synchronous inputs and outputs for Apex from benchmark tests to integration tests which is where they should be. Also the tests were amended to use the common integration test data. Change-Id: Id2d098b0a7d70c50dbb4547b0386cc7bcf6245a9 Issue-ID: POLICY-954 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-11-15Use param obj for contxt album declnkris.jinka4-26/+177
Modify code generator cli editor to use param object for the sonar issue fix Issue-ID: POLICY-1251 Change-Id: I3efbdbe2ce7c16702508b9f1f36ecbb9b1e12856 Signed-off-by: kris.jinka <kris.jinka@samsung.com>
2018-11-14Use param obj for policymodel AxStatekris.jinka4-117/+328
Define AxStateParams object for parameters input Fix sonar issue about more than 7 parameters in method Modify the builder approach as suggested in review Issue-ID: POLICY-1251 Change-Id: Ic11b8cc2a4aed5394c5450fed4f0702c4ad9eda4 Signed-off-by: kris.jinka <kris.jinka@samsung.com>
2018-11-12Clean up eclipse and document warningsliamfallon16-276/+440
Parent versions in some POMs only called on the test profile were incorrect Warnings in Eclipse on POM including from outside its project are fixed Some checkstyle fixes Some javadoc warnings fixed Issue-ID: POLICY-954 Change-Id: I640bc842dc79a9fa580015abb9a76c84a7845efe Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-11-07Refactor unit test dataliamfallon222-100492/+4270
There were many copies of test policies and examples strewn through the Apex unit tests. This change cleans up the unit tests so that a single version of all example policies is used in all tests. Also added a new relative file root command line parameter to Apex to allow the root of relative paths in configuration files to be set. Apologies for the size of this review but unfortunately all of this must be done in one shot. Issue-ID: POLICY-1252 Change-Id: Ibbb18fbf18e3897a1c61301d0a65e62bc643a0e9 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-11-01Upgrade Jython for security, add doc warningliamfallon2-2/+8
Upgrading Jython to use a full release version. This will probably noit remove security problem but upgrades Jython to the most popular version. A warning is added telling developers to check extra pcakages in the Jython plugin documentation. Issue-ID: POLICY-1065 Change-Id: I83275204c1905bd48dd5ea58e98dcbbd9c47195f Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-10-31Set new master version for Dublinliamfallon85-292/+190
Issue-ID: POLICY-1232 Change-Id: If43c40e9e13bd9387e2b6ee876717f8413a17e34 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-10-24Fix refering to snapshot in policy/apex-pdp2.0.1ramverma88-92/+91
Issue-ID: POLICY-1213 Change-Id: I9187462aa470cff6ca7adc750c8a666bf8e15429 Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
2018-10-23Adding stability test plan of apex-pdpramverma4-0/+363
Change-Id: I41e1237c350b9cceca2b80db3fc9dcccf1173a66 Issue-ID: POLICY-817 Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
2018-10-19Merge "Add utility packages to Apex docker image"Jorge Hernandez1-0/+1
2018-10-19Add utility packages to Apex docker imageliamfallon1-0/+1
Add zip/curl/ping/vi to the image for debugging Issue-ID: POLICY-812 Change-Id: I31b156aedd1500ef0ae50a45354f033b057dc7e4 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-10-19Fix bug to allow JSON arrays of eventsliamfallon2-3/+5
Apex should allow JSON arrays of events to be processed, processing the array of events as they come in. This review changes the Apex JSON array handling to allow arrays of JSON events to be processed. Arrays of events are required to perform Apex pewrformance tests. Change-Id: I08ddc9659414bd076fbaa250182335d6f38473e6 Issue-ID: POLICY-812 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-10-09Added documentation for readthedocsmmis38-0/+13650
Issue-ID: POLICY-1161 Change-Id: I8a3ac2b8fbfccacd04cfd5cb3bc649d9674ec59b Signed-off-by: mmis <michael.morris@ericsson.com>
2018-10-08Upgrade to release policy/common2.0.0Pamela Dragosh1-2/+2
1.3.0 is released. Change-Id: I2da787ab3203ef7eba5f50aa4bff30c76f1c6cd4 Issue-ID: POLICY-1189 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-10-08Remove Sonar Vulnerabilitliamfallon1-1/+1
The coverage review for teh Apex engine introduced a vulnerability flag in Sonar. This review fixes that vulnerability Change-Id: Ie90c61a22c79604513ff2393a768a22ec9542484 Issue-ID: POLICY-1034 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-10-08Merge "Unit test for Apex engine"Pamela Dragosh34-71/+3715
2018-10-07Unit test for Apex engineliamfallon34-71/+3715
Coverage for unit test of engie state and state machine handling. Added coverage of the facade and executor context classes Added coverage for executors Added coverage for the remainder of the core engine Issue-ID: POLICY-1034 Change-Id: I85c66005dfdffdf2b4ee5672473a3ae4823d0d9c Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-10-05JUnit for apex Admin Protocol listenerliamfallon9-13/+669
Added coverage for this package. i Issue-ID: POLICY-1034 Change-Id: I2e4b51983eec245eb9f105587d15f853656ce35a Signed-off-by: liamfallon <liam.fallon@ericsson.com>