summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2018-11-20Refactor Apex benchmark testsliamfallon86-7974/+4421
Apex performance tests are refactored and reorganised to be all in the one place and to be coherent. A test REST server that can generate events in batches is introduced and this can be configured to respond to REST calls from Apex with various batch sizes that can be varied for performance tests. Actual performance tests are added for the various executors in Apex. Change-Id: I692b41e1e4451e821a618c64dead5cc8e9685d08 Issue-ID: POLICY-812 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-11-20Rename test classes in apex-pdpParshad Patel42-64/+64
Make test classes name consistence under auth, model, plugins, testsuits, tools projects Issue-ID: POLICY-1263 Change-Id: I49ec9a9f5b457d6381e693de2c04ec0268ad1b02 Signed-off-by: Parshad Patel <pars.patel@samsung.com>
2018-11-19Rename test classes in apex-pdpParshad Patel62-72/+72
Make test classes name consistence by putting 'Test' at end Issue-ID: POLICY-1263 Change-Id: I0179388d84826e698276a1995dd8173a40b5fd2b Signed-off-by: Parshad Patel <pars.patel@samsung.com>
2018-11-16Fix timing and move testsliamfallon12-89/+344
The timings on the REST test are too short and time out on ONAP Jenkins The tests of the Apex service and Apex model upgrade are not benchmark tests so are moved to Integration. Issue-ID: POLICY-1251 Change-Id: I2672d01042b33fe0cce5223005295e3b1aa26e7a Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-11-15Fix checkstyle warnings in AxState/Codegenliamfallon4-321/+265
Recent checkins introduced some very minor checkstyle warnings, this review fixes those. Change-Id: Ie7784ad22a748017e1647be0e23dc9d3fe100cf0 Issue-ID: POLICY-1251 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-11-15Merge "Use param obj for contxt album decln"Jorge Hernandez4-26/+177
2018-11-15Merge "Refactored Asynchronous tests to integration"Jorge Hernandez21-4980/+235
2018-11-15Refactored Asynchronous tests to integrationliamfallon21-4980/+235
Moved the tests of asynchronous and synchronous inputs and outputs for Apex from benchmark tests to integration tests which is where they should be. Also the tests were amended to use the common integration test data. Change-Id: Id2d098b0a7d70c50dbb4547b0386cc7bcf6245a9 Issue-ID: POLICY-954 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-11-15Use param obj for contxt album declnkris.jinka4-26/+177
Modify code generator cli editor to use param object for the sonar issue fix Issue-ID: POLICY-1251 Change-Id: I3efbdbe2ce7c16702508b9f1f36ecbb9b1e12856 Signed-off-by: kris.jinka <kris.jinka@samsung.com>
2018-11-14Use param obj for policymodel AxStatekris.jinka4-117/+328
Define AxStateParams object for parameters input Fix sonar issue about more than 7 parameters in method Modify the builder approach as suggested in review Issue-ID: POLICY-1251 Change-Id: Ic11b8cc2a4aed5394c5450fed4f0702c4ad9eda4 Signed-off-by: kris.jinka <kris.jinka@samsung.com>
2018-11-12Clean up eclipse and document warningsliamfallon16-276/+440
Parent versions in some POMs only called on the test profile were incorrect Warnings in Eclipse on POM including from outside its project are fixed Some checkstyle fixes Some javadoc warnings fixed Issue-ID: POLICY-954 Change-Id: I640bc842dc79a9fa580015abb9a76c84a7845efe Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-11-07Refactor unit test dataliamfallon222-100492/+4270
There were many copies of test policies and examples strewn through the Apex unit tests. This change cleans up the unit tests so that a single version of all example policies is used in all tests. Also added a new relative file root command line parameter to Apex to allow the root of relative paths in configuration files to be set. Apologies for the size of this review but unfortunately all of this must be done in one shot. Issue-ID: POLICY-1252 Change-Id: Ibbb18fbf18e3897a1c61301d0a65e62bc643a0e9 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-11-01Upgrade Jython for security, add doc warningliamfallon2-2/+8
Upgrading Jython to use a full release version. This will probably noit remove security problem but upgrades Jython to the most popular version. A warning is added telling developers to check extra pcakages in the Jython plugin documentation. Issue-ID: POLICY-1065 Change-Id: I83275204c1905bd48dd5ea58e98dcbbd9c47195f Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-10-31Set new master version for Dublinliamfallon85-292/+190
Issue-ID: POLICY-1232 Change-Id: If43c40e9e13bd9387e2b6ee876717f8413a17e34 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-10-24Fix refering to snapshot in policy/apex-pdp2.0.1ramverma88-92/+91
Issue-ID: POLICY-1213 Change-Id: I9187462aa470cff6ca7adc750c8a666bf8e15429 Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
2018-10-23Adding stability test plan of apex-pdpramverma4-0/+363
Change-Id: I41e1237c350b9cceca2b80db3fc9dcccf1173a66 Issue-ID: POLICY-817 Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
2018-10-19Merge "Add utility packages to Apex docker image"Jorge Hernandez1-0/+1
2018-10-19Add utility packages to Apex docker imageliamfallon1-0/+1
Add zip/curl/ping/vi to the image for debugging Issue-ID: POLICY-812 Change-Id: I31b156aedd1500ef0ae50a45354f033b057dc7e4 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-10-19Fix bug to allow JSON arrays of eventsliamfallon2-3/+5
Apex should allow JSON arrays of events to be processed, processing the array of events as they come in. This review changes the Apex JSON array handling to allow arrays of JSON events to be processed. Arrays of events are required to perform Apex pewrformance tests. Change-Id: I08ddc9659414bd076fbaa250182335d6f38473e6 Issue-ID: POLICY-812 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-10-09Added documentation for readthedocsmmis38-0/+13650
Issue-ID: POLICY-1161 Change-Id: I8a3ac2b8fbfccacd04cfd5cb3bc649d9674ec59b Signed-off-by: mmis <michael.morris@ericsson.com>
2018-10-08Upgrade to release policy/common2.0.0Pamela Dragosh1-2/+2
1.3.0 is released. Change-Id: I2da787ab3203ef7eba5f50aa4bff30c76f1c6cd4 Issue-ID: POLICY-1189 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-10-08Remove Sonar Vulnerabilitliamfallon1-1/+1
The coverage review for teh Apex engine introduced a vulnerability flag in Sonar. This review fixes that vulnerability Change-Id: Ie90c61a22c79604513ff2393a768a22ec9542484 Issue-ID: POLICY-1034 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-10-08Merge "Unit test for Apex engine"Pamela Dragosh34-71/+3715
2018-10-07Unit test for Apex engineliamfallon34-71/+3715
Coverage for unit test of engie state and state machine handling. Added coverage of the facade and executor context classes Added coverage for executors Added coverage for the remainder of the core engine Issue-ID: POLICY-1034 Change-Id: I85c66005dfdffdf2b4ee5672473a3ae4823d0d9c Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-10-05JUnit for apex Admin Protocol listenerliamfallon9-13/+669
Added coverage for this package. i Issue-ID: POLICY-1034 Change-Id: I2e4b51983eec245eb9f105587d15f853656ce35a Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-10-05Fix sonar bugs in apex-pdpramverma2-2/+8
Change-Id: I1ab9b9d9b0b8d1655301959d7d6b9ab3cc87eba3 Issue-ID: POLICY-954 Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
2018-10-05Set pretty print on JSON creationliamfallon1-1/+1
Pretty printing was set off, making debugging of JSON messages more difficult. Issue-ID: POLICY-954 Change-Id: Ifcc32cdba822f2bfc105c99cc3dc85ee05a89f6f Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-10-04Fix creation of sub Avro itemsliamfallon7-30/+186
When an Avro object is created, nested sub avro objects are not created automatically. This change allows invocation of a method to create sub objects of Avro objects. Issue-ID: POLICY-954 Change-Id: Ie510867f2631ba6a8c6f5452c08aef5db67e8997 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-10-03Add unit test for core events and contextliamfallon12-24/+1287
This code is covered by feature testing but does not show up in Sonar. These unit tests give coverage on engine modules. Issue-ID: POLICY-1034 Change-Id: Ib7a288bcb9729ec88346cc8047e38f3a58f9a97c Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-10-03Add Unit Test for Admin Protocol messagesliamfallon19-111/+818
Issue-ID: POLICY-1034 Change-Id: Ie07d5036ab328ab51843694a3b2a6bac87920f2e Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-10-01Add JUnit for test conceptsliamfallon7-56/+984
JUnit test for test concepts. Issue-ID: POLICY-1034 Change-Id: Ia2cd896272d4278d842d19d21237edcdca54a1f8 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-10-01Refactor monitoring REST tests to remove PowerMockliamfallon4-43/+184
Removed PowerMock from tests becasue coverage of PowerMock is not counted by JaCoCO. It was easier to remove PowerMock than to try and hack the build get PowerMock coverage counted. Issue-ID: POLICY-1034 Change-Id: Ifc3e1ff93b2bfcb5619a5af6dec320d2de992f87 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-09-30Unit test for client monitoringliamfallon10-3/+759
Coverage for the client monitoring module. Issue-ID: POLICY-1034 Change-Id: I6bb6dab26ce0572923c3d451a3b5f4745d40d088 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-09-28Add JUnit for cli-codegenliamfallon4-0/+7269
The cli-codegen tool did not have any unit tests. Issue-ID: POLICY-1034 Change-Id: If9d3924adea703b165b360e314ea3cb417a91d21 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-09-28Add unit test for core distributionliamfallon11-134/+7673
JUnit for the batch deployer and deploy facade. Issue-ID: POLICY-1034 Change-Id: I3959578ba8666d64b48bbe4ee9aeab27b92d77ae Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-09-27Unit test for core deploymentliamfallon8-61/+476
This module was not covered by unit test. Issue-ID: POLICY-1034 Change-Id: I700d43c0bde58c2b236f46994f380e20116418d9 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-09-27Add JUnit for web service client toolliamfallon6-59/+283
JUnit, SOnar fixes, and some minor bug fixes. Issue-ID: POLICY-1034 Change-Id: I72f46e944051f7d65d6b106afe33c759975283af Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-09-27Add missing example policy models to installliamfallon2-2/+29
The policy models for the decision maker, periodic, and vCPE examples were not included in the install because the policy model json files are generated from CLI commands. THis review installs the generated policy models. Issue-ID: POLICY-954 Change-Id: Ie2076ddfb6199dac0c8b272de8d7c47f1652485e Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-09-27Add unit test for Apex command line toolsliamfallon21-128/+23036
THere was no unit test for the command line tools. This review adds unit test and also fixes a few small bugs that showed up when uit test was run. Issue-ID: POLICY-1034 Change-Id: Ic19aacdb168fb5a6faa0cd83ed22ccfcedaa51f5 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-09-26Allow custom JSON adapter specificationliamfallon13-95/+822
In order to decode and encode complex Java POJOs with GSON, type adapters must be specified. This change allows specification of GSON type adapters for decoding and encoding of JSON in apex. Issue-ID: POLICY-954 Change-Id: Ib402d4e82c4f22fa4d532c016f77fb8e7bb568d3 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-09-26Fix boolean constants in examplesliamfallon26-60/+60
When the checkstyle changes were made in the java code the .TRUE and .FALSE values were changed to .isTrue and .isFalse to comply with checkstyle. THis change needs to be propogated into example scripts. Issue-ID: POLICY-103 Change-Id: I419b5f398ef4f43b1b877d52bbe4ec638870f31d Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-09-26Add JUnit for engine serviceliamfallon14-812/+9267
Although the Apex engine service is called by the policy engine tests and the various interface tests, the test coverage on these classes is not showing up in Sonar. In any event it is better that specific JUint is done for them. Issue-ID: POLICY-1034 Change-Id: I0028c7e5e870c18649870536cf3691fce2ab689c Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-09-25JUnit for evaluation test model generatorliamfallon4-4/+177
Issue-ID: POLICY-1034 Change-Id: Ic8f9971d612dd5500c73f95e5cbbb786c5ad51f3 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-09-25Fix sonar issues in Command line editorliamfallon4-168/+258
THe Apex command line editor had issues in teh way its loops for processing commands were written. The loops are simplified in this review. Issue-ID: POLICY-1034 Change-Id: If684a57de79bd56211e1ca3e8c446bd9698666be Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-09-23Fix more sonar issuesliamfallon2-138/+248
These are the last few easy to fix issues. Most remaining issues are to do with code coverage. Othersare due tot he way script interpreters work and will have to be exempted. Issue-ID: POLICY-1034 Change-Id: Ie1d1def43d33ef78a13d7f9b43ae4e22ef00cb5b Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-09-22Fix sonar problems in Apexliamfallon51-541/+956
Fixed some easy to resolve Sonar issues. Issue-ID: POLICY-1034 Change-Id: Ia8e4606bd4307daca499b4a74c96135211e572fd Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-09-20Fix bug with POJO events in APexliamfallon24-94/+1511
When an envet should be decoded entirely into a POJO and is too complex for Avro, apex decoding breaks. This reviuew fixes thsi issue. Issue-ID: POLICY-1034 Change-Id: Iccd739c4bb5c1645a2a7165f5bbfdfd4b964d79e Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-09-20Refactor Editor REST servletliamfallon38-2089/+3551
Issue-ID: POLICY-1034 Change-Id: Ifa08c7a31b4fe19eb62c2035b67b6f5cad313b5f Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-09-19Fix examples broken by checkstyle changesliamfallon27-59/+59
Checkstyle changes to some class names must be propgated into example configurations and name changes meant some examples were not being packaged. Issue-ID: POLICY-1034 Change-Id: I5485fc2ffc22c496bbae9465e1c3b09c4feade97 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-09-19Fix license issue with Hibernate dependencyliamfallon1-1/+1
Change-Id: I0f0ce81661c505a7df4b6199c6d0baf7a9d0ce3e Issue-ID: POLICY-1059 Signed-off-by: liamfallon <liam.fallon@ericsson.com>