summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2021-04-15Code coverage for jms protocol event pluginarkadiusz.adamski5-3/+420
- Increase code coverage for jms protocol event plugin Issue-ID: POLICY-3092 Signed-off-by: arkadiusz.adamski <aadamski@est.tech> Change-Id: I615d56736b548b3d5f552ae1becac771d445b477
2021-03-31Update jMeter test filearkadiusz.adamski1-7/+7
Issue-ID: POLICY-3093 Signed-off-by: arkadiusz.adamski <aadamski@est.tech> Change-Id: If9600785d46bed5596847991690fe1631b97bbf3
2021-03-29Fix sonar issuesarkadiusz.adamski2-33/+21
- reduce methods Cognitive Complexity from 19 to the 15 allowed in CommandLineParser - iteration replaced with bulk 'Collection.addAll' call - remove redundant initializers - replace try with try-with-resources Issue-ID: POLICY-3093 Signed-off-by: arkadiusz.adamski <aadamski@est.tech> Change-Id: Ia727b3145ef8f63bcfc07723191c85e1ec8c923c
2021-03-26Merge "Fix sonar issues"Jim Hahn7-8/+14
2021-03-25Merge "Fix sonar issues"Jorge Hernandez3-3/+3
2021-03-24Fix sonar issuesarkadiusz.adamski7-8/+14
- change test method name to avoid triggering SQ warning Issue-ID: POLICY-3093 Signed-off-by: arkadiusz.adamski <aadamski@est.tech> Change-Id: Id2997319e9986582a85f383c1f737340f4b4ea2c
2021-03-23Override to default entry point in apex-pdpRam Krishna Verma1-0/+1
Overriding to default entry point (/bin/sh) in apex-pdp docker file to support stand alone installations of docker image. Issue-ID: POLICY-3062 Change-Id: I100674cedf78f7221128bc87dd562835f297e0dd Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2021-03-23Fix sonar issuesarkadiusz.adamski3-3/+3
- fix method name on ApexModel Issue-ID: POLICY-3093 Signed-off-by: arkadiusz.adamski <aadamski@est.tech> Change-Id: I853de0f48bbe683249b4c60c4189fb053c5c12a2
2021-03-23Merge "Fixing issues around deploying APEX policies with duplicate concepts"Jim Hahn1-25/+35
2021-03-22Merge "Delete keystores from apex"Ram Krishna Verma3-4/+4
2021-03-19Fixing issues around deploying APEX policies with duplicate conceptsa.sreekumar1-25/+35
Deploying invalid APEX policies with duplicate concepts resulting in corrupting all the policies in memory. This is fixed here. This entire functionality handling multiple policies will be revisited as part of https://jira.onap.org/browse/POLICY-3018 Change-Id: I751102d5dddcb92cdcede8222855e2f467bb724d Issue-ID: POLICY-3141 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2021-03-19Delete keystores from apexJim Hahn3-4/+4
The Keystore is no longer needed in the tarball, as it is supplied externally by the CSITs and Helm charts. Deleted that file. Also modified the junits to use utils-test to generates keystores at runtime, thus deleted the junit keystore file, too. Issue-ID: POLICY-3143 Change-Id: I9bb53fcb5887e73d661ec4c4083970630c61e5c1 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-03-19Fixing parallel event execution problem in APEX-PDP REST layera.sreekumar6-135/+29
Parallel event execution in APEX was resulting in incorrect dynamic REST url. This issue is fixed in this review. Change-Id: Id8a28c001a7fd7915df1f5909109bb369667ab40 Issue-ID: POLICY-3019 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2021-03-18Merge "Bump policy references to latest snapshot versions"Jim Hahn1-3/+3
2021-03-18Bump policy references to latest snapshot versionsliamfallon1-3/+3
Issue-ID: POLICY-3105 Change-Id: I59daab64c4e36fc382d3c1c6a9f4ffe805ddc252 Signed-off-by: liamfallon <liam.fallon@est.tech>
2021-03-18Merge "Increase code coverage"Liam Fallon8-38/+232
2021-03-16Increase code coveragearkadiusz.adamski8-38/+232
- increased test coverage in plugins-event-carrier-restserver package Issue-ID: POLICY-3092 Change-Id: I10ad7f0dd24293de6ce426553c7bc7a2fe3be013 Signed-off-by: arkadiusz.adamski <aadamski@est.tech>
2021-03-16Update policy-keystore with newer certificatesjhh2-0/+0
Issue-ID: POLICY-3139 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: Ia67cb1486a5625385a710c5f6c2b4325ca108820
2021-03-15Merge "Increase code coverage"Ram Krishna Verma2-1/+96
2021-03-15Increase code coveragearkadiusz.adamski2-1/+96
- increased test coverage in the event.protocol.xml package Issue-ID: POLICY-3092 Change-Id: Ie68f8acf49d258536ddc23a14d05302273687634 Signed-off-by: arkadiusz.adamski <aadamski@est.tech>
2021-03-12Bump apex-pdp to 2.6.0-SNAPSHOTliamfallon81-82/+82
Issue-ID: POLICY-3105 Change-Id: I53abd7e9cf8c1425d115b0bb917db6389e9ded92 Signed-off-by: liamfallon <liam.fallon@est.tech>
2021-03-10Bump apex-pdp to 2.5.2-SNAPSHOTa.sreekumar81-81/+81
Change-Id: I291f968367b1f864bb417a72fd0bdb22a07ba0f7 Issue-ID: POLICY-3127 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2021-03-10Release apex-pdp 2.5.1 dockera.sreekumar1-0/+8
Change-Id: I9b5ee20c4760d4f9adcc28c708af62922d6952fa Issue-ID: POLICY-3127 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2021-03-10Release apex-pdp 2.5.1 maven artifactsa.sreekumar1-0/+5
Change-Id: Ib32e0a9dc3d3b9a27f712a02c0317bf7640bc12d Issue-ID: POLICY-3127 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2021-03-09Point to policy-models 2.4.1a.sreekumar1-1/+1
Change-Id: I142f196ddcd71048b6812af2d6af014ca42aa5a9 Issue-ID: POLICY-3127 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2021-02-24Update info.yaml in apex-pdpRam Krishna Verma1-2/+2
Issue-ID: POLICY-3028 Change-Id: Icf1319122ed19a0ba36b148bab7d77be626ba20e Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2021-02-24Bump apex-pdp to 2.5.1-SNAPSHOTa.sreekumar81-81/+81
Change-Id: I761ded255a97128f858d3a7ce95f2479b6208a4e Issue-ID: POLICY-3088 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2021-02-23Release apex-pdp 2.5.0 docker imageRam Krishna Verma1-0/+8
Issue-ID: POLICY-3088 Change-Id: Id5754dac1e8bab68cdb280800750ad98f14c76b1 Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2021-02-23Merge "Fixing intermittent test failures in APEX"Ram Krishna Verma1-75/+58
2021-02-23Release apex-pdp 2.5.0 maven artifactsRam Krishna Verma1-0/+5
Issue-ID: POLICY-3088 Change-Id: Ifa746c534623e43f883f9101c4beb0f34dffbaac Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2021-02-23Fixing intermittent test failures in APEXa.sreekumar1-75/+58
This review should fix the intermittent test failures in TestExecutionPropertyRest class in APEX. Change-Id: I1871a3ac1a40985ad44bbd1433c54930793c7b3c Issue-ID: POLICY-3096 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2021-02-23Point to released version of docker, parent, common and modelsa.sreekumar2-5/+6
Change-Id: I17e2e093421733fc94a3de8f5946b867b3b73ba9 Issue-ID: POLICY-3088 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2021-02-19Convert Date to Instant in statsliamfallon1-2/+2
Issue-ID: POLICY-3069 Change-Id: Ib30782485652ec693d2dbea79514183c7cfbb0c4 Signed-off-by: liamfallon <liam.fallon@est.tech>
2021-02-19Merge "Fix sonars in apex-pdp"Ram Krishna Verma58-720/+509
2021-02-18Update CSIT to check for 202 response during PAP Deploymenta.sreekumar1-1/+1
Change-Id: I947207f10cfd3bc54193ee7c8d356ad40587f072 Issue-ID: POLICY-2526 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2021-02-18Fix sonars in apex-pdpJim Hahn58-720/+509
Addressed the following issues: - initialize mocks before use - use parameterized queries - Random() is not secure - provide parameterized type for generics - unused imports - constructor visibility - use compute() instead of containsKey()/put() - make final fields static - rename constants to all upper case - no assert() in Thread.run() methods - nested try - nested if/else - too many break/continue - use try-with-resources - repeatable annotations - overlapping characters in reg ex - hashcode is not sufficient in compareTo() - need equals() with compareTo() - make class an interface - use parameterized test - multiple calls in assert() - log or re-throw - use different type of lambda - use parameterized logging - use StringBuilder instead of concatenation - use StandardCharsets.UTF_8 Issue-ID: POLICY-2906 Change-Id: I2cf8c885e3e22c2c6cbe6403a34906928afad022 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-02-18Replace GsonXxxAdaptersJim Hahn14-29/+93
The GsonXxxAdapters were removed from the models Serialization classes and replaced with type adapters from common. Modified the code to refer to the new adapters. Without this fix, examples-onap-vcpe will not compile. Could that be the cause of the apex-pdp standalone issue, POLICY-3066? Allow TypeAdapter in lieu of JsonSerializer/Deserializer adapters in config files. Note: examples-ona-bbs refers to the following, which were removed several releases ago (during the actor re-write?): - appclcm.util.Serialization$RequestAdapter & Serialization$ResponseAdapter Issue-ID: POLICY-2905 Change-Id: Ia57e0346343614cbd4a1cffd9c8393f207284244 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-02-11Fix jackson version in apex-pdpJim Hahn1-1/+12
The kafka_2.12 jar depends on jackson-module-scala, but the default version does not work with the version of jackson used by policy. Modified the dependency tree to include a version that does work. Issue-ID: POLICY-3005 Change-Id: I06fd5b99d6e5c1053e17a754f22f815062f907b2 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-02-11move csit to policy/apex-pdp repoTaka Cho7-0/+7603
move csit to policy/apex-pdp repo Issue-ID: POLICY-2895 Change-Id: I73bd2f59c09f4ae213cab9b1dd2a83e909b218c6 Signed-off-by: Taka Cho <takamune.cho@att.com>
2021-02-11Changes related to multi policy handling improvement in APEXa.sreekumar8-323/+343
This review fixes an issue identified during testing the changes done for improving multiple policy handling in APEX. Changes done to a few test files in the previous review are reverted as well. Change-Id: I98324da708239d314aadd4c45dc377137fd552ba Issue-ID: POLICY-2883 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2021-02-10Remove URL and useerid from JMS pluginliamfallon5-44/+55
This review makes the default URL and userid for JMS null, the actual values must be specified as parameters. Issue-ID: POLICY-3035 Change-Id: I9c06d94d8816092425e2df58b849d837ad953fb2 Signed-off-by: liamfallon <liam.fallon@est.tech>
2021-02-08Remove security credentials from JMS pluginliamfallon4-26/+40
The default security credential of "password" was encoded in a constant in the JMS plugin parameters file. This commit removes these credentials and defaults the credentials to null. Issue-ID: POLICY-3035 Change-Id: I6313340e64c893c4f99de78d9dd448ac53d81246 Signed-off-by: liamfallon <liam.fallon@est.tech>
2021-01-28Improve handling of multiple policy in APEX PDPa.sreekumar14-506/+958
Change-Id: Ic4adf5bd8876dc31fc93993298e90389baaa2c39 Issue-ID: POLICY-2883 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2021-01-20Merge "Add logs for REST request/response in APEX"Ram Krishna Verma5-16/+29
2021-01-20Update Hazelcast version, remove security vulnerabilityliamfallon2-9/+11
Security vulnerabillitles were flagged in CLM in Hazelcast version 3.11-BETA-1. Hazelcast version 4.1.1 removes that vulnerability. The lock handling is slightly different in version 4.1.1 and the old ILock class is removed. The code is updated to use the new FencedLock locks. Issue-ID: POLICY-2943 Change-Id: I0cb7d3cb279fed17b3f8758e55902703491f4b5c Signed-off-by: liamfallon <liam.fallon@est.tech>
2021-01-20Add logs for REST request/response in APEXa.sreekumar5-16/+29
Change-Id: Ibf2cf19a1ec91473d8c655b87a712aa8738848c8 Issue-ID: POLICY-3003 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2021-01-15Add exception to logsRam Krishna Verma2-8/+8
Fixing the comments from previous review - https://gerrit.onap.org/r/c/policy/apex-pdp/+/116833 Issue-ID: POLICY-2885 Change-Id: I85474b365d92771e6e1b56bba95bde6e319d4ec2 Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2021-01-13Avoiding unwanted logging in APEX during event processinga.sreekumar12-127/+52
Change-Id: If0c93bfea08025c6c10e3f4572a14088990f415f Issue-ID: POLICY-2885 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2021-01-06Merge "Changed identifiers to concept identifiers"Liam Fallon8-56/+55
2021-01-06Removing duplicate logging of single response eventa.sreekumar1-4/+2
Change-Id: I88c8f2eea9cb295e422d20222df21a46ef84cd4e Issue-ID: POLICY-2885 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>