summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2021-02-19Merge "Fix sonars in apex-pdp"Ram Krishna Verma58-720/+509
2021-02-18Update CSIT to check for 202 response during PAP Deploymenta.sreekumar1-1/+1
Change-Id: I947207f10cfd3bc54193ee7c8d356ad40587f072 Issue-ID: POLICY-2526 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2021-02-18Fix sonars in apex-pdpJim Hahn58-720/+509
Addressed the following issues: - initialize mocks before use - use parameterized queries - Random() is not secure - provide parameterized type for generics - unused imports - constructor visibility - use compute() instead of containsKey()/put() - make final fields static - rename constants to all upper case - no assert() in Thread.run() methods - nested try - nested if/else - too many break/continue - use try-with-resources - repeatable annotations - overlapping characters in reg ex - hashcode is not sufficient in compareTo() - need equals() with compareTo() - make class an interface - use parameterized test - multiple calls in assert() - log or re-throw - use different type of lambda - use parameterized logging - use StringBuilder instead of concatenation - use StandardCharsets.UTF_8 Issue-ID: POLICY-2906 Change-Id: I2cf8c885e3e22c2c6cbe6403a34906928afad022 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-02-18Replace GsonXxxAdaptersJim Hahn14-29/+93
The GsonXxxAdapters were removed from the models Serialization classes and replaced with type adapters from common. Modified the code to refer to the new adapters. Without this fix, examples-onap-vcpe will not compile. Could that be the cause of the apex-pdp standalone issue, POLICY-3066? Allow TypeAdapter in lieu of JsonSerializer/Deserializer adapters in config files. Note: examples-ona-bbs refers to the following, which were removed several releases ago (during the actor re-write?): - appclcm.util.Serialization$RequestAdapter & Serialization$ResponseAdapter Issue-ID: POLICY-2905 Change-Id: Ia57e0346343614cbd4a1cffd9c8393f207284244 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-02-11Fix jackson version in apex-pdpJim Hahn1-1/+12
The kafka_2.12 jar depends on jackson-module-scala, but the default version does not work with the version of jackson used by policy. Modified the dependency tree to include a version that does work. Issue-ID: POLICY-3005 Change-Id: I06fd5b99d6e5c1053e17a754f22f815062f907b2 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-02-11move csit to policy/apex-pdp repoTaka Cho7-0/+7603
move csit to policy/apex-pdp repo Issue-ID: POLICY-2895 Change-Id: I73bd2f59c09f4ae213cab9b1dd2a83e909b218c6 Signed-off-by: Taka Cho <takamune.cho@att.com>
2021-02-11Changes related to multi policy handling improvement in APEXa.sreekumar8-323/+343
This review fixes an issue identified during testing the changes done for improving multiple policy handling in APEX. Changes done to a few test files in the previous review are reverted as well. Change-Id: I98324da708239d314aadd4c45dc377137fd552ba Issue-ID: POLICY-2883 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2021-02-10Remove URL and useerid from JMS pluginliamfallon5-44/+55
This review makes the default URL and userid for JMS null, the actual values must be specified as parameters. Issue-ID: POLICY-3035 Change-Id: I9c06d94d8816092425e2df58b849d837ad953fb2 Signed-off-by: liamfallon <liam.fallon@est.tech>
2021-02-08Remove security credentials from JMS pluginliamfallon4-26/+40
The default security credential of "password" was encoded in a constant in the JMS plugin parameters file. This commit removes these credentials and defaults the credentials to null. Issue-ID: POLICY-3035 Change-Id: I6313340e64c893c4f99de78d9dd448ac53d81246 Signed-off-by: liamfallon <liam.fallon@est.tech>
2021-01-28Improve handling of multiple policy in APEX PDPa.sreekumar14-506/+958
Change-Id: Ic4adf5bd8876dc31fc93993298e90389baaa2c39 Issue-ID: POLICY-2883 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2021-01-20Merge "Add logs for REST request/response in APEX"Ram Krishna Verma5-16/+29
2021-01-20Update Hazelcast version, remove security vulnerabilityliamfallon2-9/+11
Security vulnerabillitles were flagged in CLM in Hazelcast version 3.11-BETA-1. Hazelcast version 4.1.1 removes that vulnerability. The lock handling is slightly different in version 4.1.1 and the old ILock class is removed. The code is updated to use the new FencedLock locks. Issue-ID: POLICY-2943 Change-Id: I0cb7d3cb279fed17b3f8758e55902703491f4b5c Signed-off-by: liamfallon <liam.fallon@est.tech>
2021-01-20Add logs for REST request/response in APEXa.sreekumar5-16/+29
Change-Id: Ibf2cf19a1ec91473d8c655b87a712aa8738848c8 Issue-ID: POLICY-3003 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2021-01-15Add exception to logsRam Krishna Verma2-8/+8
Fixing the comments from previous review - https://gerrit.onap.org/r/c/policy/apex-pdp/+/116833 Issue-ID: POLICY-2885 Change-Id: I85474b365d92771e6e1b56bba95bde6e319d4ec2 Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2021-01-13Avoiding unwanted logging in APEX during event processinga.sreekumar12-127/+52
Change-Id: If0c93bfea08025c6c10e3f4572a14088990f415f Issue-ID: POLICY-2885 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2021-01-06Merge "Changed identifiers to concept identifiers"Liam Fallon8-56/+55
2021-01-06Removing duplicate logging of single response eventa.sreekumar1-4/+2
Change-Id: I88c8f2eea9cb295e422d20222df21a46ef84cd4e Issue-ID: POLICY-2885 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2021-01-05use jre base 2.2.0 - apexTaka Cho1-1/+1
use jre base 2.2.0 Issue-ID: POLICY-2917 Change-Id: I75ae9f401c3665cfad6bc9657511e8c59fe09d02 Signed-off-by: Taka Cho <takamune.cho@att.com>
2021-01-04Changed identifiers to concept identifiersliamfallon8-56/+55
The policy models tosca classes ToscaPolicyIdentifier and ToscaPolicyIdentifierOptVersion can be used to identify any TOSCA concept, not just TOSCA policies so they are renamed to ToscaConceptIdentifier and ToscaCinceptIdentifierOptVersion respectively. The class ToscaPolicyTypeIdentifier is redundant and is replaced by ToscaConceptIdentifier. Issue-ID: POLICY-2900 Change-Id: I5df89d023949cdf0f649951dbbd81a0b30f44ef6 Signed-off-by: liamfallon <liam.fallon@est.tech>
2020-12-21Merge "Prune superfluous log and exception messages"Liam Fallon10-50/+58
2020-12-17Prune superfluous log and exception messagesgregory.hayes10-50/+58
Large volume exception messages should not be repeated in log messages or in rethrown exceptions. Jira-Link: https://jira.onap.org/browse/POLICY-2885 Issue-ID: POLICY-2885 Signed-off-by: gregory.hayes <gregory.hayes@est.tech> Change-Id: I345531d3a7640cc5ad9dbfc367052b9c8cc19387
2020-12-07move all bash to ash shell scripts - apexTaka Cho8-129/+200
bash scripts convert to ash Issue-ID: POLICY-2847 Change-Id: I4617223d4914820797f5ea121f75ee5f69a6ba40 Signed-off-by: Taka Cho <takamune.cho@att.com>
2020-11-16Merge "Update vCPE example for JSON Stringify"Jim Hahn6-9/+30
2020-11-16Merge "Update gRPC example for JSON Stringify"Jim Hahn2-5/+48
2020-11-16Apex CLI editor closes standard input/output/errorliamfallon1-2/+9
The Apex CLI editor closes its input and output when it completes. This is correct behaviour when the input and output are files. However, if the input and output are tied to standard input, output, and error then if there are subsequent actions in the JVM (Such as continuing to run Apex as we do in tests), then any output such as logging is lost. This fix checks for standard input/output/error before closing the input and output. Issue-ID: POLICY-2897 Change-Id: Ifa20b62511f770197f30c4a817212a92876dd6a6 Signed-off-by: liamfallon <liam.fallon@est.tech>
2020-11-16Update vCPE example for JSON Stringifyliamfallon6-9/+30
The JSON.stringify() call in the Rhino Javascript interpreter is not working correctly. A previous patch introduced a method into the Apex execution context to provide an alternative method for stringifying JSON. This patch updates the vCPE example in apex to use that new method. Issue-ID: POLICY-2463 Change-Id: I85cc33dc4633b1b6f4c4db3d5ad8579c66d7c18c Signed-off-by: liamfallon <liam.fallon@est.tech>
2020-11-16Update gRPC example for JSON Stringifyliamfallon2-5/+48
The JSON.stringify() call in the Rhino Javascript interpreter is not working correctly. A previous patch introduced a method into the Apex execution context to provide an alternative method for stringifying JSON. This patch updates the gRPC example in apex to use that new method. Issue-ID: POLICY-2463 Change-Id: I7f789c000d53dec60020fda2a6fccd71ef18edc3 Signed-off-by: liamfallon <liam.fallon@est.tech>
2020-11-11Add method to allow JSON conversion to execution context for logicliamfallon5-63/+147
The Rhino JSON.Stringify() method does not work well. This patch allows the user to call schema specific or generic JSON conversion using the schema handling in Apex or not as the developer chooses. Added a single argument stringify2Json() method. Issue-ID: POLICY-2463 Change-Id: I9ec1e0dea2f6cd153b73b2eace63d8806674884d Signed-off-by: liamfallon <liam.fallon@est.tech>
2020-10-28Stability test planwaynedunican1-11/+10
Update to apexPdpStabilityTestPlan.jmx file Issue-ID: POLICY-2831 Change-Id: I76764e0614a523f2e58df04eed01111c59623e09 Signed-off-by: waynedunican <wayne.dunican@est.tech>
2020-10-27Point to snapshot versionsRam Krishna Verma1-3/+3
Issue-ID: POLICY-2875 Change-Id: I8a7dbd9a1f8fbd88a94a85491304e0f75a05969c Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2020-10-27Bump apex-pdp master to 2.5.0-SNAPSHOTRam Krishna Verma81-82/+82
Issue-ID: POLICY-2875 Change-Id: Ibb0e9a243bf92f0255cb5c145d31ccddb988fdf5 Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2020-10-20Bump apex-pdp to 2.4.4-SNAPSHOTa.sreekumar81-81/+81
Change-Id: I5e2cd92ee3620dea4070d9fa3aeb5ffd65f9412c Issue-ID: POLICY-2869 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2020-10-20Release apex-pdp 2.4.3 dockera.sreekumar1-0/+8
Change-Id: I08f7984cbc4f3b00f1720f21f27b6d019f90490e Issue-ID: POLICY-2869 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2020-10-20Release apex-pdp 2.4.3 artifactsa.sreekumar1-0/+5
Change-Id: I57e11b3993c2b97450ba8cd82872bcce466c2ee5 Issue-ID: POLICY-2869 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2020-10-20Point apex to models 2.3.5Pamela Dragosh1-1/+1
Issue-ID: POLICY-2869 Change-Id: I9880a3571da66390999f174ea2101a5e93280ac2 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-10-16Merge "Remove apex asciidoc documents"Jim Hahn291-32377/+0
2020-10-16Remove apex asciidoc documentsliamfallon291-32377/+0
Apex documentation has now all been ported to use the ONAP recommended rst format. This review removes the old asciidoc documents. Issue-ID: POLICY-2824 Change-Id: I562bd344cb7d6ff36e7d54bdb8f95e3b656468f8 Signed-off-by: liamfallon <liam.fallon@est.tech>
2020-10-08Bump apex-pdp to 2.4.3-SNAPSHOTRam Krishna Verma81-81/+81
Issue-ID: POLICY-2839 Change-Id: Ia7c847b3dafd28958d5df209af95cac19fa480a0 Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2020-10-07Release apex-pdp 2.4.2 docker artifactsRam Krishna Verma1-0/+8
Issue-ID: POLICY-2839 Change-Id: I5b7ee8e97fd47896877e3eadc8ebb61e60b082fa Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2020-10-07Release apex-pdp 2.4.2 maven artifactsRam Krishna Verma1-0/+5
Issue-ID: POLICY-2839 Change-Id: I003109f4b999efaf57aba8a880f1800438baddf6 Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2020-10-07Point to models 2.3.2 releaseRam Krishna Verma1-1/+1
Issue-ID: POLICY-2839 Change-Id: Icb05b2c63cf760f8b8e02731e235041d7430a06e Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2020-10-05Remove legacy operational policy type from apex-pdpRam Krishna Verma7-14/+46
The legacy operational policy type for apex has been removed in Guilin release. Removing it fron supported policy type and other places in apex-pdp. Issue-ID: POLICY-2857 Change-Id: I41d58bf7e82292e11ff752f61dbe9be96a8a7af4 Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2020-09-28Fixing APEX eventName handling to avoid duplicate requestsa.sreekumar1-26/+48
Change-Id: I6ee50fb455424ae1f241b7a12d1cdbf0e6ee4011 Issue-ID: POLICY-2815 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2020-09-24update default keystoresjhh2-0/+0
Issue-ID: POLICY-2827 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I7cde8197621ccc3d366baab952243c7b7894a29b
2020-09-17Cleanup related to removal of legacy format support in APEXa.sreekumar94-95/+2
This review basically just removes all "policyModelFileName" occurences which are not used anymore. Change-Id: Ibac8ec776dd989a5d677ff27a99eb7a36110773f Issue-ID: POLICY-2835 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2020-09-14Use alpine base image 2.1.1Jim Hahn1-1/+1
Issue-ID: POLICY-2819 Change-Id: I28b4c8acdef0302b6419a07c4445d60c398c4f73 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-09-10Bump APEX version to 2.4.2-SNAPSHOTa.sreekumar81-81/+81
Change-Id: Idde5050b425eb1bebe312e80e795c21513367a1b Issue-ID: POLICY-2789 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2020-09-10Release APEX docker 2.4.1a.sreekumar1-0/+8
Change-Id: Ief1025869ee480fe0d43063c2590d74c6de2c77d Issue-ID: POLICY-2789 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2020-09-10Release APEX maven 2.4.1a.sreekumar1-0/+5
Change-Id: I50a84d9abbb8563d1886f1ef199a79f1cc99b4ff Issue-ID: POLICY-2789 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2020-09-09Delete apex-client from packagingJim Hahn1-7/+1
The "stage-release" failed due to: 18:51:12 [ERROR] Failed to execute goal org.apache.maven.plugins:maven-dependency-plugin:3.1.1:copy (copy-fat-jars) on project apex-pdp-package-full: Unable to find/resolve artifact. Could not find artifact org.onap.policy.apex-pdp.client:apex-client-full:jar:full:2.4.1 in release-mirror (https://nexus.onap.org/content/repositories/public/) -> [Help 1] Removed it from the package, as it is no longer part of apex-pdp. Issue-ID: POLICY-2789 Change-Id: I4089096ab9668af33e885c70e140ce8fc1f51939 Signed-off-by: Jim Hahn <jrh3@att.com>