summaryrefslogtreecommitdiffstats
path: root/testsuites/integration/integration-uservice-test/src
diff options
context:
space:
mode:
authorliamfallon <liam.fallon@est.tech>2019-12-04 09:20:04 +0000
committerliamfallon <liam.fallon@est.tech>2019-12-04 17:14:11 +0000
commit7a0a44eac6167cfeff935c39f2c3f20d3a893c3e (patch)
tree5874e4b8f0e4b5ce8cc222912833029729fe4ed3 /testsuites/integration/integration-uservice-test/src
parent9253f81d14a5217479ca8e59efb198eaa32ec9f0 (diff)
Minor changes for new Eclipse checkstyle checks
The laest Eclipse checkstyle version 8.26.0 does more thorough checking and identified a number of small issues in the apex-pdp codebase. This review fixes those issues. Issue-ID: POLICY-1913 Change-Id: I30ba25e3e425c6d54c77f925e8da3ab841a8357c Signed-off-by: liamfallon <liam.fallon@est.tech>
Diffstat (limited to 'testsuites/integration/integration-uservice-test/src')
-rw-r--r--testsuites/integration/integration-uservice-test/src/test/java/org/onap/policy/apex/testsuites/integration/uservice/adapt/jms/TestContext.java44
-rw-r--r--testsuites/integration/integration-uservice-test/src/test/java/org/onap/policy/apex/testsuites/integration/uservice/adapt/jms/TestInitialContextFactory.java10
-rw-r--r--testsuites/integration/integration-uservice-test/src/test/java/org/onap/policy/apex/testsuites/integration/uservice/executionproperties/DummyApexEventProducer.java5
3 files changed, 42 insertions, 17 deletions
diff --git a/testsuites/integration/integration-uservice-test/src/test/java/org/onap/policy/apex/testsuites/integration/uservice/adapt/jms/TestContext.java b/testsuites/integration/integration-uservice-test/src/test/java/org/onap/policy/apex/testsuites/integration/uservice/adapt/jms/TestContext.java
index a44f84444..b547cc482 100644
--- a/testsuites/integration/integration-uservice-test/src/test/java/org/onap/policy/apex/testsuites/integration/uservice/adapt/jms/TestContext.java
+++ b/testsuites/integration/integration-uservice-test/src/test/java/org/onap/policy/apex/testsuites/integration/uservice/adapt/jms/TestContext.java
@@ -90,49 +90,65 @@ public class TestContext implements Context {
* {@inheritDoc}.
*/
@Override
- public void bind(final Name name, final Object obj) throws NamingException {}
+ public void bind(final Name name, final Object obj) throws NamingException {
+ // Not used here
+ }
/**
* {@inheritDoc}.
*/
@Override
- public void bind(final String name, final Object obj) throws NamingException {}
+ public void bind(final String name, final Object obj) throws NamingException {
+ // Not used here
+ }
/**
* {@inheritDoc}.
*/
@Override
- public void rebind(final Name name, final Object obj) throws NamingException {}
+ public void rebind(final Name name, final Object obj) throws NamingException {
+ // Not used here
+ }
/**
* {@inheritDoc}.
*/
@Override
- public void rebind(final String name, final Object obj) throws NamingException {}
+ public void rebind(final String name, final Object obj) throws NamingException {
+ // Not used here
+ }
/**
* {@inheritDoc}.
*/
@Override
- public void unbind(final Name name) throws NamingException {}
+ public void unbind(final Name name) throws NamingException {
+ // Not used here
+ }
/**
* {@inheritDoc}.
*/
@Override
- public void unbind(final String name) throws NamingException {}
+ public void unbind(final String name) throws NamingException {
+ // Not used here
+ }
/**
* {@inheritDoc}.
*/
@Override
- public void rename(final Name oldName, final Name newName) throws NamingException {}
+ public void rename(final Name oldName, final Name newName) throws NamingException {
+ // Not used here
+ }
/**
* {@inheritDoc}.
*/
@Override
- public void rename(final String oldName, final String newName) throws NamingException {}
+ public void rename(final String oldName, final String newName) throws NamingException {
+ // Not used here
+ }
/**
* {@inheritDoc}.
@@ -170,13 +186,17 @@ public class TestContext implements Context {
* {@inheritDoc}.
*/
@Override
- public void destroySubcontext(final Name name) throws NamingException {}
+ public void destroySubcontext(final Name name) throws NamingException {
+ // Not used here
+ }
/**
* {@inheritDoc}.
*/
@Override
- public void destroySubcontext(final String name) throws NamingException {}
+ public void destroySubcontext(final String name) throws NamingException {
+ // Not used here
+ }
/**
* {@inheritDoc}.
@@ -270,7 +290,9 @@ public class TestContext implements Context {
* {@inheritDoc}.
*/
@Override
- public void close() throws NamingException {}
+ public void close() throws NamingException {
+ // Not used here
+ }
/**
* {@inheritDoc}.
diff --git a/testsuites/integration/integration-uservice-test/src/test/java/org/onap/policy/apex/testsuites/integration/uservice/adapt/jms/TestInitialContextFactory.java b/testsuites/integration/integration-uservice-test/src/test/java/org/onap/policy/apex/testsuites/integration/uservice/adapt/jms/TestInitialContextFactory.java
index ddd70a3b9..c54c790cb 100644
--- a/testsuites/integration/integration-uservice-test/src/test/java/org/onap/policy/apex/testsuites/integration/uservice/adapt/jms/TestInitialContextFactory.java
+++ b/testsuites/integration/integration-uservice-test/src/test/java/org/onap/policy/apex/testsuites/integration/uservice/adapt/jms/TestInitialContextFactory.java
@@ -5,15 +5,15 @@
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
- *
+ *
* http://www.apache.org/licenses/LICENSE-2.0
- *
+ *
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
- *
+ *
* SPDX-License-Identifier: Apache-2.0
* ============LICENSE_END=========================================================
*/
@@ -40,7 +40,9 @@ public class TestInitialContextFactory implements InitialContextFactory {
*
* @throws NamingException the naming exception
*/
- public TestInitialContextFactory() throws NamingException {}
+ public TestInitialContextFactory() throws NamingException {
+ // Default constructor
+ }
/**
* {@inheritDoc}.
diff --git a/testsuites/integration/integration-uservice-test/src/test/java/org/onap/policy/apex/testsuites/integration/uservice/executionproperties/DummyApexEventProducer.java b/testsuites/integration/integration-uservice-test/src/test/java/org/onap/policy/apex/testsuites/integration/uservice/executionproperties/DummyApexEventProducer.java
index 0c2ac32fa..670f4991f 100644
--- a/testsuites/integration/integration-uservice-test/src/test/java/org/onap/policy/apex/testsuites/integration/uservice/executionproperties/DummyApexEventProducer.java
+++ b/testsuites/integration/integration-uservice-test/src/test/java/org/onap/policy/apex/testsuites/integration/uservice/executionproperties/DummyApexEventProducer.java
@@ -125,7 +125,6 @@ public class DummyApexEventProducer implements ApexEventProducer {
throw new ApexEventRuntimeException(message);
}
-
try {
executionProperties.store(new FileOutputStream(new File(dummyProducerProperties.getPropertyFileName())),
"");
@@ -141,5 +140,7 @@ public class DummyApexEventProducer implements ApexEventProducer {
* {@inheritDoc}.
*/
@Override
- public void stop() {}
+ public void stop() {
+ // Not used
+ }
}