Immediately return this expression

Immediately return this expression instead of assigning it to the temporary variable "json".

Issue-ID: OPTFRA-644
Change-Id: I955612b752cc6fcfa23090f47f36bdf5e22810d4
Signed-off-by: anushadasari <danush10@in.ibm.com>

1 files changed, 4 insertions, 8 deletions

diff --git a/cmso-service/src/main/java/org/onap/optf/cmso/ticketmgt/bean/BuildCreateRequest.java b/cmso-service/src/main/java/org/onap/optf/cmso/ticketmgt/bean/BuildCreateRequest.java
index 290375f..8ab915c 100644
--- a/cmso-service/src/main/java/org/onap/optf/cmso/ticketmgt/bean/BuildCreateRequest.java
+++ b/cmso-service/src/main/java/org/onap/optf/cmso/ticketmgt/bean/BuildCreateRequest.java
@@ -104,8 +104,7 @@ public class BuildCreateRequest {
     public JsonNode createChangeRecordRequest(Map<String, Object> variables, List<TmAsset> assetList,

             String workflowName) {

         JsonNode rawjson = getYaml("CreateChangeTicket");

-        JsonNode json = substituteJson(rawjson, variables);

-        return json;

+        return substituteJson(rawjson, variables);

     }

 

     /**

@@ -116,8 +115,7 @@ public class BuildCreateRequest {
      */

     public JsonNode createCloseCancelChangeRecord(Map<String, Object> variables) {

         JsonNode rawjson = getYaml("CloseCancelChangeRecord");

-        JsonNode json = substituteJson(rawjson, variables);

-        return json;

+        return substituteJson(rawjson, variables);

     }

 

     /**

@@ -128,8 +126,7 @@ public class BuildCreateRequest {
      */

     public JsonNode createCancelChangeRecord(Map<String, Object> variables) {

         JsonNode rawjson = getYaml("CancelChangeRecord");

-        JsonNode json = substituteJson(rawjson, variables);

-        return json;

+        return substituteJson(rawjson, variables);

     }

 

     /**

@@ -140,8 +137,7 @@ public class BuildCreateRequest {
      */

     public JsonNode createUpdateChangeRecord(Map<String, Object> variables) {

         JsonNode rawjson = getYaml("UpdateChangeRecord");

-        JsonNode json = substituteJson(rawjson, variables);

-        return json;

+        return substituteJson(rawjson, variables);

     }

 

     /**