Age | Commit message (Collapse) | Author | Files | Lines |
|
This review upgrades the checckstyle in ONAP to version 8.32, and
re-aligns the ONAP style definition with the 8.32 version of the Google
style guide.
This change was triggered by incompatible changes in checkstyle version
8.32.
Checkstyle has removed the directives "allowMissingThrowsTag" and
"allowThrowsTagsForSubclasses". These directives controlled whether the existence
of @Throws tags should be checked or not. In ONAP, these directives were set
to "don't check".
The default behaviour in checkstyle now is not to check @Throws javadoc
tags for existence.
See: https://github.com/checkstyle/checkstyle/issues/7329
Issue-ID: INT-1271
Change-Id: Iaabbf05b6aaf244388f654aa4e965da3d3a4f4e9
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Checkstyle rules updated to:
1) allow getters and setters not to have javadoc
2) allow methods with less than 2 lines to not have javadoc
3) allow protected and private methods not to have javadoc
4) allow methods with names beginning with test|before|after not to have
javaodc
Issue-ID: INT-1395
Change-Id: I570cd90034c7b20d45a7e5a6ecacacdef80876a1
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Checkstyle 8.27 introduces incompatible changes in the checkstyle rule
definition xml file. The latest Eclipse checkstyle plugin (version 8.26)
uses this new checkstyle xml rule format.
This change brings in the checkstyle 8.27 rule formats into oparent.
Issue-ID: INT-1395
Change-Id: I453120e5cc95fa2e30a5d2f24083fd030e960a01
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
This reverts commit 6a2d8c71aa39a6f47a683c38267c07cd9a00dfeb.
Revert until we fix the jjb verify and master
Issue-ID: INT-1271
Change-Id: I11da29bee4f17c40ae96ab647d1517572a20b864
Signed-off-by: Brian Freeman <bf1936@att.com>
|
|
Upgrade to use the latest google style (plus onap style).
This latest style adds rules for jdk 8 source level.
Upgrade the version of checkstyle to 8.24. The latest google
style rules are compatible with 8.24 and later.
Upgrade checkstyle maven plugin to 3.1.0 (from 2.17).
This jdk8 version of checkstyle is active only when the build-time
java runtime is jdk8 or later, otherwise, the original checkstyle
is active.
Issue-ID: INT-1271
Change-Id: Ib190b39efc5a6028ab4874301e6a813f0a36b138
Signed-off-by: John J. Franey <john.franey@att.com>
|
|
The XML for onap-java-code style has a bug identified by Eclipse. The
maxLineLength field is not allowed.
In addition, not sure how any jobs work already, the sourceDirectory
appends and extra "src/main/java" to the path so some builds don't
always find the correct source files to generate warnings. The plugin
is a bit flaky and sometimes seems to find the java files, while other
times it does not. So some checkstyle warnings are not generated.
Change-Id: Ia07065a0d0df1429643680cb5bd70b5ec13bebde
Issue-ID: TSC-71
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Change-Id: Ie7ce5da5f0baa6a77dd3bfefd523f28682fe27ba
Issue-ID: INT-103
Signed-off-by: Gary Wu <gary.i.wu@huawei.com>
|
|
Relax O-Parent license check formatting requirements.
At the same time, violations will now become errors and
will fail builds.
Change-Id: Ie581895796cc06a9f008d7b739583fb44673aa19
Issue-ID: INT-135
Signed-off-by: Gary Wu <gary.i.wu@huawei.com>
|
|
Change-Id: I543f394b360b6926986f33b48bef4b3355363beb
Issue-id: INT-103
Signed-off-by: Gary Wu <gary.i.wu@huawei.com>
|