diff options
| author |   liamfallon <liam.fallon@est.tech> | 2021-06-17 16:10:32 +0100 |
|---|---|---|
| committer | liamfallon <liam.fallon@est.tech> | 2021-06-17 17:05:15 +0100 |
| commit | 3a44a36ba79a7eddb44b20d60e0a46e1ee4fabe6 (patch) | |
| tree | a69de8b0536f57e340dbc457d276d3df31cbbf24 | |
| parent | c6044f697e3345c8b907a4f8d5f0cfa3d4069071 (diff) | |
Update Checkstyle to version 8.43
The checkstyle plugin in the 2021-03 version of Eclipse defaults to
version 8.43 of Checkstyle. This version of Checkstyle removes the
"scope" keyword from the JavadocMethod module, because it is redundant,
so the ONAP checkstyle onap-kava-style.xml file breaks.
This review:
- Removes the "scope" property from the "JavadocMethod" module, where it
is redundant anyhow (scope applies on the "MissingJavadocMethod" module
- Removes the "scope" property from the "MissingJavadocMethod" because
it defaults to the correct value for ONAP, that is "public"
Issue-ID: POLICY-3206
Change-Id: I62736ec812595929392b5eef0658acb77365c52a
Signed-off-by: liamfallon <liam.fallon@est.tech>
| -rw-r--r-- | checkstyle/src/main/resources/onap-checkstyle/onap-java-style.xml | 2 | ||||
| -rw-r--r-- | oparent/pom.xml | 2 |
2 files changed, 1 insertions, 3 deletions
diff --git a/checkstyle/src/main/resources/onap-checkstyle/onap-java-style.xml b/checkstyle/src/main/resources/onap-checkstyle/onap-java-style.xml index 609b3ee..4f03bae 100644 --- a/checkstyle/src/main/resources/onap-checkstyle/onap-java-style.xml +++ b/checkstyle/src/main/resources/onap-checkstyle/onap-java-style.xml @@ -302,14 +302,12 @@ value="CLASS_DEF, INTERFACE_DEF, ENUM_DEF, METHOD_DEF, CTOR_DEF, VARIABLE_DEF" /> </module> <module name="JavadocMethod"> - <property name="scope" value="public" /> <property name="allowMissingParamTags" value="true" /> <property name="allowMissingReturnTag" value="true" /> <property name="allowedAnnotations" value="Override, Test" /> <property name="tokens" value="METHOD_DEF, CTOR_DEF, ANNOTATION_FIELD_DEF" /> </module> <module name="MissingJavadocMethod"> - <property name="scope" value="public" /> <property name="minLineCount" value="2" /> <property name="allowedAnnotations" value="Override, Test" /> <property name="tokens" value="METHOD_DEF, CTOR_DEF, ANNOTATION_FIELD_DEF" /> diff --git a/oparent/pom.xml b/oparent/pom.xml index 7c1b781..2b87863 100644 --- a/oparent/pom.xml +++ b/oparent/pom.xml @@ -444,7 +444,7 @@ <dependency> <groupId>com.puppycrawl.tools</groupId> <artifactId>checkstyle</artifactId> - <version>8.37</version> + <version>8.43</version> </dependency> </dependencies> </plugin> |