summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--certService/src/main/java/org/onap/aaf/certservice/CertServiceApplication.java2
-rw-r--r--certService/src/main/java/org/onap/aaf/certservice/certification/configuration/CmpServersConfig.java13
-rw-r--r--certService/src/main/java/org/onap/aaf/certservice/certification/configuration/CmpServersConfigLoader.java31
-rw-r--r--certService/src/main/java/org/onap/aaf/certservice/certification/configuration/model/Authentication.java4
-rw-r--r--certService/src/main/java/org/onap/aaf/certservice/certification/configuration/model/Cmpv2Server.java9
-rw-r--r--certService/src/main/java/org/onap/aaf/certservice/certification/configuration/validation/Cmpv2ServerConfigurationValidator.java48
-rw-r--r--certService/src/main/java/org/onap/aaf/certservice/certification/configuration/validation/constraints/Cmpv2URL.java39
-rw-r--r--certService/src/main/java/org/onap/aaf/certservice/certification/configuration/validation/constraints/Cmpv2URLValidator.java55
-rw-r--r--certService/src/main/java/org/onap/aaf/certservice/certification/configuration/validation/constraints/violations/PortNumberViolation.java43
-rw-r--r--certService/src/main/java/org/onap/aaf/certservice/certification/configuration/validation/constraints/violations/RequestTypeViolation.java49
-rw-r--r--certService/src/main/java/org/onap/aaf/certservice/certification/configuration/validation/constraints/violations/URLServerViolation.java25
-rw-r--r--certService/src/test/java/org/onap/aaf/certservice/certification/configuration/CmpServersConfigLoaderTest.java17
-rw-r--r--certService/src/test/java/org/onap/aaf/certservice/certification/configuration/validation/Cmpv2ServerConfigurationValidatorTest.java127
-rw-r--r--certService/src/test/java/org/onap/aaf/certservice/certification/configuration/validation/constraints/Cmpv2URLValidatorTest.java55
-rw-r--r--certService/src/test/java/org/onap/aaf/certservice/certification/configuration/validation/constraints/violations/PortNumberViolationTest.java76
-rw-r--r--certService/src/test/java/org/onap/aaf/certservice/certification/configuration/validation/constraints/violations/RequestTypeViolationTest.java54
16 files changed, 630 insertions, 17 deletions
diff --git a/certService/src/main/java/org/onap/aaf/certservice/CertServiceApplication.java b/certService/src/main/java/org/onap/aaf/certservice/CertServiceApplication.java
index e6b27ca8..087cf259 100644
--- a/certService/src/main/java/org/onap/aaf/certservice/CertServiceApplication.java
+++ b/certService/src/main/java/org/onap/aaf/certservice/CertServiceApplication.java
@@ -22,8 +22,10 @@ package org.onap.aaf.certservice;
import org.springframework.boot.SpringApplication;
import org.springframework.boot.autoconfigure.SpringBootApplication;
+import org.springframework.context.annotation.PropertySource;
@SpringBootApplication
+@PropertySource(value={"classpath:application.properties"})
public class CertServiceApplication {
// We are excluding this line in Sonar due to fact that
diff --git a/certService/src/main/java/org/onap/aaf/certservice/certification/configuration/CmpServersConfig.java b/certService/src/main/java/org/onap/aaf/certservice/certification/configuration/CmpServersConfig.java
index 20e8934e..93721e88 100644
--- a/certService/src/main/java/org/onap/aaf/certservice/certification/configuration/CmpServersConfig.java
+++ b/certService/src/main/java/org/onap/aaf/certservice/certification/configuration/CmpServersConfig.java
@@ -23,6 +23,8 @@ package org.onap.aaf.certservice.certification.configuration;
import org.onap.aaf.certservice.certification.configuration.model.Cmpv2Server;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.beans.factory.annotation.Value;
import org.springframework.cloud.context.config.annotation.RefreshScope;
@@ -39,20 +41,19 @@ import org.springframework.context.event.EventListener;
@Configuration
public class CmpServersConfig {
- private static final String CMP_SERVERS_CONFIG_FILENAME = "cmpServers.json";
-
private static final Logger LOGGER = LoggerFactory.getLogger(CmpServersConfig.class);
+ private static final String CMP_SERVERS_CONFIG_FILENAME = "cmpServers.json";
private static final String REFRESHING_CONFIGURATION = "Refreshing configuration";
- @Value("${app.config.path}")
private String configPath;
-
- private CmpServersConfigLoader cmpServersConfigLoader;
private List<Cmpv2Server> cmpServers;
+ private final CmpServersConfigLoader cmpServersConfigLoader;
@Autowired
- public CmpServersConfig(CmpServersConfigLoader cmpServersConfigLoader) {
+ public CmpServersConfig(@Value("${app.config.path}") String configPath,
+ CmpServersConfigLoader cmpServersConfigLoader) {
this.cmpServersConfigLoader = cmpServersConfigLoader;
+ this.configPath = configPath;
}
@PostConstruct
diff --git a/certService/src/main/java/org/onap/aaf/certservice/certification/configuration/CmpServersConfigLoader.java b/certService/src/main/java/org/onap/aaf/certservice/certification/configuration/CmpServersConfigLoader.java
index c8415ac0..a6dd5fcf 100644
--- a/certService/src/main/java/org/onap/aaf/certservice/certification/configuration/CmpServersConfigLoader.java
+++ b/certService/src/main/java/org/onap/aaf/certservice/certification/configuration/CmpServersConfigLoader.java
@@ -21,30 +21,45 @@
package org.onap.aaf.certservice.certification.configuration;
import com.fasterxml.jackson.databind.ObjectMapper;
+import java.io.File;
+import java.io.IOException;
+import java.security.InvalidParameterException;
+import java.util.ArrayList;
+import java.util.List;
import org.onap.aaf.certservice.certification.configuration.model.CmpServers;
import org.onap.aaf.certservice.certification.configuration.model.Cmpv2Server;
+import org.onap.aaf.certservice.certification.configuration.validation.Cmpv2ServerConfigurationValidator;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.stereotype.Component;
-import java.io.File;
-import java.io.IOException;
-import java.util.ArrayList;
-import java.util.List;
-
@Component
class CmpServersConfigLoader {
+
private static final Logger LOGGER = LoggerFactory.getLogger(CmpServersConfigLoader.class);
+ private final Cmpv2ServerConfigurationValidator validator;
+
+ @Autowired
+ public CmpServersConfigLoader(Cmpv2ServerConfigurationValidator validator) {
+ this.validator = validator;
+ }
+
List<Cmpv2Server> load(String path) {
- List<Cmpv2Server> result = new ArrayList<>();
+ List<Cmpv2Server> servers = new ArrayList<>();
try {
- result = loadConfigFromFile(path).getCmpv2Servers();
+ servers = loadConfigFromFile(path).getCmpv2Servers();
+ servers.forEach(validator::validate);
LOGGER.info(String.format("CMP Servers configuration successfully loaded from file '%s'", path));
} catch (IOException e) {
LOGGER.error("Exception occurred during CMP Servers configuration loading: ", e);
+ } catch (InvalidParameterException e) {
+ LOGGER.error("Validation of CMPv2 servers configuration failed:", e);
+ throw e;
}
- return result;
+
+ return servers;
}
private CmpServers loadConfigFromFile(String path) throws IOException {
diff --git a/certService/src/main/java/org/onap/aaf/certservice/certification/configuration/model/Authentication.java b/certService/src/main/java/org/onap/aaf/certservice/certification/configuration/model/Authentication.java
index b689eb54..ffd63ecf 100644
--- a/certService/src/main/java/org/onap/aaf/certservice/certification/configuration/model/Authentication.java
+++ b/certService/src/main/java/org/onap/aaf/certservice/certification/configuration/model/Authentication.java
@@ -20,9 +20,13 @@
package org.onap.aaf.certservice.certification.configuration.model;
+import org.hibernate.validator.constraints.Length;
+
public class Authentication {
+ @Length(min = 1, max = 256)
private String iak;
+ @Length(min = 1, max = 256)
private String rv;
public String getIak() {
diff --git a/certService/src/main/java/org/onap/aaf/certservice/certification/configuration/model/Cmpv2Server.java b/certService/src/main/java/org/onap/aaf/certservice/certification/configuration/model/Cmpv2Server.java
index 0ee91cd4..21349d93 100644
--- a/certService/src/main/java/org/onap/aaf/certservice/certification/configuration/model/Cmpv2Server.java
+++ b/certService/src/main/java/org/onap/aaf/certservice/certification/configuration/model/Cmpv2Server.java
@@ -20,12 +20,21 @@
package org.onap.aaf.certservice.certification.configuration.model;
+import org.hibernate.validator.constraints.Length;
+import org.onap.aaf.certservice.certification.configuration.validation.constraints.Cmpv2URL;
+
+import javax.validation.Valid;
+
public class Cmpv2Server {
+ @Valid
private Authentication authentication;
private CaMode caMode;
+ @Length(min = 1, max = 128)
private String caName;
+ @Length(min = 4, max = 256)
private String issuerDN;
+ @Cmpv2URL
private String url;
public Authentication getAuthentication() {
diff --git a/certService/src/main/java/org/onap/aaf/certservice/certification/configuration/validation/Cmpv2ServerConfigurationValidator.java b/certService/src/main/java/org/onap/aaf/certservice/certification/configuration/validation/Cmpv2ServerConfigurationValidator.java
new file mode 100644
index 00000000..736a65d1
--- /dev/null
+++ b/certService/src/main/java/org/onap/aaf/certservice/certification/configuration/validation/Cmpv2ServerConfigurationValidator.java
@@ -0,0 +1,48 @@
+/*
+ * ============LICENSE_START=======================================================
+ * PROJECT
+ * ================================================================================
+ * Copyright (C) 2020 Nokia. All rights reserved.
+ * ================================================================================
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * ============LICENSE_END=========================================================
+ */
+
+package org.onap.aaf.certservice.certification.configuration.validation;
+
+import org.onap.aaf.certservice.certification.configuration.model.Cmpv2Server;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.stereotype.Service;
+
+import javax.validation.ConstraintViolation;
+import javax.validation.Validator;
+import java.security.InvalidParameterException;
+import java.util.Set;
+
+@Service
+public class Cmpv2ServerConfigurationValidator {
+
+ private final Validator validator;
+
+ @Autowired
+ public Cmpv2ServerConfigurationValidator(Validator validator) {
+ this.validator = validator;
+ }
+
+ public void validate(Cmpv2Server serverDetails) {
+ Set<ConstraintViolation<Cmpv2Server>> violations = validator.validate(serverDetails);
+ if (!violations.isEmpty()) {
+ throw new InvalidParameterException(violations.toString());
+ }
+ }
+}
diff --git a/certService/src/main/java/org/onap/aaf/certservice/certification/configuration/validation/constraints/Cmpv2URL.java b/certService/src/main/java/org/onap/aaf/certservice/certification/configuration/validation/constraints/Cmpv2URL.java
new file mode 100644
index 00000000..7c942548
--- /dev/null
+++ b/certService/src/main/java/org/onap/aaf/certservice/certification/configuration/validation/constraints/Cmpv2URL.java
@@ -0,0 +1,39 @@
+/*
+ * ============LICENSE_START=======================================================
+ * PROJECT
+ * ================================================================================
+ * Copyright (C) 2020 Nokia. All rights reserved.
+ * ================================================================================
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * ============LICENSE_END=========================================================
+ */
+
+package org.onap.aaf.certservice.certification.configuration.validation.constraints;
+
+import javax.validation.Constraint;
+import javax.validation.Payload;
+import java.lang.annotation.Retention;
+import java.lang.annotation.Target;
+
+import static java.lang.annotation.ElementType.ANNOTATION_TYPE;
+import static java.lang.annotation.ElementType.FIELD;
+import static java.lang.annotation.RetentionPolicy.RUNTIME;
+
+@Target( { FIELD, ANNOTATION_TYPE })
+@Retention(RUNTIME)
+@Constraint(validatedBy = Cmpv2URLValidator.class)
+public @interface Cmpv2URL {
+ String message() default "Server URL is invalid.";
+ Class<?>[] groups() default {};
+ Class<? extends Payload>[] payload() default {};
+}
diff --git a/certService/src/main/java/org/onap/aaf/certservice/certification/configuration/validation/constraints/Cmpv2URLValidator.java b/certService/src/main/java/org/onap/aaf/certservice/certification/configuration/validation/constraints/Cmpv2URLValidator.java
new file mode 100644
index 00000000..b3224c45
--- /dev/null
+++ b/certService/src/main/java/org/onap/aaf/certservice/certification/configuration/validation/constraints/Cmpv2URLValidator.java
@@ -0,0 +1,55 @@
+/*
+ * ============LICENSE_START=======================================================
+ * PROJECT
+ * ================================================================================
+ * Copyright (C) 2020 Nokia. All rights reserved.
+ * ================================================================================
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * ============LICENSE_END=========================================================
+ */
+
+
+package org.onap.aaf.certservice.certification.configuration.validation.constraints;
+
+import org.onap.aaf.certservice.certification.configuration.validation.constraints.violations.PortNumberViolation;
+import org.onap.aaf.certservice.certification.configuration.validation.constraints.violations.RequestTypeViolation;
+import org.onap.aaf.certservice.certification.configuration.validation.constraints.violations.URLServerViolation;
+
+import javax.validation.ConstraintValidator;
+import javax.validation.ConstraintValidatorContext;
+import java.util.Arrays;
+import java.util.List;
+import java.util.concurrent.atomic.AtomicBoolean;
+
+class Cmpv2URLValidator implements ConstraintValidator<Cmpv2URL, String> {
+
+ private final List<URLServerViolation> violations;
+
+ public Cmpv2URLValidator() {
+ this.violations = Arrays.asList(
+ new PortNumberViolation(),
+ new RequestTypeViolation()
+ );
+ }
+
+ @Override
+ public boolean isValid(String url, ConstraintValidatorContext context) {
+ AtomicBoolean isValid = new AtomicBoolean(true);
+ violations.forEach(violation -> {
+ if (!violation.validate(url)) {
+ isValid.set(false);
+ }
+ });
+ return isValid.get();
+ }
+}
diff --git a/certService/src/main/java/org/onap/aaf/certservice/certification/configuration/validation/constraints/violations/PortNumberViolation.java b/certService/src/main/java/org/onap/aaf/certservice/certification/configuration/validation/constraints/violations/PortNumberViolation.java
new file mode 100644
index 00000000..acde0417
--- /dev/null
+++ b/certService/src/main/java/org/onap/aaf/certservice/certification/configuration/validation/constraints/violations/PortNumberViolation.java
@@ -0,0 +1,43 @@
+/*
+ * ============LICENSE_START=======================================================
+ * PROJECT
+ * ================================================================================
+ * Copyright (C) 2020 Nokia. All rights reserved.
+ * ================================================================================
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * ============LICENSE_END=========================================================
+ */
+
+package org.onap.aaf.certservice.certification.configuration.validation.constraints.violations;
+
+import java.net.MalformedURLException;
+import java.net.URL;
+
+public class PortNumberViolation implements URLServerViolation {
+
+ private static final int MIN_PORT = 1;
+ private static final int MAX_PORT = 65535;
+ private static final int PORT_UNDEFINED = -1;
+
+ @Override
+ public boolean validate(String serverUrl) {
+ try {
+ URL url = new URL(serverUrl);
+ int port = url.getPort();
+ return port >= MIN_PORT && port <= MAX_PORT || port == PORT_UNDEFINED;
+ } catch (MalformedURLException e) {
+ return false;
+ }
+ }
+
+}
diff --git a/certService/src/main/java/org/onap/aaf/certservice/certification/configuration/validation/constraints/violations/RequestTypeViolation.java b/certService/src/main/java/org/onap/aaf/certservice/certification/configuration/validation/constraints/violations/RequestTypeViolation.java
new file mode 100644
index 00000000..7fbbdf34
--- /dev/null
+++ b/certService/src/main/java/org/onap/aaf/certservice/certification/configuration/validation/constraints/violations/RequestTypeViolation.java
@@ -0,0 +1,49 @@
+/*
+ * ============LICENSE_START=======================================================
+ * PROJECT
+ * ================================================================================
+ * Copyright (C) 2020 Nokia. All rights reserved.
+ * ================================================================================
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * ============LICENSE_END=========================================================
+ */
+
+
+package org.onap.aaf.certservice.certification.configuration.validation.constraints.violations;
+
+import java.net.MalformedURLException;
+import java.net.URL;
+import java.util.Collections;
+import java.util.List;
+import java.util.concurrent.atomic.AtomicBoolean;
+
+public class RequestTypeViolation implements URLServerViolation {
+
+ private final static List<String> VALID_REQUESTS = Collections.singletonList("http");
+
+ @Override
+ public boolean validate(String serverUrl) {
+ try {
+ AtomicBoolean isValid = new AtomicBoolean(false);
+ String protocol = new URL(serverUrl).getProtocol();
+ VALID_REQUESTS.forEach(requestType -> {
+ if (protocol.equals(requestType)) {
+ isValid.set(true);
+ }
+ });
+ return isValid.get();
+ } catch (MalformedURLException e) {
+ return false;
+ }
+ }
+}
diff --git a/certService/src/main/java/org/onap/aaf/certservice/certification/configuration/validation/constraints/violations/URLServerViolation.java b/certService/src/main/java/org/onap/aaf/certservice/certification/configuration/validation/constraints/violations/URLServerViolation.java
new file mode 100644
index 00000000..e5a110d2
--- /dev/null
+++ b/certService/src/main/java/org/onap/aaf/certservice/certification/configuration/validation/constraints/violations/URLServerViolation.java
@@ -0,0 +1,25 @@
+/*
+ * ============LICENSE_START=======================================================
+ * PROJECT
+ * ================================================================================
+ * Copyright (C) 2020 Nokia. All rights reserved.
+ * ================================================================================
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * ============LICENSE_END=========================================================
+ */
+
+package org.onap.aaf.certservice.certification.configuration.validation.constraints.violations;
+
+public interface URLServerViolation {
+ boolean validate(String url);
+}
diff --git a/certService/src/test/java/org/onap/aaf/certservice/certification/configuration/CmpServersConfigLoaderTest.java b/certService/src/test/java/org/onap/aaf/certservice/certification/configuration/CmpServersConfigLoaderTest.java
index f4421ffe..b4eec400 100644
--- a/certService/src/test/java/org/onap/aaf/certservice/certification/configuration/CmpServersConfigLoaderTest.java
+++ b/certService/src/test/java/org/onap/aaf/certservice/certification/configuration/CmpServersConfigLoaderTest.java
@@ -21,7 +21,13 @@
package org.onap.aaf.certservice.certification.configuration;
import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.ExtendWith;
+import org.onap.aaf.certservice.CertServiceApplication;
import org.onap.aaf.certservice.certification.configuration.model.Cmpv2Server;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.context.annotation.PropertySource;
+import org.springframework.test.context.ContextConfiguration;
+import org.springframework.test.context.junit.jupiter.SpringExtension;
import java.io.IOException;
import java.util.List;
@@ -29,6 +35,8 @@ import java.util.Map;
import static org.assertj.core.api.Assertions.assertThat;
+@ExtendWith(SpringExtension.class)
+@ContextConfiguration(classes = CertServiceApplication.class)
class CmpServersConfigLoaderTest {
private static final String EXISTING_CONFIG_FILENAME = "cmpServers.json";
private static final String NONEXISTING_CONFIG_FILENAME = "nonexisting_cmpServers.json";
@@ -49,13 +57,16 @@ class CmpServersConfigLoaderTest {
"RV", "yyy"
);
+ @Autowired
+ private CmpServersConfigLoader configLoader;
+
@Test
- public void shouldLoadCmpServersConfigWhenFileAvailable() throws IOException {
+ public void shouldLoadCmpServersConfigWhenFileAvailable() {
// Given
String path = getClass().getClassLoader().getResource(EXISTING_CONFIG_FILENAME).getFile();
// When
- List<Cmpv2Server> cmpServers = new CmpServersConfigLoader().load(path);
+ List<Cmpv2Server> cmpServers = configLoader.load(path);
// Then
assertThat(cmpServers).isNotNull();
@@ -67,7 +78,7 @@ class CmpServersConfigLoaderTest {
@Test()
public void shouldReturnEmptyListWhenFileMissing() {
// When
- List<Cmpv2Server> cmpServers = new CmpServersConfigLoader().load(NONEXISTING_CONFIG_FILENAME);
+ List<Cmpv2Server> cmpServers = configLoader.load(NONEXISTING_CONFIG_FILENAME);
// Then
assertThat(cmpServers).isNotNull();
diff --git a/certService/src/test/java/org/onap/aaf/certservice/certification/configuration/validation/Cmpv2ServerConfigurationValidatorTest.java b/certService/src/test/java/org/onap/aaf/certservice/certification/configuration/validation/Cmpv2ServerConfigurationValidatorTest.java
new file mode 100644
index 00000000..ea15740c
--- /dev/null
+++ b/certService/src/test/java/org/onap/aaf/certservice/certification/configuration/validation/Cmpv2ServerConfigurationValidatorTest.java
@@ -0,0 +1,127 @@
+/*
+ * ============LICENSE_START=======================================================
+ * PROJECT
+ * ================================================================================
+ * Copyright (C) 2020 Nokia. All rights reserved.
+ * ================================================================================
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * ============LICENSE_END=========================================================
+ */
+
+package org.onap.aaf.certservice.certification.configuration.validation;
+
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.ExtendWith;
+import org.onap.aaf.certservice.CertServiceApplication;
+import org.onap.aaf.certservice.certification.configuration.model.Authentication;
+import org.onap.aaf.certservice.certification.configuration.model.CaMode;
+import org.onap.aaf.certservice.certification.configuration.model.Cmpv2Server;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.test.context.ContextConfiguration;
+import org.springframework.test.context.junit.jupiter.SpringExtension;
+
+import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
+import static org.junit.jupiter.api.Assertions.assertThrows;
+
+@ExtendWith(SpringExtension.class)
+@ContextConfiguration(classes = CertServiceApplication.class)
+class Cmpv2ServerConfigurationValidatorTest {
+
+ @Autowired
+ private Cmpv2ServerConfigurationValidator validator;
+
+ private Authentication authentication;
+ private Cmpv2Server server;
+
+ @BeforeEach
+ private void init() {
+ setAuthentication();
+ setServerConfiguration();
+ }
+
+ @Test
+ public void givenValidServerDetailsWhenValidatingShouldNotThrowAnyException() {
+ //then
+ assertDoesNotThrow(() -> validator.validate(server));
+ }
+
+ @Test
+ public void givenWrongProtocolInURLServerDetailsWhenValidatingShouldThrowException() {
+ //given
+ server.setUrl("https://test.test.test:60000/");
+
+ //then
+ assertThrows(IllegalArgumentException.class, () -> {validator.validate(server);});
+ }
+
+ @Test
+ public void givenWrongPortInURLServerDetailsWhenValidatingShouldThrowException() {
+ //given
+ server.setUrl("http://test.test.test:70000/");
+
+ //then
+ assertThrows(IllegalArgumentException.class, () -> validator.validate(server));
+ }
+
+ @Test
+ public void givenWrongCANameLengthInURLServerDetailsWhenValidatingShouldThrowException() {
+ //given
+ server.setCaName("");
+
+ //then
+ assertThrows(IllegalArgumentException.class, () -> validator.validate(server));
+ }
+
+ @Test
+ public void givenWrongIssuerDNLengthInURLServerDetailsWhenValidatingShouldThrowException() {
+ //given
+ server.setIssuerDN("123");
+
+ //then
+ assertThrows(IllegalArgumentException.class, () -> validator.validate(server));
+ }
+
+ @Test
+ public void givenWrongRVLengthInURLServerDetailsWhenValidatingShouldThrowException() {
+ //given
+ authentication.setRv("");
+
+ //then
+ assertThrows(IllegalArgumentException.class, () -> validator.validate(server));
+ }
+
+ @Test
+ public void givenWrongIAKLengthInURLServerDetailsWhenValidatingShouldThrowException() {
+ //given
+ authentication.setIak("");
+
+ //then
+ assertThrows(IllegalArgumentException.class, () -> validator.validate(server));
+ }
+
+ private void setServerConfiguration() {
+ server = new Cmpv2Server();
+ server.setCaMode(CaMode.CLIENT);
+ server.setCaName("TEST");
+ server.setIssuerDN("CN=ManagementCA");
+ server.setUrl("http://127.0.0.1/ejbca/publicweb/cmp/cmp");
+ server.setAuthentication(authentication);
+ }
+
+ private void setAuthentication() {
+ authentication = new Authentication();
+ authentication.setRv("testRV");
+ authentication.setIak("testIAK");
+ }
+} \ No newline at end of file
diff --git a/certService/src/test/java/org/onap/aaf/certservice/certification/configuration/validation/constraints/Cmpv2URLValidatorTest.java b/certService/src/test/java/org/onap/aaf/certservice/certification/configuration/validation/constraints/Cmpv2URLValidatorTest.java
new file mode 100644
index 00000000..a2a03860
--- /dev/null
+++ b/certService/src/test/java/org/onap/aaf/certservice/certification/configuration/validation/constraints/Cmpv2URLValidatorTest.java
@@ -0,0 +1,55 @@
+/*
+ * ============LICENSE_START=======================================================
+ * PROJECT
+ * ================================================================================
+ * Copyright (C) 2020 Nokia. All rights reserved.
+ * ================================================================================
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * ============LICENSE_END=========================================================
+ */
+
+
+package org.onap.aaf.certservice.certification.configuration.validation.constraints;
+
+import org.junit.jupiter.api.Test;
+
+import static org.junit.jupiter.api.Assertions.*;
+
+class Cmpv2URLValidatorTest {
+
+ private Cmpv2URLValidator validator = new Cmpv2URLValidator();
+
+ @Test
+ public void givenCorrectURLWhenValidatingShouldReturnTrue() {
+ //given
+ String URL = "http://127.0.0.1/ejbca/publicweb/cmp/cmp";
+
+ //when
+ boolean result = validator.isValid(URL, null);
+
+ //then
+ assertTrue(result);
+ }
+
+ @Test
+ public void givenIncorrectURLWhenValidatingShouldReturnFalse() {
+ //given
+ String URL = "httttp://127.0.0.1:80000/ejbca/publicweb/cmp/cmp";
+
+ //when
+ boolean result = validator.isValid(URL, null);
+
+ //then
+ assertFalse(result);
+ }
+} \ No newline at end of file
diff --git a/certService/src/test/java/org/onap/aaf/certservice/certification/configuration/validation/constraints/violations/PortNumberViolationTest.java b/certService/src/test/java/org/onap/aaf/certservice/certification/configuration/validation/constraints/violations/PortNumberViolationTest.java
new file mode 100644
index 00000000..8ae4cd88
--- /dev/null
+++ b/certService/src/test/java/org/onap/aaf/certservice/certification/configuration/validation/constraints/violations/PortNumberViolationTest.java
@@ -0,0 +1,76 @@
+/*
+ * ============LICENSE_START=======================================================
+ * PROJECT
+ * ================================================================================
+ * Copyright (C) 2020 Nokia. All rights reserved.
+ * ================================================================================
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * ============LICENSE_END=========================================================
+ */
+
+
+package org.onap.aaf.certservice.certification.configuration.validation.constraints.violations;
+
+import org.junit.jupiter.api.Test;
+
+import static org.junit.jupiter.api.Assertions.*;
+
+class PortNumberViolationTest {
+
+ private PortNumberViolation violation = new PortNumberViolation();
+
+ @Test
+ public void givenValidPortShouldReturnTrue() {
+ //given
+ String validURL1 = "http://127.0.0.1:8080/ejbca/publicweb/cmp/cmp";
+ String validURL2 = "http://127.0.0.1:1/ejbca/publicweb/cmp/cmp";
+ String validURL3 = "http://127.0.0.1:65535/ejbca/publicweb/cmp/cmp";
+
+ //when
+ boolean result1 = violation.validate(validURL1);
+ boolean result2 = violation.validate(validURL2);
+ boolean result3 = violation.validate(validURL3);
+
+ //then
+ assertTrue(result1);
+ assertTrue(result2);
+ assertTrue(result3);
+ }
+
+ @Test
+ public void givenEmptyPortShouldReturnTrue() {
+ //given
+ String validURL = "http://127.0.0.1/ejbca/publicweb/cmp/cmp";
+
+ //when
+ boolean result = violation.validate(validURL);
+
+ //then
+ assertTrue(result);
+ }
+
+ @Test
+ public void givenInvalidPortShouldReturnFalse() {
+ //given
+ String invalidURL1 = "http://127.0.0.1:0/ejbca/publicweb/cmp/cmp";
+ String invalidURL2 = "http://127.0.0.1:65536/ejbca/publicweb/cmp/cmp";
+
+ //when
+ boolean result1 = violation.validate(invalidURL1);
+ boolean result2 = violation.validate(invalidURL2);
+
+ //then
+ assertFalse(result1);
+ assertFalse(result2);
+ }
+} \ No newline at end of file
diff --git a/certService/src/test/java/org/onap/aaf/certservice/certification/configuration/validation/constraints/violations/RequestTypeViolationTest.java b/certService/src/test/java/org/onap/aaf/certservice/certification/configuration/validation/constraints/violations/RequestTypeViolationTest.java
new file mode 100644
index 00000000..9e220560
--- /dev/null
+++ b/certService/src/test/java/org/onap/aaf/certservice/certification/configuration/validation/constraints/violations/RequestTypeViolationTest.java
@@ -0,0 +1,54 @@
+/*
+ * ============LICENSE_START=======================================================
+ * PROJECT
+ * ================================================================================
+ * Copyright (C) 2020 Nokia. All rights reserved.
+ * ================================================================================
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * ============LICENSE_END=========================================================
+ */
+
+package org.onap.aaf.certservice.certification.configuration.validation.constraints.violations;
+
+import org.junit.jupiter.api.Test;
+
+import static org.junit.jupiter.api.Assertions.*;
+
+class RequestTypeViolationTest {
+
+ private RequestTypeViolation violation = new RequestTypeViolation();
+
+ @Test
+ public void givenValidRequestTypeShouldReturnTrue() {
+ //given
+ String validURL = "http://127.0.0.1/ejbca/publicweb/cmp/cmp";
+
+ //when
+ boolean result = violation.validate(validURL);
+
+ //then
+ assertTrue(result);
+ }
+
+ @Test
+ public void givenInvalidRequestTypeShouldReturnFalse() {
+ //given
+ String invalidURL = "htestps://127.0.0.1/ejbca/publicweb/cmp/cmp";
+
+ //when
+ boolean result = violation.validate(invalidURL);
+
+ //then
+ assertFalse(result);
+ }
+} \ No newline at end of file