diff options
| author |   Piotr Marcinkiewicz <piotr.marcinkiewicz@nokia.com> | 2020-12-09 18:45:13 +0100 |
|---|---|---|
| committer | Piotr Marcinkiewicz <piotr.marcinkiewicz@nokia.com> | 2020-12-09 18:45:13 +0100 |
| commit | 10277b4d97f4f1266affe0e5edcc6734ec9aa74d (patch) | |
| tree | 95bdadcb969b33f182b4e95f8f1554ed49487452 | |
| parent | 34934050c5b000fa59190ecbab6891e3a1ef0042 (diff) | |
[OOM-CERT-SERVICE] Correct SANs documentation and logging
- correct properties logging format in external provider
- correct SANs documentation
Issue-ID: OOM-2559
Signed-off-by: Piotr Marcinkiewicz <piotr.marcinkiewicz@nokia.com>
Change-Id: If58e6ca53849e6d091bba652b1cc091f37d8eeeb
| -rw-r--r-- | certServiceK8sExternalProvider/src/cmpv2controller/logger/certificate_request_logger.go | 8 | ||||
| -rw-r--r-- | docs/sections/usage.rst | 2 |
2 files changed, 4 insertions, 6 deletions
diff --git a/certServiceK8sExternalProvider/src/cmpv2controller/logger/certificate_request_logger.go b/certServiceK8sExternalProvider/src/cmpv2controller/logger/certificate_request_logger.go index 5eeaf2e6..1bf5556a 100644 --- a/certServiceK8sExternalProvider/src/cmpv2controller/logger/certificate_request_logger.go +++ b/certServiceK8sExternalProvider/src/cmpv2controller/logger/certificate_request_logger.go @@ -25,6 +25,7 @@ import ( "net" "net/url" "strconv" + "strings" cmapi "github.com/jetstack/cert-manager/pkg/apis/certmanager/v1" @@ -102,11 +103,8 @@ func logPropertiesNotSupportedByCertService(log leveledlogger.Logger, request *c } func extractStringArray(strArray []string) string { - values := "" - for _, val := range strArray { - values = values + val + ", " - } - return values + separator := "," + return strings.Join(strArray, separator) } func mapUrisToText(uris []*url.URL) []string { diff --git a/docs/sections/usage.rst b/docs/sections/usage.rst index 6cba936a..0bbf348e 100644 --- a/docs/sections/usage.rst +++ b/docs/sections/usage.rst @@ -31,7 +31,7 @@ CertService client needs the following configuration parameters to work properly - LOCATION *(optional)* - Location for which certificate from CMPv2 server should be issued - STATE *(required)* - State for which certificate from CMPv2 server should be issued - COUNTRY *(required)* - Country for which certificate from CMPv2 server should be issued - - SANS *(optional)(SANS's should be separated by a comma e.g. test.onap.org,onap.com)* - Subject Alternative Names (SANs) for which certificate from CMPv2 server should be issued. All SANs types are supported (DNS names, IPs, URIs, emails). + - SANS *(optional)(SANS's should be separated by a comma e.g. test.onap.org,onap.com)* - Subject Alternative Names (SANs) for which certificate from CMPv2 server should be issued. The following SANs types are supported: DNS names, IPs, URIs, emails. 3. Parameters to establish secure communication to CertService: |